187752 2018-07-18 04:27:13 -0700 [JSC] Root wrapper object in JSON.stringify is not necessary if replacer is not callable 2018-07-18 11:31:01 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ysuzuki ysuzuki commit-queue ews-watchlist keith_miller mark.lam msaboff saam webkit-bug-importer oldest_to_newest 1442960 0 ysuzuki 2018-07-18 04:27:13 -0700 [JSC] Root wrapper object in JSON.stringify is not necessary if replacer is not callable 1442961 1 345236 ysuzuki 2018-07-18 04:35:37 -0700 Created attachment 345236 Patch 1443055 2 345236 mark.lam 2018-07-18 11:02:54 -0700 Comment on attachment 345236 Patch r=me 1443063 3 345236 ysuzuki 2018-07-18 11:10:50 -0700 Comment on attachment 345236 Patch Thanks! 1443076 4 345236 commit-queue 2018-07-18 11:27:14 -0700 Comment on attachment 345236 Patch Clearing flags on attachment: 345236 Committed r233917: <https://trac.webkit.org/changeset/233917> 1443077 5 commit-queue 2018-07-18 11:27:16 -0700 All reviewed patches have been landed. Closing bug. 1443079 6 webkit-bug-importer 2018-07-18 11:31:01 -0700 <rdar://problem/42343813> 345236 2018-07-18 04:35:37 -0700 2018-07-18 11:27:14 -0700 Patch bug-187752-20180718203536.patch text/plain 4349 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMjMzOTEwCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBi NGNiYTY5OTRkYTNkOTcxYzE4NTAyNGY0OGIzYzExMDVhMjRkMmZhLi45ZTJkNzQ4ZGZiYzViY2Ni ZDg5Nzk0YjRkMjRlZGYxMWNiZGU0M2Q5IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyNyBAQAorMjAxOC0wNy0xOCAgWXVzdWtlIFN1enVraSAgPHV0YXRhbmUudGVhQGdtYWls LmNvbT4KKworICAgICAgICBbSlNDXSBSb290IHdyYXBwZXIgb2JqZWN0IGluIEpTT04uc3RyaW5n aWZ5IGlzIG5vdCBuZWNlc3NhcnkgaWYgcmVwbGFjZXIgaXMgbm90IGNhbGxhYmxlCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODc3NTIKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBKU09OLnN0cmluZ2lmeSBo YXMgYW4gaW1wbGljaXQgcm9vdCB3cmFwcGVyIG9iamVjdCBzaW5jZSB3ZSB3b3VsZCBsaWtlIHRv IGNhbGwgcmVwbGFjZXIKKyAgICAgICAgd2l0aCBhIHdyYXBwZXIgb2JqZWN0IGFuZCBhIHByb3Bl cnR5IG5hbWUuIFdoaWxlIHdlIGFsd2F5cyBjcmVhdGUgdGhpcyB3cmFwcGVyIG9iamVjdCwKKyAg ICAgICAgaXQgaXMgdW5uZWNlc3NhcnkgaWYgdGhlIGdpdmVuIHJlcGxhY2VyIGlzIG5vdCBjYWxs YWJsZS4KKworICAgICAgICBUaGlzIHBhdGNoIHJlbW92ZXMgd3JhcHBlciBvYmplY3QgY3JlYXRp b24gd2hlbiBhIHJlcGxhY2VyIGlzIG5vdCBjYWxsYWJsZSB0byBhdm9pZCB1bm5lY2Vzc2FyeQor ICAgICAgICBhbGxvY2F0aW9ucy4gVGhpcyBjaGFuZ2Ugc2xpZ2h0bHkgaW1wcm92ZXMgdGhlIHBl cmZvcm1hbmNlIG9mIEtyYWtlbi9qc29uLXN0cmluZ2lmeS10aW5kZXJib3guCisKKyAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBiYXNlbGluZSAgICAgICAgICAgICAg ICAgIHBhdGNoZWQKKworICAgICAgICBqc29uLXN0cmluZ2lmeS10aW5kZXJib3ggICAgICAgIDM5 LjczMCstMC41OTAgICAgICBeICAgICAgMzguODUzKy0wLjI2NiAgICAgICAgIF4gZGVmaW5pdGVs eSAxLjAyMjZ4IGZhc3RlcgorCisgICAgICAgICogcnVudGltZS9KU09OT2JqZWN0LmNwcDoKKyAg ICAgICAgKEpTQzo6U3RyaW5naWZpZXI6OmlzQ2FsbGFibGVSZXBsYWNlciBjb25zdCk6CisgICAg ICAgIChKU0M6OlN0cmluZ2lmaWVyOjpTdHJpbmdpZmllcik6CisgICAgICAgIChKU0M6OlN0cmlu Z2lmaWVyOjpzdHJpbmdpZnkpOgorICAgICAgICAoSlNDOjpTdHJpbmdpZmllcjo6YXBwZW5kU3Ry aW5naWZpZWRWYWx1ZSk6CisKIDIwMTgtMDctMTcgIEtlaXRoIE1pbGxlciAgPGtlaXRoX21pbGxl ckBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2ZXJ0IHIyMzM2MzAgc2luY2UgaXQgYnJva2UgaW50 ZXJuYWwgd2FzbSBiZW5jaG1hcmtzCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv cnVudGltZS9KU09OT2JqZWN0LmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pT T05PYmplY3QuY3BwCmluZGV4IGRjNzg1ODg3MjhkOWY4NmI4ODM5ODg2ZmQzNThkNjQwOWQxYWQw NGEuLjA3YmNkNzQzOWZlOWI0NmI5YTA5ZDU5YTI3MzNmYjI5OTU3MWE0MTkgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTT05PYmplY3QuY3BwCisrKyBiL1NvdXJj ZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTT05PYmplY3QuY3BwCkBAIC0xMjAsMTIgKzEyMCwx MyBAQCBjbGFzcyBTdHJpbmdpZmllciB7CiAgICAgdm9pZCBpbmRlbnQoKTsKICAgICB2b2lkIHVu aW5kZW50KCk7CiAgICAgdm9pZCBzdGFydE5ld0xpbmUoU3RyaW5nQnVpbGRlciYpIGNvbnN0Owor ICAgIGJvb2wgaXNDYWxsYWJsZVJlcGxhY2VyKCkgY29uc3QgeyByZXR1cm4gbV9yZXBsYWNlckNh bGxUeXBlICE9IENhbGxUeXBlOjpOb25lOyB9CiAKICAgICBFeGVjU3RhdGUqIGNvbnN0IG1fZXhl YzsKICAgICBKU1ZhbHVlIG1fcmVwbGFjZXI7Ci0gICAgYm9vbCBtX3VzaW5nQXJyYXlSZXBsYWNl cjsKKyAgICBib29sIG1fdXNpbmdBcnJheVJlcGxhY2VyIHsgZmFsc2UgfTsKICAgICBQcm9wZXJ0 eU5hbWVBcnJheSBtX2FycmF5UmVwbGFjZXJQcm9wZXJ0eU5hbWVzOwotICAgIENhbGxUeXBlIG1f cmVwbGFjZXJDYWxsVHlwZTsKKyAgICBDYWxsVHlwZSBtX3JlcGxhY2VyQ2FsbFR5cGUgeyBDYWxs VHlwZTo6Tm9uZSB9OwogICAgIENhbGxEYXRhIG1fcmVwbGFjZXJDYWxsRGF0YTsKICAgICBTdHJp bmcgbV9nYXA7CiAKQEAgLTIyMCw5ICsyMjEsNyBAQCBKU1ZhbHVlIFByb3BlcnR5TmFtZUZvckZ1 bmN0aW9uQ2FsbDo6dmFsdWUoRXhlY1N0YXRlKiBleGVjKSBjb25zdAogU3RyaW5naWZpZXI6OlN0 cmluZ2lmaWVyKEV4ZWNTdGF0ZSogZXhlYywgSlNWYWx1ZSByZXBsYWNlciwgSlNWYWx1ZSBzcGFj ZSkKICAgICA6IG1fZXhlYyhleGVjKQogICAgICwgbV9yZXBsYWNlcihyZXBsYWNlcikKLSAgICAs IG1fdXNpbmdBcnJheVJlcGxhY2VyKGZhbHNlKQogICAgICwgbV9hcnJheVJlcGxhY2VyUHJvcGVy dHlOYW1lcygmZXhlYy0+dm0oKSwgUHJvcGVydHlOYW1lTW9kZTo6U3RyaW5ncywgUHJpdmF0ZVN5 bWJvbE1vZGU6OkV4Y2x1ZGUpCi0gICAgLCBtX3JlcGxhY2VyQ2FsbFR5cGUoQ2FsbFR5cGU6Ok5v bmUpCiB7CiAgICAgVk0mIHZtID0gZXhlYy0+dm0oKTsKICAgICBhdXRvIHNjb3BlID0gREVDTEFS RV9USFJPV19TQ09QRSh2bSk7CkBAIC0yNjQsMTEgKzI2MywxNyBAQCBKU1ZhbHVlIFN0cmluZ2lm aWVyOjpzdHJpbmdpZnkoSlNWYWx1ZSB2YWx1ZSkKIHsKICAgICBWTSYgdm0gPSBtX2V4ZWMtPnZt KCk7CiAgICAgYXV0byBzY29wZSA9IERFQ0xBUkVfVEhST1dfU0NPUEUodm0pOwotICAgIEpTT2Jq ZWN0KiBvYmplY3QgPSBjb25zdHJ1Y3RFbXB0eU9iamVjdChtX2V4ZWMpOwotICAgIFJFVFVSTl9J Rl9FWENFUFRJT04oc2NvcGUsIGpzTnVsbCgpKTsKIAogICAgIFByb3BlcnR5TmFtZUZvckZ1bmN0 aW9uQ2FsbCBlbXB0eVByb3BlcnR5TmFtZSh2bS5wcm9wZXJ0eU5hbWVzLT5lbXB0eUlkZW50aWZp ZXIpOwotICAgIG9iamVjdC0+cHV0RGlyZWN0KHZtLCB2bS5wcm9wZXJ0eU5hbWVzLT5lbXB0eUlk ZW50aWZpZXIsIHZhbHVlKTsKKworICAgIC8vIElmIHRoZSByZXBsYWNlciBpcyBub3QgY2FsbGFi bGUsIHJvb3Qgb2JqZWN0IHdyYXBwZXIgaXMgbm9uLXVzZXItb2JzZXJ2YWJsZS4KKyAgICAvLyBX ZSBjYW4gc2tpcCBjcmVhdGluZyB0aGlzIHdyYXBwZXIgb2JqZWN0LgorICAgIEpTT2JqZWN0KiBv YmplY3QgPSBudWxscHRyOworICAgIGlmIChpc0NhbGxhYmxlUmVwbGFjZXIoKSkgeworICAgICAg ICBvYmplY3QgPSBjb25zdHJ1Y3RFbXB0eU9iamVjdChtX2V4ZWMpOworICAgICAgICBSRVRVUk5f SUZfRVhDRVBUSU9OKHNjb3BlLCBqc051bGwoKSk7CisgICAgICAgIG9iamVjdC0+cHV0RGlyZWN0 KHZtLCB2bS5wcm9wZXJ0eU5hbWVzLT5lbXB0eUlkZW50aWZpZXIsIHZhbHVlKTsKKyAgICB9CiAK ICAgICBTdHJpbmdCdWlsZGVyIHJlc3VsdDsKICAgICBIb2xkZXIgcm9vdChIb2xkZXI6OlJvb3RI b2xkZXIsIG9iamVjdCk7CkBAIC0zMjUsMTEgKzMzMCwxMiBAQCBTdHJpbmdpZmllcjo6U3RyaW5n aWZ5UmVzdWx0IFN0cmluZ2lmaWVyOjphcHBlbmRTdHJpbmdpZmllZFZhbHVlKFN0cmluZ0J1aWxk ZXImCiAgICAgUkVUVVJOX0lGX0VYQ0VQVElPTihzY29wZSwgU3RyaW5naWZ5RmFpbGVkKTsKIAog ICAgIC8vIENhbGwgdGhlIHJlcGxhY2VyIGZ1bmN0aW9uLgotICAgIGlmIChtX3JlcGxhY2VyQ2Fs bFR5cGUgIT0gQ2FsbFR5cGU6Ok5vbmUpIHsKKyAgICBpZiAoaXNDYWxsYWJsZVJlcGxhY2VyKCkp IHsKICAgICAgICAgTWFya2VkQXJndW1lbnRCdWZmZXIgYXJnczsKICAgICAgICAgYXJncy5hcHBl bmQocHJvcGVydHlOYW1lLnZhbHVlKG1fZXhlYykpOwogICAgICAgICBhcmdzLmFwcGVuZCh2YWx1 ZSk7CiAgICAgICAgIEFTU0VSVCghYXJncy5oYXNPdmVyZmxvd2VkKCkpOworICAgICAgICBBU1NF UlQoaG9sZGVyLm9iamVjdCgpKTsKICAgICAgICAgdmFsdWUgPSBjYWxsKG1fZXhlYywgbV9yZXBs YWNlciwgbV9yZXBsYWNlckNhbGxUeXBlLCBtX3JlcGxhY2VyQ2FsbERhdGEsIGhvbGRlci5vYmpl Y3QoKSwgYXJncyk7CiAgICAgICAgIFJFVFVSTl9JRl9FWENFUFRJT04oc2NvcGUsIFN0cmluZ2lm eUZhaWxlZCk7CiAgICAgfQo=