187736 2018-07-17 12:09:48 -0700 CodeBlock::baselineVersion() should account for executables with purged codeBlocks. 2018-07-17 13:20:54 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mark.lam mark.lam fpizlo keith_miller msaboff rmorisset saam tzagallo webkit-bug-importer oldest_to_newest 1442749 0 mark.lam 2018-07-17 12:09:48 -0700 <rdar://problem/42114371> 1442751 1 345180 mark.lam 2018-07-17 12:15:30 -0700 Created attachment 345180 proposed patch. 1442752 2 345180 msaboff 2018-07-17 12:18:56 -0700 Comment on attachment 345180 proposed patch. r=me 1442753 3 345180 msaboff 2018-07-17 12:19:47 -0700 Comment on attachment 345180 proposed patch. Need to fix the EWS build failures. 1442754 4 345181 mark.lam 2018-07-17 12:21:12 -0700 Created attachment 345181 proposed patch. 1442757 5 345181 msaboff 2018-07-17 12:23:49 -0700 Comment on attachment 345181 proposed patch. r=me 1442766 6 mark.lam 2018-07-17 13:20:54 -0700 Thanks for the review. Landed in r233893: <http://trac.webkit.org/r233893>. 345180 2018-07-17 12:15:30 -0700 2018-07-17 12:21:12 -0700 proposed patch. bug-187736.patch text/plain 2693 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjMzODkyKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBA CisyMDE4LTA3LTE3ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBD b2RlQmxvY2s6OmJhc2VsaW5lVmVyc2lvbigpIHNob3VsZCBhY2NvdW50IGZvciBleGVjdXRhYmxl cyB3aXRoIHB1cmdlZCBjb2RlQmxvY2tzLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTg3NzM2CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS80MjExNDM3 MT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDb2Rl QmxvY2s6OmJhc2VsaW5lVmVyc2lvbigpIGN1cnJlbnRseSBjaGVja3MgZm9yIGEgbnVsbCByZXBs YWNlbWVudCBidXQgZG9lcyBub3QKKyAgICAgICAgYWNjb3VudCBmb3IgdGhlIGZhY3QgdGhhdCB0 aGF0IHRoZSByZXBsYWNlbWVudCBjYW4gYWxzbyBiZSBudWxsIGR1ZSB0byB0aGUKKyAgICAgICAg ZXhlY3V0YWJsZSBoYXZpbmcgYmVpbmcgcHVyZ2VkIG9mIGl0cyBjb2RlQmxvY2tzIGR1ZSB0byBh IG1lbW9yeSBldmVudCAoc2VlCisgICAgICAgIEV4ZWN1dGFibGVCYXNlOjpjbGVhckNvZGUoKSku ICBUaGlzIHBhdGNoIGFkZHMgY29kZSB0byBhY2NvdW50IGZvciB0aGlzLgorCisgICAgICAgICog Ynl0ZWNvZGUvQ29kZUJsb2NrLmNwcDoKKyAgICAgICAgKEpTQzo6Q29kZUJsb2NrOjpiYXNlbGlu ZVZlcnNpb24pOgorCiAyMDE4LTA3LTE2ICBZdXN1a2UgU3V6dWtpICA8dXRhdGFuZS50ZWFAZ21h aWwuY29tPgogCiAgICAgICAgIFtKU0NdIFVubGlua2VkQ29kZUJsb2NrOjpzaHJpbmtUb0ZpdCBt aXNzIG1fY29uc3RhbnRJZGVudGlmaWVyU2V0cwpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3Jl L2J5dGVjb2RlL0NvZGVCbG9jay5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRD b3JlL2J5dGVjb2RlL0NvZGVCbG9jay5jcHAJKHJldmlzaW9uIDIzMzg2NykKKysrIFNvdXJjZS9K YXZhU2NyaXB0Q29yZS9ieXRlY29kZS9Db2RlQmxvY2suY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0x NjM3LDE2ICsxNjM3LDI2IEBAIENvZGVCbG9jayogQ29kZUJsb2NrOjpiYXNlbGluZUFsdGVybmF0 aXYKIENvZGVCbG9jayogQ29kZUJsb2NrOjpiYXNlbGluZVZlcnNpb24oKQogewogI2lmIEVOQUJM RShKSVQpCi0gICAgaWYgKEpJVENvZGU6OmlzQmFzZWxpbmVDb2RlKGppdFR5cGUoKSkpCisgICAg SklUVHlwZSBzZWxmSklUVHlwZSA9IGppdFR5cGUoKTsKKyAgICBpZiAoSklUQ29kZTo6aXNCYXNl bGluZUNvZGUoc2VsZkpJVFR5cGUpKQogICAgICAgICByZXR1cm4gdGhpczsKICAgICBDb2RlQmxv Y2sqIHJlc3VsdCA9IHJlcGxhY2VtZW50KCk7CiAgICAgaWYgKCFyZXN1bHQpIHsKLSAgICAgICAg Ly8gVGhpcyBjYW4gaGFwcGVuIGlmIHdlJ3JlIGNyZWF0aW5nIHRoZSBvcmlnaW5hbCBDb2RlQmxv Y2sgZm9yIGFuIGV4ZWN1dGFibGUuCi0gICAgICAgIC8vIEFzc3VtZSB0aGF0IHdlJ3JlIHRoZSBi YXNlbGluZSBDb2RlQmxvY2suCi0gICAgICAgIFJFTEVBU0VfQVNTRVJUKGppdFR5cGUoKSA9PSBK SVRDb2RlOjpOb25lKTsKLSAgICAgICAgcmV0dXJuIHRoaXM7CisgICAgICAgIGlmIChpc09wdGlt aXppbmdKSVQoc2VsZkpJVFR5cGUpKSB7CisgICAgICAgICAgICAvLyBUaGUgcmVwbGFjZW1lbnQg Y2FuIGJlIG51bGwgaWYgd2UndmUgaGFkIGEgbWVtb3J5IGNsZWFuIHVwIGFuZCB0aGUgZXhlY3V0 YWJsZQorICAgICAgICAgICAgLy8gaGFzIGJlZW4gcHVyZ2VkIG9mIGl0cyBjb2RlQmxvY2tzIChz ZWUgRXhlY3V0YWJsZUJhc2U6OmNsZWFyQ29kZSgpKS4gUmVnYXJkbGVzcywKKyAgICAgICAgICAg IC8vIHRoZSBjdXJyZW50IGNvZGVCbG9jayBpcyBzdGlsbCBsaXZlIG9uIHRoZSBzdGFjaywgYW5k IGFzIGFuIG9wdGltaXppbmcgSklUCisgICAgICAgICAgICAvLyBjb2RlQmxvY2ssIGl0IHdpbGwg a2VlcCBpdHMgYmFzZWxpbmVBbHRlcm5hdGl2ZSgpIGFsaXZlIGZvciB1cyB0byBmZXRjaCBiZWxv dy4KKyAgICAgICAgICAgIHJlc3VsdCA9IHRoaXM7CisgICAgICAgIH0gZWxzZSB7CisgICAgICAg ICAgICAvLyBUaGlzIGNhbiBoYXBwZW4gaWYgd2UncmUgY3JlYXRpbmcgdGhlIG9yaWdpbmFsIENv ZGVCbG9jayBmb3IgYW4gZXhlY3V0YWJsZS4KKyAgICAgICAgICAgIC8vIEFzc3VtZSB0aGF0IHdl J3JlIHRoZSBiYXNlbGluZSBDb2RlQmxvY2suCisgICAgICAgICAgICBSRUxFQVNFX0FTU0VSVChz ZWxmSklUVHlwZSA9PSBKSVRDb2RlOjpOb25lKTsKKyAgICAgICAgICAgIHJldHVybiB0aGlzOwor ICAgICAgICB9CiAgICAgfQogICAgIHJlc3VsdCA9IHJlc3VsdC0+YmFzZWxpbmVBbHRlcm5hdGl2 ZSgpOworICAgIEFTU0VSVChyZXN1bHQpOwogICAgIHJldHVybiByZXN1bHQ7CiAjZWxzZQogICAg IHJldHVybiB0aGlzOwo= 345181 2018-07-17 12:21:12 -0700 2018-07-17 12:23:49 -0700 proposed patch. bug-187736.patch text/plain 2711 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjMzODkyKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBA CisyMDE4LTA3LTE3ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBD b2RlQmxvY2s6OmJhc2VsaW5lVmVyc2lvbigpIHNob3VsZCBhY2NvdW50IGZvciBleGVjdXRhYmxl cyB3aXRoIHB1cmdlZCBjb2RlQmxvY2tzLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTg3NzM2CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS80MjExNDM3 MT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDb2Rl QmxvY2s6OmJhc2VsaW5lVmVyc2lvbigpIGN1cnJlbnRseSBjaGVja3MgZm9yIGEgbnVsbCByZXBs YWNlbWVudCBidXQgZG9lcyBub3QKKyAgICAgICAgYWNjb3VudCBmb3IgdGhlIGZhY3QgdGhhdCB0 aGF0IHRoZSByZXBsYWNlbWVudCBjYW4gYWxzbyBiZSBudWxsIGR1ZSB0byB0aGUKKyAgICAgICAg ZXhlY3V0YWJsZSBoYXZpbmcgYmVpbmcgcHVyZ2VkIG9mIGl0cyBjb2RlQmxvY2tzIGR1ZSB0byBh IG1lbW9yeSBldmVudCAoc2VlCisgICAgICAgIEV4ZWN1dGFibGVCYXNlOjpjbGVhckNvZGUoKSku ICBUaGlzIHBhdGNoIGFkZHMgY29kZSB0byBhY2NvdW50IGZvciB0aGlzLgorCisgICAgICAgICog Ynl0ZWNvZGUvQ29kZUJsb2NrLmNwcDoKKyAgICAgICAgKEpTQzo6Q29kZUJsb2NrOjpiYXNlbGlu ZVZlcnNpb24pOgorCiAyMDE4LTA3LTE2ICBZdXN1a2UgU3V6dWtpICA8dXRhdGFuZS50ZWFAZ21h aWwuY29tPgogCiAgICAgICAgIFtKU0NdIFVubGlua2VkQ29kZUJsb2NrOjpzaHJpbmtUb0ZpdCBt aXNzIG1fY29uc3RhbnRJZGVudGlmaWVyU2V0cwpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3Jl L2J5dGVjb2RlL0NvZGVCbG9jay5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRD b3JlL2J5dGVjb2RlL0NvZGVCbG9jay5jcHAJKHJldmlzaW9uIDIzMzg2NykKKysrIFNvdXJjZS9K YXZhU2NyaXB0Q29yZS9ieXRlY29kZS9Db2RlQmxvY2suY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0x NjM3LDE2ICsxNjM3LDI2IEBAIENvZGVCbG9jayogQ29kZUJsb2NrOjpiYXNlbGluZUFsdGVybmF0 aXYKIENvZGVCbG9jayogQ29kZUJsb2NrOjpiYXNlbGluZVZlcnNpb24oKQogewogI2lmIEVOQUJM RShKSVQpCi0gICAgaWYgKEpJVENvZGU6OmlzQmFzZWxpbmVDb2RlKGppdFR5cGUoKSkpCisgICAg SklUQ29kZTo6SklUVHlwZSBzZWxmSklUVHlwZSA9IGppdFR5cGUoKTsKKyAgICBpZiAoSklUQ29k ZTo6aXNCYXNlbGluZUNvZGUoc2VsZkpJVFR5cGUpKQogICAgICAgICByZXR1cm4gdGhpczsKICAg ICBDb2RlQmxvY2sqIHJlc3VsdCA9IHJlcGxhY2VtZW50KCk7CiAgICAgaWYgKCFyZXN1bHQpIHsK LSAgICAgICAgLy8gVGhpcyBjYW4gaGFwcGVuIGlmIHdlJ3JlIGNyZWF0aW5nIHRoZSBvcmlnaW5h bCBDb2RlQmxvY2sgZm9yIGFuIGV4ZWN1dGFibGUuCi0gICAgICAgIC8vIEFzc3VtZSB0aGF0IHdl J3JlIHRoZSBiYXNlbGluZSBDb2RlQmxvY2suCi0gICAgICAgIFJFTEVBU0VfQVNTRVJUKGppdFR5 cGUoKSA9PSBKSVRDb2RlOjpOb25lKTsKLSAgICAgICAgcmV0dXJuIHRoaXM7CisgICAgICAgIGlm IChKSVRDb2RlOjppc09wdGltaXppbmdKSVQoc2VsZkpJVFR5cGUpKSB7CisgICAgICAgICAgICAv LyBUaGUgcmVwbGFjZW1lbnQgY2FuIGJlIG51bGwgaWYgd2UndmUgaGFkIGEgbWVtb3J5IGNsZWFu IHVwIGFuZCB0aGUgZXhlY3V0YWJsZQorICAgICAgICAgICAgLy8gaGFzIGJlZW4gcHVyZ2VkIG9m IGl0cyBjb2RlQmxvY2tzIChzZWUgRXhlY3V0YWJsZUJhc2U6OmNsZWFyQ29kZSgpKS4gUmVnYXJk bGVzcywKKyAgICAgICAgICAgIC8vIHRoZSBjdXJyZW50IGNvZGVCbG9jayBpcyBzdGlsbCBsaXZl IG9uIHRoZSBzdGFjaywgYW5kIGFzIGFuIG9wdGltaXppbmcgSklUCisgICAgICAgICAgICAvLyBj b2RlQmxvY2ssIGl0IHdpbGwga2VlcCBpdHMgYmFzZWxpbmVBbHRlcm5hdGl2ZSgpIGFsaXZlIGZv ciB1cyB0byBmZXRjaCBiZWxvdy4KKyAgICAgICAgICAgIHJlc3VsdCA9IHRoaXM7CisgICAgICAg IH0gZWxzZSB7CisgICAgICAgICAgICAvLyBUaGlzIGNhbiBoYXBwZW4gaWYgd2UncmUgY3JlYXRp bmcgdGhlIG9yaWdpbmFsIENvZGVCbG9jayBmb3IgYW4gZXhlY3V0YWJsZS4KKyAgICAgICAgICAg IC8vIEFzc3VtZSB0aGF0IHdlJ3JlIHRoZSBiYXNlbGluZSBDb2RlQmxvY2suCisgICAgICAgICAg ICBSRUxFQVNFX0FTU0VSVChzZWxmSklUVHlwZSA9PSBKSVRDb2RlOjpOb25lKTsKKyAgICAgICAg ICAgIHJldHVybiB0aGlzOworICAgICAgICB9CiAgICAgfQogICAgIHJlc3VsdCA9IHJlc3VsdC0+ YmFzZWxpbmVBbHRlcm5hdGl2ZSgpOworICAgIEFTU0VSVChyZXN1bHQpOwogICAgIHJldHVybiBy ZXN1bHQ7CiAjZWxzZQogICAgIHJldHVybiB0aGlzOwo=