187713 2018-07-16 15:29:19 -0700 Release assert in ~TimerBase is getting hit in WK1 apps which uses JSC API directly 2018-07-16 19:50:13 -0700 1 1 1 Unclassified WebKit DOM WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 rniwa rniwa beidson cdumez ddkilzer mark.lam simon.fraser oldest_to_newest 1442531 0 rniwa 2018-07-16 15:29:19 -0700 Apparently, JSC API doesn't grab the web thread lock, as a result, some apps are hitting the release assertion in ~TimerBase. <rdar://problem/41759548> 1442532 1 345124 rniwa 2018-07-16 15:31:03 -0700 Created attachment 345124 Fixes the crash 1442535 2 mark.lam 2018-07-16 15:45:23 -0700 The GTK and wpe build failure looks legit. 1442540 3 345128 rniwa 2018-07-16 16:10:09 -0700 Created attachment 345128 Fixed non-iOS builds 1442589 4 345128 simon.fraser 2018-07-16 19:09:02 -0700 Comment on attachment 345128 Fixed non-iOS builds View in context: https://bugs.webkit.org/attachment.cgi?id=345128&action=review > Source/WebCore/ChangeLog:8 > + Turn this into a debug assertion in WebKit1. This needs more explanation that mentions the JSC lack of WebThreadLock etc, and reference a radar. 1442606 5 rniwa 2018-07-16 19:50:13 -0700 Committed r233879: <https://trac.webkit.org/changeset/233879> 345124 2018-07-16 15:31:03 -0700 2018-07-16 16:10:08 -0700 Fixes the crash bug-187713-20180716153102.patch text/plain 1851 rniwa SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIzMzg2NykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE4LTA3LTE2ICBSeW9zdWtl IE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIFJlbGVhc2UgYXNzZXJ0IGluIH5U aW1lckJhc2UgaXMgZ2V0dGluZyBoaXQgaW4gV0sxIGFwcHMgd2hpY2ggdXNlcyBKU0MgQVBJIGRp cmVjdGx5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x ODc3MTMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBU dXJuIHRoaXMgaW50byBhIGRlYnVnIGFzc2VydGlvbiBpbiBXZWJLaXQxLgorCisgICAgICAgICog cGxhdGZvcm0vVGltZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6VGltZXJCYXNlOjp+VGltZXJC YXNlKToKKyAgICAgICAgKFdlYkNvcmU6OlRpbWVyQmFzZTo6c2V0TmV4dEZpcmVUaW1lKToKKwog MjAxOC0wNy0xNSAgSmlld2VuIFRhbiAgPGppZXdlbl90YW5AYXBwbGUuY29tPgogCiAgICAgICAg IFtXZWJDcnlwdG9dIENyeXB0byBvcGVyYXRpb25zIHNob3VsZCBjb3B5IHRoZWlyIHBhcmFtZXRl cnMgYmVmb3JlIGhvcGluZyB0byBhbm90aGVyIHRocmVhZApJbmRleDogU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vVGltZXIuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L1RpbWVyLmNwcAkocmV2aXNpb24gMjMzODY3KQorKysgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v VGltZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xOTAsNyArMTkwLDggQEAgVGltZXJCYXNlOjpU aW1lckJhc2UoKQogCiBUaW1lckJhc2U6On5UaW1lckJhc2UoKQogewotICAgIFJFTEVBU0VfQVNT RVJUX1dJVEhfU0VDVVJJVFlfSU1QTElDQVRJT04oY2FuQWNjZXNzVGhyZWFkTG9jYWxEYXRhRm9y VGhyZWFkKG1fdGhyZWFkLmdldCgpKSk7CisgICAgQVNTRVJUKGNhbkFjY2Vzc1RocmVhZExvY2Fs RGF0YUZvclRocmVhZChtX3RocmVhZC5nZXQoKSkpOworICAgIFJFTEVBU0VfQVNTRVJUKFdlYlRo cmVhZElzRW5hYmxlZCgpIHx8IGNhbkFjY2Vzc1RocmVhZExvY2FsRGF0YUZvclRocmVhZChtX3Ro cmVhZC5nZXQoKSkpOwogICAgIHN0b3AoKTsKICAgICBBU1NFUlQoIWluSGVhcCgpKTsKICAgICBt X3dhc0RlbGV0ZWQgPSB0cnVlOwpAQCAtMzU3LDcgKzM1OCw4IEBAIHZvaWQgVGltZXJCYXNlOjp1 cGRhdGVIZWFwSWZOZWVkZWQoTW9ub3QKIAogdm9pZCBUaW1lckJhc2U6OnNldE5leHRGaXJlVGlt ZShNb25vdG9uaWNUaW1lIG5ld1RpbWUpCiB7Ci0gICAgUkVMRUFTRV9BU1NFUlQoY2FuQWNjZXNz VGhyZWFkTG9jYWxEYXRhRm9yVGhyZWFkKG1fdGhyZWFkLmdldCgpKSk7CisgICAgQVNTRVJUKGNh bkFjY2Vzc1RocmVhZExvY2FsRGF0YUZvclRocmVhZChtX3RocmVhZC5nZXQoKSkpOworICAgIFJF TEVBU0VfQVNTRVJUKFdlYlRocmVhZElzRW5hYmxlZCgpIHx8IGNhbkFjY2Vzc1RocmVhZExvY2Fs RGF0YUZvclRocmVhZChtX3RocmVhZC5nZXQoKSkpOwogICAgIFJFTEVBU0VfQVNTRVJUX1dJVEhf U0VDVVJJVFlfSU1QTElDQVRJT04oIW1fd2FzRGVsZXRlZCk7CiAKICAgICBpZiAobV91bmFsaWdu ZWROZXh0RmlyZVRpbWUgIT0gbmV3VGltZSkK 345128 2018-07-16 16:10:09 -0700 2018-07-16 19:09:02 -0700 Fixed non-iOS builds bug-187713-20180716161008.patch text/plain 1997 rniwa SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIzMzg2NykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE4LTA3LTE2ICBSeW9zdWtl IE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIFJlbGVhc2UgYXNzZXJ0IGluIH5U aW1lckJhc2UgaXMgZ2V0dGluZyBoaXQgaW4gV0sxIGFwcHMgd2hpY2ggdXNlcyBKU0MgQVBJIGRp cmVjdGx5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x ODc3MTMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBU dXJuIHRoaXMgaW50byBhIGRlYnVnIGFzc2VydGlvbiBpbiBXZWJLaXQxLgorCisgICAgICAgICog cGxhdGZvcm0vVGltZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6VGltZXJCYXNlOjp+VGltZXJC YXNlKToKKyAgICAgICAgKFdlYkNvcmU6OlRpbWVyQmFzZTo6c2V0TmV4dEZpcmVUaW1lKToKKwog MjAxOC0wNy0xNSAgSmlld2VuIFRhbiAgPGppZXdlbl90YW5AYXBwbGUuY29tPgogCiAgICAgICAg IFtXZWJDcnlwdG9dIENyeXB0byBvcGVyYXRpb25zIHNob3VsZCBjb3B5IHRoZWlyIHBhcmFtZXRl cnMgYmVmb3JlIGhvcGluZyB0byBhbm90aGVyIHRocmVhZApJbmRleDogU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vVGltZXIuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L1RpbWVyLmNwcAkocmV2aXNpb24gMjMzODY3KQorKysgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v VGltZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xOTAsNyArMTkwLDEyIEBAIFRpbWVyQmFzZTo6 VGltZXJCYXNlKCkKIAogVGltZXJCYXNlOjp+VGltZXJCYXNlKCkKIHsKLSAgICBSRUxFQVNFX0FT U0VSVF9XSVRIX1NFQ1VSSVRZX0lNUExJQ0FUSU9OKGNhbkFjY2Vzc1RocmVhZExvY2FsRGF0YUZv clRocmVhZChtX3RocmVhZC5nZXQoKSkpOworI2lmIFVTRShXRUJfVEhSRUFEKQorICAgIEFTU0VS VChjYW5BY2Nlc3NUaHJlYWRMb2NhbERhdGFGb3JUaHJlYWQobV90aHJlYWQuZ2V0KCkpKTsKKyAg ICBSRUxFQVNFX0FTU0VSVChXZWJUaHJlYWRJc0VuYWJsZWQoKSB8fCBjYW5BY2Nlc3NUaHJlYWRM b2NhbERhdGFGb3JUaHJlYWQobV90aHJlYWQuZ2V0KCkpKTsKKyNlbHNlCisgICAgUkVMRUFTRV9B U1NFUlQoY2FuQWNjZXNzVGhyZWFkTG9jYWxEYXRhRm9yVGhyZWFkKG1fdGhyZWFkLmdldCgpKSk7 CisjZW5kaWYKICAgICBzdG9wKCk7CiAgICAgQVNTRVJUKCFpbkhlYXAoKSk7CiAgICAgbV93YXNE ZWxldGVkID0gdHJ1ZTsKQEAgLTM1Nyw3ICszNjIsMTIgQEAgdm9pZCBUaW1lckJhc2U6OnVwZGF0 ZUhlYXBJZk5lZWRlZChNb25vdAogCiB2b2lkIFRpbWVyQmFzZTo6c2V0TmV4dEZpcmVUaW1lKE1v bm90b25pY1RpbWUgbmV3VGltZSkKIHsKKyNpZiBVU0UoV0VCX1RIUkVBRCkKKyAgICBBU1NFUlQo Y2FuQWNjZXNzVGhyZWFkTG9jYWxEYXRhRm9yVGhyZWFkKG1fdGhyZWFkLmdldCgpKSk7CisgICAg UkVMRUFTRV9BU1NFUlQoV2ViVGhyZWFkSXNFbmFibGVkKCkgfHwgY2FuQWNjZXNzVGhyZWFkTG9j YWxEYXRhRm9yVGhyZWFkKG1fdGhyZWFkLmdldCgpKSk7CisjZWxzZQogICAgIFJFTEVBU0VfQVNT RVJUKGNhbkFjY2Vzc1RocmVhZExvY2FsRGF0YUZvclRocmVhZChtX3RocmVhZC5nZXQoKSkpOwor I2VuZGlmCiAgICAgUkVMRUFTRV9BU1NFUlRfV0lUSF9TRUNVUklUWV9JTVBMSUNBVElPTighbV93 YXNEZWxldGVkKTsKIAogICAgIGlmIChtX3VuYWxpZ25lZE5leHRGaXJlVGltZSAhPSBuZXdUaW1l KQo=