187705 2018-07-16 12:20:41 -0700 [JSC] Make SourceParseMode small 2018-07-16 13:13:20 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ysuzuki ysuzuki ews-watchlist keith_miller mark.lam msaboff saam webkit-bug-importer oldest_to_newest 1442465 0 ysuzuki 2018-07-16 12:20:41 -0700 [JSC] Make SourceParseMode small 1442466 1 345108 ysuzuki 2018-07-16 12:23:27 -0700 Created attachment 345108 Patch 1442470 2 345108 mark.lam 2018-07-16 12:33:43 -0700 Comment on attachment 345108 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=345108&action=review r=me > Source/JavaScriptCore/parser/ParserModes.h:45 > +// Keep it less tha 32, it means this should be within 5 bits. /tha/than/. 1442476 3 345108 ysuzuki 2018-07-16 12:48:24 -0700 Comment on attachment 345108 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=345108&action=review Thank you! >> Source/JavaScriptCore/parser/ParserModes.h:45 >> +// Keep it less tha 32, it means this should be within 5 bits. > > /tha/than/. Fixed. 1442477 4 ysuzuki 2018-07-16 12:49:19 -0700 Committed r233860: <https://trac.webkit.org/changeset/233860> 1442495 5 webkit-bug-importer 2018-07-16 13:13:20 -0700 <rdar://problem/42252920> 345108 2018-07-16 12:23:27 -0700 2018-07-16 12:33:43 -0700 Patch bug-187705-20180717042326.patch text/plain 5353 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMjMzODU2CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA1 YzFmODNjZDdjZjE3YTEwNmE2YjU5ZDkzYmM2ZDkyZTBkYWJhNmMzLi5mNzFiMWQ4YmRlMmU1ODNh MDY1Y2EzN2YxYjRkNzRiNzljNWNiMjcxIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMCBAQAorMjAxOC0wNy0xNiAgWXVzdWtlIFN1enVraSAgPHV0YXRhbmUudGVhQGdtYWls LmNvbT4KKworICAgICAgICBbSlNDXSBNYWtlIFNvdXJjZVBhcnNlTW9kZSBzbWFsbAorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg3NzA1CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRWFjaCBTb3VyY2VQYXJz ZU1vZGUgaXMgZGlzdGluY3QuIFNvIHdlIGRvIG5vdCBuZWVkIHRvIG1ha2UgaXQgYSBzZXQtc3R5 bGUgKHBvd2VyIG9mIDIgc3R5bGUpLgorICAgICAgICBPcmlnaW5hbGx5LCB0aGlzIGlzIGRvbmUg dG8gbWFrZSBTb3VyY2VQYXJzZU1vZGVTZXQgZmFzdGVyIGJlY2F1c2UgaXQgaXMgY3JpdGljYWwg aW4gb3VyIHBhcnNlci4KKyAgICAgICAgQnV0IHdlIGNhbiBrZWVwIFNvdXJjZVBhcnNlTW9kZVNl dCBmYXN0IGJ5IGAxVSA8PCBtb2RlIHwgc2V0YC4gQW5kIHdlIGNhbiBtYWtlIFNvdXJjZVBhcnNl TW9kZQorICAgICAgICB3aXRoaW4gNSBiaXRzLiBUaGlzIHJlZHVjZXMgdGhlIHNpemUgb2YgVW5s aW5rZWRDb2RlQmxvY2sgZnJvbSAyODggdG8gMjgwLgorCisgICAgICAgICogcGFyc2VyL1BhcnNl ck1vZGVzLmg6CisgICAgICAgIChKU0M6OlNvdXJjZVBhcnNlTW9kZVNldDo6U291cmNlUGFyc2VN b2RlU2V0KToKKyAgICAgICAgKEpTQzo6U291cmNlUGFyc2VNb2RlU2V0Ojpjb250YWlucyk6Cisg ICAgICAgIChKU0M6OlNvdXJjZVBhcnNlTW9kZVNldDo6bWVyZ2VTb3VyY2VQYXJzZU1vZGVzKToK KwogMjAxOC0wNy0xMiAgWXVzdWtlIFN1enVraSAgPHV0YXRhbmUudGVhQGdtYWlsLmNvbT4KIAog ICAgICAgICBbSlNDXSBHZW5lcmF0b3IgYW5kIEFzeW5jR2VuZXJhdG9yTWV0aG9kJ3MgcHJvdG90 eXBlIGlzIGluY29ycmVjdApkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3BhcnNl ci9QYXJzZXJNb2Rlcy5oIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3BhcnNlci9QYXJzZXJNb2Rl cy5oCmluZGV4IGFmZDZmNTA5MjYyMTllODljNDk0YzZiYjczZjdjY2RhNzYyMzI3ODAuLjcwM2Nh MGE5MTY2ZGJiZjU0OWY4MDViNTY4OTVlOGNiZGY0NjNkYzMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9K YXZhU2NyaXB0Q29yZS9wYXJzZXIvUGFyc2VyTW9kZXMuaAorKysgYi9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvcGFyc2VyL1BhcnNlck1vZGVzLmgKQEAgLTQyLDUxICs0Miw1MiBAQCBlbnVtIERlYnVn Z2VyTW9kZSB7IERlYnVnZ2VyT2ZmLCBEZWJ1Z2dlck9uIH07CiAKIGVudW0gY2xhc3MgRnVuY3Rp b25Nb2RlIHsgRnVuY3Rpb25FeHByZXNzaW9uLCBGdW5jdGlvbkRlY2xhcmF0aW9uLCBNZXRob2RE ZWZpbml0aW9uIH07CiAKLWVudW0gY2xhc3MgU291cmNlUGFyc2VNb2RlIDogdWludDMyX3Qgewot ICAgIE5vcm1hbEZ1bmN0aW9uTW9kZSAgICAgICAgICAgICAgICA9IDBiMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDEsCi0gICAgR2VuZXJhdG9yQm9keU1vZGUgICAgICAgICAgICAgICAg ID0gMGIwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAxMCwKLSAgICBHZW5lcmF0b3JXcmFw cGVyRnVuY3Rpb25Nb2RlICAgICAgPSAwYjAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMTAw LAotICAgIEdldHRlck1vZGUgICAgICAgICAgICAgICAgICAgICAgICA9IDBiMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDEwMDAsCi0gICAgU2V0dGVyTW9kZSAgICAgICAgICAgICAgICAgICAg ICAgID0gMGIwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAxMDAwMCwKLSAgICBNZXRob2RNb2Rl ICAgICAgICAgICAgICAgICAgICAgICAgPSAwYjAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMTAw MDAwLAotICAgIEFycm93RnVuY3Rpb25Nb2RlICAgICAgICAgICAgICAgICA9IDBiMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDEwMDAwMDAsCi0gICAgQXN5bmNGdW5jdGlvbkJvZHlNb2RlICAgICAg ICAgICAgID0gMGIwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAxMDAwMDAwMCwKLSAgICBBc3luY0Fy cm93RnVuY3Rpb25Cb2R5TW9kZSAgICAgICAgPSAwYjAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMTAw MDAwMDAwLAotICAgIEFzeW5jRnVuY3Rpb25Nb2RlICAgICAgICAgICAgICAgICA9IDBiMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDEwMDAwMDAwMDAsCi0gICAgQXN5bmNNZXRob2RNb2RlICAgICAgICAg ICAgICAgICAgID0gMGIwMDAwMDAwMDAwMDAwMDAwMDAwMDAxMDAwMDAwMDAwMCwKLSAgICBBc3lu Y0Fycm93RnVuY3Rpb25Nb2RlICAgICAgICAgICAgPSAwYjAwMDAwMDAwMDAwMDAwMDAwMDAwMTAw MDAwMDAwMDAwLAotICAgIFByb2dyYW1Nb2RlICAgICAgICAgICAgICAgICAgICAgICA9IDBiMDAw MDAwMDAwMDAwMDAwMDAwMDEwMDAwMDAwMDAwMDAsCi0gICAgTW9kdWxlQW5hbHl6ZU1vZGUgICAg ICAgICAgICAgICAgID0gMGIwMDAwMDAwMDAwMDAwMDAwMDAxMDAwMDAwMDAwMDAwMCwKLSAgICBN b2R1bGVFdmFsdWF0ZU1vZGUgICAgICAgICAgICAgICAgPSAwYjAwMDAwMDAwMDAwMDAwMDAwMTAw MDAwMDAwMDAwMDAwLAotICAgIEFzeW5jR2VuZXJhdG9yQm9keU1vZGUgICAgICAgICAgICA9IDBi MDAwMDAwMDAwMDAwMDAwMDEwMDAwMDAwMDAwMDAwMDAsCi0gICAgQXN5bmNHZW5lcmF0b3JXcmFw cGVyRnVuY3Rpb25Nb2RlID0gMGIwMDAwMDAwMDAwMDAwMDAxMDAwMDAwMDAwMDAwMDAwMCwKLSAg ICBBc3luY0dlbmVyYXRvcldyYXBwZXJNZXRob2RNb2RlICAgPSAwYjAwMDAwMDAwMDAwMDAwMTAw MDAwMDAwMDAwMDAwMDAwLAotICAgIEdlbmVyYXRvcldyYXBwZXJNZXRob2RNb2RlICAgICAgICA9 IDBiMDAwMDAwMDAwMDAwMDEwMDAwMDAwMDAwMDAwMDAwMDAsCisvLyBLZWVwIGl0IGxlc3MgdGhh IDMyLCBpdCBtZWFucyB0aGlzIHNob3VsZCBiZSB3aXRoaW4gNSBiaXRzLgorZW51bSBjbGFzcyBT b3VyY2VQYXJzZU1vZGUgOiB1aW50OF90IHsKKyAgICBOb3JtYWxGdW5jdGlvbk1vZGUgICAgICAg ICAgICAgICAgPSAwLAorICAgIEdlbmVyYXRvckJvZHlNb2RlICAgICAgICAgICAgICAgICA9IDEs CisgICAgR2VuZXJhdG9yV3JhcHBlckZ1bmN0aW9uTW9kZSAgICAgID0gMiwKKyAgICBHZXR0ZXJN b2RlICAgICAgICAgICAgICAgICAgICAgICAgPSAzLAorICAgIFNldHRlck1vZGUgICAgICAgICAg ICAgICAgICAgICAgICA9IDQsCisgICAgTWV0aG9kTW9kZSAgICAgICAgICAgICAgICAgICAgICAg ID0gNSwKKyAgICBBcnJvd0Z1bmN0aW9uTW9kZSAgICAgICAgICAgICAgICAgPSA2LAorICAgIEFz eW5jRnVuY3Rpb25Cb2R5TW9kZSAgICAgICAgICAgICA9IDcsCisgICAgQXN5bmNBcnJvd0Z1bmN0 aW9uQm9keU1vZGUgICAgICAgID0gOCwKKyAgICBBc3luY0Z1bmN0aW9uTW9kZSAgICAgICAgICAg ICAgICAgPSA5LAorICAgIEFzeW5jTWV0aG9kTW9kZSAgICAgICAgICAgICAgICAgICA9IDEwLAor ICAgIEFzeW5jQXJyb3dGdW5jdGlvbk1vZGUgICAgICAgICAgICA9IDExLAorICAgIFByb2dyYW1N b2RlICAgICAgICAgICAgICAgICAgICAgICA9IDEyLAorICAgIE1vZHVsZUFuYWx5emVNb2RlICAg ICAgICAgICAgICAgICA9IDEzLAorICAgIE1vZHVsZUV2YWx1YXRlTW9kZSAgICAgICAgICAgICAg ICA9IDE0LAorICAgIEFzeW5jR2VuZXJhdG9yQm9keU1vZGUgICAgICAgICAgICA9IDE1LAorICAg IEFzeW5jR2VuZXJhdG9yV3JhcHBlckZ1bmN0aW9uTW9kZSA9IDE2LAorICAgIEFzeW5jR2VuZXJh dG9yV3JhcHBlck1ldGhvZE1vZGUgICA9IDE3LAorICAgIEdlbmVyYXRvcldyYXBwZXJNZXRob2RN b2RlICAgICAgICA9IDE4LAogfTsKIAogY2xhc3MgU291cmNlUGFyc2VNb2RlU2V0IHsgCiBwdWJs aWM6IAogICAgIHRlbXBsYXRlPHR5cGVuYW1lLi4uIE1vZGVzPiAKLSAgICBTb3VyY2VQYXJzZU1v ZGVTZXQoTW9kZXMuLi4gYXJncykgCisgICAgY29uc3RleHByIFNvdXJjZVBhcnNlTW9kZVNldChN b2Rlcy4uLiBhcmdzKQogICAgICAgICA6IG1fbWFzayhtZXJnZVNvdXJjZVBhcnNlTW9kZXMoYXJn cy4uLikpIAogICAgIHsgCiAgICAgfSAKIAotICAgIEFMV0FZU19JTkxJTkUgYm9vbCBjb250YWlu cyhTb3VyY2VQYXJzZU1vZGUgbW9kZSkgCisgICAgQUxXQVlTX0lOTElORSBjb25zdGV4cHIgYm9v bCBjb250YWlucyhTb3VyY2VQYXJzZU1vZGUgbW9kZSkKICAgICB7IAotICAgICAgICByZXR1cm4g c3RhdGljX2Nhc3Q8dW5zaWduZWQ+KG1vZGUpICYgbV9tYXNrOyAKKyAgICAgICAgcmV0dXJuICgx VSA8PCBzdGF0aWNfY2FzdDx1bnNpZ25lZD4obW9kZSkpICYgbV9tYXNrOwogICAgIH0gCiAKIHBy aXZhdGU6IAotICAgIEFMV0FZU19JTkxJTkUgc3RhdGljIHVuc2lnbmVkIG1lcmdlU291cmNlUGFy c2VNb2RlcyhTb3VyY2VQYXJzZU1vZGUgbW9kZSkgCisgICAgQUxXQVlTX0lOTElORSBzdGF0aWMg Y29uc3RleHByIHVuc2lnbmVkIG1lcmdlU291cmNlUGFyc2VNb2RlcyhTb3VyY2VQYXJzZU1vZGUg bW9kZSkKICAgICB7IAotICAgICAgICByZXR1cm4gc3RhdGljX2Nhc3Q8dW5zaWduZWQ+KG1vZGUp OyAKKyAgICAgICAgcmV0dXJuICgxVSA8PCBzdGF0aWNfY2FzdDx1bnNpZ25lZD4obW9kZSkpOwog ICAgIH0gCiAKICAgICB0ZW1wbGF0ZTx0eXBlbmFtZS4uLiBSZXN0PiAKLSAgICBBTFdBWVNfSU5M SU5FIHN0YXRpYyB1bnNpZ25lZCBtZXJnZVNvdXJjZVBhcnNlTW9kZXMoU291cmNlUGFyc2VNb2Rl IG1vZGUsIFJlc3QuLi4gcmVzdCkgCisgICAgQUxXQVlTX0lOTElORSBzdGF0aWMgY29uc3RleHBy IHVuc2lnbmVkIG1lcmdlU291cmNlUGFyc2VNb2RlcyhTb3VyY2VQYXJzZU1vZGUgbW9kZSwgUmVz dC4uLiByZXN0KQogICAgIHsgCi0gICAgICAgIHJldHVybiBzdGF0aWNfY2FzdDx1bnNpZ25lZD4o bW9kZSkgfCBtZXJnZVNvdXJjZVBhcnNlTW9kZXMocmVzdC4uLik7IAorICAgICAgICByZXR1cm4g KDFVIDw8IHN0YXRpY19jYXN0PHVuc2lnbmVkPihtb2RlKSkgfCBtZXJnZVNvdXJjZVBhcnNlTW9k ZXMocmVzdC4uLik7CiAgICAgfSAKIAogICAgIGNvbnN0IHVuc2lnbmVkIG1fbWFzazsgCg==