187704 2018-07-16 11:04:53 -0700 jsc shell's noFTL utility test function should be more robust. 2018-07-16 11:43:26 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mark.lam mark.lam ews-watchlist keith_miller msaboff saam webkit-bug-importer oldest_to_newest 1442434 0 mark.lam 2018-07-16 11:04:53 -0700 <rdar://problem/42231988> 1442436 1 345102 mark.lam 2018-07-16 11:13:20 -0700 Created attachment 345102 proposed patch. 1442441 2 345102 msaboff 2018-07-16 11:34:25 -0700 Comment on attachment 345102 proposed patch. r=me 1442443 3 345102 keith_miller 2018-07-16 11:34:41 -0700 Comment on attachment 345102 proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=345102&action=review r=me. > Source/JavaScriptCore/jsc.cpp:1443 > + if (exec->argumentCount() >= 1) { Nit: you can just do if (exec->argumentCount()) here. 1442446 4 345102 mark.lam 2018-07-16 11:38:52 -0700 Comment on attachment 345102 proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=345102&action=review >> Source/JavaScriptCore/jsc.cpp:1443 >> + if (exec->argumentCount() >= 1) { > > Nit: you can just do if (exec->argumentCount()) here. Will fix before landing. 1442447 5 mark.lam 2018-07-16 11:43:02 -0700 Thanks for the review. Landed in r233854: <http://trac.webkit.org/r233854>. 345102 2018-07-16 11:13:20 -0700 2018-07-16 11:34:25 -0700 proposed patch. bug-187704.patch text/plain 1577 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjMzODUxKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBA CisyMDE4LTA3LTE2ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBq c2Mgc2hlbGwncyBub0ZUTCB1dGlsaXR5IHRlc3QgZnVuY3Rpb24gc2hvdWxkIGJlIG1vcmUgcm9i dXN0LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg3 NzA0CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS80MjIzMTk4OD4KKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGpzYy5jcHA6CisgICAgICAgIChmdW5j dGlvbk5vRlRMKToKKyAgICAgICAgLSBvbmx5IHNldE5ldmVyRlRMT3B0aW1pemUoKSBpZiB0aGUg ZnVuY3Rpb24gaXMgYWN0dWFsbHkgYSBKUyBmdW5jdGlvbi4KKwogMjAxOC0wNy0xNSAgQ2FybG9z IEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CiAKICAgICAgICAgW0dMSUJdIEFk ZCBBUEkgdG8gZXZhbHVhdGUgY29kZSB1c2luZyBhIGdpdmVuIG9iamVjdCB0byBzdG9yZSBnbG9i YWwgc3ltYm9scwpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2pzYy5jcHAKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2pzYy5jcHAJKHJldmlzaW9uIDIzMzg0OSkKKysr IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9qc2MuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xNDQwLDEy ICsxNDQwLDExIEBAIEVuY29kZWRKU1ZhbHVlIEpTQ19IT1NUX0NBTEwgZnVuY3Rpb25Ob0QKIAog RW5jb2RlZEpTVmFsdWUgSlNDX0hPU1RfQ0FMTCBmdW5jdGlvbk5vRlRMKEV4ZWNTdGF0ZSogZXhl YykKIHsKLSAgICBWTSYgdm0gPSBleGVjLT52bSgpOwotICAgIGlmIChKU0Z1bmN0aW9uKiBmdW5j dGlvbiA9IGpzRHluYW1pY0Nhc3Q8SlNGdW5jdGlvbio+KHZtLCBleGVjLT5hcmd1bWVudCgwKSkp IHsKLSAgICAgICAgRnVuY3Rpb25FeGVjdXRhYmxlKiBleGVjdXRhYmxlID0gZnVuY3Rpb24tPmpz RXhlY3V0YWJsZSgpOwotICAgICAgICBleGVjdXRhYmxlLT5zZXROZXZlckZUTE9wdGltaXplKHRy dWUpOworICAgIGlmIChleGVjLT5hcmd1bWVudENvdW50KCkgPj0gMSkgeworICAgICAgICBGdW5j dGlvbkV4ZWN1dGFibGUqIGV4ZWN1dGFibGUgPSBnZXRFeGVjdXRhYmxlRm9yRnVuY3Rpb24oZXhl Yy0+YXJndW1lbnQoMCkpOworICAgICAgICBpZiAoZXhlY3V0YWJsZSkKKyAgICAgICAgICAgIGV4 ZWN1dGFibGUtPnNldE5ldmVyRlRMT3B0aW1pemUodHJ1ZSk7CiAgICAgfQotCiAgICAgcmV0dXJu IEpTVmFsdWU6OmVuY29kZShqc1VuZGVmaW5lZCgpKTsKIH0KIAo=