187702 2018-07-16 10:26:49 -0700 Make sure LibWebRTCMediaEndpoint is always destroyed on the main thread 2018-07-16 11:56:21 -0700 1 1 1 Unclassified WebKit Media WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cdumez cdumez achristensen commit-queue eric.carlson rniwa webkit-bug-importer youennf oldest_to_newest 1442409 0 cdumez 2018-07-16 10:26:49 -0700 Make sure LibWebRTCMediaEndpoint is always destroyed on the main thread since it has a Timer data member. 1442412 1 345098 cdumez 2018-07-16 10:32:37 -0700 Created attachment 345098 Patch 1442417 2 345098 youennf 2018-07-16 10:36:35 -0700 Comment on attachment 345098 Patch It seems safer with the patch. I wonder whether this is an actual issue though. When the pc goes away, LibWebRTCMediaEndpoint::close() is called which stops the timer. Or is it needed to destroy the timer as well? 1442419 3 cdumez 2018-07-16 10:41:05 -0700 (In reply to youenn fablet from comment #2) > Comment on attachment 345098 [details] > Patch > > It seems safer with the patch. > I wonder whether this is an actual issue though. > When the pc goes away, LibWebRTCMediaEndpoint::close() is called which stops > the timer. > Or is it needed to destroy the timer as well? You'd still hit release assertions I believe, the Timer destructor calls stop() and stop() calls TimerBase::setNextFireTime() which has: RELEASE_ASSERT(canAccessThreadLocalDataForThread(m_thread.get())); 1442422 4 cdumez 2018-07-16 10:43:09 -0700 (In reply to Chris Dumez from comment #3) > (In reply to youenn fablet from comment #2) > > Comment on attachment 345098 [details] > > Patch > > > > It seems safer with the patch. > > I wonder whether this is an actual issue though. > > When the pc goes away, LibWebRTCMediaEndpoint::close() is called which stops > > the timer. > > Or is it needed to destroy the timer as well? > > You'd still hit release assertions I believe, the Timer destructor calls > stop() and stop() calls TimerBase::setNextFireTime() which has: > RELEASE_ASSERT(canAccessThreadLocalDataForThread(m_thread.get())); This became a RELEASE_ASSERT() very recently in http://trac.webkit.org/r233821 to try and find cases where we're destroying timers on the wrong thread (As this could explain rdar://problem/33352721). 1442453 5 345098 commit-queue 2018-07-16 11:55:14 -0700 Comment on attachment 345098 Patch Clearing flags on attachment: 345098 Committed r233857: <https://trac.webkit.org/changeset/233857> 1442454 6 commit-queue 2018-07-16 11:55:16 -0700 All reviewed patches have been landed. Closing bug. 1442455 7 webkit-bug-importer 2018-07-16 11:56:21 -0700 <rdar://problem/42249803> 345098 2018-07-16 10:32:37 -0700 2018-07-16 11:55:14 -0700 Patch bug-187702-20180716103225.patch text/plain 2532 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjMzODQ5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMmFhODI1OWQxNjE2ZDQ1 NmVlMzZiZTc0ODNlYTQyZjQ2ZTQ3MTQ0Ni4uYjZkMWJiNGM2YjIxNTVmYmExYjI2ODA0ZWE4Y2M2 OWY3MzkyODliNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE4LTA3LTE2ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgTWFrZSBzdXJlIExpYldlYlJU Q01lZGlhRW5kcG9pbnQgaXMgYWx3YXlzIGRlc3Ryb3llZCBvbiB0aGUgbWFpbiB0aHJlYWQKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4NzcwMgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE1ha2Ugc3VyZSBM aWJXZWJSVENNZWRpYUVuZHBvaW50IGlzIGFsd2F5cyBjb25zdHJ1Y3RlZCBhbmQgZGVzdHJ1Y3Rl ZCBvbiB0aGUgbWFpbiB0aHJlYWQgc2luY2UKKyAgICAgICAgaXQgaGFzIGEgVGltZXIgZGF0YSBt ZW1iZXIgYW5kIGl0IHdvdWxkIG5vdCBiZSBzYWZlIG90aGVyd2lzZS4gTGliV2ViUlRDTWVkaWFF bmRwb2ludCBpcworICAgICAgICBUaHJlYWRTYWZlUmVmQ291bnRlZCBhbmQgZnJlcXVlbnRseSBw YXNzZWQgdG8gb3RoZXIgdGhyZWFkcy4KKworICAgICAgICAqIE1vZHVsZXMvbWVkaWFzdHJlYW0v bGlid2VicnRjL0xpYldlYlJUQ01lZGlhRW5kcG9pbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6 TGliV2ViUlRDTWVkaWFFbmRwb2ludDo6TGliV2ViUlRDTWVkaWFFbmRwb2ludCk6CisgICAgICAg ICogTW9kdWxlcy9tZWRpYXN0cmVhbS9saWJ3ZWJydGMvTGliV2ViUlRDTWVkaWFFbmRwb2ludC5o OgorCiAyMDE4LTA3LTE2ICBTZXJnaW8gVmlsbGFyIFNlbmluICA8c3ZpbGxhckBpZ2FsaWEuY29t PgogCiAgICAgICAgIFtXZWJWUl0gQWRkIHN1cHBvcnQgZm9yIGNvbm5lY3QvZGlzY29ubmVjdCBh bmQgbW91bnQvdW5tb3VudCBkZXZpY2UgZXZlbnRzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9Nb2R1bGVzL21lZGlhc3RyZWFtL2xpYndlYnJ0Yy9MaWJXZWJSVENNZWRpYUVuZHBvaW50LmNw cCBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFzdHJlYW0vbGlid2VicnRjL0xpYldlYlJU Q01lZGlhRW5kcG9pbnQuY3BwCmluZGV4IDY0ZTJiYmYxMWI2MTViZGQ0YmRiOTk4ODczM2M3ZDFk YjJhM2UxNDguLmFjOTcxOTYxY2VmZmU1NTNiZThkZmFiOTJhMDdkMTEyMzJhNjNjN2IgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFzdHJlYW0vbGlid2VicnRjL0xpYldl YlJUQ01lZGlhRW5kcG9pbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFz dHJlYW0vbGlid2VicnRjL0xpYldlYlJUQ01lZGlhRW5kcG9pbnQuY3BwCkBAIC03NCw2ICs3NCw3 IEBAIExpYldlYlJUQ01lZGlhRW5kcG9pbnQ6OkxpYldlYlJUQ01lZGlhRW5kcG9pbnQoTGliV2Vi UlRDUGVlckNvbm5lY3Rpb25CYWNrZW5kJiBwCiAgICAgLCBtX2xvZ0lkZW50aWZpZXIocGVlckNv bm5lY3Rpb24ubG9nSWRlbnRpZmllcigpKQogI2VuZGlmCiB7CisgICAgQVNTRVJUKGlzTWFpblRo cmVhZCgpKTsKICAgICBBU1NFUlQoY2xpZW50LmZhY3RvcnkoKSk7CiB9CiAKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFzdHJlYW0vbGlid2VicnRjL0xpYldlYlJUQ01l ZGlhRW5kcG9pbnQuaCBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFzdHJlYW0vbGlid2Vi cnRjL0xpYldlYlJUQ01lZGlhRW5kcG9pbnQuaAppbmRleCAyMmFlMjg0ZTg1MmUzNGI1YTlkMWY2 YzdlMzMzM2RmYjUwYjk1ZDc3Li4yOTdiNjBjMTg1ZWYwNDVhZGFmMmZiN2E1ZjA2MzhlMzNiM2Ew NGI2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhc3RyZWFtL2xpYndl YnJ0Yy9MaWJXZWJSVENNZWRpYUVuZHBvaW50LmgKKysrIGIvU291cmNlL1dlYkNvcmUvTW9kdWxl cy9tZWRpYXN0cmVhbS9saWJ3ZWJydGMvTGliV2ViUlRDTWVkaWFFbmRwb2ludC5oCkBAIC01Nyw3 ICs1Nyw3IEBAIGNsYXNzIE1lZGlhU3RyZWFtVHJhY2s7CiBjbGFzcyBSVENTZXNzaW9uRGVzY3Jp cHRpb247CiAKIGNsYXNzIExpYldlYlJUQ01lZGlhRW5kcG9pbnQKLSAgICA6IHB1YmxpYyBUaHJl YWRTYWZlUmVmQ291bnRlZDxMaWJXZWJSVENNZWRpYUVuZHBvaW50PgorICAgIDogcHVibGljIFRo cmVhZFNhZmVSZWZDb3VudGVkPExpYldlYlJUQ01lZGlhRW5kcG9pbnQsIFdURjo6RGVzdHJ1Y3Rp b25UaHJlYWQ6Ok1haW4+CiAgICAgLCBwcml2YXRlIHdlYnJ0Yzo6UGVlckNvbm5lY3Rpb25PYnNl cnZlcgogICAgICwgcHJpdmF0ZSB3ZWJydGM6OlJUQ1N0YXRzQ29sbGVjdG9yQ2FsbGJhY2sKICNp ZiAhUkVMRUFTRV9MT0dfRElTQUJMRUQK