187690 2018-07-15 19:27:27 -0700 [iOS apps on macOS] Playing embedded Twitter videos in the News app crashes the web process 2018-07-17 15:48:24 -0700 1 1 1 Unclassified WebKit Media WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 wenson_hsieh wenson_hsieh ap bdakin commit-queue eric.carlson jer.noble thorton webkit-bug-importer oldest_to_newest 1442315 0 wenson_hsieh 2018-07-15 19:27:27 -0700 <rdar://problem/41869703> 1442316 1 345073 wenson_hsieh 2018-07-15 19:52:04 -0700 Created attachment 345073 Patch 1442319 2 345075 wenson_hsieh 2018-07-15 20:15:04 -0700 Created attachment 345075 ChangeLog tweak 1442325 3 345075 thorton 2018-07-15 21:51:46 -0700 Comment on attachment 345075 ChangeLog tweak Ha! This makes so much sense. 1442326 4 345075 wenson_hsieh 2018-07-15 21:53:03 -0700 Comment on attachment 345075 ChangeLog tweak Thanks for the review! 1442327 5 345075 commit-queue 2018-07-15 22:19:49 -0700 Comment on attachment 345075 ChangeLog tweak Clearing flags on attachment: 345075 Committed r233841: <https://trac.webkit.org/changeset/233841> 1442328 6 commit-queue 2018-07-15 22:19:51 -0700 All reviewed patches have been landed. Closing bug. 1442816 7 345075 ap 2018-07-17 15:46:01 -0700 Comment on attachment 345075 ChangeLog tweak View in context: https://bugs.webkit.org/attachment.cgi?id=345075&action=review > Source/WebCore/platform/graphics/avfoundation/objc/AVFoundationMIMETypeCache.mm:97 > +#if PLATFORM(IOSMAC) Why does the same issue not impact other configurations? It seems fragile that the only do the safe thing on IOSMAC. 1442821 8 wenson_hsieh 2018-07-17 15:48:24 -0700 (In reply to Alexey Proskuryakov from comment #7) > Comment on attachment 345075 [details] > ChangeLog tweak > > View in context: > https://bugs.webkit.org/attachment.cgi?id=345075&action=review > > > Source/WebCore/platform/graphics/avfoundation/objc/AVFoundationMIMETypeCache.mm:97 > > +#if PLATFORM(IOSMAC) > > Why does the same issue not impact other configurations? It seems fragile > that the only do the safe thing on IOSMAC. It doesn't impact macOS because we don't need to dynamically load iOS-only symbols there. In this case (on iosmac), we were failing to link symbols in AudioSessionIOS, which is not compiled on macOS. 345073 2018-07-15 19:52:04 -0700 2018-07-15 20:15:03 -0700 Patch bug-187690-20180715195203.patch text/plain 2345 wenson_hsieh U3VidmVyc2lvbiBSZXZpc2lvbjogMjMzNjU1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggM2Q3NTMwYzUxNDk5YzQw ODk3ZTI3N2I0ODRmZDVkYmQxM2M1OWU1YS4uMDUzNzFkZDQ4MDU1ZGFjOTNhYmQ5OTI2YzI0ZWRj ZDdkZWU1YTQxYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE4LTA3LTE1ICBXZW5z b24gSHNpZWggIDx3ZW5zb25faHNpZWhAYXBwbGUuY29tPgorCisgICAgICAgIFtpT1MgYXBwcyBv biBtYWNPU10gUGxheWluZyBlbWJlZGRlZCBUd2l0dGVyIHZpZGVvcyBpbiB0aGUgTmV3cyBhcHAg Y3Jhc2hlcyB0aGUgd2ViIHByb2Nlc3MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTE4NzY5MAorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNDE4Njk3MDM+ CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV29yayBh cm91bmQgdW5leHBlY3RlZCBiZWhhdmlvciB3aGVuIHNvZnQtbGlua2luZyBBVkZvdW5kYXRpb24u IEFmdGVyIHVzaW5nIGBkbG9wZW5fcHJlZmxpZ2h0YAorICAgICAgICB0byBjaGVjayBmb3IgdGhl IGV4aXN0ZW5jZSBvZiBhIGxpYnJhcnkgcHJpb3IgdG8gbG9hZGluZyB0aGUgbGlicmFyeSB1c2lu ZyBgZGxvcGVuYCwgYGRsc3ltYAorICAgICAgICBzdWJzZXF1ZW50bHkgcmV0dXJucyBudWxsIGZv ciBzb21lIHN5bWJvbHMgdGhhdCB3b3VsZCBvdGhlcndpc2UgYmUgYXZhaWxhYmxlLgorCisgICAg ICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvYXZmb3VuZGF0aW9uL29iamMvQVZGb3VuZGF0aW9uTUlN RVR5cGVDYWNoZS5tbToKKyAgICAgICAgKFdlYkNvcmU6OkFWRm91bmRhdGlvbk1JTUVUeXBlQ2Fj aGU6OmlzQXZhaWxhYmxlIGNvbnN0KToKKwogMjAxOC0wNy0wOSAgU2ltb24gRnJhc2VyICA8c2lt b24uZnJhc2VyQGFwcGxlLmNvbT4KIAogICAgICAgICBTaHJpbmsgV2ViQ29yZTo6UGFpcgpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvYXZmb3VuZGF0aW9uL29i amMvQVZGb3VuZGF0aW9uTUlNRVR5cGVDYWNoZS5tbSBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL2F2Zm91bmRhdGlvbi9vYmpjL0FWRm91bmRhdGlvbk1JTUVUeXBlQ2FjaGUubW0K aW5kZXggMWI3MTBjODk2YTFjMWJiNmIxODc0YzZhMzNiYzhiMDNiN2U2OWQ3OC4uMGIzMmY3OWY1 ZTkzMzY4NjI4MDE1NjcwYmJkNDQ3NTQzMWVhMTJhZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vZ3JhcGhpY3MvYXZmb3VuZGF0aW9uL29iamMvQVZGb3VuZGF0aW9uTUlNRVR5 cGVDYWNoZS5tbQorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9hdmZvdW5k YXRpb24vb2JqYy9BVkZvdW5kYXRpb25NSU1FVHlwZUNhY2hlLm1tCkBAIC0zNSw3ICszNSw5IEBA CiAjaW1wb3J0IDxwYWwvY2YvQ29yZU1lZGlhU29mdExpbmsuaD4KIAogI2lmIEVOQUJMRShWSURF TykgJiYgVVNFKEFWRk9VTkRBVElPTikKKyNpZiAhUExBVEZPUk0oSU9TTUFDKQogU09GVF9MSU5L X0ZSQU1FV09SS19PUFRJT05BTF9QUkVGTElHSFQoQVZGb3VuZGF0aW9uKQorI2VuZGlmCiBTT0ZU X0xJTktfRlJBTUVXT1JLX09QVElPTkFMKEFWRm91bmRhdGlvbikKIFNPRlRfTElOS19DTEFTUyhB VkZvdW5kYXRpb24sIEFWVVJMQXNzZXQpCiAjZW5kaWYKQEAgLTkyLDcgKzk0LDEzIEBAIGJvb2wg QVZGb3VuZGF0aW9uTUlNRVR5cGVDYWNoZTo6Y2FuRGVjb2RlVHlwZShjb25zdCBTdHJpbmcmIG1p bWVUeXBlKQogYm9vbCBBVkZvdW5kYXRpb25NSU1FVHlwZUNhY2hlOjppc0F2YWlsYWJsZSgpIGNv bnN0CiB7CiAjaWYgRU5BQkxFKFZJREVPKSAmJiBVU0UoQVZGT1VOREFUSU9OKQorI2lmIFBMQVRG T1JNKElPU01BQykKKyAgICAvLyBGSVhNRTogVGhpcyBzaG91bGQgYmUgdXNpbmcgQVZGb3VuZGF0 aW9uTGlicmFyeUlzQXZhaWxhYmxlKCkgaW5zdGVhZCwgYnV0IGRvaW5nIHNvIGNhdXNlcyBzb2Z0 LWxpbmtpbmcKKyAgICAvLyB0byBzdWJzZXF1ZW50bHkgZmFpbCBvbiBjZXJ0YWluIHN5bWJvbHMu IFNlZSA8cmRhcjovL3Byb2JsZW0vNDIyMjQ3ODA+IGZvciBtb3JlIGRldGFpbHMuCisgICAgcmV0 dXJuIEFWRm91bmRhdGlvbkxpYnJhcnkoKTsKKyNlbHNlCiAgICAgcmV0dXJuIEFWRm91bmRhdGlv bkxpYnJhcnlJc0F2YWlsYWJsZSgpOworI2VuZGlmCiAjZWxzZQogICAgIHJldHVybiBmYWxzZTsK ICNlbmRpZgo= 345075 2018-07-15 20:15:04 -0700 2018-07-15 22:19:49 -0700 ChangeLog tweak bug-187690-20180715201504.patch text/plain 2664 wenson_hsieh U3VidmVyc2lvbiBSZXZpc2lvbjogMjMzNjU1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggM2Q3NTMwYzUxNDk5YzQw ODk3ZTI3N2I0ODRmZDVkYmQxM2M1OWU1YS4uOWZlOGVmOTRjMGIzYmJjNTk2YTg5NjU2MGUyMWMx MTUxYjgwMWQ2OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDE4LTA3LTE1ICBXZW5z b24gSHNpZWggIDx3ZW5zb25faHNpZWhAYXBwbGUuY29tPgorCisgICAgICAgIFtpT1MgYXBwcyBv biBtYWNPU10gUGxheWluZyBlbWJlZGRlZCBUd2l0dGVyIHZpZGVvcyBpbiB0aGUgTmV3cyBhcHAg Y3Jhc2hlcyB0aGUgd2ViIHByb2Nlc3MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTE4NzY5MAorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNDE4Njk3MDM+ CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV29yayBh cm91bmQgdW5leHBlY3RlZCBiZWhhdmlvciB3aGVuIHNvZnQtbGlua2luZyBBVkZvdW5kYXRpb24u IEFmdGVyIHVzaW5nIGBkbG9wZW5fcHJlZmxpZ2h0YCB0byBjaGVjayBmb3IgdGhlCisgICAgICAg IGV4aXN0ZW5jZSBvZiBhIGxpYnJhcnkgcHJpb3IgdG8gbG9hZGluZyB0aGUgbGlicmFyeSB1c2lu ZyBgZGxvcGVuYCwgYGRsc3ltYCBzdWJzZXF1ZW50bHkgcmV0dXJucyBudWxsIGZvciBzb21lCisg ICAgICAgIHN5bWJvbHMgdGhhdCB3b3VsZCBvdGhlcndpc2UgYmUgYXZhaWxhYmxlLiBUaGlzIGNh dXNlcyB1cyB0byBSRUxFQVNFX0FTU0VSVCBsYXRlciBkb3duIHRoZSByb2FkIHdoZW4gd2UgdHJ5 IHRvCisgICAgICAgIGxvYWQgQVZBdWRpb1Nlc3Npb25Nb2RlRGVmYXVsdCBpbiBBdWRpb1Nlc3Np b25JT1MubW0uCisKKyAgICAgICAgVG8gZml4IHRoaXMgZm9yIG5vdywgc2ltcGx5IGNoZWNrIGZv ciB0aGUgbGlicmFyeSBkaXJlY3RseSBpbnN0ZWFkIG9mIHVzaW5nIHRoZSBtb3JlIGxpZ2h0d2Vp Z2h0IHByZWZsaWdodAorICAgICAgICBjaGVjay4gU2VlIGNsb25lOiA8cmRhcjovL3Byb2JsZW0v NDIyMjQ3ODA+IGZvciBtb3JlIGRldGFpbC4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNz L2F2Zm91bmRhdGlvbi9vYmpjL0FWRm91bmRhdGlvbk1JTUVUeXBlQ2FjaGUubW06CisgICAgICAg IChXZWJDb3JlOjpBVkZvdW5kYXRpb25NSU1FVHlwZUNhY2hlOjppc0F2YWlsYWJsZSBjb25zdCk6 CisKIDIwMTgtMDctMDkgIFNpbW9uIEZyYXNlciAgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+CiAK ICAgICAgICAgU2hyaW5rIFdlYkNvcmU6OlBhaXIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2dyYXBoaWNzL2F2Zm91bmRhdGlvbi9vYmpjL0FWRm91bmRhdGlvbk1JTUVUeXBl Q2FjaGUubW0gYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9hdmZvdW5kYXRpb24v b2JqYy9BVkZvdW5kYXRpb25NSU1FVHlwZUNhY2hlLm1tCmluZGV4IDFiNzEwYzg5NmExYzFiYjZi MTg3NGM2YTMzYmM4YjAzYjdlNjlkNzguLjBiMzJmNzlmNWU5MzM2ODYyODAxNTY3MGJiZDQ0NzU0 MzFlYTEyYWQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2F2 Zm91bmRhdGlvbi9vYmpjL0FWRm91bmRhdGlvbk1JTUVUeXBlQ2FjaGUubW0KKysrIGIvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvYXZmb3VuZGF0aW9uL29iamMvQVZGb3VuZGF0aW9u TUlNRVR5cGVDYWNoZS5tbQpAQCAtMzUsNyArMzUsOSBAQAogI2ltcG9ydCA8cGFsL2NmL0NvcmVN ZWRpYVNvZnRMaW5rLmg+CiAKICNpZiBFTkFCTEUoVklERU8pICYmIFVTRShBVkZPVU5EQVRJT04p CisjaWYgIVBMQVRGT1JNKElPU01BQykKIFNPRlRfTElOS19GUkFNRVdPUktfT1BUSU9OQUxfUFJF RkxJR0hUKEFWRm91bmRhdGlvbikKKyNlbmRpZgogU09GVF9MSU5LX0ZSQU1FV09SS19PUFRJT05B TChBVkZvdW5kYXRpb24pCiBTT0ZUX0xJTktfQ0xBU1MoQVZGb3VuZGF0aW9uLCBBVlVSTEFzc2V0 KQogI2VuZGlmCkBAIC05Miw3ICs5NCwxMyBAQCBib29sIEFWRm91bmRhdGlvbk1JTUVUeXBlQ2Fj aGU6OmNhbkRlY29kZVR5cGUoY29uc3QgU3RyaW5nJiBtaW1lVHlwZSkKIGJvb2wgQVZGb3VuZGF0 aW9uTUlNRVR5cGVDYWNoZTo6aXNBdmFpbGFibGUoKSBjb25zdAogewogI2lmIEVOQUJMRShWSURF TykgJiYgVVNFKEFWRk9VTkRBVElPTikKKyNpZiBQTEFURk9STShJT1NNQUMpCisgICAgLy8gRklY TUU6IFRoaXMgc2hvdWxkIGJlIHVzaW5nIEFWRm91bmRhdGlvbkxpYnJhcnlJc0F2YWlsYWJsZSgp IGluc3RlYWQsIGJ1dCBkb2luZyBzbyBjYXVzZXMgc29mdC1saW5raW5nCisgICAgLy8gdG8gc3Vi c2VxdWVudGx5IGZhaWwgb24gY2VydGFpbiBzeW1ib2xzLiBTZWUgPHJkYXI6Ly9wcm9ibGVtLzQy MjI0NzgwPiBmb3IgbW9yZSBkZXRhaWxzLgorICAgIHJldHVybiBBVkZvdW5kYXRpb25MaWJyYXJ5 KCk7CisjZWxzZQogICAgIHJldHVybiBBVkZvdW5kYXRpb25MaWJyYXJ5SXNBdmFpbGFibGUoKTsK KyNlbmRpZgogI2Vsc2UKICAgICByZXR1cm4gZmFsc2U7CiAjZW5kaWYK