187683 2018-07-14 17:16:10 -0700 Shrink CompositeAnimation and AnimationBase 2018-07-18 00:03:27 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 simon.fraser simon.fraser commit-queue dbates dino dstockwell ews-watchlist graouts graouts simon.fraser webkit-bug-importer oldest_to_newest 1442254 0 simon.fraser 2018-07-14 17:16:10 -0700 Shrink CompositeAnimation and AnimationBase 1442255 1 345044 simon.fraser 2018-07-14 17:17:04 -0700 Created attachment 345044 Patch 1442410 2 345044 graouts 2018-07-16 10:30:36 -0700 Comment on attachment 345044 Patch I was a bit puzzled by this patch since there was no explanation as to why the member variables were declared in a different spot. Ideally there would be a comment or an assertion if the class size exceeds the expected amount. Then we could refer back to this patch as good practice for memory-efficient classes. 1442613 3 345044 dbates 2018-07-16 20:06:32 -0700 Comment on attachment 345044 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=345044&action=review We may want to consider taking a similar approach as RenderStyle? and add static asserts to prevent a size regression. > Source/WebCore/ChangeLog:8 > + Reduce the size of CompositeAnimation and AnimationBase. How much did we reduce it by? 1442936 4 345044 commit-queue 2018-07-18 00:02:09 -0700 Comment on attachment 345044 Patch Clearing flags on attachment: 345044 Committed r233908: <https://trac.webkit.org/changeset/233908> 1442937 5 commit-queue 2018-07-18 00:02:10 -0700 All reviewed patches have been landed. Closing bug. 1442938 6 webkit-bug-importer 2018-07-18 00:03:27 -0700 <rdar://problem/42323652> 345044 2018-07-14 17:17:04 -0700 2018-07-18 00:02:09 -0700 Patch bug-187683-20180714171703.patch text/plain 4261 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMjMzODMzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZWU1YTQ1NzIzMzdhNTA2 NjljMmYyM2NhNzU0NDdjYTQ4Nzc3YzA4Yi4uNTY4NTMxNmE1ZTU1ODgwOTZmZWEwZjkyNTBmYTdi NDhmMGM4MjEyZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE4LTA3LTE0ICBTaW1v biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCisgICAgICAgIFNocmluayBDb21w b3NpdGVBbmltYXRpb24gYW5kIEFuaW1hdGlvbkJhc2UKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4NzY4MworCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlZHVjZSB0aGUgc2l6ZSBvZiBDb21wb3NpdGVBbmlt YXRpb24gYW5kIEFuaW1hdGlvbkJhc2UuCisKKyAgICAgICAgKiBwYWdlL2FuaW1hdGlvbi9Bbmlt YXRpb25CYXNlLmg6CisgICAgICAgICogcGFnZS9hbmltYXRpb24vQ29tcG9zaXRlQW5pbWF0aW9u Lmg6CisKIDIwMTgtMDctMTMgIFNpbW9uIEZyYXNlciAgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+ CiAKICAgICAgICAgQXZvaWQgZmV0Y2hpbmcgdmlzaXRlZERlcGVuZGVudENvbG9yKCkgc28gbWFu eSB0aW1lcyBpbiBlZGl0aW5nIGNvZGUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BhZ2Uv YW5pbWF0aW9uL0FuaW1hdGlvbkJhc2UuaCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvYW5pbWF0aW9u L0FuaW1hdGlvbkJhc2UuaAppbmRleCBjMDdiOGI1OTE5MTdiNTkxYzJlM2YyNDJhNzg1OTZjNGQz NTNiOWM4Li41Mjk2NmFmOTAwOWJhNDk2MWYyMWFkY2MxNDVjNDA1MDg0NjIxYTQyIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL2FuaW1hdGlvbi9BbmltYXRpb25CYXNlLmgKKysrIGIv U291cmNlL1dlYkNvcmUvcGFnZS9hbmltYXRpb24vQW5pbWF0aW9uQmFzZS5oCkBAIC02Niw3ICs2 Niw3IEBAIHB1YmxpYzoKICAgICAvLyBJZiBzbywgd2Ugc3RheSBpbiB0aGlzIHN0YXRlIHVudGls IHRoYXQgcmVzcG9uc2UgaXMgcmVjZWl2ZWQgKGFuZCBpdCByZXR1cm5zIHRoZSBzdGFydCB0aW1l KS4KICAgICAvLyBPdGhlcndpc2UsIHdlIHVzZSB0aGUgY3VycmVudCB0aW1lIGFzIHRoZSBzdGFy dCB0aW1lIGFuZCBnbyBpbW1lZGlhdGVseSB0byBBbmltYXRpb25TdGF0ZTo6TG9vcGluZwogICAg IC8vIG9yIEFuaW1hdGlvblN0YXRlOjpFbmRpbmcuCi0gICAgZW51bSBjbGFzcyBBbmltYXRpb25T dGF0ZSB7CisgICAgZW51bSBjbGFzcyBBbmltYXRpb25TdGF0ZSA6IHVpbnQ4X3QgewogICAgICAg ICBOZXcsICAgICAgICAgICAgICAgICAgICAgICAgLy8gYW5pbWF0aW9uIGp1c3QgY3JlYXRlZCwg YW5pbWF0aW9uIG5vdCBydW5uaW5nIHlldAogICAgICAgICBTdGFydFdhaXRUaW1lciwgICAgICAg ICAgICAgLy8gc3RhcnQgdGltZXIgcnVubmluZywgd2FpdGluZyBmb3IgZmlyZQogICAgICAgICBT dGFydFdhaXRTdHlsZUF2YWlsYWJsZSwgICAgLy8gd2FpdGluZyBmb3Igc3R5bGUgc2V0dXAgc28g d2UgY2FuIHN0YXJ0IGFuaW1hdGlvbnMKQEAgLTgyLDcgKzgyLDcgQEAgcHVibGljOgogICAgICAg ICBGaWxsaW5nRm9yd2FyZHMgICAgICAgICAgICAgLy8gYW5pbWF0aW9uIGhhcyBlbmRlZCBhbmQg aXMgcmV0YWluaW5nIGl0cyBmaW5hbCB2YWx1ZQogICAgIH07CiAKLSAgICBlbnVtIGNsYXNzIEFu aW1hdGlvblN0YXRlSW5wdXQgeworICAgIGVudW0gY2xhc3MgQW5pbWF0aW9uU3RhdGVJbnB1dCA6 IHVpbnQ4X3QgewogICAgICAgICBNYWtlTmV3LCAgICAgICAgICAgLy8gcmVzZXQgYmFjayB0byBu ZXcgZnJvbSBhbnkgc3RhdGUKICAgICAgICAgU3RhcnRBbmltYXRpb24sICAgIC8vIGFuaW1hdGlv biByZXF1ZXN0cyBhIHN0YXJ0CiAgICAgICAgIFJlc3RhcnRBbmltYXRpb24sICAvLyBmb3JjZSBh IHJlc3RhcnQgZnJvbSBhbnkgc3RhdGUKQEAgLTI0MSw2ICsyNDEsMTQgQEAgcHJvdGVjdGVkOgog ICAgIGJvb2wgY29tcHV0ZVRyYW5zZm9ybWVkRXh0ZW50VmlhVHJhbnNmb3JtTGlzdChjb25zdCBG bG9hdFJlY3QmIHJlbmRlcmVyQm94LCBjb25zdCBSZW5kZXJTdHlsZSYsIExheW91dFJlY3QmIGJv dW5kcykgY29uc3Q7CiAgICAgYm9vbCBjb21wdXRlVHJhbnNmb3JtZWRFeHRlbnRWaWFNYXRyaXgo Y29uc3QgRmxvYXRSZWN0JiByZW5kZXJlckJveCwgY29uc3QgUmVuZGVyU3R5bGUmLCBMYXlvdXRS ZWN0JiBib3VuZHMpIGNvbnN0OwogCitwcm90ZWN0ZWQ6CisgICAgYm9vbCBtX2lzQWNjZWxlcmF0 ZWQgeyBmYWxzZSB9OworICAgIGJvb2wgbV90cmFuc2Zvcm1GdW5jdGlvbkxpc3RzTWF0Y2ggeyBm YWxzZSB9OworICAgIGJvb2wgbV9maWx0ZXJGdW5jdGlvbkxpc3RzTWF0Y2ggeyBmYWxzZSB9Owor I2lmIEVOQUJMRShGSUxURVJTX0xFVkVMXzIpCisgICAgYm9vbCBtX2JhY2tkcm9wRmlsdGVyRnVu Y3Rpb25MaXN0c01hdGNoIHsgZmFsc2UgfTsKKyNlbmRpZgorCiBwcml2YXRlOgogICAgIFJlZlB0 cjxFbGVtZW50PiBtX2VsZW1lbnQ7CiAKQEAgLTI1NSwxMiArMjYzLDYgQEAgcHJvdGVjdGVkOgog ICAgIHN0ZDo6b3B0aW9uYWw8ZG91YmxlPiBtX25leHRJdGVyYXRpb25EdXJhdGlvbjsKIAogICAg IEFuaW1hdGlvblN0YXRlIG1fYW5pbWF0aW9uU3RhdGUgeyBBbmltYXRpb25TdGF0ZTo6TmV3IH07 Ci0gICAgYm9vbCBtX2lzQWNjZWxlcmF0ZWQgeyBmYWxzZSB9OwotICAgIGJvb2wgbV90cmFuc2Zv cm1GdW5jdGlvbkxpc3RzTWF0Y2ggeyBmYWxzZSB9OwotICAgIGJvb2wgbV9maWx0ZXJGdW5jdGlv bkxpc3RzTWF0Y2ggeyBmYWxzZSB9OwotI2lmIEVOQUJMRShGSUxURVJTX0xFVkVMXzIpCi0gICAg Ym9vbCBtX2JhY2tkcm9wRmlsdGVyRnVuY3Rpb25MaXN0c01hdGNoIHsgZmFsc2UgfTsKLSNlbmRp ZgogICAgIGJvb2wgbV9jb2xvckZpbHRlckZ1bmN0aW9uTGlzdHNNYXRjaCB7IGZhbHNlIH07CiB9 OwogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL2FuaW1hdGlvbi9Db21wb3NpdGVB bmltYXRpb24uaCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvYW5pbWF0aW9uL0NvbXBvc2l0ZUFuaW1h dGlvbi5oCmluZGV4IGZiOGFhMWVkMmRiZDFhMTk0MTUyN2ZiOWNjODA5MWVlZGMxYWRjNDUuLjYz Mzc1OWRhZWMxOWJlODliNzVkNjBkNTM2OGM1NjE1M2YxZWJlZDYgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL3BhZ2UvYW5pbWF0aW9uL0NvbXBvc2l0ZUFuaW1hdGlvbi5oCisrKyBiL1NvdXJj ZS9XZWJDb3JlL3BhZ2UvYW5pbWF0aW9uL0NvbXBvc2l0ZUFuaW1hdGlvbi5oCkBAIC05NSwxNSAr OTUsMTYgQEAgcHJpdmF0ZToKICAgICB0eXBlZGVmIEhhc2hNYXA8aW50LCBSZWZQdHI8SW1wbGlj aXRBbmltYXRpb24+PiBDU1NQcm9wZXJ0eVRyYW5zaXRpb25zTWFwOwogICAgIHR5cGVkZWYgSGFz aE1hcDxBdG9taWNTdHJpbmdJbXBsKiwgUmVmUHRyPEtleWZyYW1lQW5pbWF0aW9uPj4gQW5pbWF0 aW9uTmFtZU1hcDsKIAotICAgIENTU0FuaW1hdGlvbkNvbnRyb2xsZXJQcml2YXRlJiBtX2FuaW1h dGlvbkNvbnRyb2xsZXI7Ci0gICAgQ1NTUHJvcGVydHlUcmFuc2l0aW9uc01hcCBtX3RyYW5zaXRp b25zOwotICAgIEFuaW1hdGlvbk5hbWVNYXAgbV9rZXlmcmFtZUFuaW1hdGlvbnM7Ci0gICAgVmVj dG9yPEF0b21pY1N0cmluZ0ltcGwqPiBtX2tleWZyYW1lQW5pbWF0aW9uT3JkZXJNYXA7Ci0gICAg Ym9vbCBtX3N1c3BlbmRlZDsKKyAgICBib29sIG1fc3VzcGVuZGVkIHsgZmFsc2UgfTsKICAgICBi b29sIG1faGFzQW5pbWF0aW9uVGhhdERlcGVuZHNPbkxheW91dCB7IGZhbHNlIH07CiAjaWYgRU5B QkxFKENTU19BTklNQVRJT05TX0xFVkVMXzIpCiAgICAgYm9vbCBtX2hhc1Njcm9sbFRyaWdnZXJl ZEFuaW1hdGlvbiB7IGZhbHNlIH07CiAjZW5kaWYKKworICAgIENTU0FuaW1hdGlvbkNvbnRyb2xs ZXJQcml2YXRlJiBtX2FuaW1hdGlvbkNvbnRyb2xsZXI7CisgICAgQ1NTUHJvcGVydHlUcmFuc2l0 aW9uc01hcCBtX3RyYW5zaXRpb25zOworICAgIEFuaW1hdGlvbk5hbWVNYXAgbV9rZXlmcmFtZUFu aW1hdGlvbnM7CisgICAgVmVjdG9yPEF0b21pY1N0cmluZ0ltcGwqPiBtX2tleWZyYW1lQW5pbWF0 aW9uT3JkZXJNYXA7CiB9OwogCiB9IC8vIG5hbWVzcGFjZSBXZWJDb3JlCg==