187676 2018-07-13 18:43:23 -0700 Avoid fetching visitedDependentColor() so many times in editing code 2018-07-13 19:16:15 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 simon.fraser simon.fraser commit-queue rniwa simon.fraser webkit-bug-importer zalan oldest_to_newest 1442142 0 simon.fraser 2018-07-13 18:43:23 -0700 Avoid fetching visitedDependentColor() so many times in editing code 1442143 1 345013 simon.fraser 2018-07-13 18:44:57 -0700 Created attachment 345013 Patch 1442149 2 345013 commit-queue 2018-07-13 19:15:56 -0700 Comment on attachment 345013 Patch Clearing flags on attachment: 345013 Committed r233833: <https://trac.webkit.org/changeset/233833> 1442150 3 commit-queue 2018-07-13 19:15:58 -0700 All reviewed patches have been landed. Closing bug. 1442151 4 webkit-bug-importer 2018-07-13 19:16:15 -0700 <rdar://problem/42190329> 345013 2018-07-13 18:44:57 -0700 2018-07-13 19:15:56 -0700 Patch bug-187676-20180713184457.patch text/plain 4470 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMjMzODE2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZmRkMzZhOTEyYmI4MjY3 MWQ3MmRhMjRkNGQyZTM4N2M4NmUzODQyNi4uODQ1NTE4MWQwNzgyYjI5NGNlZmE5NTUyMWU5ZWQ0 NDY2NmY1YzFhMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDE4LTA3LTEzICBTaW1v biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCisgICAgICAgIEF2b2lkIGZldGNo aW5nIHZpc2l0ZWREZXBlbmRlbnRDb2xvcigpIHNvIG1hbnkgdGltZXMgaW4gZWRpdGluZyBjb2Rl CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODc2NzYK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKyAgICAgICAgCisgICAgICAg IGVkaXRpbmdBdHRyaWJ1dGVkU3RyaW5nRnJvbVJhbmdlIGNhbGxlZCBzdHlsZS52aXNpdGVkRGVw ZW5kZW50Q29sb3IoKSB0d2ljZSBmb3IgZWFjaCBwcm9wZXJ0eSwKKyAgICAgICAgYW5kIGZvbnRB dHRyaWJ1dGVzRm9yU2VsZWN0aW9uU3RhcnQoKSBjYWxsZWQgaXQgdHdvIG9yIHRocmVlIHRpbWVz LiBVc2UgYSBsb2NhbCBDb2xvciB2YXJpYWJsZQorICAgICAgICB0byBhdm9pZCBzbyBtYW55IGNh bGxzLiBBbHNvIHJlcGxhY2UgYSBjYWxsIHRvIGFscGhhKCkgd2l0aCBpc1Zpc2libGUoKSB3aGlj aCBtYWtlcyB0aGUgdXNhZ2UgbW9yZSBjbGVhci4KKworICAgICAgICBObyBiZWhhdmlvciBjaGFu Z2UuCisKKyAgICAgICAgKiBlZGl0aW5nL2NvY29hL0VkaXRvckNvY29hLm1tOgorICAgICAgICAo V2ViQ29yZTo6RWRpdG9yOjpmb250QXR0cmlidXRlc0ZvclNlbGVjdGlvblN0YXJ0IGNvbnN0KToK KyAgICAgICAgKiBlZGl0aW5nL2NvY29hL0hUTUxDb252ZXJ0ZXIubW06CisgICAgICAgIChXZWJD b3JlOjplZGl0aW5nQXR0cmlidXRlZFN0cmluZ0Zyb21SYW5nZSk6CisKIDIwMTgtMDctMTMgIFJ5 b3N1a2UgTml3YSAgPHJuaXdhQHdlYmtpdC5vcmc+CiAKICAgICAgICAgW2lPU10gW1dLMV0gQ3Jh c2ggaW5zaWRlIElPU3VyZmFjZVBvb2w6OnBsYXRmb3JtR2FyYmFnZUNvbGxlY3ROb3coKSBpbiBX ZWJUaHJlYWQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2VkaXRpbmcvY29jb2EvRWRpdG9y Q29jb2EubW0gYi9Tb3VyY2UvV2ViQ29yZS9lZGl0aW5nL2NvY29hL0VkaXRvckNvY29hLm1tCmlu ZGV4IDA2M2Q3MjMxYWFjMTUwMTZkMzhiOWEyNGViNDNiODg2NjM3NTM1ZDIuLjQzMmRjMTk1MDc2 MzVmNTZmODMwOThmMGJjNGFhM2M4ZWM4MzRlYWIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L2VkaXRpbmcvY29jb2EvRWRpdG9yQ29jb2EubW0KKysrIGIvU291cmNlL1dlYkNvcmUvZWRpdGlu Zy9jb2NvYS9FZGl0b3JDb2NvYS5tbQpAQCAtOTMsMTEgKzkzLDEzIEBAIFJldGFpblB0cjxOU0Rp Y3Rpb25hcnk+IEVkaXRvcjo6Zm9udEF0dHJpYnV0ZXNGb3JTZWxlY3Rpb25TdGFydCgpIGNvbnN0 CiAKICAgICAvLyBGSVhNRTogV2h5IHdvdWxkIHdlIG5vdCB3YW50IHRvIHJldHJpZXZlIHRoZXNl IGF0dHJpYnV0ZXMgb24gaU9TPwogI2lmIFBMQVRGT1JNKE1BQykKLSAgICBpZiAoc3R5bGUtPnZp c2l0ZWREZXBlbmRlbnRDb2xvcihDU1NQcm9wZXJ0eUJhY2tncm91bmRDb2xvcikuaXNWaXNpYmxl KCkpCi0gICAgICAgIFthdHRyaWJ1dGVzIHNldE9iamVjdDpuc0NvbG9yKHN0eWxlLT52aXNpdGVk RGVwZW5kZW50Q29sb3IoQ1NTUHJvcGVydHlCYWNrZ3JvdW5kQ29sb3IpKSBmb3JLZXk6TlNCYWNr Z3JvdW5kQ29sb3JBdHRyaWJ1dGVOYW1lXTsKKyAgICBDb2xvciBiYWNrZ3JvdW5kQ29sb3IgPSBz dHlsZS0+dmlzaXRlZERlcGVuZGVudENvbG9yKENTU1Byb3BlcnR5QmFja2dyb3VuZENvbG9yKTsK KyAgICBpZiAoYmFja2dyb3VuZENvbG9yLmlzVmlzaWJsZSgpKQorICAgICAgICBbYXR0cmlidXRl cyBzZXRPYmplY3Q6bnNDb2xvcihiYWNrZ3JvdW5kQ29sb3IpIGZvcktleTpOU0JhY2tncm91bmRD b2xvckF0dHJpYnV0ZU5hbWVdOwogCi0gICAgaWYgKHN0eWxlLT52aXNpdGVkRGVwZW5kZW50Q29s b3IoQ1NTUHJvcGVydHlDb2xvcikuaXNWYWxpZCgpICYmICFDb2xvcjo6aXNCbGFja0NvbG9yKHN0 eWxlLT52aXNpdGVkRGVwZW5kZW50Q29sb3IoQ1NTUHJvcGVydHlDb2xvcikpKQotICAgICAgICBb YXR0cmlidXRlcyBzZXRPYmplY3Q6bnNDb2xvcihzdHlsZS0+dmlzaXRlZERlcGVuZGVudENvbG9y KENTU1Byb3BlcnR5Q29sb3IpKSBmb3JLZXk6TlNGb3JlZ3JvdW5kQ29sb3JBdHRyaWJ1dGVOYW1l XTsKKyAgICBDb2xvciBmb3JlZ3JvdW5kQ29sb3IgPSBzdHlsZS0+dmlzaXRlZERlcGVuZGVudENv bG9yKENTU1Byb3BlcnR5Q29sb3IpOworICAgIGlmIChmb3JlZ3JvdW5kQ29sb3IuaXNWYWxpZCgp ICYmICFDb2xvcjo6aXNCbGFja0NvbG9yKGZvcmVncm91bmRDb2xvcikpCisgICAgICAgIFthdHRy aWJ1dGVzIHNldE9iamVjdDpuc0NvbG9yKGZvcmVncm91bmRDb2xvcikgZm9yS2V5Ok5TRm9yZWdy b3VuZENvbG9yQXR0cmlidXRlTmFtZV07CiAKICAgICBjb25zdCBTaGFkb3dEYXRhKiBzaGFkb3dE YXRhID0gc3R5bGUtPnRleHRTaGFkb3coKTsKICAgICBpZiAoc2hhZG93RGF0YSkgewpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvZWRpdGluZy9jb2NvYS9IVE1MQ29udmVydGVyLm1tIGIvU291 cmNlL1dlYkNvcmUvZWRpdGluZy9jb2NvYS9IVE1MQ29udmVydGVyLm1tCmluZGV4IDIxNDQ2NTI4 N2QxM2U1MjFmOGJiNTEyMGMzMWFiMTk2MzBmNzA3NDkuLjM5MDcyMzU5NDk1YTQ0NDhmYjU0MGI2 MmE0NTAyNWNhNmU3YWFiNDUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2VkaXRpbmcvY29j b2EvSFRNTENvbnZlcnRlci5tbQorKysgYi9Tb3VyY2UvV2ViQ29yZS9lZGl0aW5nL2NvY29hL0hU TUxDb252ZXJ0ZXIubW0KQEAgLTI1MTMsMTIgKzI1MTMsMTYgQEAgTlNBdHRyaWJ1dGVkU3RyaW5n ICplZGl0aW5nQXR0cmlidXRlZFN0cmluZ0Zyb21SYW5nZShSYW5nZSYgcmFuZ2UsIEluY2x1ZGVJ bWFnZXMKICAgICAgICAgICAgIFthdHRycy5nZXQoKSBzZXRPYmplY3Q6dG9OU0ZvbnQoZm9udCkg Zm9yS2V5Ok5TRm9udEF0dHJpYnV0ZU5hbWVdOwogICAgICAgICBlbHNlCiAgICAgICAgICAgICBb YXR0cnMuZ2V0KCkgc2V0T2JqZWN0Oltmb250TWFuYWdlciBjb252ZXJ0Rm9udDpXZWJEZWZhdWx0 Rm9udCgpIHRvU2l6ZTpzdHlsZS5mb250Q2FzY2FkZSgpLnByaW1hcnlGb250KCkucGxhdGZvcm1E YXRhKCkuc2l6ZSgpXSBmb3JLZXk6TlNGb250QXR0cmlidXRlTmFtZV07Ci0gICAgICAgIGlmIChz dHlsZS52aXNpdGVkRGVwZW5kZW50Q29sb3IoQ1NTUHJvcGVydHlDb2xvcikuYWxwaGEoKSkKLSAg ICAgICAgICAgIFthdHRycy5nZXQoKSBzZXRPYmplY3Q6bnNDb2xvcihzdHlsZS52aXNpdGVkRGVw ZW5kZW50Q29sb3IoQ1NTUHJvcGVydHlDb2xvcikpIGZvcktleTpOU0ZvcmVncm91bmRDb2xvckF0 dHJpYnV0ZU5hbWVdOworCisgICAgICAgIENvbG9yIGZvcmVncm91bmRDb2xvciA9IHN0eWxlLnZp c2l0ZWREZXBlbmRlbnRDb2xvcihDU1NQcm9wZXJ0eUNvbG9yKTsKKyAgICAgICAgaWYgKGZvcmVn cm91bmRDb2xvci5pc1Zpc2libGUoKSkKKyAgICAgICAgICAgIFthdHRycy5nZXQoKSBzZXRPYmpl Y3Q6bnNDb2xvcihmb3JlZ3JvdW5kQ29sb3IpIGZvcktleTpOU0ZvcmVncm91bmRDb2xvckF0dHJp YnV0ZU5hbWVdOwogICAgICAgICBlbHNlCiAgICAgICAgICAgICBbYXR0cnMuZ2V0KCkgcmVtb3Zl T2JqZWN0Rm9yS2V5Ok5TRm9yZWdyb3VuZENvbG9yQXR0cmlidXRlTmFtZV07Ci0gICAgICAgIGlm IChzdHlsZS52aXNpdGVkRGVwZW5kZW50Q29sb3IoQ1NTUHJvcGVydHlCYWNrZ3JvdW5kQ29sb3Ip LmFscGhhKCkpCi0gICAgICAgICAgICBbYXR0cnMuZ2V0KCkgc2V0T2JqZWN0Om5zQ29sb3Ioc3R5 bGUudmlzaXRlZERlcGVuZGVudENvbG9yKENTU1Byb3BlcnR5QmFja2dyb3VuZENvbG9yKSkgZm9y S2V5Ok5TQmFja2dyb3VuZENvbG9yQXR0cmlidXRlTmFtZV07CisKKyAgICAgICAgQ29sb3IgYmFj a2dyb3VuZENvbG9yID0gc3R5bGUudmlzaXRlZERlcGVuZGVudENvbG9yKENTU1Byb3BlcnR5QmFj a2dyb3VuZENvbG9yKTsKKyAgICAgICAgaWYgKGJhY2tncm91bmRDb2xvci5pc1Zpc2libGUoKSkK KyAgICAgICAgICAgIFthdHRycy5nZXQoKSBzZXRPYmplY3Q6bnNDb2xvcihiYWNrZ3JvdW5kQ29s b3IpIGZvcktleTpOU0JhY2tncm91bmRDb2xvckF0dHJpYnV0ZU5hbWVdOwogICAgICAgICBlbHNl CiAgICAgICAgICAgICBbYXR0cnMuZ2V0KCkgcmVtb3ZlT2JqZWN0Rm9yS2V5Ok5TQmFja2dyb3Vu ZENvbG9yQXR0cmlidXRlTmFtZV07CiAK