187675 2018-07-13 18:40:08 -0700 CustomConfigurationTestGroupForm should dispatch different arguments based on whether analysis task is created. 2018-07-16 22:18:21 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 dewei_zhu webkit-unassigned dewei_zhu rniwa oldest_to_newest 1442141 0 dewei_zhu 2018-07-13 18:40:08 -0700 CustomConfigurationTestGroupForm should dispatch different arguments based on whether analysis task is created. 1442144 1 345014 dewei_zhu 2018-07-13 18:46:06 -0700 Created attachment 345014 Patch 1442611 2 345014 rniwa 2018-07-16 20:00:38 -0700 Comment on attachment 345014 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=345014&action=review > Websites/perf.webkit.org/public/v3/components/custom-configuration-test-group-form.js:41 > + if (!this._hasTask) We should assert that !!this._hasTask == !taskName 1442645 3 dewei_zhu 2018-07-16 22:18:21 -0700 Landed in r233884. 345014 2018-07-13 18:46:06 -0700 2018-07-16 19:59:47 -0700 Patch bug-187675-20180713184605.patch text/plain 2386 dewei_zhu U3VidmVyc2lvbiBSZXZpc2lvbjogMjMzODMxCmRpZmYgLS1naXQgYS9XZWJzaXRlcy9wZXJmLndl YmtpdC5vcmcvQ2hhbmdlTG9nIGIvV2Vic2l0ZXMvcGVyZi53ZWJraXQub3JnL0NoYW5nZUxvZwpp bmRleCA0NGZiOWNlZjM0MTc3NGIwNTc5YzJhODBjODg4ZTIzOTQ2Zjk4YzM0Li43YzE5YjM2YmNi NThhYzkzNDI0YzE5ODNkYzcxZTEyOTcxODAyZGM4IDEwMDY0NAotLS0gYS9XZWJzaXRlcy9wZXJm LndlYmtpdC5vcmcvQ2hhbmdlTG9nCisrKyBiL1dlYnNpdGVzL3BlcmYud2Via2l0Lm9yZy9DaGFu Z2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAxOC0wNy0xMyAgRGV3ZWkgWmh1ICA8ZGV3ZWlfemh1 QGFwcGxlLmNvbT4KKworICAgICAgICBDdXN0b21Db25maWd1cmF0aW9uVGVzdEdyb3VwRm9ybSBz aG91bGQgZGlzcGF0Y2ggZGlmZmVyZW50IGFyZ3VtZW50cyBiYXNlZCBvbiB3aGV0aGVyIGFuYWx5 c2lzIHRhc2sgaXMgY3JlYXRlZC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTE4NzY3NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIFRoaXMgY2hhbmdlIHdpbGwgZml4IHRoZSBidWcgdGhhdCBubyBub3RpZmlj YXRpb24gd2lsbCBiZSBzZW50IGZvciBhbnkgdGVzdCBncm91cHMgZXhjZXB0IHRoZQorICAgICAg ICBmaXJzdCBvbmUgaW4gYW55IGN1c3RvbSBwZXJmLXRyeSBBL0IgdGFzay4KKworICAgICAgICAq IHB1YmxpYy92My9jb21wb25lbnRzL2N1c3RvbS1jb25maWd1cmF0aW9uLXRlc3QtZ3JvdXAtZm9y bS5qczoKKyAgICAgICAgKEN1c3RvbUNvbmZpZ3VyYXRpb25UZXN0R3JvdXBGb3JtLnByb3RvdHlw ZS5zdGFydFRlc3RpbmcpOiBDb25kaXRpb25hbGx5IGluY2x1ZGVzIHRhc2tOYW1lIGJhc2VkIG9u CisgICAgICAgIHdoZXRoZXIgb3Igbm90IGFuYWx5c2lzIHRhc2sgaXMgY3JlYXRlZC4KKwogMjAx OC0wNy0wMyAgRGV3ZWkgWmh1ICA8ZGV3ZWlfemh1QGFwcGxlLmNvbT4KIAogICAgICAgICBNZWFz dXJlbWVudFNldCBzaG91bGQgbWVyZ2UgbGFzdCBmb3VyIHNlZ21lbnRzIGludG8gdHdvIGlmIHZh bHVlcyBhcmUgaWRlbnRpY2FsLgpkaWZmIC0tZ2l0IGEvV2Vic2l0ZXMvcGVyZi53ZWJraXQub3Jn L3B1YmxpYy92My9jb21wb25lbnRzL2N1c3RvbS1jb25maWd1cmF0aW9uLXRlc3QtZ3JvdXAtZm9y bS5qcyBiL1dlYnNpdGVzL3BlcmYud2Via2l0Lm9yZy9wdWJsaWMvdjMvY29tcG9uZW50cy9jdXN0 b20tY29uZmlndXJhdGlvbi10ZXN0LWdyb3VwLWZvcm0uanMKaW5kZXggMmEyYjg2N2Y1ZmIzNjIy OGY1ZDhiYTYwNTAxNjg4NzAyODliMzRmNi4uMDJlMzQyOTZlNTVhNDdmZmZjNTdmNmQyNTI3ZWZj OTg3NjNlM2IyZCAxMDA2NDQKLS0tIGEvV2Vic2l0ZXMvcGVyZi53ZWJraXQub3JnL3B1YmxpYy92 My9jb21wb25lbnRzL2N1c3RvbS1jb25maWd1cmF0aW9uLXRlc3QtZ3JvdXAtZm9ybS5qcworKysg Yi9XZWJzaXRlcy9wZXJmLndlYmtpdC5vcmcvcHVibGljL3YzL2NvbXBvbmVudHMvY3VzdG9tLWNv bmZpZ3VyYXRpb24tdGVzdC1ncm91cC1mb3JtLmpzCkBAIC0zOCw3ICszOCwxMCBAQCBjbGFzcyBD dXN0b21Db25maWd1cmF0aW9uVGVzdEdyb3VwRm9ybSBleHRlbmRzIFRlc3RHcm91cEZvcm0gewog ICAgICAgICBjb25zdCBjb21taXRTZXRzID0gY29uZmlndXJhdG9yLmNvbW1pdFNldHMoKTsKICAg ICAgICAgY29uc3QgcGxhdGZvcm0gPSBjb25maWd1cmF0b3IucGxhdGZvcm0oKTsKICAgICAgICAg Y29uc3QgdGVzdCA9IGNvbmZpZ3VyYXRvci50ZXN0cygpWzBdOyAvLyBGSVhNRTogQWRkIHRoZSBz dXBwb3J0IGZvciBzcGVjaWZ5aW5nIG11bHRpcGxlIHRlc3RzLgotICAgICAgICB0aGlzLmRpc3Bh dGNoQWN0aW9uKCdzdGFydFRlc3RpbmcnLCB0aGlzLl9yZXBldGl0aW9uQ291bnQsIHRlc3RHcm91 cE5hbWUsIGNvbW1pdFNldHMsIHBsYXRmb3JtLCB0ZXN0LCB0YXNrTmFtZSwgdGhpcy5fbm90aWZ5 T25Db21wbGV0aW9uKTsKKyAgICAgICAgaWYgKCF0aGlzLl9oYXNUYXNrKQorICAgICAgICAgICAg dGhpcy5kaXNwYXRjaEFjdGlvbignc3RhcnRUZXN0aW5nJywgdGhpcy5fcmVwZXRpdGlvbkNvdW50 LCB0ZXN0R3JvdXBOYW1lLCBjb21taXRTZXRzLCBwbGF0Zm9ybSwgdGVzdCwgdGFza05hbWUsIHRo aXMuX25vdGlmeU9uQ29tcGxldGlvbik7CisgICAgICAgIGVsc2UKKyAgICAgICAgICAgIHRoaXMu ZGlzcGF0Y2hBY3Rpb24oJ3N0YXJ0VGVzdGluZycsIHRoaXMuX3JlcGV0aXRpb25Db3VudCwgdGVz dEdyb3VwTmFtZSwgY29tbWl0U2V0cywgcGxhdGZvcm0sIHRlc3QsIHRoaXMuX25vdGlmeU9uQ29t cGxldGlvbik7CiAgICAgfQogCiAgICAgZGlkQ29uc3RydWN0U2hhZG93VHJlZSgpCg==