187672 2018-07-13 16:59:41 -0700 Replace TR2_OPTIONAL_ASSERTED_EXPRESSION macro in <wtf/Optional.h> 2018-07-14 10:01:18 -0700 1 1 1 Unclassified WebKit Web Template Framework WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=187669 https://bugs.webkit.org/show_bug.cgi?id=185159 https://bugs.webkit.org/show_bug.cgi?id=186536 InRadar P2 Normal --- 1 ddkilzer webkit-unassigned benjamin cdumez cmarcelo commit-queue dbates ews-watchlist fred.wang mcatanzaro rniwa webkit-bug-importer ysuzuki oldest_to_newest 1442108 0 ddkilzer 2018-07-13 16:59:41 -0700 Replace the TR2_OPTIONAL_ASSERTED_EXPRESSION macro in <wtf/Optional.h> since we can use ASSERT_UNDER_CONSTEXPR_CONTEXT() instead. Makes all the assertions more consistent within the class. 1442119 1 345007 ddkilzer 2018-07-13 17:23:20 -0700 Created attachment 345007 Patch v1 1442185 2 345007 fred.wang 2018-07-13 23:44:01 -0700 Comment on attachment 345007 Patch v1 Yes, I guess the only reason we have this is because we copied it from https://github.com/akrzemi1/Optional/blob/master/optional.hpp#L199. 1442217 3 345007 commit-queue 2018-07-14 10:00:01 -0700 Comment on attachment 345007 Patch v1 Clearing flags on attachment: 345007 Committed r233836: <https://trac.webkit.org/changeset/233836> 1442218 4 commit-queue 2018-07-14 10:00:03 -0700 All reviewed patches have been landed. Closing bug. 1442219 5 webkit-bug-importer 2018-07-14 10:01:18 -0700 <rdar://problem/42202102> 345007 2018-07-13 17:23:20 -0700 2018-07-14 10:00:01 -0700 Patch v1 0001-Replace-TR2_OPTIONAL_ASSERTED_EXPRESSION-macro-in-wt.patch text/plain 3447 ddkilzer RnJvbSBlOWI2NGRhMDk1ODYxZGNiOGMxYzdmMjVhNWEzZTUyNGEyN2I5MDJmIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBEYXZpZCBLaWx6ZXIgPGRka2lsemVyQGFwcGxlLmNvbT4KRGF0 ZTogRnJpLCAxMyBKdWwgMjAxOCAxNzoxNTo1MyAtMDcwMApTdWJqZWN0OiBbUEFUQ0ggMS8yXSBS ZXBsYWNlIFRSMl9PUFRJT05BTF9BU1NFUlRFRF9FWFBSRVNTSU9OIG1hY3JvIGluCiA8d3RmL09w dGlvbmFsLmg+IDxodHRwczovL3dlYmtpdC5vcmcvYi8xODc2NzI+CgpSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KCiogd3RmL09wdGlvbmFsLmg6CihzdGQ6Om9wdGlvbmFsOjpvcGVyYXRvciAt PiBjb25zdCk6CihzdGQ6Om9wdGlvbmFsOjpvcGVyYXRvciAqIGNvbnN0KToKKHN0ZDo6b3B0aW9u YWw8VDo6b3BlcmF0b3ItPiBjb25zdCk6CihzdGQ6Om9wdGlvbmFsPFQ6Om9wZXJhdG9yKiBjb25z dCk6Ci0gUmVwbGFjZSBUUjJfT1BUSU9OQUxfQVNTRVJURURfRVhQUkVTU0lPTiBtYWNybyB3aXRo CiAgQVNTRVJUX1VOREVSX0NPTlNURVhQUl9DT05URVhUIG1hY3JvIGFuZCByZXR1cm4gc3RhdGVt ZW50LgotLS0KIFNvdXJjZS9XVEYvQ2hhbmdlTG9nICAgICAgfCAxNSArKysrKysrKysrKysrKysK IFNvdXJjZS9XVEYvd3RmL09wdGlvbmFsLmggfCAxOSArKysrKysrKy0tLS0tLS0tLS0tCiAyIGZp bGVzIGNoYW5nZWQsIDIzIGluc2VydGlvbnMoKyksIDExIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdp dCBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nIGIvU291cmNlL1dURi9DaGFuZ2VMb2cKaW5kZXggZDRk NzkxZTgyOGYuLmE4ODA3NzFkNjQ5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL0NoYW5nZUxvZwor KysgYi9Tb3VyY2UvV1RGL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE4LTA3LTEzICBE YXZpZCBLaWx6ZXIgIDxkZGtpbHplckBhcHBsZS5jb20+CisKKyAgICAgICAgUmVwbGFjZSBUUjJf T1BUSU9OQUxfQVNTRVJURURfRVhQUkVTU0lPTiBtYWNybyBpbiA8d3RmL09wdGlvbmFsLmg+Cisg ICAgICAgIDxodHRwczovL3dlYmtpdC5vcmcvYi8xODc2NzI+CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiB3dGYvT3B0aW9uYWwuaDoKKyAgICAgICAg KHN0ZDo6b3B0aW9uYWw6Om9wZXJhdG9yIC0+IGNvbnN0KToKKyAgICAgICAgKHN0ZDo6b3B0aW9u YWw6Om9wZXJhdG9yICogY29uc3QpOgorICAgICAgICAoc3RkOjpvcHRpb25hbDxUOjpvcGVyYXRv ci0+IGNvbnN0KToKKyAgICAgICAgKHN0ZDo6b3B0aW9uYWw8VDo6b3BlcmF0b3IqIGNvbnN0KToK KyAgICAgICAgLSBSZXBsYWNlIFRSMl9PUFRJT05BTF9BU1NFUlRFRF9FWFBSRVNTSU9OIG1hY3Jv IHdpdGgKKyAgICAgICAgICBBU1NFUlRfVU5ERVJfQ09OU1RFWFBSX0NPTlRFWFQgbWFjcm8gYW5k IHJldHVybiBzdGF0ZW1lbnQuCisKIDIwMTgtMDctMTMgIE1hcmsgTGFtICA8bWFyay5sYW1AYXBw bGUuY29tPgogCiAgICAgICAgIFNpZ25hbC5jcHAncyBhY3RpdmVUaHJlYWRzKCkgc2hvdWxkIG9u bHkgY3JlYXRlIGl0cyBUaHJlYWRHcm91cCBvbmNlLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dURi93 dGYvT3B0aW9uYWwuaCBiL1NvdXJjZS9XVEYvd3RmL09wdGlvbmFsLmgKaW5kZXggZDE4MmRjOGRh YTEuLmU2NGE4MGE1ZDZkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL3d0Zi9PcHRpb25hbC5oCisr KyBiL1NvdXJjZS9XVEYvd3RmL09wdGlvbmFsLmgKQEAgLTIzNSwxMiArMjM1LDYgQEAgdGVtcGxh dGUgPGNsYXNzIFQ+IGlubGluZSBjb25zdGV4cHIgdHlwZW5hbWUgc3RkOjpyZW1vdmVfcmVmZXJl bmNlPFQ+Ojp0eXBlJiYgY28KICAgICByZXR1cm4gc3RhdGljX2Nhc3Q8dHlwZW5hbWUgc3RkOjpy ZW1vdmVfcmVmZXJlbmNlPFQ+Ojp0eXBlJiY+KHQpOwogfQogCi0jaWYgZGVmaW5lZCBOREVCVUcK LSMgZGVmaW5lIFRSMl9PUFRJT05BTF9BU1NFUlRFRF9FWFBSRVNTSU9OKENIRUNLLCBFWFBSKSAo RVhQUikKLSNlbHNlCi0jIGRlZmluZSBUUjJfT1BUSU9OQUxfQVNTRVJURURfRVhQUkVTU0lPTihD SEVDSywgRVhQUikgKChDSEVDSykgPyAoRVhQUikgOiAoW117YXNzZXJ0KCEjQ0hFQ0spO30oKSwg KEVYUFIpKSkKLSNlbmRpZgotCiAKIC8vIHN0YXRpY19hZGRyZXNzb2Y6IGEgY29uc3RleHByIHZl cnNpb24gb2YgYWRkcmVzc29mCiB0ZW1wbGF0ZSA8dHlwZW5hbWUgVD4KQEAgLTUyNiw3ICs1MjAs OCBAQCBwdWJsaWM6CiAgIGNvbnN0ZXhwciBib29sIGhhc192YWx1ZSgpIGNvbnN0IF9fTk9FWENF UFQgeyByZXR1cm4gaW5pdGlhbGl6ZWQoKTsgfQogCiAgIGNvbnN0ZXhwciBUIGNvbnN0KiBvcGVy YXRvciAtPigpIGNvbnN0IHsKLSAgICByZXR1cm4gVFIyX09QVElPTkFMX0FTU0VSVEVEX0VYUFJF U1NJT04oaW5pdGlhbGl6ZWQoKSwgZGF0YXB0cigpKTsKKyAgICBBU1NFUlRfVU5ERVJfQ09OU1RF WFBSX0NPTlRFWFQoaW5pdGlhbGl6ZWQoKSk7CisgICAgcmV0dXJuIGRhdGFwdHIoKTsKICAgfQog CiAgIE9QVElPTkFMX01VVEFCTEVfQ09OU1RFWFBSIFQqIG9wZXJhdG9yIC0+KCkgewpAQCAtNTM1 LDcgKzUzMCw4IEBAIHB1YmxpYzoKICAgfQogCiAgIGNvbnN0ZXhwciBUIGNvbnN0JiBvcGVyYXRv ciAqKCkgY29uc3QmIHsKLSAgICByZXR1cm4gVFIyX09QVElPTkFMX0FTU0VSVEVEX0VYUFJFU1NJ T04oaW5pdGlhbGl6ZWQoKSwgY29udGFpbmVkX3ZhbCgpKTsKKyAgICBBU1NFUlRfVU5ERVJfQ09O U1RFWFBSX0NPTlRFWFQoaW5pdGlhbGl6ZWQoKSk7CisgICAgcmV0dXJuIGNvbnRhaW5lZF92YWwo KTsKICAgfQogCiAgIE9QVElPTkFMX01VVEFCTEVfQ09OU1RFWFBSIFQmIG9wZXJhdG9yICooKSAm IHsKQEAgLTY2OSwxMSArNjY1LDEzIEBAIHB1YmxpYzoKIAogICAvLyAyMC41LjUuMywgb2JzZXJ2 ZXJzCiAgIGNvbnN0ZXhwciBUKiBvcGVyYXRvci0+KCkgY29uc3QgewotICAgIHJldHVybiBUUjJf T1BUSU9OQUxfQVNTRVJURURfRVhQUkVTU0lPTihyZWYsIHJlZik7CisgICAgQVNTRVJUX1VOREVS X0NPTlNURVhQUl9DT05URVhUKHJlZik7CisgICAgcmV0dXJuIHJlZjsKICAgfQogCiAgIGNvbnN0 ZXhwciBUJiBvcGVyYXRvciooKSBjb25zdCB7Ci0gICAgcmV0dXJuIFRSMl9PUFRJT05BTF9BU1NF UlRFRF9FWFBSRVNTSU9OKHJlZiwgKnJlZik7CisgICAgQVNTRVJUX1VOREVSX0NPTlNURVhQUl9D T05URVhUKHJlZik7CisgICAgcmV0dXJuICpyZWY7CiAgIH0KIAogICBjb25zdGV4cHIgVCYgdmFs dWUoKSBjb25zdCB7CkBAIC0xMDM1LDcgKzEwMzMsNiBAQCBuYW1lc3BhY2Ugc3RkCiB9CiAKICMg dW5kZWYgVFIyX09QVElPTkFMX1JFUVVJUkVTCi0jIHVuZGVmIFRSMl9PUFRJT05BTF9BU1NFUlRF RF9FWFBSRVNTSU9OCiAKICNlbmRpZiAvLyBkZWZpbmVkKF9fY3BwX2xpYl9vcHRpb25hbCkKIAot LSAKMi4xNy4xIChBcHBsZSBHaXQtMTEwKQoK