187661 2018-07-13 14:08:40 -0700 Crash under ApplicationCacheGroup::didFailLoadingEntry() 2018-07-13 15:58:19 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cdumez cdumez dbates ews-watchlist japhet webkit-bug-importer youennf oldest_to_newest 1442005 0 cdumez 2018-07-13 14:08:40 -0700 Crash under ApplicationCacheGroup::didFailLoadingEntry(): Thread[0] EXC_BAD_ACCESS (SIGSEGV) (KERN_INVALID_ADDRESS at 0x000000000000000c) [ 0] 0x000000023b8396c4 WebCore`WebCore::ApplicationCacheGroup::didFailLoadingEntry(WebCore::ApplicationCacheResourceLoader::Error, WebCore::URL const&) [inlined] WebCore::ApplicationCacheResourceLoader::type() const at ApplicationCacheResourceLoader.h:51:36 47 void cancel(Error = Error::Abort); 48 49 const CachedResource* resource() const { return m_resource.get(); } 50 bool hasRedirection() const { return m_hasRedirection; } -> 51 unsigned type() const { return m_type; } 52 53 private: 54 explicit ApplicationCacheResourceLoader(unsigned, CachedResourceHandle<CachedRawResource>&&, CompletionHandler<void(ResourceOrError&&)>&&); 55 0x000000023b8396b4: ldr x1, [x19, #0xf8] 0x000000023b8396b8: add x3, sp, #0x40 ; =0x40 0x000000023b8396bc: bl 0xf3ab5c ; WebCore::InspectorInstrumentation::didFailLoadingImpl at InspectorInstrumentation.cpp:609 0x000000023b8396c0: ldr x8, [x19, #0xf0] -> 0x000000023b8396c4: ldr w20, [x8, #0xc] 0x000000023b8396c8: ldr x8, [x22] 0x000000023b8396cc: str x8, [sp, #0x10] 0x000000023b8396d0: cbz x8, 0x100d6e0 ; <+164> [inlined] WebCore::URL::URL(WebCore::URL const&) + 24 at URL.h:55 0x000000023b8396d4: ldr w9, [x8] [ 0] 0x000000023b8396c4 WebCore`WebCore::ApplicationCacheGroup::didFailLoadingEntry(WebCore::ApplicationCacheResourceLoader::Error, WebCore::URL const&) + 136 at ApplicationCacheGroup.cpp:548 544 ResourceError resourceError { error == ApplicationCacheResourceLoader::Error::CannotCreateResource ? ResourceError::Type::AccessControl : ResourceError::Type::General }; 545 546 InspectorInstrumentation::didFailLoading(m_frame, m_frame->loader().documentLoader(), m_currentResourceIdentifier, resourceError); 547 -> 548 unsigned type = m_entryLoader->type(); 549 URL url(entryURL); 550 url.removeFragmentIdentifier(); 551 552 ASSERT(!m_currentResource || !m_pendingEntries.contains(url)); [ 1] 0x000000023b8396bf WebCore`WebCore::ApplicationCacheGroup::didFailLoadingEntry(WebCore::ApplicationCacheResourceLoader::Error, WebCore::URL const&) [inlined] WebCore::InspectorInstrumentation::didFailLoading(WebCore::Frame*, WebCore::DocumentLoader*, unsigned long, WebCore::ResourceError const&) + 43 at InspectorInstrumentation.h:983:9 979 980 inline void InspectorInstrumentation::didFailLoading(Frame* frame, DocumentLoader* loader, unsigned long identifier, const ResourceError& error) 981 { 982 if (InstrumentingAgents* instrumentingAgents = instrumentingAgentsForFrame(frame)) -> 983 didFailLoadingImpl(*instrumentingAgents, identifier, loader, error); 984 } 985 986 inline void InspectorInstrumentation::didFailLoading(WorkerGlobalScope& workerGlobalScope, unsigned long identifier, const ResourceError& error) 987 { [ 1] 0x000000023b839694 WebCore`WebCore::ApplicationCacheGroup::didFailLoadingEntry(WebCore::ApplicationCacheResourceLoader::Error, WebCore::URL const&) + 88 at ApplicationCacheGroup.cpp:546 542 { 543 // FIXME: We should get back the error from ApplicationCacheResourceLoader level. 544 ResourceError resourceError { error == ApplicationCacheResourceLoader::Error::CannotCreateResource ? ResourceError::Type::AccessControl : ResourceError::Type::General }; 545 -> 546 InspectorInstrumentation::didFailLoading(m_frame, m_frame->loader().documentLoader(), m_currentResourceIdentifier, resourceError); 547 548 unsigned type = m_entryLoader->type(); 549 URL url(entryURL); 550 url.removeFragmentIdentifier(); [ 2] 0x000000023b8388f3 WebCore`WebCore::ApplicationCacheResourceLoader::create(unsigned int, WebCore::CachedResourceLoader&, WebCore::ResourceRequest&&, WTF::CompletionHandler<void (std::experimental::fundamentals_v3::expected<WTF::RefPtr<WebCore::ApplicationCacheResource, WTF::DumbPtrTraits<WebCore::ApplicationCacheResource> >, WebCore::ApplicationCacheResourceLoader::Error>&&)>&&) [inlined] WTF::Function<void (std::experimental::fundamentals_v3::expected<WTF::RefPtr<WebCore::ApplicationCacheResource, WTF::DumbPtrTraits<WebCore::ApplicationCacheResource> >, WebCore::ApplicationCacheResourceLoader::Error>&&)>::operator()(std::experimental::fundamentals_v3::expected<WTF::RefPtr<WebCore::ApplicationCacheResource, WTF::DumbPtrTraits<WebCore::ApplicationCacheResource> >, WebCore::ApplicationCacheResourceLoader::Error>&&) const + 19 at Function.h:56:35 [ 2] 0x000000023b8388e0 WebCore`WebCore::ApplicationCacheResourceLoader::create(unsigned int, WebCore::CachedResourceLoader&, WebCore::ResourceRequest&&, WTF::CompletionHandler<void (std::experimental::fundamentals_v3::expected<WTF::RefPtr<WebCore::ApplicationCacheResource, WTF::DumbPtrTraits<WebCore::ApplicationCacheResource> >, WebCore::ApplicationCacheResourceLoader::Error>&&)>&&) [inlined] WTF::CompletionHandler<void (std::experimental::fundamentals_v3::expected<WTF::RefPtr<WebCore::ApplicationCacheResource, WTF::DumbPtrTraits<WebCore::ApplicationCacheResource> >, WebCore::ApplicationCacheResourceLoader::Error>&&)>::operator()(std::experimental::fundamentals_v3::expected<WTF::RefPtr<WebCore::ApplicationCacheResource, WTF::DumbPtrTraits<WebCore::ApplicationCacheResource> >, WebCore::ApplicationCacheResourceLoader::Error>&&) const + 8 at CompletionHandler.h:60 [ 2] 0x000000023b8388d8 WebCore`WebCore::ApplicationCacheResourceLoader::create(unsigned int, WebCore::CachedResourceLoader&, WebCore::ResourceRequest&&, WTF::CompletionHandler<void (std::experimental::fundamentals_v3::expected<WTF::RefPtr<WebCore::ApplicationCacheResource, WTF::DumbPtrTraits<WebCore::ApplicationCacheResource> >, WebCore::ApplicationCacheResourceLoader::Error>&&)>&&) + 388 at ApplicationCacheResourceLoader.cpp:42 1442006 1 cdumez 2018-07-13 14:08:52 -0700 <rdar://problem/42179755> 1442007 2 344979 cdumez 2018-07-13 14:11:36 -0700 Created attachment 344979 Patch 1442069 3 344979 youennf 2018-07-13 15:46:39 -0700 Comment on attachment 344979 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=344979&action=review > Source/WebCore/loader/appcache/ApplicationCacheGroup.cpp:556 > + m_frame->document()->addConsoleMessage(MessageSource::AppCache, MessageLevel::Error, "Application Cache update failed, because " + url.stringCenterEllipsizedToLength() + (m_entryLoader && m_entryLoader->hasRedirection() ? " was redirected." : " could not be fetched.")); makeString() ? 1442078 4 cdumez 2018-07-13 15:54:23 -0700 Committed r233823: <https://trac.webkit.org/changeset/233823> 344979 2018-07-13 14:11:36 -0700 2018-07-13 15:58:19 -0700 Patch bug-187661-20180713141131.patch text/plain 5072 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjMzODA4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNGE0ZDY4MDk1NGU2YWZh ZjAyYTg1MzI3NjBhYzdiNjljZGUzMjc1NS4uZjY0NmZhMjlmZjM2NzcyYTc0MDVjMjNhNzhkZmNh OTc0NTkxZjA1ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDE4LTA3LTEzICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgQ3Jhc2ggdW5kZXIgQXBwbGlj YXRpb25DYWNoZUdyb3VwOjpkaWRGYWlsTG9hZGluZ0VudHJ5KCkKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4NzY2MQorICAgICAgICA8cmRhcjovL3By b2JsZW0vNDIxNzk3NTU+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgSWYgQXBwbGljYXRpb25DYWNoZVJlc291cmNlTG9hZGVyOjpjcmVhdGUoKSBmYWls cyBzeW5jaHJvbm91c2x5IHdpdGgKKyAgICAgICAgQXBwbGljYXRpb25DYWNoZVJlc291cmNlTG9h ZGVyOjpFcnJvcjo6Q2Fubm90Q3JlYXRlUmVzb3VyY2UgZXJyb3IsIHRoZW4KKyAgICAgICAgbV9l bnRyeUxvYWRlciB3aWxsIGJlIG51bGwgd2hlbiBkaWRGYWlsTG9hZGluZ0VudHJ5KCkgaXMgY2Fs bGVkLiBIb3dldmVyLAorICAgICAgICBkaWRGYWlsTG9hZGluZ0VudHJ5KCkgZmFpbHMgdG8gbnVs bCBjaGVjayBtX2VudHJ5TG9hZGVyIGJlZm9yZSB1c2luZyBpdC4KKworICAgICAgICAqIGxvYWRl ci9hcHBjYWNoZS9BcHBsaWNhdGlvbkNhY2hlR3JvdXAuY3BwOgorICAgICAgICAoV2ViQ29yZTo6 QXBwbGljYXRpb25DYWNoZUdyb3VwOjpkaWRGYWlsTG9hZGluZ0VudHJ5KToKKyAgICAgICAgKFdl YkNvcmU6OkFwcGxpY2F0aW9uQ2FjaGVHcm91cDo6c3RhcnRMb2FkaW5nRW50cnkpOgorICAgICAg ICAqIGxvYWRlci9hcHBjYWNoZS9BcHBsaWNhdGlvbkNhY2hlR3JvdXAuaDoKKwogMjAxOC0wNy0x MyAgQ2hhcmxpZSBUdXJuZXIgIDxjdHVybmVyQGlnYWxpYS5jb20+CiAKICAgICAgICAgW0dTdHJl YW1lcl0gVXNlIHNtYXJ0IHBvaW50ZXJzIGZvciBHc3RCeXRlUmVhZGVyCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9sb2FkZXIvYXBwY2FjaGUvQXBwbGljYXRpb25DYWNoZUdyb3VwLmNwcCBi L1NvdXJjZS9XZWJDb3JlL2xvYWRlci9hcHBjYWNoZS9BcHBsaWNhdGlvbkNhY2hlR3JvdXAuY3Bw CmluZGV4IDA2ZWQ4ZWYxOTJlOWI2Mzc4OWI3YjQxMzQwZTJmZDBmYmY5MmU4ZTMuLmE4NTBjMGIz ZmNmYjExY2EwYTE0N2RjNDYwMjQ4Y2YwOGUyZWEzZGEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL2xvYWRlci9hcHBjYWNoZS9BcHBsaWNhdGlvbkNhY2hlR3JvdXAuY3BwCisrKyBiL1NvdXJj ZS9XZWJDb3JlL2xvYWRlci9hcHBjYWNoZS9BcHBsaWNhdGlvbkNhY2hlR3JvdXAuY3BwCkBAIC01 MzgsMTQgKzUzOCwxMyBAQCB2b2lkIEFwcGxpY2F0aW9uQ2FjaGVHcm91cDo6ZGlkRmluaXNoTG9h ZGluZ0VudHJ5KGNvbnN0IFVSTCYgZW50cnlVUkwpCiAgICAgc3RhcnRMb2FkaW5nRW50cnkoKTsK IH0KIAotdm9pZCBBcHBsaWNhdGlvbkNhY2hlR3JvdXA6OmRpZEZhaWxMb2FkaW5nRW50cnkoQXBw bGljYXRpb25DYWNoZVJlc291cmNlTG9hZGVyOjpFcnJvciBlcnJvciwgY29uc3QgVVJMJiBlbnRy eVVSTCkKK3ZvaWQgQXBwbGljYXRpb25DYWNoZUdyb3VwOjpkaWRGYWlsTG9hZGluZ0VudHJ5KEFw cGxpY2F0aW9uQ2FjaGVSZXNvdXJjZUxvYWRlcjo6RXJyb3IgZXJyb3IsIGNvbnN0IFVSTCYgZW50 cnlVUkwsIHVuc2lnbmVkIHR5cGUpCiB7CiAgICAgLy8gRklYTUU6IFdlIHNob3VsZCBnZXQgYmFj ayB0aGUgZXJyb3IgZnJvbSBBcHBsaWNhdGlvbkNhY2hlUmVzb3VyY2VMb2FkZXIgbGV2ZWwuCiAg ICAgUmVzb3VyY2VFcnJvciByZXNvdXJjZUVycm9yIHsgZXJyb3IgPT0gQXBwbGljYXRpb25DYWNo ZVJlc291cmNlTG9hZGVyOjpFcnJvcjo6Q2Fubm90Q3JlYXRlUmVzb3VyY2UgPyBSZXNvdXJjZUVy cm9yOjpUeXBlOjpBY2Nlc3NDb250cm9sIDogUmVzb3VyY2VFcnJvcjo6VHlwZTo6R2VuZXJhbCB9 OwogCiAgICAgSW5zcGVjdG9ySW5zdHJ1bWVudGF0aW9uOjpkaWRGYWlsTG9hZGluZyhtX2ZyYW1l LCBtX2ZyYW1lLT5sb2FkZXIoKS5kb2N1bWVudExvYWRlcigpLCBtX2N1cnJlbnRSZXNvdXJjZUlk ZW50aWZpZXIsIHJlc291cmNlRXJyb3IpOwogCi0gICAgdW5zaWduZWQgdHlwZSA9IG1fZW50cnlM b2FkZXItPnR5cGUoKTsKICAgICBVUkwgdXJsKGVudHJ5VVJMKTsKICAgICB1cmwucmVtb3ZlRnJh Z21lbnRJZGVudGlmaWVyKCk7CiAKQEAgLTU1NCw3ICs1NTMsNyBAQCB2b2lkIEFwcGxpY2F0aW9u Q2FjaGVHcm91cDo6ZGlkRmFpbExvYWRpbmdFbnRyeShBcHBsaWNhdGlvbkNhY2hlUmVzb3VyY2VM b2FkZXI6OgogICAgIG1fcGVuZGluZ0VudHJpZXMucmVtb3ZlKHVybCk7CiAKICAgICBpZiAoKHR5 cGUgJiBBcHBsaWNhdGlvbkNhY2hlUmVzb3VyY2U6OkV4cGxpY2l0KSB8fCAodHlwZSAmIEFwcGxp Y2F0aW9uQ2FjaGVSZXNvdXJjZTo6RmFsbGJhY2spKSB7Ci0gICAgICAgIG1fZnJhbWUtPmRvY3Vt ZW50KCktPmFkZENvbnNvbGVNZXNzYWdlKE1lc3NhZ2VTb3VyY2U6OkFwcENhY2hlLCBNZXNzYWdl TGV2ZWw6OkVycm9yLCAiQXBwbGljYXRpb24gQ2FjaGUgdXBkYXRlIGZhaWxlZCwgYmVjYXVzZSAi ICsgdXJsLnN0cmluZ0NlbnRlckVsbGlwc2l6ZWRUb0xlbmd0aCgpICsgKG1fZW50cnlMb2FkZXIt Pmhhc1JlZGlyZWN0aW9uKCkgPyAiIHdhcyByZWRpcmVjdGVkLiIgOiAiIGNvdWxkIG5vdCBiZSBm ZXRjaGVkLiIpKTsKKyAgICAgICAgbV9mcmFtZS0+ZG9jdW1lbnQoKS0+YWRkQ29uc29sZU1lc3Nh Z2UoTWVzc2FnZVNvdXJjZTo6QXBwQ2FjaGUsIE1lc3NhZ2VMZXZlbDo6RXJyb3IsICJBcHBsaWNh dGlvbiBDYWNoZSB1cGRhdGUgZmFpbGVkLCBiZWNhdXNlICIgKyB1cmwuc3RyaW5nQ2VudGVyRWxs aXBzaXplZFRvTGVuZ3RoKCkgKyAobV9lbnRyeUxvYWRlciAmJiBtX2VudHJ5TG9hZGVyLT5oYXNS ZWRpcmVjdGlvbigpID8gIiB3YXMgcmVkaXJlY3RlZC4iIDogIiBjb3VsZCBub3QgYmUgZmV0Y2hl ZC4iKSk7CiAgICAgICAgIC8vIE5vdGUgdGhhdCBjYWNoZVVwZGF0ZUZhaWxlZCgpIGNhbiBjYXVz ZSB0aGUgY2FjaGUgZ3JvdXAgdG8gYmUgZGVsZXRlZC4KICAgICAgICAgY2FjaGVVcGRhdGVGYWls ZWQoKTsKICAgICAgICAgcmV0dXJuOwpAQCAtOTA0LDEyICs5MDMsMTMgQEAgdm9pZCBBcHBsaWNh dGlvbkNhY2hlR3JvdXA6OnN0YXJ0TG9hZGluZ0VudHJ5KCkKIAogICAgIGF1dG8mIGRvY3VtZW50 TG9hZGVyID0gKm1fZnJhbWUtPmxvYWRlcigpLmRvY3VtZW50TG9hZGVyKCk7CiAgICAgYXV0byBy ZXF1ZXN0VVJMID0gcmVxdWVzdC51cmwoKTsKLSAgICBtX2VudHJ5TG9hZGVyID0gQXBwbGljYXRp b25DYWNoZVJlc291cmNlTG9hZGVyOjpjcmVhdGUobV9wZW5kaW5nRW50cmllcy5iZWdpbigpLT52 YWx1ZSwgZG9jdW1lbnRMb2FkZXIuY2FjaGVkUmVzb3VyY2VMb2FkZXIoKSwgV1RGTW92ZShyZXF1 ZXN0KSwgW3RoaXMsIHJlcXVlc3RVUkwgPSBXVEZNb3ZlKHJlcXVlc3RVUkwpXSAoYXV0byYmIHJl c291cmNlT3JFcnJvcikgeworICAgIHVuc2lnbmVkIHR5cGUgPSBtX3BlbmRpbmdFbnRyaWVzLmJl Z2luKCktPnZhbHVlOworICAgIG1fZW50cnlMb2FkZXIgPSBBcHBsaWNhdGlvbkNhY2hlUmVzb3Vy Y2VMb2FkZXI6OmNyZWF0ZSh0eXBlLCBkb2N1bWVudExvYWRlci5jYWNoZWRSZXNvdXJjZUxvYWRl cigpLCBXVEZNb3ZlKHJlcXVlc3QpLCBbdGhpcywgcmVxdWVzdFVSTCA9IFdURk1vdmUocmVxdWVz dFVSTCksIHR5cGVdIChhdXRvJiYgcmVzb3VyY2VPckVycm9yKSB7CiAgICAgICAgIGlmICghcmVz b3VyY2VPckVycm9yLmhhc192YWx1ZSgpKSB7CiAgICAgICAgICAgICBhdXRvIGVycm9yID0gcmVz b3VyY2VPckVycm9yLmVycm9yKCk7CiAgICAgICAgICAgICBpZiAoZXJyb3IgPT0gQXBwbGljYXRp b25DYWNoZVJlc291cmNlTG9hZGVyOjpFcnJvcjo6QWJvcnQpCiAgICAgICAgICAgICAgICAgcmV0 dXJuOwotICAgICAgICAgICAgdGhpcy0+ZGlkRmFpbExvYWRpbmdFbnRyeShlcnJvciwgcmVxdWVz dFVSTCk7CisgICAgICAgICAgICB0aGlzLT5kaWRGYWlsTG9hZGluZ0VudHJ5KGVycm9yLCByZXF1 ZXN0VVJMLCB0eXBlKTsKICAgICAgICAgICAgIHJldHVybjsKICAgICAgICAgfQogCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvYXBwY2FjaGUvQXBwbGljYXRpb25DYWNoZUdyb3Vw LmggYi9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvYXBwY2FjaGUvQXBwbGljYXRpb25DYWNoZUdyb3Vw LmgKaW5kZXggOWY2MjhmZGFmMmE0ZWQ1YTA5NDQ3Mjk5YmIyYzdlZDIzZWNhYTY3NS4uYWJhYTcz ZTE0YWI0YjhjN2FiYWIxMDg4ZGQ4YzIzOGU2OWUyYjQxZSAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvbG9hZGVyL2FwcGNhY2hlL0FwcGxpY2F0aW9uQ2FjaGVHcm91cC5oCisrKyBiL1NvdXJj ZS9XZWJDb3JlL2xvYWRlci9hcHBjYWNoZS9BcHBsaWNhdGlvbkNhY2hlR3JvdXAuaApAQCAtMTA0 LDcgKzEwNCw3IEBAIHByaXZhdGU6CiAgICAgdm9pZCBkaWRGaW5pc2hMb2FkaW5nTWFuaWZlc3Qo KTsKICAgICB2b2lkIGRpZEZhaWxMb2FkaW5nTWFuaWZlc3QoQXBwbGljYXRpb25DYWNoZVJlc291 cmNlTG9hZGVyOjpFcnJvcik7CiAKLSAgICB2b2lkIGRpZEZhaWxMb2FkaW5nRW50cnkoQXBwbGlj YXRpb25DYWNoZVJlc291cmNlTG9hZGVyOjpFcnJvciwgY29uc3QgVVJMJik7CisgICAgdm9pZCBk aWRGYWlsTG9hZGluZ0VudHJ5KEFwcGxpY2F0aW9uQ2FjaGVSZXNvdXJjZUxvYWRlcjo6RXJyb3Is IGNvbnN0IFVSTCYsIHVuc2lnbmVkIHR5cGUpOwogICAgIHZvaWQgZGlkRmluaXNoTG9hZGluZ0Vu dHJ5KGNvbnN0IFVSTCYpOwogCiAgICAgdm9pZCBkaWRSZWFjaE1heEFwcENhY2hlU2l6ZSgpOwo=