187646 2018-07-13 08:28:32 -0700 [WPE] Provide API to configure the default page background 2019-03-18 06:12:39 -0700 1 1 1 Unclassified WebKit WPE WebKit Other Unspecified Unspecified RESOLVED DUPLICATE 192305 P2 Normal --- 1 aperez webkit-unassigned bugs-noreply calvaris magomez pnormand oldest_to_newest 1441865 0 aperez 2018-07-13 08:28:32 -0700 In the GTK+ port there is the following in the API: void webkit_web_view_set_background_color (WebKitWebView *web_view, const GdkRGBA *rgba); but in WPE there is no equivalent function. Having something similar would be handy in certain scenarios, to avoid flashing white frames while content is being loaded. For example: 1. A device boots with a splash screen, which has a dark background. 2. Right after boot, a program using WPE is launched, and starts loading some content. This is designed to have the same background color as the splash screen. 3. The content takes some time to complete loading, and during this time WebKit may render a few frames which are white (or almost completely white), while the styling for the content is not yet available. 4. The Web content finishes loading, and goes back to using the same dark background as the splash screen. This way, step (3.) causes the device screen to produce a white flash, even if the Web content is loaded quite fast. 1441867 1 344945 aperez 2018-07-13 08:32:22 -0700 Created attachment 344945 Patch which hardcodes black as background As an example, this is a patch which changes Color::white to Color::black in a few places to avoid the white flash for a device I am working with at the moment. It could be that there is a better way, but this is working well for me right now. IMHO there is value in providing API for this, I can easily imagine more situations in which setting the background may be useful. 1497307 2 magomez 2019-01-23 07:01:14 -0800 Adri, can close this as duplicate of bug 192305? (I know this is older, but the other one has the fix) 1517664 3 pnormand 2019-03-18 06:12:39 -0700 Yep, a dupe indeed. Sorry I've just noticed this bug and didn't reuse it for the bg-color patch :) *** This bug has been marked as a duplicate of bug 192305 *** 344945 2018-07-13 08:32:22 -0700 2018-07-13 08:32:22 -0700 Patch which hardcodes black as background 0009-Paint-background-black-by-default.patch text/plain 6266 aperez UGFpbnQgYmFja2dyb3VuZCBhcyBibGFjayBieSBkZWZhdWx0CgotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9wYWdlL0ZyYW1lVmlldy5jcHAJMjAxOC0wNy0xMyAwMTo1MTo1My4yMDg2NDA2NjggKzAzMDAK KysrIGIvU291cmNlL1dlYkNvcmUvcGFnZS9GcmFtZVZpZXcuY3BwCTIwMTgtMDctMTMgMDE6NTI6 MTIuODcyODgwOTEyICswMzAwCkBAIC0xNzQsNyArMTc0LDcgQEAKICAgICAsIG1fdXBkYXRlRW1i ZWRkZWRPYmplY3RzVGltZXIoKnRoaXMsICZGcmFtZVZpZXc6OnVwZGF0ZUVtYmVkZGVkT2JqZWN0 c1RpbWVyRmlyZWQpCiAgICAgLCBtX3VwZGF0ZVdpZGdldFBvc2l0aW9uc1RpbWVyKCp0aGlzLCAm RnJhbWVWaWV3Ojp1cGRhdGVXaWRnZXRQb3NpdGlvbnNUaW1lckZpcmVkKQogICAgICwgbV9pc1Ry YW5zcGFyZW50KGZhbHNlKQotICAgICwgbV9iYXNlQmFja2dyb3VuZENvbG9yKENvbG9yOjp3aGl0 ZSkKKyAgICAsIG1fYmFzZUJhY2tncm91bmRDb2xvcihDb2xvcjo6YmxhY2spCiAgICAgLCBtX21l ZGlhVHlwZSgic2NyZWVuIikKICAgICAsIG1fb3ZlcmZsb3dTdGF0dXNEaXJ0eSh0cnVlKQogICAg ICwgbV93YXNTY3JvbGxlZEJ5VXNlcihmYWxzZSkKQEAgLTI4OTQsNyArMjg5NCw3IEBACiAgICAg Ym9vbCB3YXNPcGFxdWUgPSBtX2Jhc2VCYWNrZ3JvdW5kQ29sb3IuaXNPcGFxdWUoKTsKICAgICAK ICAgICBpZiAoIWJhY2tncm91bmRDb2xvci5pc1ZhbGlkKCkpCi0gICAgICAgIG1fYmFzZUJhY2tn cm91bmRDb2xvciA9IENvbG9yOjp3aGl0ZTsKKyAgICAgICAgbV9iYXNlQmFja2dyb3VuZENvbG9y ID0gQ29sb3I6OmJsYWNrOwogICAgIGVsc2UKICAgICAgICAgbV9iYXNlQmFja2dyb3VuZENvbG9y ID0gYmFja2dyb3VuZENvbG9yOwogCi0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5k ZXJMYXllckNvbXBvc2l0b3IuY3BwCTIwMTgtMDctMTMgMTI6MzY6NDIuNjI2MzIxODQwICswMzAw CisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllckNvbXBvc2l0b3IuY3Bw CTIwMTgtMDctMTMgMTI6MzY6NTEuNjg2NDg2NDI4ICswMzAwCkBAIC0zMDc2LDcgKzMwNzYsNyBA QAogCiAgICAgQ29sb3IgZG9jdW1lbnRCYWNrZ3JvdW5kQ29sb3IgPSBtX3JlbmRlclZpZXcuZnJh bWVWaWV3KCkuZG9jdW1lbnRCYWNrZ3JvdW5kQ29sb3IoKTsKICAgICBpZiAoIWRvY3VtZW50QmFj a2dyb3VuZENvbG9yLmlzVmFsaWQoKSkKLSAgICAgICAgZG9jdW1lbnRCYWNrZ3JvdW5kQ29sb3Ig PSBDb2xvcjo6d2hpdGU7CisgICAgICAgIGRvY3VtZW50QmFja2dyb3VuZENvbG9yID0gQ29sb3I6 OmJsYWNrOwogCiAgICAgaWYgKGJhY2tncm91bmRDb2xvcikKICAgICAgICAgKmJhY2tncm91bmRD b2xvciA9IGRvY3VtZW50QmFja2dyb3VuZENvbG9yOwotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5k ZXJpbmcvUmVuZGVyU2Nyb2xsYmFyLmNwcAkyMDE4LTA3LTEzIDEyOjM4OjQyLjkyMTc3OTQzMCAr MDMwMAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyU2Nyb2xsYmFyLmNwcAky MDE4LTA3LTEzIDEyOjM4OjQ1Ljc4NTE2MTgzMyArMDMwMApAQCAtMTQ3LDcgKzE0Nyw3IEBACiAg ICAgLy8gVGhpcyBpcyBiZWNhdXNlIFdlYktpdCBhc3N1bWVzIHNjcm9sbGJhciB0byBiZSBhbHdh eXMgcGFpbnRlZCBhbmQgbWlzc2luZyBiYWNrZ3JvdW5kCiAgICAgLy8gY2F1c2VzIHZpc3VhbCBh cnRpZmFjdCBsaWtlIG5vbi1yZXBhaW50ZWQgZGlydHkgcmVnaW9uLgogICAgIGlmIChyZXN1bHQg JiYgbV9vd25pbmdGcmFtZSAmJiBtX293bmluZ0ZyYW1lLT52aWV3KCkgJiYgIW1fb3duaW5nRnJh bWUtPnZpZXcoKS0+aXNUcmFuc3BhcmVudCgpICYmICFyZXN1bHQtPmhhc0JhY2tncm91bmQoKSkK LSAgICAgICAgcmVzdWx0LT5zZXRCYWNrZ3JvdW5kQ29sb3IoQ29sb3I6OndoaXRlKTsKKyAgICAg ICAgcmVzdWx0LT5zZXRCYWNrZ3JvdW5kQ29sb3IoQ29sb3I6OmJsYWNrKTsKIAogICAgIHJldHVy biByZXN1bHQ7CiB9Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJTY3JvbGxi YXJUaGVtZS5jcHAJMjAxOC0wNy0xMyAxMjozOTo0OC4zMTI4ODQ3MjAgKzAzMDAKKysrIGIvU291 cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclNjcm9sbGJhclRoZW1lLmNwcAkyMDE4LTA3LTEz IDEyOjM5OjUzLjMxOTYzNDc1MSArMDMwMApAQCAtMTI5LDcgKzEyOSw3IEBACiB2b2lkIFJlbmRl clNjcm9sbGJhclRoZW1lOjpwYWludFNjcm9sbENvcm5lcihTY3JvbGxWaWV3KiwgR3JhcGhpY3ND b250ZXh0JiBjb250ZXh0LCBjb25zdCBJbnRSZWN0JiBjb3JuZXJSZWN0KQogewogICAgIC8vIEZJ WE1FOiBJbXBsZW1lbnQuCi0gICAgY29udGV4dC5maWxsUmVjdChjb3JuZXJSZWN0LCBDb2xvcjo6 d2hpdGUpOworICAgIGNvbnRleHQuZmlsbFJlY3QoY29ybmVyUmVjdCwgQ29sb3I6OmJsYWNrKTsK IH0KIAogdm9pZCBSZW5kZXJTY3JvbGxiYXJUaGVtZTo6cGFpbnRTY3JvbGxiYXJCYWNrZ3JvdW5k KEdyYXBoaWNzQ29udGV4dCYgY29udGV4dCwgU2Nyb2xsYmFyJiBzY3JvbGxiYXIpCi0tLSBhL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL1Njcm9sbGJhclRoZW1lLmgJMjAxOC0wNy0xMyAxMjo0Mjoy Ny4zMTU0NTYxMjggKzAzMDAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vU2Nyb2xsYmFy VGhlbWUuaAkyMDE4LTA3LTEzIDEyOjQyOjM0LjQxMjIzNDI3MCArMDMwMApAQCAtODUsNyArODUs NyBAQAogICAgIHZpcnR1YWwgdm9pZCBpbnZhbGlkYXRlUGFydChTY3JvbGxiYXImLCBTY3JvbGxi YXJQYXJ0KSB7IH0KIAogICAgIHZpcnR1YWwgdm9pZCBwYWludFNjcm9sbENvcm5lcihTY3JvbGxW aWV3KiwgR3JhcGhpY3NDb250ZXh0JiBjb250ZXh0LCBjb25zdCBJbnRSZWN0JiBjb3JuZXJSZWN0 KSB7IGRlZmF1bHRQYWludFNjcm9sbENvcm5lcihjb250ZXh0LCBjb3JuZXJSZWN0KTsgfQotICAg IHN0YXRpYyB2b2lkIGRlZmF1bHRQYWludFNjcm9sbENvcm5lcihHcmFwaGljc0NvbnRleHQmIGNv bnRleHQsIGNvbnN0IEludFJlY3QmIGNvcm5lclJlY3QpIHsgY29udGV4dC5maWxsUmVjdChjb3Ju ZXJSZWN0LCBDb2xvcjo6d2hpdGUpOyB9CisgICAgc3RhdGljIHZvaWQgZGVmYXVsdFBhaW50U2Ny b2xsQ29ybmVyKEdyYXBoaWNzQ29udGV4dCYgY29udGV4dCwgY29uc3QgSW50UmVjdCYgY29ybmVy UmVjdCkgeyBjb250ZXh0LmZpbGxSZWN0KGNvcm5lclJlY3QsIENvbG9yOjpibGFjayk7IH0KIAog ICAgIHZpcnR1YWwgdm9pZCBwYWludFRpY2ttYXJrcyhHcmFwaGljc0NvbnRleHQmLCBTY3JvbGxi YXImLCBjb25zdCBJbnRSZWN0JikgeyB9CiAgICAgdmlydHVhbCB2b2lkIHBhaW50T3ZlcmhhbmdB cmVhcyhTY3JvbGxWaWV3JiwgR3JhcGhpY3NDb250ZXh0JiwgY29uc3QgSW50UmVjdCYsIGNvbnN0 IEludFJlY3QmLCBjb25zdCBJbnRSZWN0JikgeyB9Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL1Njcm9sbGJhclRoZW1lQ29tcG9zaXRlLmNwcAkyMDE4LTA3LTEzIDEyOjQzOjI1Ljk4MzAz NzAwNCArMDMwMAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9TY3JvbGxiYXJUaGVtZUNv bXBvc2l0ZS5jcHAJMjAxOC0wNy0xMyAxMjo0NDoyNi40MDcyOTU3MTEgKzAzMDAKQEAgLTI2Miw3 ICsyNjIsNyBAQAogCiB2b2lkIFNjcm9sbGJhclRoZW1lQ29tcG9zaXRlOjpwYWludFNjcm9sbENv cm5lcihTY3JvbGxWaWV3KiwgR3JhcGhpY3NDb250ZXh0JiBjb250ZXh0LCBjb25zdCBJbnRSZWN0 JiBjb3JuZXJSZWN0KQogewotICAgIGNvbnRleHQuZmlsbFJlY3QoY29ybmVyUmVjdCwgQ29sb3I6 OndoaXRlKTsKKyAgICBjb250ZXh0LmZpbGxSZWN0KGNvcm5lclJlY3QsIENvbG9yOjpibGFjayk7 CiB9CiAKIEludFJlY3QgU2Nyb2xsYmFyVGhlbWVDb21wb3NpdGU6OnRodW1iUmVjdChTY3JvbGxi YXImIHNjcm9sbGJhcikKQEAgLTI4MSwxMSArMjgxLDExIEBACiAKIHZvaWQgU2Nyb2xsYmFyVGhl bWVDb21wb3NpdGU6OnBhaW50T3ZlcmhhbmdBcmVhcyhTY3JvbGxWaWV3JiwgR3JhcGhpY3NDb250 ZXh0JiBjb250ZXh0LCBjb25zdCBJbnRSZWN0JiBob3Jpem9udGFsT3ZlcmhhbmdSZWN0LCBjb25z dCBJbnRSZWN0JiB2ZXJ0aWNhbE92ZXJoYW5nUmVjdCwgY29uc3QgSW50UmVjdCYgZGlydHlSZWN0 KQogeyAgICAKLSAgICBjb250ZXh0LnNldEZpbGxDb2xvcihDb2xvcjo6d2hpdGUpOworICAgIGNv bnRleHQuc2V0RmlsbENvbG9yKENvbG9yOjpibGFjayk7CiAgICAgaWYgKCFob3Jpem9udGFsT3Zl cmhhbmdSZWN0LmlzRW1wdHkoKSkKICAgICAgICAgY29udGV4dC5maWxsUmVjdChpbnRlcnNlY3Rp b24oaG9yaXpvbnRhbE92ZXJoYW5nUmVjdCwgZGlydHlSZWN0KSk7CiAKLSAgICBjb250ZXh0LnNl dEZpbGxDb2xvcihDb2xvcjo6d2hpdGUpOworICAgIGNvbnRleHQuc2V0RmlsbENvbG9yKENvbG9y OjpibGFjayk7CiAgICAgaWYgKCF2ZXJ0aWNhbE92ZXJoYW5nUmVjdC5pc0VtcHR5KCkpCiAgICAg ICAgIGNvbnRleHQuZmlsbFJlY3QoaW50ZXJzZWN0aW9uKHZlcnRpY2FsT3ZlcmhhbmdSZWN0LCBk aXJ0eVJlY3QpKTsKIH0KLS0tIGEvU291cmNlL1dlYktpdC9TaGFyZWQvQ29vcmRpbmF0ZWRHcmFw aGljcy9Db29yZGluYXRlZEdyYXBoaWNzU2NlbmUuY3BwCTIwMTgtMDctMTMgMTI6NDU6MzcuMjY1 MDI5MDIzICswMzAwCisrKyBiL1NvdXJjZS9XZWJLaXQvU2hhcmVkL0Nvb3JkaW5hdGVkR3JhcGhp Y3MvQ29vcmRpbmF0ZWRHcmFwaGljc1NjZW5lLmNwcAkyMDE4LTA3LTEzIDEyOjQ1OjM5LjU3MTcz MDEwNiArMDMwMApAQCAtNjgsNyArNjgsNyBAQAogICAgIDogbV9jbGllbnQoY2xpZW50KQogICAg ICwgbV9pc0FjdGl2ZShmYWxzZSkKICAgICAsIG1fcm9vdExheWVySUQoSW52YWxpZENvb3JkaW5h dGVkTGF5ZXJJRCkKLSAgICAsIG1fdmlld0JhY2tncm91bmRDb2xvcihDb2xvcjo6d2hpdGUpCisg ICAgLCBtX3ZpZXdCYWNrZ3JvdW5kQ29sb3IoQ29sb3I6OmJsYWNrKQogICAgICwgbV9jbGllbnRS dW5Mb29wKFJ1bkxvb3A6OmN1cnJlbnQoKSkKIHsKIH0KLS0tIGEvU291cmNlL1dlYktpdC9XZWJQ cm9jZXNzL1dlYkNvcmVTdXBwb3J0L1dlYkZyYW1lTG9hZGVyQ2xpZW50LmNwcAkyMDE4LTA3LTEz IDEyOjQ3OjI3LjI3NjY1MTE4NCArMDMwMAorKysgYi9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3Mv V2ViQ29yZVN1cHBvcnQvV2ViRnJhbWVMb2FkZXJDbGllbnQuY3BwCTIwMTgtMDctMTMgMTI6NDc6 NDEuNzc2ODYyMjkwICswMzAwCkBAIC0xMzg3LDcgKzEzODcsNyBAQAogewogICAgIFdlYlBhZ2Uq IHdlYlBhZ2UgPSBtX2ZyYW1lLT5wYWdlKCk7CiAKLSAgICBDb2xvciBiYWNrZ3JvdW5kQ29sb3Ig PSB3ZWJQYWdlLT5kcmF3c0JhY2tncm91bmQoKSA/IENvbG9yOjp3aGl0ZSA6IENvbG9yOjp0cmFu c3BhcmVudDsKKyAgICBDb2xvciBiYWNrZ3JvdW5kQ29sb3IgPSB3ZWJQYWdlLT5kcmF3c0JhY2tn cm91bmQoKSA/IENvbG9yOjpibGFjayA6IENvbG9yOjp0cmFuc3BhcmVudDsKICAgICBib29sIGlz TWFpbkZyYW1lID0gbV9mcmFtZS0+aXNNYWluRnJhbWUoKTsKICAgICBib29sIGlzVHJhbnNwYXJl bnQgPSAhd2ViUGFnZS0+ZHJhd3NCYWNrZ3JvdW5kKCk7CiAgICAgYm9vbCBzaG91bGRVc2VGaXhl ZExheW91dCA9IGlzTWFpbkZyYW1lICYmIHdlYlBhZ2UtPnVzZUZpeGVkTGF5b3V0KCk7Ci0tLSBh L1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2UuaAkyMDE4LTA3LTEzIDEy OjQ4OjIyLjExMDc3OTg3MCArMDMwMAorKysgYi9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvV2Vi UGFnZS9XZWJQYWdlLmgJMjAxOC0wNy0xMyAxMjo1MjowMC4zNDA1NDM4MzUgKzAzMDAKQEAgLTE2 MzEsNyArMTYzMSw3IEBACiAgICAgYm9vbCBtX2lzU3VzcGVuZGVkVW5kZXJMb2NrIHsgZmFsc2Ug fTsKIAogICAgIEhhc2hTZXQ8U3RyaW5nLCBBU0NJSUNhc2VJbnNlbnNpdGl2ZUhhc2g+IG1fbWlt ZVR5cGVzV2l0aEN1c3RvbUNvbnRlbnRQcm92aWRlcnM7Ci0gICAgV2ViQ29yZTo6Q29sb3IgbV9i YWNrZ3JvdW5kQ29sb3IgeyBXZWJDb3JlOjpDb2xvcjo6d2hpdGUgfTsKKyAgICBXZWJDb3JlOjpD b2xvciBtX2JhY2tncm91bmRDb2xvciB7IFdlYkNvcmU6OkNvbG9yOjpibGFjayB9OwogCiAgICAg SGFzaFNldDx1bnNpZ25lZD4gbV9hY3RpdmVSZW5kZXJpbmdTdXBwcmVzc2lvblRva2VuczsKICAg ICB1bnNpZ25lZCBtX21heGltdW1SZW5kZXJpbmdTdXBwcmVzc2lvblRva2VuIHsgMCB9Owo=