187634 2018-07-12 22:34:07 -0700 Signal.cpp's activeThreads() should only create its ThreadGroup once. 2018-07-13 00:04:19 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mark.lam mark.lam benjamin cdumez cmarcelo commit-queue dbates ews-watchlist fpizlo keith_miller msaboff rmorisset saam tzagallo webkit-bug-importer ysuzuki oldest_to_newest 1441801 0 mark.lam 2018-07-12 22:34:07 -0700 registerThreadForMachExceptionHandling() is relying on the activeThreads() ThreadGroup being a singleton. <rdar://problem/40662311> 1441804 1 344926 mark.lam 2018-07-12 22:40:12 -0700 Created attachment 344926 proposed patch. 1441808 2 344926 ysuzuki 2018-07-12 22:50:31 -0700 Comment on attachment 344926 proposed patch. r=me 1441814 3 344926 mark.lam 2018-07-12 23:37:11 -0700 Comment on attachment 344926 proposed patch. Thanks for the review. Landing now. 1441815 4 344926 commit-queue 2018-07-13 00:04:17 -0700 Comment on attachment 344926 proposed patch. Clearing flags on attachment: 344926 Committed r233795: <https://trac.webkit.org/changeset/233795> 1441816 5 commit-queue 2018-07-13 00:04:19 -0700 All reviewed patches have been landed. Closing bug. 344926 2018-07-12 22:40:12 -0700 2018-07-13 00:04:17 -0700 proposed patch. bug-187634.patch text/plain 1661 mark.lam SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh bmdlTG9nCShyZXZpc2lvbiAyMzM3OTMpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDE4LTA3LTEyICBNYXJrIExhbSAgPG1hcmsubGFt QGFwcGxlLmNvbT4KKworICAgICAgICBTaWduYWwuY3BwJ3MgYWN0aXZlVGhyZWFkcygpIHNob3Vs ZCBvbmx5IGNyZWF0ZSBpdHMgVGhyZWFkR3JvdXAgb25jZS4KKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4NzYzNAorICAgICAgICA8cmRhcjovL3Byb2Js ZW0vNDA2NjIzMTE+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgcmVnaXN0ZXJUaHJlYWRGb3JNYWNoRXhjZXB0aW9uSGFuZGxpbmcoKSBpcyByZWx5aW5n IG9uIHRoZSBhY3RpdmVUaHJlYWRzKCkKKyAgICAgICAgVGhyZWFkR3JvdXAgYmVpbmcgYSBzaW5n bGV0b24uCisKKyAgICAgICAgKiB3dGYvdGhyZWFkcy9TaWduYWxzLmNwcDoKKyAgICAgICAgKFdU Rjo6YWN0aXZlVGhyZWFkcyk6CisKIDIwMTgtMDctMTIgIERhdmlkIEtpbHplciAgPGRka2lsemVy QGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZlcnQ6IGlPUyBwb3J0IHNob3VsZCBkZWZpbmUgSEFW RV9SVU5MT09QX1RJTUVSCkluZGV4OiBTb3VyY2UvV1RGL3d0Zi90aHJlYWRzL1NpZ25hbHMuY3Bw Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvd3RmL3RocmVhZHMvU2lnbmFscy5jcHAJKHJldmlz aW9uIDIzMzc5MykKKysrIFNvdXJjZS9XVEYvd3RmL3RocmVhZHMvU2lnbmFscy5jcHAJKHdvcmtp bmcgY29weSkKQEAgLTIwOSwxMCArMjA5LDE1IEBAIGlubGluZSB2b2lkIHNldEV4Y2VwdGlvblBv cnRzKGNvbnN0IEFic3QKICAgICB9CiB9CiAKLWlubGluZSBUaHJlYWRHcm91cCYgYWN0aXZlVGhy ZWFkcygpCitzdGF0aWMgVGhyZWFkR3JvdXAmIGFjdGl2ZVRocmVhZHMoKQogewotICAgIHN0YXRp YyBOZXZlckRlc3Ryb3llZDxzdGQ6OnNoYXJlZF9wdHI8VGhyZWFkR3JvdXA+PiBhY3RpdmVUaHJl YWRzIHsgVGhyZWFkR3JvdXA6OmNyZWF0ZSgpIH07Ci0gICAgcmV0dXJuICphY3RpdmVUaHJlYWRz LmdldCgpOworICAgIHN0YXRpYyBzdGQ6Om9uY2VfZmxhZyBpbml0aWFsaXplS2V5OworICAgIHN0 YXRpYyBUaHJlYWRHcm91cCogYWN0aXZlVGhyZWFkc1B0ciA9IG51bGxwdHI7CisgICAgc3RkOjpj YWxsX29uY2UoaW5pdGlhbGl6ZUtleSwgWyZdIHsKKyAgICAgICAgc3RhdGljIE5ldmVyRGVzdHJv eWVkPHN0ZDo6c2hhcmVkX3B0cjxUaHJlYWRHcm91cD4+IGFjdGl2ZVRocmVhZHMgeyBUaHJlYWRH cm91cDo6Y3JlYXRlKCkgfTsKKyAgICAgICAgYWN0aXZlVGhyZWFkc1B0ciA9IGFjdGl2ZVRocmVh ZHMuZ2V0KCkuZ2V0KCk7CisgICAgfSk7CisgICAgcmV0dXJuICphY3RpdmVUaHJlYWRzUHRyOwog fQogCiB2b2lkIHJlZ2lzdGVyVGhyZWFkRm9yTWFjaEV4Y2VwdGlvbkhhbmRsaW5nKFRocmVhZCYg dGhyZWFkKQo=