187624 2018-07-12 15:49:57 -0700 PingLoad does not need to ref the NetworkConnectionToWebProcess 2018-07-12 16:47:17 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cdumez cdumez commit-queue webkit-bug-importer youennf oldest_to_newest 1441699 0 cdumez 2018-07-12 15:49:57 -0700 PingLoad does not need to ref the NetworkConnectionToWebProcess and keep it alive longer than it needs to be. 1441700 1 344893 cdumez 2018-07-12 15:53:42 -0700 Created attachment 344893 Patch 1441701 2 344893 youennf 2018-07-12 15:59:20 -0700 Comment on attachment 344893 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=344893&action=review > Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.cpp:270 > + auto completionHandler = [connection = m_connection.copyRef(), identifier = loadParameters.identifier] (const ResourceError& error, const ResourceResponse& response) { Is it really safe? LOL ;) 1441726 3 344893 commit-queue 2018-07-12 16:46:24 -0700 Comment on attachment 344893 Patch Clearing flags on attachment: 344893 Committed r233787: <https://trac.webkit.org/changeset/233787> 1441727 4 commit-queue 2018-07-12 16:46:26 -0700 All reviewed patches have been landed. Closing bug. 1441728 5 webkit-bug-importer 2018-07-12 16:47:17 -0700 <rdar://problem/42143573> 344893 2018-07-12 15:53:42 -0700 2018-07-12 16:46:24 -0700 Patch bug-187624-20180712155339.patch text/plain 3710 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjMzNzg0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDQxMGQ3NDQwMDA1NThiMjg4 OTVmN2I2YTUyOWIwMDQyZjEyZGVlOTQuLmVjNGNmOTcyNzYwNmNkMzJjNDRjMDFhNzY2NDViMjBm NWM4MDY2MzYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTgtMDctMTIgIENocmlzIER1 bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KKworICAgICAgICBQaW5nTG9hZCBkb2VzIG5vdCBuZWVk IHRvIHJlZiB0aGUgTmV0d29ya0Nvbm5lY3Rpb25Ub1dlYlByb2Nlc3MKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4NzYyNAorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFBpbmdMb2FkIGRvZXMgbm90IG5lZWQg dG8gcmVmIHRoZSBOZXR3b3JrQ29ubmVjdGlvblRvV2ViUHJvY2VzcyBhbmQga2VlcCBpdCBhbGl2 ZSBsb25nZXIgdGhhbiBpdCBuZWVkcyB0byBiZS4KKyAgICAgICAgSW5zdGVhZCwgcmVmIHRoZSBJ UEM6OkNvbm5lY3Rpb24gd2hpY2ggaXMgbGlnaHRlciB3ZWlnaHQgYW5kIGdldHMgaW52YWxpZGF0 ZWQgd2hlbiB0aGUgTmV0d29ya0Nvbm5lY3Rpb25Ub1dlYlByb2Nlc3MKKyAgICAgICAgaXMgZGVz dHJveWVkLgorCisgICAgICAgICogTmV0d29ya1Byb2Nlc3MvTmV0d29ya0Nvbm5lY3Rpb25Ub1dl YlByb2Nlc3MuY3BwOgorICAgICAgICAoV2ViS2l0OjpOZXR3b3JrQ29ubmVjdGlvblRvV2ViUHJv Y2Vzczo6bG9hZFBpbmcpOgorICAgICAgICAoV2ViS2l0OjpOZXR3b3JrQ29ubmVjdGlvblRvV2Vi UHJvY2Vzczo6ZGlkRmluaXNoUGluZ0xvYWQpOiBEZWxldGVkLgorICAgICAgICAqIE5ldHdvcmtQ cm9jZXNzL05ldHdvcmtDb25uZWN0aW9uVG9XZWJQcm9jZXNzLmg6CisKIDIwMTgtMDctMTIgIENo cmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KIAogICAgICAgICBNYWtlIHN1cmUgV2ViUHJv Y2Vzczo6ZW5zdXJlTmV0d29ya1Byb2Nlc3NDb25uZWN0aW9uKCkgaXMgYWx3YXlzIGNhbGxlZCBv biB0aGUgbWFpbiB0aHJlYWQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nl c3MvTmV0d29ya0Nvbm5lY3Rpb25Ub1dlYlByb2Nlc3MuY3BwIGIvU291cmNlL1dlYktpdC9OZXR3 b3JrUHJvY2Vzcy9OZXR3b3JrQ29ubmVjdGlvblRvV2ViUHJvY2Vzcy5jcHAKaW5kZXggZTdlZmYw M2JlZDhlNjZiYjYzZmI1ZDE5OGY5Yzk4ZDVlMmQ5NTc4NS4uNWRmYmQxMDQ1ZGY4NjQ2MzZiYzAy NjZhNTI1YTM3Yjc1NzllOTg5NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9OZXR3b3JrUHJv Y2Vzcy9OZXR3b3JrQ29ubmVjdGlvblRvV2ViUHJvY2Vzcy5jcHAKKysrIGIvU291cmNlL1dlYktp dC9OZXR3b3JrUHJvY2Vzcy9OZXR3b3JrQ29ubmVjdGlvblRvV2ViUHJvY2Vzcy5jcHAKQEAgLTI2 NywyMiArMjY3LDE0IEBAIHZvaWQgTmV0d29ya0Nvbm5lY3Rpb25Ub1dlYlByb2Nlc3M6OnBlcmZv cm1TeW5jaHJvbm91c0xvYWQoTmV0d29ya1Jlc291cmNlTG9hZFBhCiAKIHZvaWQgTmV0d29ya0Nv bm5lY3Rpb25Ub1dlYlByb2Nlc3M6OmxvYWRQaW5nKE5ldHdvcmtSZXNvdXJjZUxvYWRQYXJhbWV0 ZXJzJiYgbG9hZFBhcmFtZXRlcnMpCiB7Ci0gICAgYXV0byBjb21wbGV0aW9uSGFuZGxlciA9IFt0 aGlzLCBwcm90ZWN0ZWRUaGlzID0gbWFrZVJlZigqdGhpcyksIGlkZW50aWZpZXIgPSBsb2FkUGFy YW1ldGVycy5pZGVudGlmaWVyXSAoY29uc3QgUmVzb3VyY2VFcnJvciYgZXJyb3IsIGNvbnN0IFJl c291cmNlUmVzcG9uc2UmIHJlc3BvbnNlKSB7Ci0gICAgICAgIGRpZEZpbmlzaFBpbmdMb2FkKGlk ZW50aWZpZXIsIGVycm9yLCByZXNwb25zZSk7CisgICAgYXV0byBjb21wbGV0aW9uSGFuZGxlciA9 IFtjb25uZWN0aW9uID0gbV9jb25uZWN0aW9uLmNvcHlSZWYoKSwgaWRlbnRpZmllciA9IGxvYWRQ YXJhbWV0ZXJzLmlkZW50aWZpZXJdIChjb25zdCBSZXNvdXJjZUVycm9yJiBlcnJvciwgY29uc3Qg UmVzb3VyY2VSZXNwb25zZSYgcmVzcG9uc2UpIHsKKyAgICAgICAgY29ubmVjdGlvbi0+c2VuZChN ZXNzYWdlczo6TmV0d29ya1Byb2Nlc3NDb25uZWN0aW9uOjpEaWRGaW5pc2hQaW5nTG9hZChpZGVu dGlmaWVyLCBlcnJvciwgcmVzcG9uc2UpLCAwKTsKICAgICB9OwogCiAgICAgLy8gUGluZ0xvYWQg bWFuYWdlcyBpdHMgb3duIGxpZmV0aW1lLCBkZWxldGluZyBpdHNlbGYgd2hlbiBpdHMgcHVycG9z ZSBoYXMgYmVlbiBmdWxmaWxsZWQuCiAgICAgbmV3IFBpbmdMb2FkKFdURk1vdmUobG9hZFBhcmFt ZXRlcnMpLCBXVEZNb3ZlKGNvbXBsZXRpb25IYW5kbGVyKSk7CiB9CiAKLXZvaWQgTmV0d29ya0Nv bm5lY3Rpb25Ub1dlYlByb2Nlc3M6OmRpZEZpbmlzaFBpbmdMb2FkKHVpbnQ2NF90IHBpbmdMb2Fk SWRlbnRpZmllciwgY29uc3QgUmVzb3VyY2VFcnJvciYgZXJyb3IsIGNvbnN0IFJlc291cmNlUmVz cG9uc2UmIHJlc3BvbnNlKQotewotICAgIGlmICghbV9jb25uZWN0aW9uLT5pc1ZhbGlkKCkpCi0g ICAgICAgIHJldHVybjsKLQotICAgIG1fY29ubmVjdGlvbi0+c2VuZChNZXNzYWdlczo6TmV0d29y a1Byb2Nlc3NDb25uZWN0aW9uOjpEaWRGaW5pc2hQaW5nTG9hZChwaW5nTG9hZElkZW50aWZpZXIs IGVycm9yLCByZXNwb25zZSksIDApOwotfQotCiB2b2lkIE5ldHdvcmtDb25uZWN0aW9uVG9XZWJQ cm9jZXNzOjpzZXRPbkxpbmVTdGF0ZShib29sIGlzT25MaW5lKQogewogICAgIG1fY29ubmVjdGlv bi0+c2VuZChNZXNzYWdlczo6TmV0d29ya1Byb2Nlc3NDb25uZWN0aW9uOjpTZXRPbkxpbmVTdGF0 ZShpc09uTGluZSksIDApOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vz cy9OZXR3b3JrQ29ubmVjdGlvblRvV2ViUHJvY2Vzcy5oIGIvU291cmNlL1dlYktpdC9OZXR3b3Jr UHJvY2Vzcy9OZXR3b3JrQ29ubmVjdGlvblRvV2ViUHJvY2Vzcy5oCmluZGV4IGVmY2Q0NWYwYzll YTQ0OGIwMWQyNjc4YThhZDBmMzJmMWQ1NDgyMmUuLjA1OTE0YWFjNjhjZGEwMjc1YzgwYWZjYmI5 YzU4N2E0ZTViYjY3MTYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3Mv TmV0d29ya0Nvbm5lY3Rpb25Ub1dlYlByb2Nlc3MuaAorKysgYi9Tb3VyY2UvV2ViS2l0L05ldHdv cmtQcm9jZXNzL05ldHdvcmtDb25uZWN0aW9uVG9XZWJQcm9jZXNzLmgKQEAgLTY4LDcgKzY4LDYg QEAgcHVibGljOgogICAgIElQQzo6Q29ubmVjdGlvbiYgY29ubmVjdGlvbigpIHsgcmV0dXJuIG1f Y29ubmVjdGlvbi5nZXQoKTsgfQogCiAgICAgdm9pZCBkaWRDbGVhbnVwUmVzb3VyY2VMb2FkZXIo TmV0d29ya1Jlc291cmNlTG9hZGVyJik7Ci0gICAgdm9pZCBkaWRGaW5pc2hQaW5nTG9hZCh1aW50 NjRfdCBwaW5nTG9hZElkZW50aWZpZXIsIGNvbnN0IFdlYkNvcmU6OlJlc291cmNlRXJyb3ImLCBj b25zdCBXZWJDb3JlOjpSZXNvdXJjZVJlc3BvbnNlJik7CiAgICAgdm9pZCBzZXRPbkxpbmVTdGF0 ZShib29sKTsKIAogICAgIGJvb2wgY2FwdHVyZUV4dHJhTmV0d29ya0xvYWRNZXRyaWNzRW5hYmxl ZCgpIGNvbnN0IHsgcmV0dXJuIG1fY2FwdHVyZUV4dHJhTmV0d29ya0xvYWRNZXRyaWNzRW5hYmxl ZDsgfQo=