187591 2018-07-12 06:38:48 -0700 [GTK] imported/w3c/web-platform-tests/media-source/mediasource-getvideoplaybackquality.html is flaky 2018-08-22 07:13:37 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 magomez Ms2ger bugs-noreply commit-queue Ms2ger tsaunier oldest_to_newest 1441475 0 magomez 2018-07-12 06:38:48 -0700 imported/w3c/web-platform-tests/media-source/mediasource-getvideoplaybackquality.html [ Failure Crash ] The test moves between crashing and failing with text constantly. When it fails with text, this is the diff: --- /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/imported/w3c/web-platform-tests/media-source/mediasource-getvideoplaybackquality-expected.txt +++ /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/imported/w3c/web-platform-tests/media-source/mediasource-getvideoplaybackquality-actual.txt @@ -1,4 +1,4 @@ -PASS Test HTMLVideoElement.getVideoPlaybackQuality() with MediaSource API -PASS Test the totalFrameDelay attribute of HTMLVideoElement.getVideoPlaybackQuality() with MediaSource API +FAIL Test HTMLVideoElement.getVideoPlaybackQuality() with MediaSource API assert_unreached: Unexpected event 'error' Reached unreachable code +FAIL Test the totalFrameDelay attribute of HTMLVideoElement.getVideoPlaybackQuality() with MediaSource API assert_unreached: Unexpected event 'error' Reached unreachable code The first crash happened in r233638. Before that it was mostly passing with text failure every now and then. I cannot be sure that r233638 is the cause of the crash, but adding the author just in case. The crash log can be seen here https://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20(Tests)/r233765%20(7376)/imported/w3c/web-platform-tests/media-source/mediasource-getvideoplaybackquality-crash-log.txt 1441496 1 tsaunier 2018-07-12 07:23:20 -0700 Seem related to the implementation of MediaStream, looking into it. 1441523 2 tsaunier 2018-07-12 09:13:34 -0700 (In reply to Thibault Saunier from comment #1) > Seem related to the implementation of MediaStream, looking into it. Sorry I misread it is about MediaSource (a.k.a MSE) and is not related at all with MediaStream. Also I do not see any way it is related to r233638 as that one is about flatpak which is not use on the build bots yet. 1452602 3 347786 Ms2ger 2018-08-22 06:39:32 -0700 Created attachment 347786 Patch 1452608 4 347786 commit-queue 2018-08-22 07:13:35 -0700 Comment on attachment 347786 Patch Clearing flags on attachment: 347786 Committed r235168: <https://trac.webkit.org/changeset/235168> 1452609 5 commit-queue 2018-08-22 07:13:37 -0700 All reviewed patches have been landed. Closing bug. 347786 2018-08-22 06:39:32 -0700 2018-08-22 07:13:35 -0700 Patch bug-187591-20180822153930.patch text/plain 1692 Ms2ger U3VidmVyc2lvbiBSZXZpc2lvbjogMjM1MTY3CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggYzQzMzRjMTc1OTdjMzM0MjAxZWUw YTY3YjgxODA1NjI1ZTA3NWE3MC4uZWQzOGY1MzM3NGM5OGUyNzNiMzU3NDU0YzMzM2NkM2Q0MTUw N2Q4ZCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE4LTA4LTIyICBNczJnZXIgIDxNczJnZXJA aWdhbGlhLmNvbT4KKworICAgICAgICBbR1RLXSBpbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRl c3RzL21lZGlhLXNvdXJjZS9tZWRpYXNvdXJjZS1nZXR2aWRlb3BsYXliYWNrcXVhbGl0eS5odG1s IGlzIGZsYWt5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xODc1OTEKKworICAgICAgICBVbnJldmlld2VkIHRlc3QgZ2FyZGVuaW5nLgorCisgICAgICAg IFJlLWVuYWJsZSBtZWRpYXNvdXJjZS1nZXR2aWRlb3BsYXliYWNrcXVhbGl0eS5odG1sLgorCisg ICAgICAgIFRoZSBjcmFzaCB3YXMgZml4ZWQgaW4gcjIzMzk4MSwgYW5kIHRoZSBmYWlsdXJlIGlu IHIyMzQ5ODEtcjIzNDk4My4KKworICAgICAgICAqIHBsYXRmb3JtL2d0ay9UZXN0RXhwZWN0YXRp b25zOgorCiAyMDE4LTA4LTIyICBNczJnZXIgIDxNczJnZXJAaWdhbGlhLmNvbT4KIAogICAgICAg ICBSRUdSRVNTSU9OKHIyMzQzMzApOiBbR1RLXSBzdmcvYXMtaW1hZ2Uvc3ZnLWltYWdlLXdpdGgt ZGF0YS11cmktYmFja2dyb3VuZC5odG1sIGlzIGZhaWxpbmcKZGlmZiAtLWdpdCBhL0xheW91dFRl c3RzL3BsYXRmb3JtL2d0ay9UZXN0RXhwZWN0YXRpb25zIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0v Z3RrL1Rlc3RFeHBlY3RhdGlvbnMKaW5kZXggYzUyMDU0M2E5ZjI5ZWNhN2YxYzAxNjNmNmFhODIz MmY1YWU5ZmU3MC4uNmVlYjgwZDNjZjZjY2E4M2E0OGZiMmJhOWI2NjY0NWQ1Yjc3NmViZSAxMDA2 NDQKLS0tIGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL1Rlc3RFeHBlY3RhdGlvbnMKKysrIGIv TGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL1Rlc3RFeHBlY3RhdGlvbnMKQEAgLTIwMDYsOCArMjAw Niw2IEBAIHdlYmtpdC5vcmcvYi8xODc1ODkgaW5zcGVjdG9yL3VuaXQtdGVzdHMvZGVib3VuY2Uu aHRtbCBbIFRpbWVvdXQgUGFzcyBdCiAKIHdlYmtpdC5vcmcvYi8xODc1OTAgaW1wb3J0ZWQvdzNj L3dlYi1wbGF0Zm9ybS10ZXN0cy93ZWItYW5pbWF0aW9ucy90aW1pbmctbW9kZWwvdGltZWxpbmVz L2RvY3VtZW50LXRpbWVsaW5lcy5odG1sIFsgRmFpbHVyZSBQYXNzIF0KIAotd2Via2l0Lm9yZy9i LzE4NzU5MSBpbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL21lZGlhLXNvdXJjZS9tZWRp YXNvdXJjZS1nZXR2aWRlb3BsYXliYWNrcXVhbGl0eS5odG1sIFsgRmFpbHVyZSBDcmFzaCBdCi0K IHdlYmtpdC5vcmcvYi8xODc3NjEgaHR0cC90ZXN0cy9zZWN1cml0eS9jb250ZW50U2VjdXJpdHlQ b2xpY3kvMS4xL3BsdWdpbnR5cGVzLWFmZmVjdHMtY2hpbGQuaHRtbCBbIFBhc3MgRmFpbHVyZSBd CiAKIHdlYmtpdC5vcmcvYi8xODc3NjAgZmFzdC9tZWRpYXN0cmVhbS9nZXQtdXNlci1tZWRpYS1v bi1sb2FkZWRtZXRhZGF0YS5odG1sIFsgUGFzcyBGYWlsdXJlIF0K