187573 2018-07-11 17:51:39 -0700 Make WebKit.LinkColorWithSystemAppearance work across system versions 2018-07-12 11:38:19 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 timothy timothy commit-queue lforschler realdawei ryanhaddad thorton webkit-bug-importer wenson_hsieh oldest_to_newest 1441313 0 timothy 2018-07-11 17:51:39 -0700 The [NSColor linkColor] is different between 10.14 and earlier macOS releases. Make this test work in all cases. 1441316 1 344800 timothy 2018-07-11 17:52:59 -0700 Created attachment 344800 Patch 1441509 2 344800 wenson_hsieh 2018-07-12 08:28:14 -0700 Comment on attachment 344800 Patch I might be missing something here, but it looks like +[NSColor linkColor] only exists in <AppKit/NSColor.h> on macOS Mojave (despite NS_AVAILABLE_MAC(10_10) in the header). 1441514 3 wenson_hsieh 2018-07-12 08:32:58 -0700 (In reply to Wenson Hsieh from comment #2) > Comment on attachment 344800 [details] > Patch > > I might be missing something here, but it looks like +[NSColor linkColor] > only exists in <AppKit/NSColor.h> on macOS Mojave (despite > NS_AVAILABLE_MAC(10_10) in the header). Ah, that being said, +[NSColor linkColor] is SPI in NSColor_Private.h on Sierra and High Sierra SDKs, where its availability is declared as NS_AVAILABLE_MAC(10_10). I'm not sure if transferring the same availability over to the public header was an intentional change in Mojave...but it seems like we need to forward declare this to get it to build on the open source WebKit bots. 1441519 4 timothy 2018-07-12 08:47:58 -0700 Sigh, yep. We declare it in our NSColorSPI.h. I’ll just include that. 1441569 5 344858 timothy 2018-07-12 10:30:58 -0700 Created attachment 344858 Patch 1441583 6 344861 timothy 2018-07-12 10:59:19 -0700 Created attachment 344861 Patch 1441601 7 344861 commit-queue 2018-07-12 11:37:54 -0700 Comment on attachment 344861 Patch Clearing flags on attachment: 344861 Committed r233775: <https://trac.webkit.org/changeset/233775> 1441602 8 commit-queue 2018-07-12 11:37:56 -0700 All reviewed patches have been landed. Closing bug. 1441603 9 webkit-bug-importer 2018-07-12 11:38:19 -0700 <rdar://problem/42130497> 344800 2018-07-11 17:52:59 -0700 2018-07-12 10:30:56 -0700 Patch bug-187573-20180711175258.patch text/plain 1909 timothy U3VidmVyc2lvbiBSZXZpc2lvbjogMjMzNzQ1CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggOWQ4MDU4MGEyZTljNzY5ZTMxNjI1NzhmYTk5NzRiNjMw YWQyZjQ5Zi4uOTQ4MGQyOTJhYzM2ZDMyNzhkZDEwNzZjMzM4NzFiNDA2NWZiYTcwMSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEz IEBACisyMDE4LTA3LTExICBUaW1vdGh5IEhhdGNoZXIgIDx0aW1vdGh5QGFwcGxlLmNvbT4KKwor ICAgICAgICBNYWtlIFdlYktpdC5MaW5rQ29sb3JXaXRoU3lzdGVtQXBwZWFyYW5jZSB3b3JrIGFj cm9zcyBzeXN0ZW0gdmVyc2lvbnMuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xODc1NzMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICAqIFRlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0Q29jb2EvU3lzdGVtQ29s b3JzLm1tOgorICAgICAgICAoVGVzdFdlYktpdEFQSS5XZWJLaXQuTGlua0NvbG9yV2l0aFN5c3Rl bUFwcGVhcmFuY2UpOiBEeW5hbWljYWxseSBnZW5lcmF0ZSB0aGUgZXhwZWN0ZWQgc3RyaW5nLgor CiAyMDE4LTA3LTExICBBbGV4IENocmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+ CiAKICAgICAgICAgUmVkdWNlIHNpemUgb2YgV2ViQ29yZTo6VVJMCmRpZmYgLS1naXQgYS9Ub29s cy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdENvY29hL1N5c3RlbUNvbG9ycy5tbSBiL1Rvb2xz L1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0Q29jb2EvU3lzdGVtQ29sb3JzLm1tCmluZGV4IGE3 OGU4ZTAzYWRmODYzMDNmZTYzZmQ5YmIxZTJmNjU4MmY0NjY3ODUuLjc2OWJmMTNiNzM3YzQ2YjRk MDUyMzkxYWMyOGFjOTBlNTFkMjY0NzggMTAwNjQ0Ci0tLSBhL1Rvb2xzL1Rlc3RXZWJLaXRBUEkv VGVzdHMvV2ViS2l0Q29jb2EvU3lzdGVtQ29sb3JzLm1tCisrKyBiL1Rvb2xzL1Rlc3RXZWJLaXRB UEkvVGVzdHMvV2ViS2l0Q29jb2EvU3lzdGVtQ29sb3JzLm1tCkBAIC01Miw4ICs1MiwxNiBAQCBU RVNUKFdlYktpdCwgTGlua0NvbG9yV2l0aFN5c3RlbUFwcGVhcmFuY2UpCiAKICAgICBbd2ViVmll dyBzeW5jaHJvbm91c2x5TG9hZEhUTUxTdHJpbmc6QCI8YSBocmVmPlRlc3Q8L2E+Il07CiAKLSAg ICBOU1N0cmluZyAqbGlua0NvbG9yID0gW3dlYlZpZXcgc3RyaW5nQnlFdmFsdWF0aW5nSmF2YVNj cmlwdDpAImdldENvbXB1dGVkU3R5bGUoZG9jdW1lbnQubGlua3NbMF0pLmNvbG9yIl07Ci0gICAg RVhQRUNUX1dLX1NUUkVRKCJyZ2IoMCwgMTA0LCAyMTgpIiwgbGlua0NvbG9yKTsKKyAgICBOU0Nv bG9yICpsaW5rQ29sb3IgPSBbTlNDb2xvci5saW5rQ29sb3IgY29sb3JVc2luZ0NvbG9yU3BhY2U6 TlNDb2xvclNwYWNlLnNSR0JDb2xvclNwYWNlXTsKKworICAgIENHRmxvYXQgcmVkID0gbGlua0Nv bG9yLnJlZENvbXBvbmVudCAqIDI1NTsKKyAgICBDR0Zsb2F0IGdyZWVuID0gbGlua0NvbG9yLmdy ZWVuQ29tcG9uZW50ICogMjU1OworICAgIENHRmxvYXQgYmx1ZSA9IGxpbmtDb2xvci5ibHVlQ29t cG9uZW50ICogMjU1OworCisgICAgTlNTdHJpbmcgKmV4cGVjdGVkU3RyaW5nID0gW05TU3RyaW5n IHN0cmluZ1dpdGhGb3JtYXQ6QCJyZ2IoJS4wZiwgJS4wZiwgJS4wZikiLCByZWQsIGdyZWVuLCBi bHVlXTsKKworICAgIE5TU3RyaW5nICpjc3NMaW5rQ29sb3IgPSBbd2ViVmlldyBzdHJpbmdCeUV2 YWx1YXRpbmdKYXZhU2NyaXB0OkAiZ2V0Q29tcHV0ZWRTdHlsZShkb2N1bWVudC5saW5rc1swXSku Y29sb3IiXTsKKyAgICBFWFBFQ1RfV0tfU1RSRVEoZXhwZWN0ZWRTdHJpbmcuVVRGOFN0cmluZywg Y3NzTGlua0NvbG9yKTsKIH0KICNlbmRpZgogCg== 344858 2018-07-12 10:30:58 -0700 2018-07-12 10:59:18 -0700 Patch bug-187573-20180712103057.patch text/plain 2114 timothy U3VidmVyc2lvbiBSZXZpc2lvbjogMjMzNzQ1CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggOWQ4MDU4MGEyZTljNzY5ZTMxNjI1NzhmYTk5NzRiNjMw YWQyZjQ5Zi4uM2M3ZWQxM2JjMjQ5NGJmZDI5M2YyMjRjYmMyZmQ0MDZmODVhYjFjNSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEz IEBACisyMDE4LTA3LTExICBUaW1vdGh5IEhhdGNoZXIgIDx0aW1vdGh5QGFwcGxlLmNvbT4KKwor ICAgICAgICBNYWtlIFdlYktpdC5MaW5rQ29sb3JXaXRoU3lzdGVtQXBwZWFyYW5jZSB3b3JrIGFj cm9zcyBzeXN0ZW0gdmVyc2lvbnMuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xODc1NzMKKworICAgICAgICBSZXZpZXdlZCBieSBXZW5zb24gSHNpZWgu CisKKyAgICAgICAgKiBUZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdENvY29hL1N5c3RlbUNvbG9y cy5tbToKKyAgICAgICAgKFRlc3RXZWJLaXRBUEkuV2ViS2l0LkxpbmtDb2xvcldpdGhTeXN0ZW1B cHBlYXJhbmNlKTogRHluYW1pY2FsbHkgZ2VuZXJhdGUgdGhlIGV4cGVjdGVkIHN0cmluZy4KKwog MjAxOC0wNy0xMSAgQWxleCBDaHJpc3RlbnNlbiAgPGFjaHJpc3RlbnNlbkB3ZWJraXQub3JnPgog CiAgICAgICAgIFJlZHVjZSBzaXplIG9mIFdlYkNvcmU6OlVSTApkaWZmIC0tZ2l0IGEvVG9vbHMv VGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXRDb2NvYS9TeXN0ZW1Db2xvcnMubW0gYi9Ub29scy9U ZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdENvY29hL1N5c3RlbUNvbG9ycy5tbQppbmRleCBhNzhl OGUwM2FkZjg2MzAzZmU2M2ZkOWJiMWUyZjY1ODJmNDY2Nzg1Li4yMGJlOWU4MjgyOTc0NGNlNjFm YjljYWQ0YTA4MTJmMGE0NDI5NzZmIDEwMDY0NAotLS0gYS9Ub29scy9UZXN0V2ViS2l0QVBJL1Rl c3RzL1dlYktpdENvY29hL1N5c3RlbUNvbG9ycy5tbQorKysgYi9Ub29scy9UZXN0V2ViS2l0QVBJ L1Rlc3RzL1dlYktpdENvY29hL1N5c3RlbUNvbG9ycy5tbQpAQCAtMzAsNiArMzAsNyBAQAogI2lt cG9ydCAiUGxhdGZvcm1VdGlsaXRpZXMuaCIKICNpbXBvcnQgIlRlc3RXS1dlYlZpZXcuaCIKICNp bXBvcnQgPFdlYktpdC9XS1dlYlZpZXdQcml2YXRlLmg+CisjaW1wb3J0IDxwYWwvc3BpL2NvY29h L05TQ29sb3JTUEkuaD4KICNpbXBvcnQgPHd0Zi9SZXRhaW5QdHIuaD4KIAogbmFtZXNwYWNlIFRl c3RXZWJLaXRBUEkgewpAQCAtNTIsOCArNTMsMTYgQEAgVEVTVChXZWJLaXQsIExpbmtDb2xvcldp dGhTeXN0ZW1BcHBlYXJhbmNlKQogCiAgICAgW3dlYlZpZXcgc3luY2hyb25vdXNseUxvYWRIVE1M U3RyaW5nOkAiPGEgaHJlZj5UZXN0PC9hPiJdOwogCi0gICAgTlNTdHJpbmcgKmxpbmtDb2xvciA9 IFt3ZWJWaWV3IHN0cmluZ0J5RXZhbHVhdGluZ0phdmFTY3JpcHQ6QCJnZXRDb21wdXRlZFN0eWxl KGRvY3VtZW50LmxpbmtzWzBdKS5jb2xvciJdOwotICAgIEVYUEVDVF9XS19TVFJFUSgicmdiKDAs IDEwNCwgMjE4KSIsIGxpbmtDb2xvcik7CisgICAgTlNDb2xvciAqbGlua0NvbG9yID0gW05TQ29s b3IubGlua0NvbG9yIGNvbG9yVXNpbmdDb2xvclNwYWNlOk5TQ29sb3JTcGFjZS5zUkdCQ29sb3JT cGFjZV07CisKKyAgICBDR0Zsb2F0IHJlZCA9IGxpbmtDb2xvci5yZWRDb21wb25lbnQgKiAyNTU7 CisgICAgQ0dGbG9hdCBncmVlbiA9IGxpbmtDb2xvci5ncmVlbkNvbXBvbmVudCAqIDI1NTsKKyAg ICBDR0Zsb2F0IGJsdWUgPSBsaW5rQ29sb3IuYmx1ZUNvbXBvbmVudCAqIDI1NTsKKworICAgIE5T U3RyaW5nICpleHBlY3RlZFN0cmluZyA9IFtOU1N0cmluZyBzdHJpbmdXaXRoRm9ybWF0OkAicmdi KCUuMGYsICUuMGYsICUuMGYpIiwgcmVkLCBncmVlbiwgYmx1ZV07CisKKyAgICBOU1N0cmluZyAq Y3NzTGlua0NvbG9yID0gW3dlYlZpZXcgc3RyaW5nQnlFdmFsdWF0aW5nSmF2YVNjcmlwdDpAImdl dENvbXB1dGVkU3R5bGUoZG9jdW1lbnQubGlua3NbMF0pLmNvbG9yIl07CisgICAgRVhQRUNUX1dL X1NUUkVRKGV4cGVjdGVkU3RyaW5nLlVURjhTdHJpbmcsIGNzc0xpbmtDb2xvcik7CiB9CiAjZW5k aWYKIAo= 344861 2018-07-12 10:59:19 -0700 2018-07-12 11:37:54 -0700 Patch bug-187573-20180712105919.patch text/plain 2113 timothy U3VidmVyc2lvbiBSZXZpc2lvbjogMjMzNzQ1CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggOWQ4MDU4MGEyZTljNzY5ZTMxNjI1NzhmYTk5NzRiNjMw YWQyZjQ5Zi4uM2M3ZWQxM2JjMjQ5NGJmZDI5M2YyMjRjYmMyZmQ0MDZmODVhYjFjNSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEz IEBACisyMDE4LTA3LTExICBUaW1vdGh5IEhhdGNoZXIgIDx0aW1vdGh5QGFwcGxlLmNvbT4KKwor ICAgICAgICBNYWtlIFdlYktpdC5MaW5rQ29sb3JXaXRoU3lzdGVtQXBwZWFyYW5jZSB3b3JrIGFj cm9zcyBzeXN0ZW0gdmVyc2lvbnMuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xODc1NzMKKworICAgICAgICBSZXZpZXdlZCBieSBXZW5zb24gSHNpZWgu CisKKyAgICAgICAgKiBUZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdENvY29hL1N5c3RlbUNvbG9y cy5tbToKKyAgICAgICAgKFRlc3RXZWJLaXRBUEkuV2ViS2l0LkxpbmtDb2xvcldpdGhTeXN0ZW1B cHBlYXJhbmNlKTogRHluYW1pY2FsbHkgZ2VuZXJhdGUgdGhlIGV4cGVjdGVkIHN0cmluZy4KKwog MjAxOC0wNy0xMSAgQWxleCBDaHJpc3RlbnNlbiAgPGFjaHJpc3RlbnNlbkB3ZWJraXQub3JnPgog CiAgICAgICAgIFJlZHVjZSBzaXplIG9mIFdlYkNvcmU6OlVSTApkaWZmIC0tZ2l0IGEvVG9vbHMv VGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXRDb2NvYS9TeXN0ZW1Db2xvcnMubW0gYi9Ub29scy9U ZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdENvY29hL1N5c3RlbUNvbG9ycy5tbQppbmRleCBhNzhl OGUwM2FkZjg2MzAzZmU2M2ZkOWJiMWUyZjY1ODJmNDY2Nzg1Li5mZTQ5ZTMwZDg0MTJmOGExYjVl OGZlNDNmZDUyMDY0OWQwNDM0ODQ1IDEwMDY0NAotLS0gYS9Ub29scy9UZXN0V2ViS2l0QVBJL1Rl c3RzL1dlYktpdENvY29hL1N5c3RlbUNvbG9ycy5tbQorKysgYi9Ub29scy9UZXN0V2ViS2l0QVBJ L1Rlc3RzL1dlYktpdENvY29hL1N5c3RlbUNvbG9ycy5tbQpAQCAtMzIsNiArMzIsMTAgQEAKICNp bXBvcnQgPFdlYktpdC9XS1dlYlZpZXdQcml2YXRlLmg+CiAjaW1wb3J0IDx3dGYvUmV0YWluUHRy Lmg+CiAKKyNpZiBQTEFURk9STShNQUMpCisjaW1wb3J0IDxwYWwvc3BpL2NvY29hL05TQ29sb3JT UEkuaD4KKyNlbmRpZgorCiBuYW1lc3BhY2UgVGVzdFdlYktpdEFQSSB7CiAKIFRFU1QoV2ViS2l0 LCBMaW5rQ29sb3IpCkBAIC01Miw4ICs1NiwxNiBAQCBURVNUKFdlYktpdCwgTGlua0NvbG9yV2l0 aFN5c3RlbUFwcGVhcmFuY2UpCiAKICAgICBbd2ViVmlldyBzeW5jaHJvbm91c2x5TG9hZEhUTUxT dHJpbmc6QCI8YSBocmVmPlRlc3Q8L2E+Il07CiAKLSAgICBOU1N0cmluZyAqbGlua0NvbG9yID0g W3dlYlZpZXcgc3RyaW5nQnlFdmFsdWF0aW5nSmF2YVNjcmlwdDpAImdldENvbXB1dGVkU3R5bGUo ZG9jdW1lbnQubGlua3NbMF0pLmNvbG9yIl07Ci0gICAgRVhQRUNUX1dLX1NUUkVRKCJyZ2IoMCwg MTA0LCAyMTgpIiwgbGlua0NvbG9yKTsKKyAgICBOU0NvbG9yICpsaW5rQ29sb3IgPSBbTlNDb2xv ci5saW5rQ29sb3IgY29sb3JVc2luZ0NvbG9yU3BhY2U6TlNDb2xvclNwYWNlLnNSR0JDb2xvclNw YWNlXTsKKworICAgIENHRmxvYXQgcmVkID0gbGlua0NvbG9yLnJlZENvbXBvbmVudCAqIDI1NTsK KyAgICBDR0Zsb2F0IGdyZWVuID0gbGlua0NvbG9yLmdyZWVuQ29tcG9uZW50ICogMjU1OworICAg IENHRmxvYXQgYmx1ZSA9IGxpbmtDb2xvci5ibHVlQ29tcG9uZW50ICogMjU1OworCisgICAgTlNT dHJpbmcgKmV4cGVjdGVkU3RyaW5nID0gW05TU3RyaW5nIHN0cmluZ1dpdGhGb3JtYXQ6QCJyZ2Io JS4wZiwgJS4wZiwgJS4wZikiLCByZWQsIGdyZWVuLCBibHVlXTsKKworICAgIE5TU3RyaW5nICpj c3NMaW5rQ29sb3IgPSBbd2ViVmlldyBzdHJpbmdCeUV2YWx1YXRpbmdKYXZhU2NyaXB0OkAiZ2V0 Q29tcHV0ZWRTdHlsZShkb2N1bWVudC5saW5rc1swXSkuY29sb3IiXTsKKyAgICBFWFBFQ1RfV0tf U1RSRVEoZXhwZWN0ZWRTdHJpbmcuVVRGOFN0cmluZywgY3NzTGlua0NvbG9yKTsKIH0KICNlbmRp ZgogCg==