187515 2018-07-10 04:04:30 -0700 [GLIB] Add jsc_context_get_global_object() to GLib API 2018-07-11 22:18:01 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED Gtk, InRadar P2 Normal --- 1 cgarcia webkit-unassigned bugs-noreply calvaris ews-watchlist keith_miller mark.lam mcatanzaro msaboff saam webkit-bug-importer oldest_to_newest 1440814 0 cgarcia 2018-07-10 04:04:30 -0700 This isn't exposed because we have convenient methods in JSCContext to get and set properties on the global object. However, getting the global object could be useful in some cases, for example to give it a well known name like 'window' in browsers and GJS. 1440815 1 344687 cgarcia 2018-07-10 04:06:37 -0700 Created attachment 344687 Patch 1440827 2 344687 mcatanzaro 2018-07-10 06:13:30 -0700 Comment on attachment 344687 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=344687&action=review > Source/JavaScriptCore/ChangeLog:10 > + This wasn't exposed because we have convenient methods in JSCContext to get and set properties on the global > + object. However, getting the global object could be useful in some cases, for example to give it a well known > + name like 'window' in browsers and GJS. What specifically are you planning to use it for? Surely it's not required to give it the name "window" in Epiphany? 1441408 3 cgarcia 2018-07-11 22:14:11 -0700 Committed r233759: <https://trac.webkit.org/changeset/233759> 1441410 4 webkit-bug-importer 2018-07-11 22:18:01 -0700 <rdar://problem/42104161> 344687 2018-07-10 04:06:37 -0700 2018-07-10 06:13:30 -0700 Patch jsc-glib-global-object.diff text/plain 7382 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9BUEkvZ2xpYi9KU0NDb250ZXh0LmNw cCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9BUEkvZ2xpYi9KU0NDb250ZXh0LmNwcAppbmRleCA1 N2VhNGYzMjRmZi4uMzJkNjYzMGQ0MDYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9BUEkvZ2xpYi9KU0NDb250ZXh0LmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQVBJ L2dsaWIvSlNDQ29udGV4dC5jcHAKQEAgLTc4NSw2ICs3ODUsMjEgQEAgSlNDVmFsdWUqIGpzY19j b250ZXh0X2V2YWx1YXRlX3dpdGhfc291cmNlX3VyaShKU0NDb250ZXh0KiBjb250ZXh0LCBjb25z dCBjaGFyKgogICAgIHJldHVybiBqc2NDb250ZXh0R2V0T3JDcmVhdGVWYWx1ZShjb250ZXh0LCBy ZXN1bHQpLmxlYWtSZWYoKTsKIH0KIAorLyoqCisgKiBqc2NfY29udGV4dF9nZXRfZ2xvYmFsX29i amVjdDoKKyAqIEBjb250ZXh0OiBhICNKU0NDb250ZXh0CisgKgorICogR2V0IGEgI0pTQ1ZhbHVl IHJlZmVyZW5jaW5nIHRoZSBAY29udGV4dCBnbG9iYWwgb2JqZWN0CisgKgorICogUmV0dXJuczog KHRyYW5zZmVyIGZ1bGwpOiBhICNKU0NWYWx1ZQorICovCitKU0NWYWx1ZSoganNjX2NvbnRleHRf Z2V0X2dsb2JhbF9vYmplY3QoSlNDQ29udGV4dCogY29udGV4dCkKK3sKKyAgICBnX3JldHVybl92 YWxfaWZfZmFpbChKU0NfSVNfQ09OVEVYVChjb250ZXh0KSwgbnVsbHB0cik7CisKKyAgICByZXR1 cm4ganNjQ29udGV4dEdldE9yQ3JlYXRlVmFsdWUoY29udGV4dCwgSlNDb250ZXh0R2V0R2xvYmFs T2JqZWN0KGNvbnRleHQtPnByaXYtPmpzQ29udGV4dC5nZXQoKSkpLmxlYWtSZWYoKTsKK30KKwog LyoqCiAgKiBqc2NfY29udGV4dF9zZXRfdmFsdWU6CiAgKiBAY29udGV4dDogYSAjSlNDQ29udGV4 dApkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL0FQSS9nbGliL0pTQ0NvbnRleHQu aCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9BUEkvZ2xpYi9KU0NDb250ZXh0LmgKaW5kZXggMzMy NmI0ZTMxMTMuLmFmNjZkZDFmMWE4IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv QVBJL2dsaWIvSlNDQ29udGV4dC5oCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9BUEkvZ2xp Yi9KU0NDb250ZXh0LmgKQEAgLTExMyw2ICsxMTMsOSBAQCBqc2NfY29udGV4dF9ldmFsdWF0ZV93 aXRoX3NvdXJjZV91cmkgKEpTQ0NvbnRleHQgICAgICAgICAqY29udGV4dCwKICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgZ3NzaXplICAgICAgICAgICAgICBsZW5ndGgsCiAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGNvbnN0IGNoYXIgICAgICAgICAq dXJpKTsKIAorSlNDX0FQSSBKU0NWYWx1ZSAqCitqc2NfY29udGV4dF9nZXRfZ2xvYmFsX29iamVj dCAgICAgICAgKEpTQ0NvbnRleHQgICAgICAgICAqY29udGV4dCk7CisKIEpTQ19BUEkgdm9pZAog anNjX2NvbnRleHRfc2V0X3ZhbHVlICAgICAgICAgICAgICAgIChKU0NDb250ZXh0ICAgICAgICAg KmNvbnRleHQsCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGNvbnN0IGNo YXIgICAgICAgICAqbmFtZSwKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9BUEkv Z2xpYi9kb2NzL2pzYy1nbGliLTQuMC1zZWN0aW9ucy50eHQgYi9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQVBJL2dsaWIvZG9jcy9qc2MtZ2xpYi00LjAtc2VjdGlvbnMudHh0CmluZGV4IDZkYmRlZGI2 YzYwLi5mMWM0OTIzOTM2NiAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL0FQSS9n bGliL2RvY3MvanNjLWdsaWItNC4wLXNlY3Rpb25zLnR4dAorKysgYi9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQVBJL2dsaWIvZG9jcy9qc2MtZ2xpYi00LjAtc2VjdGlvbnMudHh0CkBAIC0zOCw2ICsz OCw3IEBAIGpzY19jb250ZXh0X3BvcF9leGNlcHRpb25faGFuZGxlcgoganNjX2NvbnRleHRfZ2V0 X2N1cnJlbnQKIGpzY19jb250ZXh0X2V2YWx1YXRlCiBqc2NfY29udGV4dF9ldmFsdWF0ZV93aXRo X3NvdXJjZV91cmkKK2pzY19jb250ZXh0X2dldF9nbG9iYWxfb2JqZWN0CiBqc2NfY29udGV4dF9z ZXRfdmFsdWUKIGpzY19jb250ZXh0X2dldF92YWx1ZQoganNjX2NvbnRleHRfcmVnaXN0ZXJfY2xh c3MKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2Uv SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDZjOWU5Y2RkNWQ5Li40YWM2NTdlNmE1YSAx MDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2Uv SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTgtMDctMTAgIENh cmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgorCisgICAgICAgIFtHTElC XSBBZGQganNjX2NvbnRleHRfZ2V0X2dsb2JhbF9vYmplY3QoKSB0byBHTGliIEFQSQorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg3NTE1CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhpcyB3YXNuJ3QgZXhw b3NlZCBiZWNhdXNlIHdlIGhhdmUgY29udmVuaWVudCBtZXRob2RzIGluIEpTQ0NvbnRleHQgdG8g Z2V0IGFuZCBzZXQgcHJvcGVydGllcyBvbiB0aGUgZ2xvYmFsCisgICAgICAgIG9iamVjdC4gSG93 ZXZlciwgZ2V0dGluZyB0aGUgZ2xvYmFsIG9iamVjdCBjb3VsZCBiZSB1c2VmdWwgaW4gc29tZSBj YXNlcywgZm9yIGV4YW1wbGUgdG8gZ2l2ZSBpdCBhIHdlbGwga25vd24KKyAgICAgICAgbmFtZSBs aWtlICd3aW5kb3cnIGluIGJyb3dzZXJzIGFuZCBHSlMuCisKKyAgICAgICAgKiBBUEkvZ2xpYi9K U0NDb250ZXh0LmNwcDoKKyAgICAgICAgKGpzY19jb250ZXh0X2dldF9nbG9iYWxfb2JqZWN0KToK KyAgICAgICAgKiBBUEkvZ2xpYi9KU0NDb250ZXh0Lmg6CisgICAgICAgICogQVBJL2dsaWIvZG9j cy9qc2MtZ2xpYi00LjAtc2VjdGlvbnMudHh0OgorCiAyMDE4LTA3LTEwICBDYXJsb3MgR2FyY2lh IENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KIAogICAgICAgICBbR0xJQl0gSGFuZGxlIEdf VFlQRV9TVFJWIGluIGdsaWIgQVBJCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cgYi9Ub29s cy9DaGFuZ2VMb2cKaW5kZXggZTEyZDM3ZGM4NDkuLjgxMDdhZDk0YTU5IDEwMDY0NAotLS0gYS9U b29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIw MTgtMDctMTAgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgorCisg ICAgICAgIFtHTElCXSBBZGQganNjX2NvbnRleHRfZ2V0X2dsb2JhbF9vYmplY3QoKSB0byBHTGli IEFQSQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg3 NTE1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRk IHRlc3QgY2FzZXMuCisKKyAgICAgICAgKiBUZXN0V2ViS2l0QVBJL1Rlc3RzL0phdmFTY3JpcHRD b3JlL2dsaWIvVGVzdEpTQy5jcHA6CisgICAgICAgICh0ZXN0SlNDR2xvYmFsT2JqZWN0KToKKyAg ICAgICAgKG1haW4pOgorCiAyMDE4LTA3LTEwICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJj aWFAaWdhbGlhLmNvbT4KIAogICAgICAgICBbR0xJQl0gSGFuZGxlIEdfVFlQRV9TVFJWIGluIGds aWIgQVBJCmRpZmYgLS1naXQgYS9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL0phdmFTY3JpcHRD b3JlL2dsaWIvVGVzdEpTQy5jcHAgYi9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL0phdmFTY3Jp cHRDb3JlL2dsaWIvVGVzdEpTQy5jcHAKaW5kZXggNGI5YjUzYmNiNzMuLjUxYzdiNDliMzg0IDEw MDY0NAotLS0gYS9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL0phdmFTY3JpcHRDb3JlL2dsaWIv VGVzdEpTQy5jcHAKKysrIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9KYXZhU2NyaXB0Q29y ZS9nbGliL1Rlc3RKU0MuY3BwCkBAIC01NDUsNiArNTQ1LDY4IEBAIHN0YXRpYyB2b2lkIHRlc3RK U0NUeXBlcygpCiAgICAgZ19hc3NlcnRfdHJ1ZShyZXN1bHQuZ2V0KCkgPT0gdmFsdWUuZ2V0KCkp OwogfQogCitzdGF0aWMgdm9pZCB0ZXN0SlNDR2xvYmFsT2JqZWN0KCkKK3sKKyAgICBMZWFrQ2hl Y2tlciBjaGVja2VyOworICAgIEdSZWZQdHI8SlNDQ29udGV4dD4gY29udGV4dCA9IGFkb3B0R1Jl Zihqc2NfY29udGV4dF9uZXcoKSk7CisgICAgY2hlY2tlci53YXRjaChjb250ZXh0LmdldCgpKTsK KyAgICBFeGNlcHRpb25IYW5kbGVyIGV4Y2VwdGlvbkhhbmRsZXIoY29udGV4dC5nZXQoKSk7CisK KyAgICBHUmVmUHRyPEpTQ1ZhbHVlPiBnbG9iYWxPYmplY3QgPSBhZG9wdEdSZWYoanNjX2NvbnRl eHRfZ2V0X2dsb2JhbF9vYmplY3QoY29udGV4dC5nZXQoKSkpOworICAgIGNoZWNrZXIud2F0Y2go Z2xvYmFsT2JqZWN0LmdldCgpKTsKKyAgICBnX2Fzc2VydF90cnVlKGpzY192YWx1ZV9pc19vYmpl Y3QoZ2xvYmFsT2JqZWN0LmdldCgpKSk7CisKKyAgICBHUmVmUHRyPEpTQ1ZhbHVlPiBmb28gPSBh ZG9wdEdSZWYoanNjX3ZhbHVlX25ld19udW1iZXIoY29udGV4dC5nZXQoKSwgMjUpKTsKKyAgICBj aGVja2VyLndhdGNoKGZvby5nZXQoKSk7CisgICAganNjX3ZhbHVlX29iamVjdF9zZXRfcHJvcGVy dHkoZ2xvYmFsT2JqZWN0LmdldCgpLCAiZm9vIiwgZm9vLmdldCgpKTsKKworICAgIEdSZWZQdHI8 SlNDVmFsdWU+IGZvbzIgPSBhZG9wdEdSZWYoanNjX2NvbnRleHRfZ2V0X3ZhbHVlKGNvbnRleHQu Z2V0KCksICJmb28iKSk7CisgICAgY2hlY2tlci53YXRjaChmb28yLmdldCgpKTsKKyAgICBnX2Fz c2VydF90cnVlKGZvby5nZXQoKSA9PSBmb28yLmdldCgpKTsKKworICAgIEdSZWZQdHI8SlNDVmFs dWU+IGJhciA9IGFkb3B0R1JlZihqc2NfdmFsdWVfbmV3X251bWJlcihjb250ZXh0LmdldCgpLCA1 MCkpOworICAgIGNoZWNrZXIud2F0Y2goYmFyLmdldCgpKTsKKyAgICBqc2NfY29udGV4dF9zZXRf dmFsdWUoY29udGV4dC5nZXQoKSwgImJhciIsIGJhci5nZXQoKSk7CisKKyAgICBHUmVmUHRyPEpT Q1ZhbHVlPiBiYXIyID0gYWRvcHRHUmVmKGpzY192YWx1ZV9vYmplY3RfZ2V0X3Byb3BlcnR5KGds b2JhbE9iamVjdC5nZXQoKSwgImJhciIpKTsKKyAgICBjaGVja2VyLndhdGNoKGJhcjIuZ2V0KCkp OworICAgIGdfYXNzZXJ0X3RydWUoYmFyLmdldCgpID09IGJhcjIuZ2V0KCkpOworCisgICAgR1Jl ZlB0cjxKU0NWYWx1ZT4gYmF6ID0gYWRvcHRHUmVmKGpzY19jb250ZXh0X2V2YWx1YXRlKGNvbnRl eHQuZ2V0KCksICJiYXogPSA3NSIsIC0xKSk7CisgICAgY2hlY2tlci53YXRjaChiYXouZ2V0KCkp OworCisgICAgR1JlZlB0cjxKU0NWYWx1ZT4gYmF6MiA9IGFkb3B0R1JlZihqc2NfdmFsdWVfb2Jq ZWN0X2dldF9wcm9wZXJ0eShnbG9iYWxPYmplY3QuZ2V0KCksICJiYXoiKSk7CisgICAgY2hlY2tl ci53YXRjaChiYXoyLmdldCgpKTsKKyAgICBnX2Fzc2VydF90cnVlKGJhei5nZXQoKSA9PSBiYXoy LmdldCgpKTsKKworICAgIGpzY19jb250ZXh0X3NldF92YWx1ZShjb250ZXh0LmdldCgpLCAid2lu ZG93IiwgZ2xvYmFsT2JqZWN0LmdldCgpKTsKKyAgICBHUmVmUHRyPEpTQ1ZhbHVlPiB3aW5kb3cg PSBhZG9wdEdSZWYoanNjX2NvbnRleHRfZXZhbHVhdGUoY29udGV4dC5nZXQoKSwgIndpbmRvdyIs IC0xKSk7CisgICAgY2hlY2tlci53YXRjaCh3aW5kb3cuZ2V0KCkpOworICAgIGdfYXNzZXJ0X3Ry dWUod2luZG93LmdldCgpID09IGdsb2JhbE9iamVjdC5nZXQoKSk7CisKKyAgICBmb28yID0gYWRv cHRHUmVmKGpzY19jb250ZXh0X2V2YWx1YXRlKGNvbnRleHQuZ2V0KCksICJ3aW5kb3cuZm9vIiwg LTEpKTsKKyAgICBjaGVja2VyLndhdGNoKGZvbzIuZ2V0KCkpOworICAgIGdfYXNzZXJ0X3RydWUo Zm9vLmdldCgpID09IGZvbzIuZ2V0KCkpOworCisgICAgR1JlZlB0cjxKU0NWYWx1ZT4gZ2xvYmFs ID0gYWRvcHRHUmVmKGpzY19jb250ZXh0X2V2YWx1YXRlKGNvbnRleHQuZ2V0KCksICJ3aW5kb3cu Z2xvYmFsID0gMTAwIiwgLTEpKTsKKyAgICBjaGVja2VyLndhdGNoKGdsb2JhbC5nZXQoKSk7Cisg ICAgZ19hc3NlcnRfdHJ1ZShqc2NfdmFsdWVfaXNfbnVtYmVyKGdsb2JhbC5nZXQoKSkpOworICAg IGdfYXNzZXJ0X2NtcGludChqc2NfdmFsdWVfdG9faW50MzIoZ2xvYmFsLmdldCgpKSwgPT0sIDEw MCk7CisKKyAgICBHUmVmUHRyPEpTQ1ZhbHVlPiBnbG9iYWwyID0gYWRvcHRHUmVmKGpzY19jb250 ZXh0X2dldF92YWx1ZShjb250ZXh0LmdldCgpLCAiZ2xvYmFsIikpOworICAgIGNoZWNrZXIud2F0 Y2goZ2xvYmFsMi5nZXQoKSk7CisgICAgZ19hc3NlcnRfdHJ1ZShnbG9iYWwuZ2V0KCkgPT0gZ2xv YmFsMi5nZXQoKSk7CisKKyAgICBnbG9iYWwyID0gYWRvcHRHUmVmKGpzY192YWx1ZV9vYmplY3Rf Z2V0X3Byb3BlcnR5KGdsb2JhbE9iamVjdC5nZXQoKSwgImdsb2JhbCIpKTsKKyAgICBjaGVja2Vy LndhdGNoKGdsb2JhbDIuZ2V0KCkpOworICAgIGdfYXNzZXJ0X3RydWUoZ2xvYmFsLmdldCgpID09 IGdsb2JhbDIuZ2V0KCkpOworCisgICAganNjX3ZhbHVlX29iamVjdF9kZWZpbmVfcHJvcGVydHlf ZGF0YShnbG9iYWxPYmplY3QuZ2V0KCksICJ3aW5kb3cyIiwgc3RhdGljX2Nhc3Q8SlNDVmFsdWVQ cm9wZXJ0eUZsYWdzPigwKSwgZ2xvYmFsT2JqZWN0LmdldCgpKTsKKyAgICBHUmVmUHRyPEpTQ1Zh bHVlPiB3aW5kb3cyID0gYWRvcHRHUmVmKGpzY19jb250ZXh0X2V2YWx1YXRlKGNvbnRleHQuZ2V0 KCksICJ3aW5kb3cyIiwgLTEpKTsKKyAgICBjaGVja2VyLndhdGNoKHdpbmRvdzIuZ2V0KCkpOwor ICAgIGdfYXNzZXJ0X3RydWUod2luZG93Mi5nZXQoKSA9PSBnbG9iYWxPYmplY3QuZ2V0KCkpOwor fQorCiBzdGF0aWMgaW50IGZvbyhpbnQgbikKIHsKICAgICByZXR1cm4gbiAqIDI7CkBAIC0yNzM4 LDYgKzI4MDAsNyBAQCBpbnQgbWFpbihpbnQgYXJnYywgY2hhcioqIGFyZ3YpCiAKICAgICBnX3Rl c3RfYWRkX2Z1bmMoIi9qc2MvYmFzaWMiLCB0ZXN0SlNDQmFzaWMpOwogICAgIGdfdGVzdF9hZGRf ZnVuYygiL2pzYy90eXBlcyIsIHRlc3RKU0NUeXBlcyk7CisgICAgZ190ZXN0X2FkZF9mdW5jKCIv anNjL2dsb2JhbC1vYmplY3QiLCB0ZXN0SlNDR2xvYmFsT2JqZWN0KTsKICAgICBnX3Rlc3RfYWRk X2Z1bmMoIi9qc2MvZnVuY3Rpb24iLCB0ZXN0SlNDRnVuY3Rpb24pOwogICAgIGdfdGVzdF9hZGRf ZnVuYygiL2pzYy9vYmplY3QiLCB0ZXN0SlNDT2JqZWN0KTsKICAgICBnX3Rlc3RfYWRkX2Z1bmMo Ii9qc2MvY2xhc3MiLCB0ZXN0SlNDQ2xhc3MpOwo=