187482 2018-07-09 14:12:24 -0700 Web Inspector: REGRESSION (r217505): Debugger content view doesn't update when left sidebar is collapsed 2018-07-10 09:44:53 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P1 Normal --- 1 mattbaker mattbaker bburg commit-queue inspector-bugzilla-changes webkit-bug-importer oldest_to_newest 1440548 0 mattbaker 2018-07-09 14:12:24 -0700 Summary: Debugger content view doesn't update when left sidebar is collapsed. Steps to Reproduce (A): 1. Inspect webkit.org 2. Open Debugger tab 3. Collapse left sidebar 4. Select a new resource using the hierarchical path component in the content view's navigation bar => Selection does not change Steps to Reproduce (B): 1. Inspect webkit.org 2. Open Debugger tab 3. Set a breakpoint in global.js 4. Switch to another resource in the Debugger tab (like wp-embed-min.js) 5. Collapse left sidebar 6. Reload inspected page => Pause in debugger, but the content view doesn't change to show the pause location 1440550 1 webkit-bug-importer 2018-07-09 14:13:30 -0700 <rdar://problem/41989190> 1440632 2 mattbaker 2018-07-09 16:58:20 -0700 This regressed in http://trac.webkit.org/changeset/217505. 1440634 3 mattbaker 2018-07-09 17:02:11 -0700 The regression also broke navigating via the hierarchical path for Storage, Search, and Resources. 1440649 4 mattbaker 2018-07-09 17:23:53 -0700 (In reply to Matt Baker from comment #3) > The regression also broke navigating via the hierarchical path for Storage, > Search, and Resources. Actually, StorageSidebarPanel._treeSelectionDidChange included the visible check prior to http://trac.webkit.org/changeset/217505. 1440753 5 344671 mattbaker 2018-07-09 23:18:14 -0700 Created attachment 344671 Patch 1440861 6 344671 bburg 2018-07-10 09:17:49 -0700 Comment on attachment 344671 Patch r=me 1440884 7 344671 commit-queue 2018-07-10 09:44:52 -0700 Comment on attachment 344671 Patch Clearing flags on attachment: 344671 Committed r233686: <https://trac.webkit.org/changeset/233686> 1440885 8 commit-queue 2018-07-10 09:44:53 -0700 All reviewed patches have been landed. Closing bug. 344671 2018-07-09 23:18:14 -0700 2018-07-10 09:44:52 -0700 Patch bug-187482-20180709231813.patch text/plain 4988 mattbaker U3VidmVyc2lvbiBSZXZpc2lvbjogMjMzNjc0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCAx ODYzNmIzZDNiODgwOGM2YWNmYmIxYzExYjA3ZjY3OGUyNjZjYzk5Li41YjBjYTQ2Nzg4YzRjZThj NGZiMTNlMDM4NjJhNmM1YTI3Y2Q0OGRjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyNyBAQAorMjAxOC0wNy0wOSAgTWF0dCBCYWtlciAgPG1hdHRiYWtlckBhcHBsZS5jb20+ CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogUkVHUkVTU0lPTiAocjIxNzUwNSk6IERlYnVnZ2Vy IGNvbnRlbnQgdmlldyBkb2Vzbid0IHVwZGF0ZSB3aGVuIGxlZnQgc2lkZWJhciBpcyBjb2xsYXBz ZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4NzQ4 MgorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNDE5ODkxOTA+CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgU3ViY2xhc3NlcyBvZiBOYXZpZ2F0aW9uU2lk ZWJhclBhbmVsIG11c3QgcHJvY2VzcyB0cmVlIHNlbGVjdGlvbiBjaGFuZ2VzCisgICAgICAgIGV2 ZW4gd2hlbiBjb2xsYXBzZWQuIFNpZGViYXIgcGFuZWxzIHBlcmZvcm0gY3JpdGljYWwgY29udHJv bGxlciB0YXNrcworICAgICAgICBmb3IgdGhlaXIgdGFicywgc3VjaCBhcyB1cGRhdGluZyB0aGUg dmlldyB3aGVuIHBhdXNpbmcgaW4gdGhlIGRlYnVnZ2VyLAorICAgICAgICBhbmQgd2hlbiB0aGUg aGllcmFyY2hpY2FsIHBhdGggY29tcG9uZW50IHNlbGVjdGlvbiBjaGFuZ2VzLgorCisgICAgICAg ICogVXNlckludGVyZmFjZS9WaWV3cy9EZWJ1Z2dlclNpZGViYXJQYW5lbC5qczoKKyAgICAgICAg KFdJLkRlYnVnZ2VyU2lkZWJhclBhbmVsLnByb3RvdHlwZS5fdHJlZVNlbGVjdGlvbkRpZENoYW5n ZSk6CisgICAgICAgICogVXNlckludGVyZmFjZS9WaWV3cy9SZXNvdXJjZVNpZGViYXJQYW5lbC5q czoKKyAgICAgICAgKFdJLlJlc291cmNlU2lkZWJhclBhbmVsLnByb3RvdHlwZS5fdHJlZVNlbGVj dGlvbkRpZENoYW5nZSk6CisgICAgICAgICogVXNlckludGVyZmFjZS9WaWV3cy9TZWFyY2hTaWRl YmFyUGFuZWwuanM6CisgICAgICAgIChXSS5TZWFyY2hTaWRlYmFyUGFuZWwucHJvdG90eXBlLl90 cmVlU2VsZWN0aW9uRGlkQ2hhbmdlKToKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1ZpZXdzL1Nv dXJjZXNTaWRlYmFyUGFuZWwuanM6CisgICAgICAgIChXSS5Tb3VyY2VzU2lkZWJhclBhbmVsLnBy b3RvdHlwZS5fdHJlZVNlbGVjdGlvbkRpZENoYW5nZSk6CisgICAgICAgICogVXNlckludGVyZmFj ZS9WaWV3cy9TdG9yYWdlU2lkZWJhclBhbmVsLmpzOgorICAgICAgICAoV0kuU3RvcmFnZVNpZGVi YXJQYW5lbC5fdHJlZVNlbGVjdGlvbkRpZENoYW5nZSk6CisKIDIwMTgtMDctMDkgIEJyaWFuIEJ1 cmcgIDxiYnVyZ0BhcHBsZS5jb20+CiAKICAgICAgICAgUkVHUkVTU0lPTjogV2ViIEluc3BlY3Rv ciBubyBsb25nZXIgcGF1c2VzIGluIGludGVybmFsIGluamVjdGVkIHNjcmlwdHMgbGlrZSBXREZp bmROb2Rlcy5qcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZh Y2UvVmlld3MvRGVidWdnZXJTaWRlYmFyUGFuZWwuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkv VXNlckludGVyZmFjZS9WaWV3cy9EZWJ1Z2dlclNpZGViYXJQYW5lbC5qcwppbmRleCA1OTE3YjA1 NjJiZGE5YjM2ZjE1YjkzMTAxMmRkZmQ3NzgyMDY4N2I2Li41YTUzNjI1ODJkMTM3ZmYwNzkwNDc2 M2JiYzUyNGJjZjA0NjAwOWNmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNl ckludGVyZmFjZS9WaWV3cy9EZWJ1Z2dlclNpZGViYXJQYW5lbC5qcworKysgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9EZWJ1Z2dlclNpZGViYXJQYW5lbC5qcwpA QCAtODI4LDcgKzgyOCw3IEBAIFdJLkRlYnVnZ2VyU2lkZWJhclBhbmVsID0gY2xhc3MgRGVidWdn ZXJTaWRlYmFyUGFuZWwgZXh0ZW5kcyBXSS5OYXZpZ2F0aW9uU2lkZWJhCiAKICAgICBfdHJlZVNl bGVjdGlvbkRpZENoYW5nZShldmVudCkKICAgICB7Ci0gICAgICAgIGlmICghdGhpcy52aXNpYmxl KQorICAgICAgICBpZiAoIXRoaXMuc2VsZWN0ZWQpCiAgICAgICAgICAgICByZXR1cm47CiAKICAg ICAgICAgbGV0IHRyZWVFbGVtZW50ID0gZXZlbnQuZGF0YS5zZWxlY3RlZEVsZW1lbnQ7CmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9SZXNvdXJj ZVNpZGViYXJQYW5lbC5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1Zp ZXdzL1Jlc291cmNlU2lkZWJhclBhbmVsLmpzCmluZGV4IDI2YWQ1MDI1M2UwZGZjNTYxM2U5NTNi MGU3ZDYzNjU0MTAwMjkxZDYuLjM0YzI2MDQxMWMzZDM2NDU5N2IwZDFhYmVlNzdjNDc5MDhiZGFi NjMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdz L1Jlc291cmNlU2lkZWJhclBhbmVsLmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2Vy SW50ZXJmYWNlL1ZpZXdzL1Jlc291cmNlU2lkZWJhclBhbmVsLmpzCkBAIC00NTIsNyArNDUyLDcg QEAgV0kuUmVzb3VyY2VTaWRlYmFyUGFuZWwgPSBjbGFzcyBSZXNvdXJjZVNpZGViYXJQYW5lbCBl eHRlbmRzIFdJLk5hdmlnYXRpb25TaWRlYmEKIAogICAgIF90cmVlU2VsZWN0aW9uRGlkQ2hhbmdl KGV2ZW50KQogICAgIHsKLSAgICAgICAgaWYgKCF0aGlzLnZpc2libGUpCisgICAgICAgIGlmICgh dGhpcy5zZWxlY3RlZCkKICAgICAgICAgICAgIHJldHVybjsKIAogICAgICAgICBsZXQgdHJlZUVs ZW1lbnQgPSBldmVudC5kYXRhLnNlbGVjdGVkRWxlbWVudDsKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1NlYXJjaFNpZGViYXJQYW5lbC5qcyBi L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1NlYXJjaFNpZGViYXJQ YW5lbC5qcwppbmRleCA2YmE2NTc0YzNlN2I3MjM5ZDRjNTEzODYzNTQ0ODQ4YjViNmMxM2JmLi4x MzBjMTQ3ZjZlMGUxM2JmNTc4OTJiZTU0MGMxNGIzYzE0OWM3YzM3IDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9TZWFyY2hTaWRlYmFyUGFuZWwu anMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvU2VhcmNo U2lkZWJhclBhbmVsLmpzCkBAIC0zNjMsNyArMzYzLDcgQEAgV0kuU2VhcmNoU2lkZWJhclBhbmVs ID0gY2xhc3MgU2VhcmNoU2lkZWJhclBhbmVsIGV4dGVuZHMgV0kuTmF2aWdhdGlvblNpZGViYXJQ YW4KIAogICAgIF90cmVlU2VsZWN0aW9uRGlkQ2hhbmdlKGV2ZW50KQogICAgIHsKLSAgICAgICAg aWYgKCF0aGlzLnZpc2libGUpCisgICAgICAgIGlmICghdGhpcy5zZWxlY3RlZCkKICAgICAgICAg ICAgIHJldHVybjsKIAogICAgICAgICBsZXQgdHJlZUVsZW1lbnQgPSBldmVudC5kYXRhLnNlbGVj dGVkRWxlbWVudDsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJm YWNlL1ZpZXdzL1NvdXJjZXNTaWRlYmFyUGFuZWwuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkv VXNlckludGVyZmFjZS9WaWV3cy9Tb3VyY2VzU2lkZWJhclBhbmVsLmpzCmluZGV4IDBiN2Y2MmQ0 YWM0NmYxYWYwMjAwYmE3Y2EyNmM3MDQ3YTk5OTgzYWEuLmRiYjBmMDM0ZWI0M2E4NmJjZWQzMjU4 MmM0YWJkZGNkNzM4OTM3YmIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2Vy SW50ZXJmYWNlL1ZpZXdzL1NvdXJjZXNTaWRlYmFyUGFuZWwuanMKKysrIGIvU291cmNlL1dlYklu c3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvU291cmNlc1NpZGViYXJQYW5lbC5qcwpAQCAt NDUyLDcgKzQ1Miw3IEBAIFdJLlNvdXJjZXNTaWRlYmFyUGFuZWwgPSBjbGFzcyBTb3VyY2VzU2lk ZWJhclBhbmVsIGV4dGVuZHMgV0kuTmF2aWdhdGlvblNpZGViYXJQCiAKICAgICBfdHJlZVNlbGVj dGlvbkRpZENoYW5nZShldmVudCkKICAgICB7Ci0gICAgICAgIGlmICghdGhpcy52aXNpYmxlKQor ICAgICAgICBpZiAoIXRoaXMuc2VsZWN0ZWQpCiAgICAgICAgICAgICByZXR1cm47CiAKICAgICAg ICAgbGV0IHRyZWVFbGVtZW50ID0gZXZlbnQuZGF0YS5zZWxlY3RlZEVsZW1lbnQ7CmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9TdG9yYWdlU2lk ZWJhclBhbmVsLmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3Mv U3RvcmFnZVNpZGViYXJQYW5lbC5qcwppbmRleCBmOTNkYzNlNzhiYzBhNmI5OWQ0MzQ4MzA3YWIw ZTQ3NzgyMGJjMjc0Li5lYjNjNTA4NzI1NmYzYjk5MDlhZjU5MTQwNGZjNGY1NDgyMjEwNTVjIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9TdG9y YWdlU2lkZWJhclBhbmVsLmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJm YWNlL1ZpZXdzL1N0b3JhZ2VTaWRlYmFyUGFuZWwuanMKQEAgLTE2Niw3ICsxNjYsNyBAQCBXSS5T dG9yYWdlU2lkZWJhclBhbmVsID0gY2xhc3MgU3RvcmFnZVNpZGViYXJQYW5lbCBleHRlbmRzIFdJ Lk5hdmlnYXRpb25TaWRlYmFyUAogCiAgICAgX3RyZWVTZWxlY3Rpb25EaWRDaGFuZ2UoZXZlbnQp CiAgICAgewotICAgICAgICBpZiAoIXRoaXMudmlzaWJsZSkKKyAgICAgICAgaWYgKCF0aGlzLnNl bGVjdGVkKQogICAgICAgICAgICAgcmV0dXJuOwogCiAgICAgICAgIGxldCB0cmVlRWxlbWVudCA9 IGV2ZW50LmRhdGEuc2VsZWN0ZWRFbGVtZW50Owo=