187470 2018-07-09 08:37:51 -0700 [Flatpak] Feature options to build-webkit and --makeargs are not passed inside the sandbox 2018-07-10 03:16:24 -0700 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 aperez tsaunier aperez commit-queue lforschler pnormand tsaunier webkit-bug-importer oldest_to_newest 1440388 0 aperez 2018-07-09 08:37:51 -0700 Certain options which are valid for “build-webkit” are never passed down to the instance that runs inside the Flatpak sandbox. For example, happens with “--cmakeargs=...” (output reformatted, to ease reading): % build-webkit --gtk --release --makeargs='-j32' Building flatpak based environment Building webkit Running in sandbox: "flatpak" "build" "--die-with-parent" "--bind-mount=/run/shm=/dev/shm" "--bind-mount=/etc/perl=/home/aperez/WebKit/WebKitBuild/GTK/FlatpakTreeRelease/files/lib/perl" "--bind-mount=/run/host//tmp=/tmp" "--bind-mount=/app/webkit=/home/aperez/WebKit" "--bind-mount=/app/webkit/WebKitBuild/Release=/home/aperez/WebKit/WebKitBuild/GTK/Release" "--env=LANG=en_US.utf8" "--env=WEBKIT_TOP_LEVEL=/app/" "--env=TEST_RUNNER_INJECTED_BUNDLE_FILENAME=/app/webkit/lib/libTestRunnerInjectedBundle.so" "--share=ipc" "--socket=x11" "--socket=wayland" "--device=all" "--share=network" "--socket=pulseaudio" "--system-talk-name=org.freedesktop.GeoClue2" "--filesystem=host" "--socket=system-bus" "--talk-name=org.freedesktop.Flatpak" "--env=GST_PRESET_PATH=/app/share/gstreamer-1.0/presets/" "/home/aperez/WebKit/WebKitBuild/GTK/FlatpakTreeRelease" "/app/webkit/Tools/Scripts/build-webkit" "--release" "--gtk" "--prefix=/app" + cmake --build /app/webkit/WebKitBuild/Release --config Release -- ... As per Thibault's suggestion, I tried “webkit-flatpak” insted, to no avail: % webkit-flatpak --release --gtk --command build-webkit --gtk --release --makeargs='-j32' Building webkit Running in sandbox: "flatpak" "build" "--die-with-parent" "--bind-mount=/run/shm=/dev/shm" "--bind-mount=/etc/perl=/home/aperez/WebKit/WebKitBuild/GTK/FlatpakTreeRelease/files/lib/perl" "--bind-mount=/run/host//tmp=/tmp" "--bind-mount=/app/webkit=/home/aperez/WebKit" "--bind-mount=/app/webkit/WebKitBuild/Release=/home/aperez/WebKit/WebKitBuild/GTK/Release" "--env=LANG=en_US.utf8" "--env=WEBKIT_TOP_LEVEL=/app/" "--env=TEST_RUNNER_INJECTED_BUNDLE_FILENAME=/app/webkit/lib/libTestRunnerInjectedBundle.so" "--share=ipc" "--socket=x11" "--socket=wayland" "--device=all" "--share=network" "--socket=pulseaudio" "--system-talk-name=org.freedesktop.GeoClue2" "--filesystem=host" "--socket=system-bus" "--talk-name=org.freedesktop.Flatpak" "--env=GST_PRESET_PATH=/app/share/gstreamer-1.0/presets/" "/home/aperez/WebKit/WebKitBuild/GTK/FlatpakTreeRelease" "/app/webkit/Tools/Scripts/build-webkit" "--release" "--gtk" "--prefix=/app" + cmake --build /app/webkit/WebKitBuild/Release --config Release -- ... The same happens with “--help” (so it's impossible to read the output from “build-webkit --help” when Flatpak is in use), and feature flag options like “--web-rtc” (nor the counterparts like “--no-web-rtc”), which are never passed down to the instance that runs inside the sandbox. 1440400 1 344590 tsaunier 2018-07-09 09:01:26 -0700 Created attachment 344590 Patch 1440797 2 344590 commit-queue 2018-07-10 03:15:07 -0700 Comment on attachment 344590 Patch Clearing flags on attachment: 344590 Committed r233681: <https://trac.webkit.org/changeset/233681> 1440798 3 commit-queue 2018-07-10 03:15:08 -0700 All reviewed patches have been landed. Closing bug. 1440799 4 webkit-bug-importer 2018-07-10 03:16:24 -0700 <rdar://problem/42016754> 344590 2018-07-09 09:01:26 -0700 2018-07-10 03:15:07 -0700 Patch bug-187470-20180709120125.patch text/plain 1696 tsaunier U3VidmVyc2lvbiBSZXZpc2lvbjogMjMzNjM5CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYmQ5YzMwNGFhYjMyMTQ0YTQ2ZTI4MDI2YmE0MmMwNDky ZTk5YmNhMi4uMGUyYmJkN2NiYjYwZWJiNTcyNmU0YTk5ODI0N2VkZWMzNWQ1ZDI5OCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3 IEBACisyMDE4LTA3LTA5ICBUaGliYXVsdCBTYXVuaWVyICA8dHNhdW5pZXJAaWdhbGlhLmNvbT4K KworICAgICAgICBbRmxhdHBha10gRmVhdHVyZSBvcHRpb25zIHRvIGJ1aWxkLXdlYmtpdCBhbmQg LS1tYWtlYXJncyBhcmUgbm90IHBhc3NlZCBpbnNpZGUgdGhlIHNhbmRib3gKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4NzQ3MAorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5ldmVyIGZvcmNlIGJ1aWxkaW5n LCB0aGUgdXNlciBpcyByZXNwb25zaWJsZSB0byBtYWtlIHRoYXQgZGVjaXNpb24gYW5kIHRoZSB3 b3JrZmxvdyBpcworICAgICAgICBub3cgYmFzZWQgb24gZXh0ZXJuYWwgc2NyaXB0cyBzbyBpdCBk b2Vzbid0IG1ha2Ugc2Vuc2UgYW55bW9yZS4gRG9pbmcgdGhhdCBsZWFkcworICAgICAgICB0byBp Z25vcmluZyB0aGUgb3B0aW9ucyB0aGUgdXNlciBwYXNzZWQgaW4uCisKKyAgICAgICAgKiBmbGF0 cGFrL2ZsYXRwYWt1dGlscy5weToKKyAgICAgICAgKFdlYmtpdEZsYXRwYWsuc2V0dXBfZGV2X2Vu dik6CisKIDIwMTgtMDctMDkgIFRoaWJhdWx0IFNhdW5pZXIgIDx0c2F1bmllckBpZ2FsaWEuY29t PgogCiAgICAgICAgIFtGbGF0cGFrXSBIVFRQIGxheW91dCB0ZXN0cyBicm9rZW4gZHVlIHRvIG1p c3NpbmcgQ0dJLnBtIGluIHRoZSBzYW5kYm94CmRpZmYgLS1naXQgYS9Ub29scy9mbGF0cGFrL2Zs YXRwYWt1dGlscy5weSBiL1Rvb2xzL2ZsYXRwYWsvZmxhdHBha3V0aWxzLnB5CmluZGV4IDEyMDA2 YWU4YzhjNzQ1NGUzMTg5MDg2Y2Q3ODAwNDQ4ZDZhZmM0ZTAuLjk0NWQzYjIzNDRmYzcyMmY4NGJm YjdmY2U1OTNiOTIxZjkwNzcxMDQgMTAwNjQ0Ci0tLSBhL1Rvb2xzL2ZsYXRwYWsvZmxhdHBha3V0 aWxzLnB5CisrKyBiL1Rvb2xzL2ZsYXRwYWsvZmxhdHBha3V0aWxzLnB5CkBAIC03NTIsOSArNzUy LDYgQEAgY2xhc3MgV2Via2l0RmxhdHBhazoKICAgICAgICAgICAgIGJ1aWxkZXJfYXJncy5hcHBl bmQoIi0tc3RvcC1hdD0lcyIgJSBzZWxmLm5hbWUpCiAgICAgICAgICAgICBzdWJwcm9jZXNzLmNo ZWNrX2NhbGwoYnVpbGRlcl9hcmdzKQogCi0gICAgICAgIGlmIG5vdCBzZWxmLnVwZGF0ZSBhbmQg bm90IG9zLnBhdGguZXhpc3RzKG9zLnBhdGguam9pbihzZWxmLmJ1aWxkX3BhdGgsICJiaW4iLCAi TWluaUJyb3dzZXIiKSk6Ci0gICAgICAgICAgICBzZWxmLmJ1aWxkX3dlYmtpdCA9IFRydWUKLQog ICAgICAgICBpZiBzZWxmLmJ1aWxkX3dlYmtpdDoKICAgICAgICAgICAgIGJ1aWxkZXIgPSBbb3Mu cGF0aC5qb2luKHNlbGYuc2FuZGJveF9zb3VyY2Vfcm9vdCwgJ1Rvb2xzL1NjcmlwdHMvYnVpbGQt d2Via2l0JyksCiAgICAgICAgICAgICAgICAgIi0tZGVidWciIGlmIHNlbGYuZGVidWcgIGVsc2Ug Ii0tcmVsZWFzZSIsICctLScgKyBzZWxmLnBsYXRmb3JtLmxvd2VyKCldCg==