187467 2018-07-09 06:33:02 -0700 [JSC] Make some data members of UnlinkedCodeBlock private 2018-07-09 10:10:30 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ysuzuki ysuzuki ews-watchlist keith_miller mark.lam msaboff saam webkit-bug-importer oldest_to_newest 1440365 0 ysuzuki 2018-07-09 06:33:02 -0700 [JSC] Make some data members of UnlinkedCodeBlock private 1440366 1 344579 ysuzuki 2018-07-09 06:34:05 -0700 Created attachment 344579 Patch 1440367 2 ews-watchlist 2018-07-09 06:36:16 -0700 Attachment 344579 did not pass style-queue: ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:374: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:375: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] Total errors found: 2 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 1440426 3 344579 mark.lam 2018-07-09 09:59:11 -0700 Comment on attachment 344579 Patch r=me 1440434 4 ysuzuki 2018-07-09 10:09:48 -0700 Committed r233645: <https://trac.webkit.org/changeset/233645> 1440435 5 webkit-bug-importer 2018-07-09 10:10:30 -0700 <rdar://problem/41977825> 344579 2018-07-09 06:34:05 -0700 2018-07-09 09:59:11 -0700 Patch bug-187467-20180709223404.patch text/plain 6946 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMjMzNjM5CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA4 MzUzODJhMTcxYWMzYjE0ZmVhOTBlZDZmZTRlYjM2ODhkYTgxYmFmLi5hMDA5ZTlmNmQxMjNhOTE0 Y2UyYWQwYmJlZjVkZjczYTRhOTE2NGQ1IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMCBAQAorMjAxOC0wNy0wOSAgWXVzdWtlIFN1enVraSAgPHV0YXRhbmUudGVhQGdtYWls LmNvbT4KKworICAgICAgICBbSlNDXSBNYWtlIHNvbWUgZGF0YSBtZW1iZXJzIG9mIFVubGlua2Vk Q29kZUJsb2NrIHByaXZhdGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTE4NzQ2NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIFRoaXMgcGF0Y2ggbWFrZXMgbV9udW1WYXJzLCBtX251bUNhbGxlZUxvY2Fscywg YW5kIG1fbnVtUGFyYW1ldGVycyBvZiBVbmxpbmtlZENvZGVCbG9jayBwcml2YXRlLgorICAgICAg ICBXZSBhbHNvIHJlbW92ZSBtX251bUNhcHR1cmVkVmFycyBzaW5jZSBpdCBpcyBubyBsb25nZXIg dXNlZC4KKworICAgICAgICAqIGJ5dGVjb2RlL0NvZGVCbG9jay5jcHA6CisgICAgICAgIChKU0M6 OkNvZGVCbG9jazo6Q29kZUJsb2NrKToKKyAgICAgICAgKiBieXRlY29kZS9Db2RlQmxvY2suaDoK KyAgICAgICAgKiBieXRlY29kZS9VbmxpbmtlZENvZGVCbG9jay5jcHA6CisgICAgICAgIChKU0M6 OlVubGlua2VkQ29kZUJsb2NrOjpVbmxpbmtlZENvZGVCbG9jayk6CisgICAgICAgICogYnl0ZWNv ZGUvVW5saW5rZWRDb2RlQmxvY2suaDoKKwogMjAxOC0wNy0wOCAgWXVzdWtlIFN1enVraSAgPHV0 YXRhbmUudGVhQGdtYWlsLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLCBidWlsZCBmaXggZm9y IGRlYnVnIGJ1aWxkcyBhZnRlciByMjMzNjMwCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvYnl0ZWNvZGUvQ29kZUJsb2NrLmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRl Y29kZS9Db2RlQmxvY2suY3BwCmluZGV4IGIyMjc4Y2U5ZTYxMDRhYTIxMzJlMzk0NDI2YjI4MWE0 OTkwMDIwNzIuLmI4YjNkZTM0ODk4Yjk2NzM2ZGM3YzU5YzA5ZTQyNjZiMDkwOTMwYWEgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29kZS9Db2RlQmxvY2suY3BwCisrKyBi L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29kZS9Db2RlQmxvY2suY3BwCkBAIC0zNzEsOCAr MzcxLDggQEAgQ29kZUJsb2NrOjpDb2RlQmxvY2soVk0qIHZtLCBTdHJ1Y3R1cmUqIHN0cnVjdHVy ZSwgU2NyaXB0RXhlY3V0YWJsZSogb3duZXJFeGVjdXQKICAgICAsIG1faXNDb25zdHJ1Y3Rvcih1 bmxpbmtlZENvZGVCbG9jay0+aXNDb25zdHJ1Y3RvcigpKQogICAgICwgbV9pc1N0cmljdE1vZGUo dW5saW5rZWRDb2RlQmxvY2stPmlzU3RyaWN0TW9kZSgpKQogICAgICwgbV9jb2RlVHlwZSh1bmxp bmtlZENvZGVCbG9jay0+Y29kZVR5cGUoKSkKLSAgICAsIG1fbnVtQ2FsbGVlTG9jYWxzKHVubGlu a2VkQ29kZUJsb2NrLT5tX251bUNhbGxlZUxvY2FscykKLSAgICAsIG1fbnVtVmFycyh1bmxpbmtl ZENvZGVCbG9jay0+bV9udW1WYXJzKQorICAgICwgbV9udW1DYWxsZWVMb2NhbHModW5saW5rZWRD b2RlQmxvY2stPm51bUNhbGxlZUxvY2FscygpKQorICAgICwgbV9udW1WYXJzKHVubGlua2VkQ29k ZUJsb2NrLT5udW1WYXJzKCkpCiAgICAgLCBtX2hhc0RlYnVnZ2VyU3RhdGVtZW50KGZhbHNlKQog ICAgICwgbV9zdGVwcGluZ01vZGUoU3RlcHBpbmdNb2RlRGlzYWJsZWQpCiAgICAgLCBtX251bUJy ZWFrcG9pbnRzKDApCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvZGUv Q29kZUJsb2NrLmggYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvZGUvQ29kZUJsb2NrLmgK aW5kZXggMGRmMWVkM2UyZTEzNjdjZmQwZjY5ODA3ZGQwOTA3YWQzN2M1M2Q2OC4uNTUzYjNiYmIw ZWM1YmYzNjI1YmE1YmE4MWMwNjRkNGNiZmRlZDcwOCAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFT Y3JpcHRDb3JlL2J5dGVjb2RlL0NvZGVCbG9jay5oCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9ieXRlY29kZS9Db2RlQmxvY2suaApAQCAtODIsNyArODIsNiBAQCBzdHJ1Y3QgT1NSRXhpdFN0 YXRlOwogfSAvLyBuYW1lc3BhY2UgREZHCiAjZW5kaWYKIAotY2xhc3MgQnl0ZWNvZGVHZW5lcmF0 b3I7CiBjbGFzcyBCeXRlY29kZUxpdmVuZXNzQW5hbHlzaXM7CiBjbGFzcyBDb2RlQmxvY2tTZXQ7 CiBjbGFzcyBFeGVjU3RhdGU7CkBAIC0xMDMsNyArMTAyLDYgQEAgZW51bSBSZW9wdGltaXphdGlv bk1vZGUgeyBEb250Q291bnRSZW9wdGltaXphdGlvbiwgQ291bnRSZW9wdGltaXphdGlvbiB9Owog CiBjbGFzcyBDb2RlQmxvY2sgOiBwdWJsaWMgSlNDZWxsIHsKICAgICB0eXBlZGVmIEpTQ2VsbCBC YXNlOwotICAgIGZyaWVuZCBjbGFzcyBCeXRlY29kZUdlbmVyYXRvcjsKICAgICBmcmllbmQgY2xh c3MgQnl0ZWNvZGVMaXZlbmVzc0FuYWx5c2lzOwogICAgIGZyaWVuZCBjbGFzcyBKSVQ7CiAgICAg ZnJpZW5kIGNsYXNzIExMSW50T2Zmc2V0c0V4dHJhY3RvcjsKZGlmZiAtLWdpdCBhL1NvdXJjZS9K YXZhU2NyaXB0Q29yZS9ieXRlY29kZS9VbmxpbmtlZENvZGVCbG9jay5jcHAgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvYnl0ZWNvZGUvVW5saW5rZWRDb2RlQmxvY2suY3BwCmluZGV4IDFhMGJiNDRj ZjdhYzQ5YWI0MjA4OGFlZWM4ODcwMTdmOTU1ZGMwNDUuLmI3MzVhZTlmN2RjMGNhMDYxYWM5MGQ2 Yzc5YmY0OTJhYjk3MWMxYTAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRl Y29kZS9VbmxpbmtlZENvZGVCbG9jay5jcHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2J5 dGVjb2RlL1VubGlua2VkQ29kZUJsb2NrLmNwcApAQCAtNTQsOSArNTQsNiBAQCBjb25zdCBDbGFz c0luZm8gVW5saW5rZWRDb2RlQmxvY2s6OnNfaW5mbyA9IHsgIlVubGlua2VkQ29kZUJsb2NrIiwg bnVsbHB0ciwgbnVsbAogCiBVbmxpbmtlZENvZGVCbG9jazo6VW5saW5rZWRDb2RlQmxvY2soVk0q IHZtLCBTdHJ1Y3R1cmUqIHN0cnVjdHVyZSwgQ29kZVR5cGUgY29kZVR5cGUsIGNvbnN0IEV4ZWN1 dGFibGVJbmZvJiBpbmZvLCBEZWJ1Z2dlck1vZGUgZGVidWdnZXJNb2RlKQogICAgIDogQmFzZSgq dm0sIHN0cnVjdHVyZSkKLSAgICAsIG1fbnVtVmFycygwKQotICAgICwgbV9udW1DYWxsZWVMb2Nh bHMoMCkKLSAgICAsIG1fbnVtUGFyYW1ldGVycygwKQogICAgICwgbV91c2VzRXZhbChpbmZvLnVz ZXNFdmFsKCkpCiAgICAgLCBtX2lzU3RyaWN0TW9kZShpbmZvLmlzU3RyaWN0TW9kZSgpKQogICAg ICwgbV9pc0NvbnN0cnVjdG9yKGluZm8uaXNDb25zdHJ1Y3RvcigpKQpAQCAtNzMsMTUgKzcwLDcg QEAgVW5saW5rZWRDb2RlQmxvY2s6OlVubGlua2VkQ29kZUJsb2NrKFZNKiB2bSwgU3RydWN0dXJl KiBzdHJ1Y3R1cmUsIENvZGVUeXBlIGNvZGUKICAgICAsIG1faGFzVGFpbENhbGxzKGZhbHNlKQog ICAgICwgbV9jb2RlVHlwZShjb2RlVHlwZSkKICAgICAsIG1fZGlkT3B0aW1pemUoTWl4ZWRUcmlT dGF0ZSkKLSAgICAsIG1fbGluZUNvdW50KDApCi0gICAgLCBtX2VuZENvbHVtbihVSU5UX01BWCkK ICAgICAsIG1fcGFyc2VNb2RlKGluZm8ucGFyc2VNb2RlKCkpCi0gICAgLCBtX2ZlYXR1cmVzKDAp Ci0gICAgLCBtX2FycmF5UHJvZmlsZUNvdW50KDApCi0gICAgLCBtX2FycmF5QWxsb2NhdGlvblBy b2ZpbGVDb3VudCgwKQotICAgICwgbV9vYmplY3RBbGxvY2F0aW9uUHJvZmlsZUNvdW50KDApCi0g ICAgLCBtX3ZhbHVlUHJvZmlsZUNvdW50KDApCi0gICAgLCBtX2xsaW50Q2FsbExpbmtJbmZvQ291 bnQoMCkKIHsKICAgICBmb3IgKGF1dG8mIGNvbnN0YW50UmVnaXN0ZXJJbmRleCA6IG1fbGlua1Rp bWVDb25zdGFudHMpCiAgICAgICAgIGNvbnN0YW50UmVnaXN0ZXJJbmRleCA9IDA7CmRpZmYgLS1n aXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvZGUvVW5saW5rZWRDb2RlQmxvY2suaCBi L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29kZS9VbmxpbmtlZENvZGVCbG9jay5oCmluZGV4 IGJjZTJiOThmNmI4MjVkYTkzNzM3MGY5N2NlMGM5MzVjMTVkMTUxZDMuLmNlYjQ2NzNmZTk2ODdl ZWI2ZjBiZTc5Y2Y0ZGJhMDc5NjZiZjRlNDYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9ieXRlY29kZS9VbmxpbmtlZENvZGVCbG9jay5oCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9ieXRlY29kZS9VbmxpbmtlZENvZGVCbG9jay5oCkBAIC00Nyw2ICs0Nyw3IEBACiAKIG5h bWVzcGFjZSBKU0MgewogCitjbGFzcyBCeXRlY29kZUdlbmVyYXRvcjsKIGNsYXNzIEJ5dGVjb2Rl TGl2ZW5lc3NBbmFseXNpczsKIGNsYXNzIEJ5dGVjb2RlUmV3cml0ZXI7CiBjbGFzcyBDb2RlQmxv Y2s7CkBAIC0yNTksMTAgKzI2MCw2IEBAIGNsYXNzIFVubGlua2VkQ29kZUJsb2NrIDogcHVibGlj IEpTQ2VsbCB7CiAgICAgaW50IG51bUNhbGxlZUxvY2FscygpIGNvbnN0IHsgcmV0dXJuIG1fbnVt Q2FsbGVlTG9jYWxzOyB9CiAgICAgaW50IG51bVZhcnMoKSBjb25zdCB7IHJldHVybiBtX251bVZh cnM7IH0KIAotICAgIGludCBtX251bVZhcnM7Ci0gICAgaW50IG1fbnVtQ2FwdHVyZWRWYXJzOwot ICAgIGludCBtX251bUNhbGxlZUxvY2FsczsKLQogICAgIC8vIEp1bXAgVGFibGVzCiAKICAgICBz aXplX3QgbnVtYmVyT2ZTd2l0Y2hKdW1wVGFibGVzKCkgY29uc3QgeyByZXR1cm4gbV9yYXJlRGF0 YSA/IG1fcmFyZURhdGEtPm1fc3dpdGNoSnVtcFRhYmxlcy5zaXplKCkgOiAwOyB9CkBAIC00MjMs NiArNDIwLDggQEAgY2xhc3MgVW5saW5rZWRDb2RlQmxvY2sgOiBwdWJsaWMgSlNDZWxsIHsKIAog cHJpdmF0ZToKICAgICBmcmllbmQgY2xhc3MgQnl0ZWNvZGVSZXdyaXRlcjsKKyAgICBmcmllbmQg Y2xhc3MgQnl0ZWNvZGVHZW5lcmF0b3I7CisKICAgICB2b2lkIGFwcGx5TW9kaWZpY2F0aW9uKEJ5 dGVjb2RlUmV3cml0ZXImLCBVbnBhY2tlZEluc3RydWN0aW9ucyYpOwogCiAgICAgdm9pZCBjcmVh dGVSYXJlRGF0YUlmTmVjZXNzYXJ5KCkKQEAgLTQzNiw4ICs0MzUsNiBAQCBjbGFzcyBVbmxpbmtl ZENvZGVCbG9jayA6IHB1YmxpYyBKU0NlbGwgewogICAgIHZvaWQgZ2V0TGluZUFuZENvbHVtbihj b25zdCBFeHByZXNzaW9uUmFuZ2VJbmZvJiwgdW5zaWduZWQmIGxpbmUsIHVuc2lnbmVkJiBjb2x1 bW4pIGNvbnN0OwogICAgIEJ5dGVjb2RlTGl2ZW5lc3NBbmFseXNpcyYgbGl2ZW5lc3NBbmFseXNp c1Nsb3coQ29kZUJsb2NrKik7CiAKLSAgICBpbnQgbV9udW1QYXJhbWV0ZXJzOwotCiAgICAgc3Rk Ojp1bmlxdWVfcHRyPFVubGlua2VkSW5zdHJ1Y3Rpb25TdHJlYW0+IG1fdW5saW5rZWRJbnN0cnVj dGlvbnM7CiAgICAgc3RkOjp1bmlxdWVfcHRyPEJ5dGVjb2RlTGl2ZW5lc3NBbmFseXNpcz4gbV9s aXZlbmVzczsKIApAQCAtNDY0LDggKzQ2MSwxMiBAQCBjbGFzcyBVbmxpbmtlZENvZGVCbG9jayA6 IHB1YmxpYyBKU0NlbGwgewogICAgIHVuc2lnbmVkIG1faGFzVGFpbENhbGxzIDogMTsKICAgICB1 bnNpZ25lZCBtX2NvZGVUeXBlIDogMjsgLy8gQ29kZVR5cGUKICAgICB1bnNpZ25lZCBtX2RpZE9w dGltaXplIDogMjsgLy8gVHJpU3RhdGUKLSAgICB1bnNpZ25lZCBtX2xpbmVDb3VudDsKLSAgICB1 bnNpZ25lZCBtX2VuZENvbHVtbjsKKyAgICB1bnNpZ25lZCBtX2xpbmVDb3VudCB7IDAgfTsKKyAg ICB1bnNpZ25lZCBtX2VuZENvbHVtbiB7IFVJTlRfTUFYIH07CisKKyAgICBpbnQgbV9udW1WYXJz IHsgMCB9OworICAgIGludCBtX251bUNhbGxlZUxvY2FscyB7IDAgfTsKKyAgICBpbnQgbV9udW1Q YXJhbWV0ZXJzIHsgMCB9OwogCiAgICAgVmlydHVhbFJlZ2lzdGVyIG1fdGhpc1JlZ2lzdGVyOwog ICAgIFZpcnR1YWxSZWdpc3RlciBtX3Njb3BlUmVnaXN0ZXI7CkBAIC00NzYsNyArNDc3LDcgQEAg Y2xhc3MgVW5saW5rZWRDb2RlQmxvY2sgOiBwdWJsaWMgSlNDZWxsIHsKIHB1YmxpYzoKICAgICBD b25jdXJyZW50SlNMb2NrIG1fbG9jazsKIHByaXZhdGU6Ci0gICAgQ29kZUZlYXR1cmVzIG1fZmVh dHVyZXM7CisgICAgQ29kZUZlYXR1cmVzIG1fZmVhdHVyZXMgeyAwIH07CiAKICAgICBWZWN0b3I8 dW5zaWduZWQ+IG1fanVtcFRhcmdldHM7CiAKQEAgLTQ5MywxMSArNDk0LDExIEBAIGNsYXNzIFVu bGlua2VkQ29kZUJsb2NrIDogcHVibGljIEpTQ2VsbCB7CiAgICAgRnVuY3Rpb25FeHByZXNzaW9u VmVjdG9yIG1fZnVuY3Rpb25FeHByczsKICAgICBzdGQ6OmFycmF5PHVuc2lnbmVkLCBMaW5rVGlt ZUNvbnN0YW50Q291bnQ+IG1fbGlua1RpbWVDb25zdGFudHM7CiAKLSAgICB1bnNpZ25lZCBtX2Fy cmF5UHJvZmlsZUNvdW50OwotICAgIHVuc2lnbmVkIG1fYXJyYXlBbGxvY2F0aW9uUHJvZmlsZUNv dW50OwotICAgIHVuc2lnbmVkIG1fb2JqZWN0QWxsb2NhdGlvblByb2ZpbGVDb3VudDsKLSAgICB1 bnNpZ25lZCBtX3ZhbHVlUHJvZmlsZUNvdW50OwotICAgIHVuc2lnbmVkIG1fbGxpbnRDYWxsTGlu a0luZm9Db3VudDsKKyAgICB1bnNpZ25lZCBtX2FycmF5UHJvZmlsZUNvdW50IHsgMCB9OworICAg IHVuc2lnbmVkIG1fYXJyYXlBbGxvY2F0aW9uUHJvZmlsZUNvdW50IHsgMCB9OworICAgIHVuc2ln bmVkIG1fb2JqZWN0QWxsb2NhdGlvblByb2ZpbGVDb3VudCB7IDAgfTsKKyAgICB1bnNpZ25lZCBt X3ZhbHVlUHJvZmlsZUNvdW50IHsgMCB9OworICAgIHVuc2lnbmVkIG1fbGxpbnRDYWxsTGlua0lu Zm9Db3VudCB7IDAgfTsKIAogcHVibGljOgogICAgIHN0cnVjdCBSYXJlRGF0YSB7Cg==