187418 2018-07-06 15:26:05 -0700 WebDriver: hang in Selenium test alerts_tests.py::testShouldHandleAlertOnPageBeforeUnload 2018-07-09 09:30:42 -0700 1 1 1 Unclassified WebKit WebDriver WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 bburg bburg bburg cgarcia commit-queue joepeck timothy webkit-bug-importer oldest_to_newest 1439945 0 bburg 2018-07-06 15:26:05 -0700 This test does not seem to be spec-conformant (beforeunload alerts should be dismissed automatically), but it shouldn't hang either. 1439946 1 bburg 2018-07-06 15:26:29 -0700 <rdar://problem/41909520> 1439951 2 344467 bburg 2018-07-06 15:33:48 -0700 Created attachment 344467 Patch 1439976 3 344467 commit-queue 2018-07-06 16:11:09 -0700 Comment on attachment 344467 Patch Clearing flags on attachment: 344467 Committed r233600: <https://trac.webkit.org/changeset/233600> 1439977 4 commit-queue 2018-07-06 16:11:10 -0700 All reviewed patches have been landed. Closing bug. 1440411 5 bburg 2018-07-09 09:30:42 -0700 Committed r233641: <https://trac.webkit.org/changeset/233641> 344467 2018-07-06 15:33:48 -0700 2018-07-06 16:11:09 -0700 Patch bug-187418-20180706153347.patch text/plain 3086 bburg U3VidmVyc2lvbiBSZXZpc2lvbjogMjMzNTkxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGYxMjBlNjQ5NjZiNDQ0NWMx MWQyMGVkNDhhNDZmY2EwMjM5NDZlNjcuLjJiNzg2ZTRmMTgzMjAxODQ1MjZhYzEyZGMyMWUzNzY1 MzQxNTM2ZmIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjYgQEAKKzIwMTgtMDctMDYgIEJyaWFuIEJ1 cmcgIDxiYnVyZ0BhcHBsZS5jb20+CisKKyAgICAgICAgV2ViRHJpdmVyOiBoYW5nIGluIFNlbGVu aXVtIHRlc3QgYWxlcnRzX3Rlc3RzLnB5Ojp0ZXN0U2hvdWxkSGFuZGxlQWxlcnRPblBhZ2VCZWZv cmVVbmxvYWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTE4NzQxOAorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNDE5MDk1MjA+CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUGVyIHRoZSBXM0Mgc3BlY2lmaWNh dGlvbiwg4oCcVXNlciBwcm9tcHRzIHRoYXQgYXJlIHNwYXduZWQgZnJvbSBiZWZvcmV1bmxvYWQg ZXZlbnQgaGFuZGxlcnMsCisgICAgICAgIGFyZSBkaXNtaXNzZWQgaW1wbGljaXRseSB1cG9uIG5h dmlnYXRpb24gb3IgY2xvc2Ugd2luZG93LCByZWdhcmRsZXNzIG9mIHRoZSBkZWZpbmVkIHVzZXIg cHJvbXB0IGhhbmRsZXIu4oCdCisKKyAgICAgICAgVGhpcyBiZWhhdmlvciBkaWZmZXJzIGZyb20g bGVnYWN5IFNlbGVuaXVtIGJlaGF2aW9yIHdoZXJlIChhcyBpbiB0aGUgdGVzdCkgaXQncyBleHBl Y3RlZCB0aGF0CisgICAgICAgIGEgdGVzdCBjYW4gYWNjZXB0IG9yIGRpc21pc3MgYSBiZWZvcmV1 bmxvYWQgYWxlcnQgbWFudWFsbHkuCisKKyAgICAgICAgUHJpb3IgdG8gdGhpcyBwYXRjaCwgYmVm b3JldW5sb2FkIGFsZXJ0cyBoYW5nIGJlY2F1c2UgU2FmYXJpIHVzZXMgYSBuZXN0ZWQgbW9kYWwg cnVuIGxvb3AsIHdoaWNoIGRvZXMKKyAgICAgICAgbm90IHByb2Nlc3MgaW5jb21pbmcgQXV0b21h dGlvbiBtZXNzYWdlcywgc28gdGhlcmUgd2FzIG5vIHdheSBmb3IgdGhlIHRlc3QgdG8gbWFudWFs bHkgZGlzbWlzcworICAgICAgICB0aGUgYWxlcnQuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvV2Vi UGFnZVByb3h5LmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViUGFnZVByb3h5OjpydW5CZWZvcmVV bmxvYWRDb25maXJtUGFuZWwpOgorICAgICAgICBEb24ndCBzaG93IGJlZm9yZXVubG9hZCBhbGVy dHMgZm9yIHBhZ2VzIGJlaW5nIGNvbnRyb2xsZWQgYnkgYXV0b21hdGlvbi4KKworCiAyMDE4LTA3 LTA2ICBBbmR5IEVzdGVzICA8YWVzdGVzQGFwcGxlLmNvbT4KIAogICAgICAgICBbaU9TXSBXS1BE RlZpZXcgc2hvdWxkIHNob3cgdGhlIERhdGEgRGV0ZWN0b3JzIHNoZWV0IHdoZW4gbG9uZy1wcmVz c2luZyBhIFVSTCB0aGF0IERhdGEgRGV0ZWN0b3JzIGNhbiBoYW5kbGUKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJLaXQvVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5jcHAgYi9Tb3VyY2UvV2ViS2l0L1VJ UHJvY2Vzcy9XZWJQYWdlUHJveHkuY3BwCmluZGV4IDZjZTM1ZDUzYTRmZGQzNjZkOWIzNzc5N2E4 OWNlYjMzYmMzOTczNzIuLjhjMzMwNzgwMjkxZjIxNTMwMTJkMjhlNGI5OGZlNjhmYTc4NGVjYzIg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5jcHAKKysr IGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2ViUGFnZVByb3h5LmNwcApAQCAtNDUyMywxNCAr NDUyMywxOCBAQCB2b2lkIFdlYlBhZ2VQcm94eTo6cnVuQmVmb3JlVW5sb2FkQ29uZmlybVBhbmVs KHVpbnQ2NF90IGZyYW1lSUQsIGNvbnN0IFNlY3VyaXR5TwogICAgIFdlYkZyYW1lUHJveHkqIGZy YW1lID0gbV9wcm9jZXNzLT53ZWJGcmFtZShmcmFtZUlEKTsKICAgICBNRVNTQUdFX0NIRUNLKGZy YW1lKTsKIAotICAgIC8vIFNpbmNlIHJ1bkJlZm9yZVVubG9hZENvbmZpcm1QYW5lbCgpIGNhbiBz cGluIGEgbmVzdGVkIHJ1biBsb29wIHdlIG5lZWQgdG8gdHVybiBvZmYgdGhlIHJlc3BvbnNpdmVu ZXNzIHRpbWVyLgotICAgIG1fcHJvY2Vzcy0+cmVzcG9uc2l2ZW5lc3NUaW1lcigpLnN0b3AoKTsK LQorICAgIC8vIFBlciDCpzE4IFVzZXIgUHJvbXB0cyBpbiB0aGUgV2ViRHJpdmVyIHNwZWMsICJV c2VyIHByb21wdHMgdGhhdCBhcmUgc3Bhd25lZCBmcm9tIGJlZm9yZXVubG9hZAorICAgIC8vIGV2 ZW50IGhhbmRsZXJzLCBhcmUgZGlzbWlzc2VkIGltcGxpY2l0bHkgdXBvbiBuYXZpZ2F0aW9uIG9y IGNsb3NlIHdpbmRvdywgcmVnYXJkbGVzcyBvZiB0aGUKKyAgICAvLyBkZWZpbmVkIHVzZXIgcHJv bXB0IGhhbmRsZXIuIiBTbywgYWx3YXlzIGFsbG93IHRoZSB1bmxvYWQgdG8gcHJvY2VlZCBpZiB0 aGUgcGFnZSBpcyBiZWluZyBhdXRvbWF0ZWQuCiAgICAgaWYgKG1fY29udHJvbGxlZEJ5QXV0b21h dGlvbikgewotICAgICAgICBpZiAoYXV0byogYXV0b21hdGlvblNlc3Npb24gPSBwcm9jZXNzKCku cHJvY2Vzc1Bvb2woKS5hdXRvbWF0aW9uU2Vzc2lvbigpKQotICAgICAgICAgICAgYXV0b21hdGlv blNlc3Npb24tPndpbGxTaG93SmF2YVNjcmlwdERpYWxvZygqdGhpcyk7CisgICAgICAgIGlmIChh dXRvKiBhdXRvbWF0aW9uU2Vzc2lvbiA9IHByb2Nlc3MoKS5wcm9jZXNzUG9vbCgpLmF1dG9tYXRp b25TZXNzaW9uKCkpIHsKKyAgICAgICAgICAgIHJlcGx5KHRydWUpOworICAgICAgICAgICAgcmV0 dXJuOworICAgICAgICB9CiAgICAgfQogCisgICAgLy8gU2luY2UgcnVuQmVmb3JlVW5sb2FkQ29u ZmlybVBhbmVsKCkgY2FuIHNwaW4gYSBuZXN0ZWQgcnVuIGxvb3Agd2UgbmVlZCB0byB0dXJuIG9m ZiB0aGUgcmVzcG9uc2l2ZW5lc3MgdGltZXIuCisgICAgbV9wcm9jZXNzLT5yZXNwb25zaXZlbmVz c1RpbWVyKCkuc3RvcCgpOwogICAgIG1fdWlDbGllbnQtPnJ1bkJlZm9yZVVubG9hZENvbmZpcm1Q YW5lbCh0aGlzLCBtZXNzYWdlLCBmcmFtZSwgc2VjdXJpdHlPcmlnaW4sIFdURk1vdmUocmVwbHkp KTsKIH0KIAo=