187404 2018-07-06 13:01:48 -0700 Check that LayerTreeHost was created before use 2018-07-09 20:06:25 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 stephan.szabo webkit-unassigned basuke cgarcia commit-queue fujii mcatanzaro ross.kirsling webkit-bug-importer zan oldest_to_newest 1439881 0 stephan.szabo 2018-07-06 13:01:48 -0700 Check that LayerTreeHost was created before use 1439884 1 344443 stephan.szabo 2018-07-06 13:03:39 -0700 Created attachment 344443 Patch 1439885 2 stephan.szabo 2018-07-06 13:05:21 -0700 I'm not sure if this is the best way to handle this, but while working on web inspector for wincairo non-legacy, we hit crashes just after this point because LayerTreeHost::create returns nullptr if not USE(COORDINATED_GRAPHICS_THREADED) but this code acts as if it will always get one. 1440288 3 fujii 2018-07-08 22:00:28 -0700 I think Windows WK2 MiniBrowser should disable AC by using WKPreferencesSetAcceleratedDrawingEnabled until AC is supported. 1440294 4 fujii 2018-07-08 22:12:10 -0700 Ah. Your primary aim is the web inspector. IIRC, the web inspector is using AC to paint element highlights. 1440332 5 fujii 2018-07-09 01:59:53 -0700 Stephan, what will happen in AC mode pages after applying your change? All becomes blank pages instead of having crash? 1440466 6 344443 commit-queue 2018-07-09 11:21:08 -0700 Comment on attachment 344443 Patch Clearing flags on attachment: 344443 Committed r233647: <https://trac.webkit.org/changeset/233647> 1440467 7 commit-queue 2018-07-09 11:21:10 -0700 All reviewed patches have been landed. Closing bug. 1440468 8 webkit-bug-importer 2018-07-09 11:27:22 -0700 <rdar://problem/41981386> 1440704 9 fujii 2018-07-09 20:06:25 -0700 Bug 187503 – [Win][MiniBrowser] Disable accelerated compositing until it is supported 344443 2018-07-06 13:03:39 -0700 2018-07-09 11:21:08 -0700 Patch bug-187404-20180706130338.patch text/plain 1443 stephan.szabo U3VidmVyc2lvbiBSZXZpc2lvbjogMjMzMzYwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDFkN2ViNzk2OWVmOGQ5OTE2 ZTZhMmM3NjIzYmQzZjRhODQ2NTg4NGEuLmZhNWNhMTdkNjUzOTcyZjg4NGUyZjI1MTIzNTQ1NDli ZDAxOTkwNDMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTgtMDctMDYgIFN0ZXBoYW4g U3phYm8gIDxzdGVwaGFuLnN6YWJvQHNvbnkuY29tPgorCisgICAgICAgIENoZWNrIHRoYXQgTGF5 ZXJUcmVlSG9zdCB3YXMgY3JlYXRlZCBiZWZvcmUgdXNlCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODc0MDQKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFdlYlByb2Nlc3MvV2ViUGFnZS9BY2NlbGVyYXRl ZERyYXdpbmdBcmVhLmNwcDoKKyAgICAgICAgKFdlYktpdDo6QWNjZWxlcmF0ZWREcmF3aW5nQXJl YTo6ZW50ZXJBY2NlbGVyYXRlZENvbXBvc2l0aW5nTW9kZSk6CisKIDIwMTgtMDYtMjkgIENocmlz IER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KIAogICAgICAgICBTdG9wIHVzaW5nIGxhbWJkYXMg Zm9yIFdlYlJlc291cmNlTG9hZFN0YXRpc3RpY3NTdG9yZSB0byBpbnRlcmFjdCB3aXRoIGl0cyBX ZWJzaXRlRGF0YVN0b3JlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvV2Vi UGFnZS9BY2NlbGVyYXRlZERyYXdpbmdBcmVhLmNwcCBiL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vz cy9XZWJQYWdlL0FjY2VsZXJhdGVkRHJhd2luZ0FyZWEuY3BwCmluZGV4IDVjZWQ4YmUwZTdmZmUz MjhmMTNlZjFlMzkxN2FiMjllNGIzYmJjMDYuLjJmOTk5MzhlMmYwMGEwYzk0YzM2NTI2OTEyNmNi MGM1ZmI0ZTkwZjggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9XZWJQYWdl L0FjY2VsZXJhdGVkRHJhd2luZ0FyZWEuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vz cy9XZWJQYWdlL0FjY2VsZXJhdGVkRHJhd2luZ0FyZWEuY3BwCkBAIC0zNTYsNiArMzU2LDkgQEAg dm9pZCBBY2NlbGVyYXRlZERyYXdpbmdBcmVhOjplbnRlckFjY2VsZXJhdGVkQ29tcG9zaXRpbmdN b2RlKEdyYXBoaWNzTGF5ZXIqIGdyYXAKICAgICB9IGVsc2UgewogICAgICAgICBtX2xheWVyVHJl ZUhvc3QgPSBMYXllclRyZWVIb3N0OjpjcmVhdGUobV93ZWJQYWdlKTsKIAorICAgICAgICBpZiAo IW1fbGF5ZXJUcmVlSG9zdCkKKyAgICAgICAgICAgIHJldHVybjsKKwogICAgICAgICBpZiAobV9p c1BhaW50aW5nU3VzcGVuZGVkKQogICAgICAgICAgICAgbV9sYXllclRyZWVIb3N0LT5wYXVzZVJl bmRlcmluZygpOwogICAgIH0K