187402 2018-07-06 12:45:39 -0700 Make RealtimeOutgoingVideoSource use DestructionThread::Main 2018-07-06 16:45:04 -0700 1 1 1 Unclassified WebKit WebRTC WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 youennf youennf achristensen cdumez commit-queue eric.carlson webkit-bug-importer youennf oldest_to_newest 1439871 0 youennf 2018-07-06 12:45:39 -0700 Make RealtimeOutgoingVideoSource use DestructionThread::Main 1439872 1 344442 youennf 2018-07-06 12:49:48 -0700 Created attachment 344442 Patch 1439877 2 344442 cdumez 2018-07-06 12:57:41 -0700 Comment on attachment 344442 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=344442&action=review > Source/WebCore/platform/mediastream/RealtimeOutgoingVideoSource.h:57 > + auto result = hasOneRef() ? rtc::RefCountReleaseStatus::kDroppedLastRef : rtc::RefCountReleaseStatus::kOtherRefsRemained; Is this thread safe? If Release() can be called from various threads, then a ref() / deref() can happen on another thread after your hasOneRef() check. 1439882 3 youennf 2018-07-06 13:02:22 -0700 > View in context: > https://bugs.webkit.org/attachment.cgi?id=344442&action=review > > > Source/WebCore/platform/mediastream/RealtimeOutgoingVideoSource.h:57 > > + auto result = hasOneRef() ? rtc::RefCountReleaseStatus::kDroppedLastRef : rtc::RefCountReleaseStatus::kOtherRefsRemained; > > Is this thread safe? If Release() can be called from various threads, then a > ref() / deref() can happen on another thread after your hasOneRef() check. Well, this whole API is not really thread safe but we need to return something as an API contract. Even if we return the true value at the time we did defer(), it will be useless for the caller, except maybe for logging. I am fine continuing returning rtc::RefCountReleaseStatus::kOtherRefsRemained like done before. 1439996 4 344442 commit-queue 2018-07-06 16:30:28 -0700 Comment on attachment 344442 Patch Clearing flags on attachment: 344442 Committed r233602: <https://trac.webkit.org/changeset/233602> 1439997 5 commit-queue 2018-07-06 16:30:30 -0700 All reviewed patches have been landed. Closing bug. 1440005 6 webkit-bug-importer 2018-07-06 16:45:04 -0700 <rdar://problem/41914556> 344442 2018-07-06 12:49:48 -0700 2018-07-06 16:30:28 -0700 Patch bug-187402-20180706124947.patch text/plain 2231 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjMzNTMyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYzhiOGI3YmZkMThmMzBl NGFkYTU4Y2M2YTRlMjg1MzQ4NzM2Y2Y4Yy4uNzgxMDhlZDRlZGU0YzIzZjZhZmFmMDdmMDg1MzIy ZGRlNWY1NDE5MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE4LTA3LTA2ICBZb3Vl bm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KKworICAgICAgICBNYWtlIFJlYWx0aW1lT3V0 Z29pbmdWaWRlb1NvdXJjZSB1c2UgRGVzdHJ1Y3Rpb25UaHJlYWQ6Ok1haW4KKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4NzQwMgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5vIGNoYW5nZSBvZiBiZWhhdmlv ci4KKworICAgICAgICAqIHBsYXRmb3JtL21lZGlhc3RyZWFtL1JlYWx0aW1lT3V0Z29pbmdWaWRl b1NvdXJjZS5oOgorCiAyMDE4LTA3LTA2ICBZb3Vlbm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNv bT4KIAogICAgICAgICBXZWJSVEMgTWVkaWFTdHJlYW1UcmFjayBFbmFibGUgLyBEaXNhYmxlIGNh dXNlcyB2aWRlbyBkZWxheSAvIGxhZwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vbWVkaWFzdHJlYW0vUmVhbHRpbWVPdXRnb2luZ1ZpZGVvU291cmNlLmggYi9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9tZWRpYXN0cmVhbS9SZWFsdGltZU91dGdvaW5nVmlkZW9Tb3VyY2UuaApp bmRleCAxN2Y4NjM1NWNmZDVjM2Y2M2M3NzcyZGUyMzNlMjNmMTE4Mzk2YzdmLi4wMjlkMTQ3ODI3 NDJlZjMzZDBjZWZiNzIxNmQxZWFkYmZhNTE4NDAxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9tZWRpYXN0cmVhbS9SZWFsdGltZU91dGdvaW5nVmlkZW9Tb3VyY2UuaAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tZWRpYXN0cmVhbS9SZWFsdGltZU91dGdvaW5nVmlk ZW9Tb3VyY2UuaApAQCAtNDIsNyArNDIsNyBAQAogCiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKLWNs YXNzIFJlYWx0aW1lT3V0Z29pbmdWaWRlb1NvdXJjZSA6IHB1YmxpYyBUaHJlYWRTYWZlUmVmQ291 bnRlZDxSZWFsdGltZU91dGdvaW5nVmlkZW9Tb3VyY2U+LCBwdWJsaWMgd2VicnRjOjpWaWRlb1Ry YWNrU291cmNlSW50ZXJmYWNlLCBwcml2YXRlIE1lZGlhU3RyZWFtVHJhY2tQcml2YXRlOjpPYnNl cnZlciB7CitjbGFzcyBSZWFsdGltZU91dGdvaW5nVmlkZW9Tb3VyY2UgOiBwdWJsaWMgVGhyZWFk U2FmZVJlZkNvdW50ZWQ8UmVhbHRpbWVPdXRnb2luZ1ZpZGVvU291cmNlLCBXVEY6OkRlc3RydWN0 aW9uVGhyZWFkOjpNYWluPiwgcHVibGljIHdlYnJ0Yzo6VmlkZW9UcmFja1NvdXJjZUludGVyZmFj ZSwgcHJpdmF0ZSBNZWRpYVN0cmVhbVRyYWNrUHJpdmF0ZTo6T2JzZXJ2ZXIgewogcHVibGljOgog ICAgIHN0YXRpYyBSZWY8UmVhbHRpbWVPdXRnb2luZ1ZpZGVvU291cmNlPiBjcmVhdGUoUmVmPE1l ZGlhU3RyZWFtVHJhY2tQcml2YXRlPiYmIHZpZGVvU291cmNlKTsKICAgICB+UmVhbHRpbWVPdXRn b2luZ1ZpZGVvU291cmNlKCkgeyBzdG9wKCk7IH0KQEAgLTU0LDEwICs1NCw5IEBAIHB1YmxpYzoK ICAgICB2b2lkIEFkZFJlZigpIGNvbnN0IGZpbmFsIHsgcmVmKCk7IH0KICAgICBydGM6OlJlZkNv dW50UmVsZWFzZVN0YXR1cyBSZWxlYXNlKCkgY29uc3QgZmluYWwKICAgICB7Ci0gICAgICAgIGNh bGxPbk1haW5UaHJlYWQoW3RoaXNdIHsKLSAgICAgICAgICAgIGRlcmVmKCk7Ci0gICAgICAgIH0p OwotICAgICAgICByZXR1cm4gcnRjOjpSZWZDb3VudFJlbGVhc2VTdGF0dXM6OmtPdGhlclJlZnNS ZW1haW5lZDsKKyAgICAgICAgYXV0byByZXN1bHQgPSBoYXNPbmVSZWYoKSA/IHJ0Yzo6UmVmQ291 bnRSZWxlYXNlU3RhdHVzOjprRHJvcHBlZExhc3RSZWYgOiBydGM6OlJlZkNvdW50UmVsZWFzZVN0 YXR1czo6a090aGVyUmVmc1JlbWFpbmVkOworICAgICAgICBkZXJlZigpOworICAgICAgICByZXR1 cm4gcmVzdWx0OwogICAgIH0KIAogICAgIHZvaWQgc2V0QXBwbHlSb3RhdGlvbihib29sIHNob3Vs ZEFwcGx5Um90YXRpb24pIHsgbV9zaG91bGRBcHBseVJvdGF0aW9uID0gc2hvdWxkQXBwbHlSb3Rh dGlvbjsgfQo=