187396 2018-07-06 11:06:27 -0700 [iOS] WKPDFView should show the Data Detectors sheet when long-pressing a URL that Data Detectors can handle 2018-07-06 13:13:31 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 aestes aestes aestes commit-queue darin ddkilzer mitz thorton webkit-bug-importer oldest_to_newest 1439822 0 aestes 2018-07-06 11:06:27 -0700 [iOS] WKPDFView should show the Data Detectors sheet when long-pressing a URL that Data Detectors can handle 1439823 1 aestes 2018-07-06 11:07:07 -0700 rdar://problem/41786980 1439824 2 344429 aestes 2018-07-06 11:09:30 -0700 Created attachment 344429 Patch 1439865 3 344440 aestes 2018-07-06 12:39:41 -0700 Created attachment 344440 Patch 1439890 4 commit-queue 2018-07-06 13:09:30 -0700 The commit-queue encountered the following flaky tests while processing attachment 344440: media/media-fullscreen-pause-inline.html bug 187406 (author: jeremyj-wk@apple.com) The commit-queue is continuing to process your patch. 1439893 5 commit-queue 2018-07-06 13:09:41 -0700 The commit-queue encountered the following flaky tests while processing attachment 344440: media/media-fullscreen-return-to-inline.html bug 187387 (authors: graouts@apple.com, mcatanzaro@igalia.com, and ryanhaddad@apple.com) The commit-queue is continuing to process your patch. 1439896 6 344440 commit-queue 2018-07-06 13:13:30 -0700 Comment on attachment 344440 Patch Clearing flags on attachment: 344440 Committed r233589: <https://trac.webkit.org/changeset/233589> 1439897 7 commit-queue 2018-07-06 13:13:31 -0700 All reviewed patches have been landed. Closing bug. 344429 2018-07-06 11:09:30 -0700 2018-07-06 12:39:40 -0700 Patch bug-187396-20180706110929.patch text/plain 3130 aestes U3VidmVyc2lvbiBSZXZpc2lvbjogMjMzNTc3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGI0MTg5M2QwYTU3NGFmMDFl NDkxYjk3NmU2MWFjNzljZGY5ZGYxY2YuLjk3OTMyYjgyZGM2NDczYWI4YjQyODJiMjNhN2NiYjI2 ODMyYzZmYTAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTgtMDctMDYgIEFuZHkgRXN0 ZXMgIDxhZXN0ZXNAYXBwbGUuY29tPgorCisgICAgICAgIFtpT1NdIFdLUERGVmlldyBzaG91bGQg c2hvdyB0aGUgRGF0YSBEZXRlY3RvcnMgc2hlZXQgd2hlbiBsb25nLXByZXNzaW5nIGEgVVJMIHRo YXQgRGF0YSBEZXRlY3RvcnMgY2FuIGhhbmRsZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg3Mzk2CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS80MTc4 Njk4MD4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJ ZiBhIFVSTCBjYW4gYmUgcHJlc2VudGVkIGJ5IERhdGEgRGV0ZWN0b3JzLCBzaG93IHRoZSBEYXRh IERldGVjdG9ycyBzaGVldCBpbnN0ZWFkCisgICAgICAgIG9mIHRoZSBsaW5rIHNoZWV0LiBBbHNv IGltcGxlbWVudCB0aGUgb3B0aW9uYWwgV0tBY3Rpb25TaGVldEFzc2lzdGFudERlbGVnYXRlCisg ICAgICAgIG1ldGhvZCB0aGF0IGFza3MgdGhlIFVJIGRlbGVnYXRlIGZvciBpdHMgZGF0YSBkZXRl Y3Rpb24gY29udGV4dC4KKworICAgICAgICAqIFVJUHJvY2Vzcy9pb3MvV0tQREZWaWV3Lm1tOgor ICAgICAgICAoLVtXS1BERlZpZXcgX3Nob3dBY3Rpb25TaGVldEZvclVSTDphdExvY2F0aW9uOndp dGhBbm5vdGF0aW9uUmVjdDpdKToKKyAgICAgICAgKC1bV0tQREZWaWV3IGRhdGFEZXRlY3Rpb25D b250ZXh0Rm9yQWN0aW9uU2hlZXRBc3Npc3RhbnQ6XSk6CisKIDIwMTgtMDctMDUgIFlvdWVubiBG YWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgogCiAgICAgICAgIFJFR1JFU1NJT04gKHIyMzA4NDMp OiBGbGFzaCBkb2Vzbid0IHdvcms7IFByb2R1Y2VzIGJsdWUgYm94IG9uIHBhZ2UKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL2lvcy9XS1BERlZpZXcubW0gYi9Tb3VyY2UvV2Vi S2l0L1VJUHJvY2Vzcy9pb3MvV0tQREZWaWV3Lm1tCmluZGV4IDBhN2I0ZmNlOWI5YThhYjUxZjZi MDI1OTI5YzZlNDE2MWMxMDQyMmYuLjUyZWY5NDA3ZWVhMDg2NTFhZTUxNTIyZTRjOGNlYjcwM2M5 ZjZhNzMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL2lvcy9XS1BERlZpZXcu bW0KKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvaW9zL1dLUERGVmlldy5tbQpAQCAtMzIs MTAgKzMyLDEyIEBACiAjaW1wb3J0ICJGaW5kQ2xpZW50LmgiCiAjaW1wb3J0ICJQREZLaXRTUEku aCIKICNpbXBvcnQgIldLQWN0aW9uU2hlZXRBc3Npc3RhbnQuaCIKKyNpbXBvcnQgIldLVUlEZWxl Z2F0ZVByaXZhdGUuaCIKICNpbXBvcnQgIldLV2ViVmlld0ludGVybmFsLmgiCiAjaW1wb3J0ICJX ZWJQYWdlUHJveHkuaCIKICNpbXBvcnQgIl9XS1dlYlZpZXdQcmludEZvcm1hdHRlckludGVybmFs LmgiCiAjaW1wb3J0IDxNb2JpbGVDb3JlU2VydmljZXMvTW9iaWxlQ29yZVNlcnZpY2VzLmg+Cisj aW1wb3J0IDxXZWJDb3JlL0RhdGFEZXRlY3Rpb24uaD4KICNpbXBvcnQgPFdlYkNvcmUvV2ViQ29y ZU5TVVJMRXh0cmFzLmg+CiAjaW1wb3J0IDx3dGYvQmxvY2tQdHIuaD4KICNpbXBvcnQgPHd0Zi9N YWluVGhyZWFkLmg+CkBAIC00MzksNyArNDQxLDEwIEBAIC0gKHZvaWQpX3Nob3dBY3Rpb25TaGVl dEZvclVSTDooTlNVUkwgKil1cmwgYXRMb2NhdGlvbjooQ0dQb2ludClsb2NhdGlvbiB3aXRoQW5u CiAgICAgcG9zaXRpb25JbmZvcm1hdGlvbi51cmwgPSB1cmw7CiAKICAgICBfcG9zaXRpb25JbmZv cm1hdGlvbiA9IFdURk1vdmUocG9zaXRpb25JbmZvcm1hdGlvbik7Ci0gICAgW19hY3Rpb25TaGVl dEFzc2lzdGFudCBzaG93TGlua1NoZWV0XTsKKyAgICBpZiAoV2ViQ29yZTo6RGF0YURldGVjdGlv bjo6Y2FuQmVQcmVzZW50ZWRCeURhdGFEZXRlY3RvcnMoX3Bvc2l0aW9uSW5mb3JtYXRpb24udXJs KSkKKyAgICAgICAgW19hY3Rpb25TaGVldEFzc2lzdGFudCBzaG93RGF0YURldGVjdG9yc1NoZWV0 XTsKKyAgICBlbHNlCisgICAgICAgIFtfYWN0aW9uU2hlZXRBc3Npc3RhbnQgc2hvd0xpbmtTaGVl dF07CiB9CiAKIC0gKHZvaWQpcGRmSG9zdFZpZXdDb250cm9sbGVyOihQREZIb3N0Vmlld0NvbnRy b2xsZXIgKiljb250cm9sbGVyIGRpZExvbmdQcmVzc1VSTDooTlNVUkwgKil1cmwgYXRMb2NhdGlv bjooQ0dQb2ludClsb2NhdGlvbiB3aXRoQW5ub3RhdGlvblJlY3Q6KENHUmVjdClhbm5vdGF0aW9u UmVjdApAQCAtNTEzLDYgKzUxOCwxOSBAQCAtIChSZXRhaW5QdHI8TlNBcnJheT4pYWN0aW9uU2hl ZXRBc3Npc3RhbnQ6KFdLQWN0aW9uU2hlZXRBc3Npc3RhbnQgKilhc3Npc3RhbnQgZAogICAgIHJl dHVybiBwYWdlLT51aUNsaWVudCgpLmFjdGlvbnNGb3JFbGVtZW50KGVsZW1lbnQsIFdURk1vdmUo ZGVmYXVsdEFjdGlvbnMpKTsKIH0KIAorLSAoTlNEaWN0aW9uYXJ5ICopZGF0YURldGVjdGlvbkNv bnRleHRGb3JBY3Rpb25TaGVldEFzc2lzdGFudDooV0tBY3Rpb25TaGVldEFzc2lzdGFudCAqKWFz c2lzdGFudAoreworICAgIGF1dG8gd2ViVmlldyA9IF93ZWJWaWV3LmdldEF1dG9yZWxlYXNlZCgp OworICAgIGlmICghd2ViVmlldykKKyAgICAgICAgcmV0dXJuIG5pbDsKKworICAgIGlkIDxXS1VJ RGVsZWdhdGVQcml2YXRlPiB1aURlbGVnYXRlID0gc3RhdGljX2Nhc3Q8aWQgPFdLVUlEZWxlZ2F0 ZVByaXZhdGU+Pih3ZWJWaWV3LlVJRGVsZWdhdGUpOworICAgIGlmICghW3VpRGVsZWdhdGUgcmVz cG9uZHNUb1NlbGVjdG9yOkBzZWxlY3RvcihfZGF0YURldGVjdGlvbkNvbnRleHRGb3JXZWJWaWV3 OildKQorICAgICAgICByZXR1cm4gbmlsOworCisgICAgcmV0dXJuIFt1aURlbGVnYXRlIF9kYXRh RGV0ZWN0aW9uQ29udGV4dEZvcldlYlZpZXc6d2ViVmlld107Cit9CisKIEBlbmQKIAogCg== 344440 2018-07-06 12:39:41 -0700 2018-07-06 13:13:30 -0700 Patch bug-187396-20180706123940.patch text/plain 3165 aestes U3VidmVyc2lvbiBSZXZpc2lvbjogMjMzNTc3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGI0MTg5M2QwYTU3NGFmMDFl NDkxYjk3NmU2MWFjNzljZGY5ZGYxY2YuLmIyNjBiYmZiYjM5NTAwYWMyMWNkYTRkMDJkOTNhMDM4 Zjc4NjIyMzcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTgtMDctMDYgIEFuZHkgRXN0 ZXMgIDxhZXN0ZXNAYXBwbGUuY29tPgorCisgICAgICAgIFtpT1NdIFdLUERGVmlldyBzaG91bGQg c2hvdyB0aGUgRGF0YSBEZXRlY3RvcnMgc2hlZXQgd2hlbiBsb25nLXByZXNzaW5nIGEgVVJMIHRo YXQgRGF0YSBEZXRlY3RvcnMgY2FuIGhhbmRsZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg3Mzk2CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS80MTc4 Njk4MD4KKworICAgICAgICBSZXZpZXdlZCBieSBEYW4gQmVybnN0ZWluLgorCisgICAgICAgIElm IGEgVVJMIGNhbiBiZSBwcmVzZW50ZWQgYnkgRGF0YSBEZXRlY3RvcnMsIHNob3cgdGhlIERhdGEg RGV0ZWN0b3JzIHNoZWV0IGluc3RlYWQKKyAgICAgICAgb2YgdGhlIGxpbmsgc2hlZXQuIEFsc28g aW1wbGVtZW50IHRoZSBvcHRpb25hbCBXS0FjdGlvblNoZWV0QXNzaXN0YW50RGVsZWdhdGUKKyAg ICAgICAgbWV0aG9kIHRoYXQgYXNrcyB0aGUgVUkgZGVsZWdhdGUgZm9yIGl0cyBkYXRhIGRldGVj dGlvbiBjb250ZXh0LgorCisgICAgICAgICogVUlQcm9jZXNzL2lvcy9XS1BERlZpZXcubW06Cisg ICAgICAgICgtW1dLUERGVmlldyBfc2hvd0FjdGlvblNoZWV0Rm9yVVJMOmF0TG9jYXRpb246d2l0 aEFubm90YXRpb25SZWN0Ol0pOgorICAgICAgICAoLVtXS1BERlZpZXcgZGF0YURldGVjdGlvbkNv bnRleHRGb3JBY3Rpb25TaGVldEFzc2lzdGFudDpdKToKKwogMjAxOC0wNy0wNSAgWW91ZW5uIEZh YmxldCAgPHlvdWVubkBhcHBsZS5jb20+CiAKICAgICAgICAgUkVHUkVTU0lPTiAocjIzMDg0Myk6 IEZsYXNoIGRvZXNuJ3Qgd29yazsgUHJvZHVjZXMgYmx1ZSBib3ggb24gcGFnZQpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvaW9zL1dLUERGVmlldy5tbSBiL1NvdXJjZS9XZWJL aXQvVUlQcm9jZXNzL2lvcy9XS1BERlZpZXcubW0KaW5kZXggMGE3YjRmY2U5YjlhOGFiNTFmNmIw MjU5MjljNmU0MTYxYzEwNDIyZi4uZjE5NzQxYzkyZmY0ZTYyYmU4Y2M2OWFiY2NlZjc5Y2ZkNTRj N2JlNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvaW9zL1dLUERGVmlldy5t bQorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9pb3MvV0tQREZWaWV3Lm1tCkBAIC0zMiwx MCArMzIsMTIgQEAKICNpbXBvcnQgIkZpbmRDbGllbnQuaCIKICNpbXBvcnQgIlBERktpdFNQSS5o IgogI2ltcG9ydCAiV0tBY3Rpb25TaGVldEFzc2lzdGFudC5oIgorI2ltcG9ydCAiV0tVSURlbGVn YXRlUHJpdmF0ZS5oIgogI2ltcG9ydCAiV0tXZWJWaWV3SW50ZXJuYWwuaCIKICNpbXBvcnQgIldl YlBhZ2VQcm94eS5oIgogI2ltcG9ydCAiX1dLV2ViVmlld1ByaW50Rm9ybWF0dGVySW50ZXJuYWwu aCIKICNpbXBvcnQgPE1vYmlsZUNvcmVTZXJ2aWNlcy9Nb2JpbGVDb3JlU2VydmljZXMuaD4KKyNp bXBvcnQgPFdlYkNvcmUvRGF0YURldGVjdGlvbi5oPgogI2ltcG9ydCA8V2ViQ29yZS9XZWJDb3Jl TlNVUkxFeHRyYXMuaD4KICNpbXBvcnQgPHd0Zi9CbG9ja1B0ci5oPgogI2ltcG9ydCA8d3RmL01h aW5UaHJlYWQuaD4KQEAgLTQzOSw3ICs0NDEsMTIgQEAgLSAodm9pZClfc2hvd0FjdGlvblNoZWV0 Rm9yVVJMOihOU1VSTCAqKXVybCBhdExvY2F0aW9uOihDR1BvaW50KWxvY2F0aW9uIHdpdGhBbm4K ICAgICBwb3NpdGlvbkluZm9ybWF0aW9uLnVybCA9IHVybDsKIAogICAgIF9wb3NpdGlvbkluZm9y bWF0aW9uID0gV1RGTW92ZShwb3NpdGlvbkluZm9ybWF0aW9uKTsKLSAgICBbX2FjdGlvblNoZWV0 QXNzaXN0YW50IHNob3dMaW5rU2hlZXRdOworI2lmIEVOQUJMRShEQVRBX0RFVEVDVElPTikKKyAg ICBpZiAoV2ViQ29yZTo6RGF0YURldGVjdGlvbjo6Y2FuQmVQcmVzZW50ZWRCeURhdGFEZXRlY3Rv cnMoX3Bvc2l0aW9uSW5mb3JtYXRpb24udXJsKSkKKyAgICAgICAgW19hY3Rpb25TaGVldEFzc2lz dGFudCBzaG93RGF0YURldGVjdG9yc1NoZWV0XTsKKyAgICBlbHNlCisjZW5kaWYKKyAgICAgICAg W19hY3Rpb25TaGVldEFzc2lzdGFudCBzaG93TGlua1NoZWV0XTsKIH0KIAogLSAodm9pZClwZGZI b3N0Vmlld0NvbnRyb2xsZXI6KFBERkhvc3RWaWV3Q29udHJvbGxlciAqKWNvbnRyb2xsZXIgZGlk TG9uZ1ByZXNzVVJMOihOU1VSTCAqKXVybCBhdExvY2F0aW9uOihDR1BvaW50KWxvY2F0aW9uIHdp dGhBbm5vdGF0aW9uUmVjdDooQ0dSZWN0KWFubm90YXRpb25SZWN0CkBAIC01MTMsNiArNTIwLDE5 IEBAIC0gKFJldGFpblB0cjxOU0FycmF5PilhY3Rpb25TaGVldEFzc2lzdGFudDooV0tBY3Rpb25T aGVldEFzc2lzdGFudCAqKWFzc2lzdGFudCBkCiAgICAgcmV0dXJuIHBhZ2UtPnVpQ2xpZW50KCku YWN0aW9uc0ZvckVsZW1lbnQoZWxlbWVudCwgV1RGTW92ZShkZWZhdWx0QWN0aW9ucykpOwogfQog CistIChOU0RpY3Rpb25hcnkgKilkYXRhRGV0ZWN0aW9uQ29udGV4dEZvckFjdGlvblNoZWV0QXNz aXN0YW50OihXS0FjdGlvblNoZWV0QXNzaXN0YW50ICopYXNzaXN0YW50Cit7CisgICAgYXV0byB3 ZWJWaWV3ID0gX3dlYlZpZXcuZ2V0QXV0b3JlbGVhc2VkKCk7CisgICAgaWYgKCF3ZWJWaWV3KQor ICAgICAgICByZXR1cm4gbmlsOworCisgICAgaWQgPFdLVUlEZWxlZ2F0ZVByaXZhdGU+IHVpRGVs ZWdhdGUgPSBzdGF0aWNfY2FzdDxpZCA8V0tVSURlbGVnYXRlUHJpdmF0ZT4+KHdlYlZpZXcuVUlE ZWxlZ2F0ZSk7CisgICAgaWYgKCFbdWlEZWxlZ2F0ZSByZXNwb25kc1RvU2VsZWN0b3I6QHNlbGVj dG9yKF9kYXRhRGV0ZWN0aW9uQ29udGV4dEZvcldlYlZpZXc6KV0pCisgICAgICAgIHJldHVybiBu aWw7CisKKyAgICByZXR1cm4gW3VpRGVsZWdhdGUgX2RhdGFEZXRlY3Rpb25Db250ZXh0Rm9yV2Vi Vmlldzp3ZWJWaWV3XTsKK30KKwogQGVuZAogCiAK