187383 2018-07-06 02:38:33 -0700 [GTK][WPE] REGRESSION(r233111): Test /webkit/WebKitUserContentManager/script-message-received fails 2018-07-09 01:11:45 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED Gtk, InRadar, Regression P2 Normal --- 1 cgarcia webkit-unassigned aperez bugs-noreply calvaris cdumez lforschler webkit-bug-importer zan oldest_to_newest 1439740 0 cgarcia 2018-07-06 02:38:33 -0700 /webkit/WebKitUserContentManager/script-message-received: Leaked objects: WebKitUserContentManager(0x5564fcabf210) WebKitWebView(0x5564fcc26fc0) FAIL ERROR:/home/slave/webkitgtk/gtk-linux-64-release/build/Tools/TestWebKitAPI/glib/WebKitGLib/TestMain.h:133:Test::~Test(): assertion failed: (m_watchedObjects.isEmpty()) This is actually a problem in the test itself. The problem is that we run js, connect to message-received and quite the main loop when the message is received, which happens before the run js operation has been completed. The test finishes early and since r233111 an IPC message is still pending (I guess the run js callback) and the web page is still protected. Just adding a run loop operation before finishing the test would fix it. We should wait for the js run to complete, instead of the message. 1439741 1 344413 cgarcia 2018-07-06 02:41:22 -0700 Created attachment 344413 Patch 1439753 2 344413 aperez 2018-07-06 03:35:33 -0700 Comment on attachment 344413 Patch Nice find, r=me (informally). 1439757 3 cgarcia 2018-07-06 03:51:43 -0700 Committed r233576: <https://trac.webkit.org/changeset/233576> 1439758 4 webkit-bug-importer 2018-07-06 03:52:19 -0700 <rdar://problem/41886574> 344413 2018-07-06 02:41:22 -0700 2018-07-06 03:43:10 -0700 Patch wk2-script-message-test.diff text/plain 3720 cgarcia ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBmYTFj YmEzZDM5MC4uYzNkZWM1M2ZlZjUgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0NoYW5nZUxvZworKysgYi9U b29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMiBAQAorMjAxOC0wNy0wNiAgQ2FybG9zIEdhcmNp YSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dUS11bV1BFXSBSRUdS RVNTSU9OKHIyMzMxMTEpOiBUZXN0IC93ZWJraXQvV2ViS2l0VXNlckNvbnRlbnRNYW5hZ2VyL3Nj cmlwdC1tZXNzYWdlLXJlY2VpdmVkIGZhaWxzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xODczODMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBUaGlzIGlzIGFjdHVhbGx5IGEgcHJvYmxlbSBpbiB0aGUgdGVz dCBpdHNlbGYuIFRoZSBwcm9ibGVtIGlzIHRoYXQgd2UgcnVuIGpzLCBjb25uZWN0IHRvIG1lc3Nh Z2UtcmVjZWl2ZWQgYW5kCisgICAgICAgIHF1aXRlIHRoZSBtYWluIGxvb3Agd2hlbiB0aGUgbWVz c2FnZSBpcyByZWNlaXZlZCwgd2hpY2ggaGFwcGVucyBiZWZvcmUgdGhlIHJ1biBqcyBvcGVyYXRp b24gaGFzIGJlZW4KKyAgICAgICAgY29tcGxldGVkLiBUaGUgdGVzdCBmaW5pc2hlcyBlYXJseSBh bmQgc2luY2UgcjIzMzExMSBhbiBJUEMgbWVzc2FnZSBpcyBzdGlsbCBwZW5kaW5nIChJIGd1ZXNz IHRoZSBydW4ganMKKyAgICAgICAgY2FsbGJhY2spIGFuZCB0aGUgd2ViIHBhZ2UgaXMgc3RpbGwg cHJvdGVjdGVkLiBKdXN0IGFkZGluZyBhIHJ1biBsb29wIG9wZXJhdGlvbiBiZWZvcmUgZmluaXNo aW5nIHRoZSB0ZXN0IHdvdWxkCisgICAgICAgIGZpeCBpdC4gV2Ugc2hvdWxkIHdhaXQgZm9yIHRo ZSBqcyBydW4gdG8gY29tcGxldGUsIGluc3RlYWQgb2YgdGhlIG1lc3NhZ2UuCisKKyAgICAgICAg KiBUZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdEdMaWIvVGVzdFdlYktpdFVzZXJDb250ZW50TWFu YWdlci5jcHA6CisgICAgICAgIChVc2VyU2NyaXB0TWVzc2FnZVRlc3Q6OnNjcmlwdE1lc3NhZ2VS ZWNlaXZlZCk6CisgICAgICAgIChVc2VyU2NyaXB0TWVzc2FnZVRlc3Q6OndhaXRVbnRpbE1lc3Nh Z2VSZWNlaXZlZCk6CisgICAgICAgIChVc2VyU2NyaXB0TWVzc2FnZVRlc3Q6OnJ1bkphdmFTY3Jp cHRGaW5pc2hlZCk6CisgICAgICAgIChVc2VyU2NyaXB0TWVzc2FnZVRlc3Q6OnBvc3RNZXNzYWdl QW5kV2FpdFVudGlsUmVjZWl2ZWQpOgorCiAyMDE4LTA3LTA1ICBZb3Vlbm4gRmFibGV0ICA8eW91 ZW5uQGFwcGxlLmNvbT4KIAogICAgICAgICBSRUdSRVNTSU9OIChyMjMwODQzKTogRmxhc2ggZG9l c24ndCB3b3JrOyBQcm9kdWNlcyBibHVlIGJveCBvbiBwYWdlCmRpZmYgLS1naXQgYS9Ub29scy9U ZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdEdMaWIvVGVzdFdlYktpdFVzZXJDb250ZW50TWFuYWdl ci5jcHAgYi9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdEdMaWIvVGVzdFdlYktpdFVz ZXJDb250ZW50TWFuYWdlci5jcHAKaW5kZXggNjU2NTdiMDU2Y2EuLjk3ODNjMzUzM2I0IDEwMDY0 NAotLS0gYS9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdEdMaWIvVGVzdFdlYktpdFVz ZXJDb250ZW50TWFuYWdlci5jcHAKKysrIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJL aXRHTGliL1Rlc3RXZWJLaXRVc2VyQ29udGVudE1hbmFnZXIuY3BwCkBAIC0yMjIsNyArMjIyLDgg QEAgcHVibGljOgogICAgIHN0YXRpYyB2b2lkIHNjcmlwdE1lc3NhZ2VSZWNlaXZlZChXZWJLaXRV c2VyQ29udGVudE1hbmFnZXIqIHVzZXJDb250ZW50TWFuYWdlciwgV2ViS2l0SmF2YXNjcmlwdFJl c3VsdCoganNSZXN1bHQsIFVzZXJTY3JpcHRNZXNzYWdlVGVzdCogdGVzdCkKICAgICB7CiAgICAg ICAgIGdfc2lnbmFsX2hhbmRsZXJzX2Rpc2Nvbm5lY3RfYnlfZnVuYyh1c2VyQ29udGVudE1hbmFn ZXIsIHJlaW50ZXJwcmV0X2Nhc3Q8Z3BvaW50ZXI+KHNjcmlwdE1lc3NhZ2VSZWNlaXZlZCksIHRl c3QpOwotICAgICAgICBnX21haW5fbG9vcF9xdWl0KHRlc3QtPm1fbWFpbkxvb3ApOworICAgICAg ICBpZiAoIXRlc3QtPm1fd2FpdEZvclNjcmlwdFJ1bikKKyAgICAgICAgICAgIGdfbWFpbl9sb29w X3F1aXQodGVzdC0+bV9tYWluTG9vcCk7CiAKICAgICAgICAgZ19hc3NlcnQoIXRlc3QtPm1fdXNl clNjcmlwdE1lc3NhZ2UpOwogICAgICAgICB0ZXN0LT5tX3VzZXJTY3JpcHRNZXNzYWdlID0gd2Vi a2l0X2phdmFzY3JpcHRfcmVzdWx0X3JlZihqc1Jlc3VsdCk7CkBAIC0yMzksMTkgKzI0MCwyOSBA QCBwdWJsaWM6CiAgICAgICAgIGdfc2lnbmFsX2Nvbm5lY3QobV91c2VyQ29udGVudE1hbmFnZXIu Z2V0KCksIHNpZ25hbE5hbWUuZ2V0KCksIEdfQ0FMTEJBQ0soc2NyaXB0TWVzc2FnZVJlY2VpdmVk KSwgdGhpcyk7CiAKICAgICAgICAgZ19tYWluX2xvb3BfcnVuKG1fbWFpbkxvb3ApOworICAgICAg ICBnX2Fzc2VydCghbV93YWl0Rm9yU2NyaXB0UnVuKTsKICAgICAgICAgZ19hc3NlcnQobV91c2Vy U2NyaXB0TWVzc2FnZSk7CiAgICAgICAgIHJldHVybiBtX3VzZXJTY3JpcHRNZXNzYWdlOwogICAg IH0KIAorICAgIHN0YXRpYyB2b2lkIHJ1bkphdmFTY3JpcHRGaW5pc2hlZChHT2JqZWN0KiwgR0Fz eW5jUmVzdWx0KiByZXN1bHQsIFVzZXJTY3JpcHRNZXNzYWdlVGVzdCogdGVzdCkKKyAgICB7Cisg ICAgICAgIGdfYXNzZXJ0KHRlc3QtPm1fd2FpdEZvclNjcmlwdFJ1bik7CisgICAgICAgIHRlc3Qt Pm1fd2FpdEZvclNjcmlwdFJ1biA9IGZhbHNlOworICAgICAgICBnX21haW5fbG9vcF9xdWl0KHRl c3QtPm1fbWFpbkxvb3ApOworICAgIH0KKwogICAgIFdlYktpdEphdmFzY3JpcHRSZXN1bHQqIHBv c3RNZXNzYWdlQW5kV2FpdFVudGlsUmVjZWl2ZWQoY29uc3QgY2hhciogaGFuZGxlck5hbWUsIGNv bnN0IGNoYXIqIGphdmFzY3JpcHRWYWx1ZUFzVGV4dCkKICAgICB7CiAgICAgICAgIEdVbmlxdWVQ dHI8Y2hhcj4gamF2YXNjcmlwdFNuaXBwZXQoZ19zdHJkdXBfcHJpbnRmKCJ3aW5kb3cud2Via2l0 Lm1lc3NhZ2VIYW5kbGVycy4lcy5wb3N0TWVzc2FnZSglcyk7IiwgaGFuZGxlck5hbWUsIGphdmFz Y3JpcHRWYWx1ZUFzVGV4dCkpOwotICAgICAgICB3ZWJraXRfd2ViX3ZpZXdfcnVuX2phdmFzY3Jp cHQobV93ZWJWaWV3LCBqYXZhc2NyaXB0U25pcHBldC5nZXQoKSwgbnVsbHB0ciwgbnVsbHB0ciwg bnVsbHB0cik7CisgICAgICAgIG1fd2FpdEZvclNjcmlwdFJ1biA9IHRydWU7CisgICAgICAgIHdl YmtpdF93ZWJfdmlld19ydW5famF2YXNjcmlwdChtX3dlYlZpZXcsIGphdmFzY3JpcHRTbmlwcGV0 LmdldCgpLCBudWxscHRyLCByZWludGVycHJldF9jYXN0PEdBc3luY1JlYWR5Q2FsbGJhY2s+KHJ1 bkphdmFTY3JpcHRGaW5pc2hlZCksIHRoaXMpOwogICAgICAgICByZXR1cm4gd2FpdFVudGlsTWVz c2FnZVJlY2VpdmVkKGhhbmRsZXJOYW1lKTsKICAgICB9CiAKIHByaXZhdGU6CiAgICAgV2ViS2l0 SmF2YXNjcmlwdFJlc3VsdCogbV91c2VyU2NyaXB0TWVzc2FnZTsKKyAgICBib29sIG1fd2FpdEZv clNjcmlwdFJ1biB7IGZhbHNlIH07CiB9OwogCiBzdGF0aWMgdm9pZCB0ZXN0VXNlckNvbnRlbnRN YW5hZ2VyU2NyaXB0TWVzc2FnZVJlY2VpdmVkKFVzZXJTY3JpcHRNZXNzYWdlVGVzdCogdGVzdCwg Z2NvbnN0cG9pbnRlcikK