187378 2018-07-05 22:01:39 -0700 REGRESSION(r233496): macOS Sierra hits debug assertions in TrackListBase::suspend 2018-07-31 19:08:57 -0700 1 1 1 Unclassified WebKit Media WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 rniwa rniwa cdumez eric.carlson jeremyj-wk jer.noble ryanhaddad webkit-bug-importer oldest_to_newest 1439699 0 rniwa 2018-07-05 22:01:39 -0700 We're seeing debug assertion failures in TrackListBase::suspend after r233496. 1439701 1 webkit-bug-importer 2018-07-05 22:02:34 -0700 <rdar://problem/41878885> 1439702 2 webkit-bug-importer 2018-07-05 22:02:51 -0700 <rdar://problem/41878897> 1439714 3 344404 rniwa 2018-07-05 23:20:38 -0700 Created attachment 344404 Fixes the bug 1439715 4 rniwa 2018-07-05 23:22:49 -0700 Wow, that was very timely review. Thanks! 1439719 5 rniwa 2018-07-06 00:37:52 -0700 Committed r233571: <https://trac.webkit.org/changeset/233571> 1440050 6 rniwa 2018-07-06 19:10:30 -0700 *** Bug 187371 has been marked as a duplicate of this bug. *** 1444872 7 cdumez 2018-07-24 16:13:28 -0700 Reverted r233496 and r233571 for reason: Likely cause of <rdar://problem/42160890> and <rdar://problem/42329658> as ActiveDOMObjects can now be constructed / destroyed while we are iterating over them. Committed r234177: <https://trac.webkit.org/changeset/234177> 1446784 8 rniwa 2018-07-31 19:08:57 -0700 Relanded in https://trac.webkit.org/changeset/234374/webkit. 344404 2018-07-05 23:20:38 -0700 2018-07-05 23:22:05 -0700 Fixes the bug bug-187378-20180705232037.patch text/plain 5701 rniwa SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIzMzU2NSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI4IEBACisyMDE4LTA3LTA1ICBSeW9zdWtl IE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIFJFR1JFU1NJT04ocjIzMzQ5Nik6 IG1hY09TIFNpZXJyYSBoaXRzIGRlYnVnIGFzc2VydGlvbnMgaW4gVHJhY2tMaXN0QmFzZTo6c3Vz cGVuZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg3 Mzc4CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS80MTg3ODg4NT4KKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGVzZSBhc3NlcnRpb25zIHdlcmUgd3Jv bmcgc2luY2UgaW5saW5lIGRlYnVnZ2VyLCBhbGVydCwgZXRjLi4uIGNhbiBzdXNwZW5kIGFjdGl2 ZSBET00gb2JqZWN0cyB3aXRob3V0CisgICAgICAgIGNhbGxpbmcgY2FuU3VzcGVuZEZvckRvY3Vt ZW50U3VzcGVuc2lvbi4gRml4ZWQgdGhlIGJ1ZyBieSByZW1vdmluZyB0aGUgYXNzZXJ0aW9uIGFu ZCBpbnN0ZWFkIHN1c3BlbmRpbmcKKyAgICAgICAgYW5kIHJlc3VtaW5nIHRoZSBnZW5lcmljIGV2 ZW50IHF1ZXVlLgorCisgICAgICAgICogTW9kdWxlcy9tZWRpYXNvdXJjZS9NZWRpYVNvdXJjZS5j cHA6CisgICAgICAgIChXZWJDb3JlOjpNZWRpYVNvdXJjZTo6c3VzcGVuZCk6CisgICAgICAgIChX ZWJDb3JlOjpNZWRpYVNvdXJjZTo6cmVzdW1lKToKKyAgICAgICAgKiBNb2R1bGVzL21lZGlhc291 cmNlL1NvdXJjZUJ1ZmZlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpTb3VyY2VCdWZmZXI6OnN1 c3BlbmQpOgorICAgICAgICAoV2ViQ29yZTo6U291cmNlQnVmZmVyOjpyZXN1bWUpOgorICAgICAg ICAqIE1vZHVsZXMvbWVkaWFzb3VyY2UvU291cmNlQnVmZmVyTGlzdC5jcHA6CisgICAgICAgIChX ZWJDb3JlOjpTb3VyY2VCdWZmZXJMaXN0OjpzdXNwZW5kKToKKyAgICAgICAgKFdlYkNvcmU6OlNv dXJjZUJ1ZmZlckxpc3Q6OnJlc3VtZSk6CisgICAgICAgICogaHRtbC90cmFjay9UcmFja0xpc3RC YXNlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlRyYWNrTGlzdEJhc2U6OnN1c3BlbmQpOgorICAg ICAgICAoV2ViQ29yZTo6VHJhY2tMaXN0QmFzZTo6cmVzdW1lKToKKwogMjAxOC0wNy0wNSAgWW91 ZW5uIEZhYmxldCAgPHlvdWVubkBhcHBsZS5jb20+CiAKICAgICAgICAgUkVHUkVTU0lPTiAocjIz MDg0Myk6IEZsYXNoIGRvZXNuJ3Qgd29yazsgUHJvZHVjZXMgYmx1ZSBib3ggb24gcGFnZQpJbmRl eDogU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYXNvdXJjZS9NZWRpYVNvdXJjZS5jcHAKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYXNvdXJjZS9NZWRpYVNvdXJj ZS5jcHAJKHJldmlzaW9uIDIzMzU1OSkKKysrIFNvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFz b3VyY2UvTWVkaWFTb3VyY2UuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC05MzUsMTQgKzkzNSwyMyBA QCBib29sIE1lZGlhU291cmNlOjpoYXNQZW5kaW5nQWN0aXZpdHkoKSBjCiAgICAgICAgIHx8IEFj dGl2ZURPTU9iamVjdDo6aGFzUGVuZGluZ0FjdGl2aXR5KCk7CiB9CiAKLXZvaWQgTWVkaWFTb3Vy Y2U6OnN1c3BlbmQoUmVhc29uRm9yU3VzcGVuc2lvbikKK3ZvaWQgTWVkaWFTb3VyY2U6OnN1c3Bl bmQoUmVhc29uRm9yU3VzcGVuc2lvbiByZWFzb24pCiB7Ci0gICAgQVNTRVJUKCFtX2FzeW5jRXZl bnRRdWV1ZS5oYXNQZW5kaW5nRXZlbnRzKCkpOworICAgIHN3aXRjaCAocmVhc29uKSB7CisgICAg Y2FzZSBSZWFzb25Gb3JTdXNwZW5zaW9uOjpQYWdlQ2FjaGU6CisgICAgY2FzZSBSZWFzb25Gb3JT dXNwZW5zaW9uOjpQYWdlV2lsbEJlU3VzcGVuZGVkOgorICAgICAgICBtX2FzeW5jRXZlbnRRdWV1 ZS5zdXNwZW5kKCk7CisgICAgICAgIGJyZWFrOworICAgIGNhc2UgUmVhc29uRm9yU3VzcGVuc2lv bjo6SmF2YVNjcmlwdERlYnVnZ2VyUGF1c2VkOgorICAgIGNhc2UgUmVhc29uRm9yU3VzcGVuc2lv bjo6V2lsbERlZmVyTG9hZGluZzoKKyAgICAgICAgLy8gRG8gbm90aGluZywgd2UgZG9uJ3QgcGF1 c2UgbWVkaWEgcGxheWJhY2sgaW4gdGhlc2UgY2FzZXMuCisgICAgICAgIGJyZWFrOworICAgIH0K IH0KIAogdm9pZCBNZWRpYVNvdXJjZTo6cmVzdW1lKCkKIHsKLSAgICBBU1NFUlQoIW1fYXN5bmNF dmVudFF1ZXVlLmhhc1BlbmRpbmdFdmVudHMoKSk7CisgICAgbV9hc3luY0V2ZW50UXVldWUucmVz dW1lKCk7CiB9CiAKIHZvaWQgTWVkaWFTb3VyY2U6OnN0b3AoKQpJbmRleDogU291cmNlL1dlYkNv cmUvTW9kdWxlcy9tZWRpYXNvdXJjZS9Tb3VyY2VCdWZmZXIuY3BwCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFzb3VyY2UvU291cmNlQnVmZmVyLmNwcAkocmV2aXNp b24gMjMzNTU5KQorKysgU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYXNvdXJjZS9Tb3VyY2VC dWZmZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC00NTgsMTQgKzQ1OCwyMyBAQCBib29sIFNvdXJj ZUJ1ZmZlcjo6aGFzUGVuZGluZ0FjdGl2aXR5KCkgCiAgICAgcmV0dXJuIG1fc291cmNlIHx8IG1f YXN5bmNFdmVudFF1ZXVlLmhhc1BlbmRpbmdFdmVudHMoKTsKIH0KIAotdm9pZCBTb3VyY2VCdWZm ZXI6OnN1c3BlbmQoUmVhc29uRm9yU3VzcGVuc2lvbikKK3ZvaWQgU291cmNlQnVmZmVyOjpzdXNw ZW5kKFJlYXNvbkZvclN1c3BlbnNpb24gcmVhc29uKQogewotICAgIEFTU0VSVCghaGFzUGVuZGlu Z0FjdGl2aXR5KCkpOworICAgIHN3aXRjaCAocmVhc29uKSB7CisgICAgY2FzZSBSZWFzb25Gb3JT dXNwZW5zaW9uOjpQYWdlQ2FjaGU6CisgICAgY2FzZSBSZWFzb25Gb3JTdXNwZW5zaW9uOjpQYWdl V2lsbEJlU3VzcGVuZGVkOgorICAgICAgICBtX2FzeW5jRXZlbnRRdWV1ZS5zdXNwZW5kKCk7Cisg ICAgICAgIGJyZWFrOworICAgIGNhc2UgUmVhc29uRm9yU3VzcGVuc2lvbjo6SmF2YVNjcmlwdERl YnVnZ2VyUGF1c2VkOgorICAgIGNhc2UgUmVhc29uRm9yU3VzcGVuc2lvbjo6V2lsbERlZmVyTG9h ZGluZzoKKyAgICAgICAgLy8gRG8gbm90aGluZywgd2UgZG9uJ3QgcGF1c2UgbWVkaWEgcGxheWJh Y2sgaW4gdGhlc2UgY2FzZXMuCisgICAgICAgIGJyZWFrOworICAgIH0KIH0KIAogdm9pZCBTb3Vy Y2VCdWZmZXI6OnJlc3VtZSgpCiB7Ci0gICAgQVNTRVJUKCFoYXNQZW5kaW5nQWN0aXZpdHkoKSk7 CisgICAgbV9hc3luY0V2ZW50UXVldWUucmVzdW1lKCk7CiB9CiAKIHZvaWQgU291cmNlQnVmZmVy OjpzdG9wKCkKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFzb3VyY2UvU291cmNl QnVmZmVyTGlzdC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRp YXNvdXJjZS9Tb3VyY2VCdWZmZXJMaXN0LmNwcAkocmV2aXNpb24gMjMzNTU5KQorKysgU291cmNl L1dlYkNvcmUvTW9kdWxlcy9tZWRpYXNvdXJjZS9Tb3VyY2VCdWZmZXJMaXN0LmNwcAkod29ya2lu ZyBjb3B5KQpAQCAtMTAzLDE0ICsxMDMsMjMgQEAgYm9vbCBTb3VyY2VCdWZmZXJMaXN0OjpjYW5T dXNwZW5kRm9yRG9jdQogICAgIHJldHVybiAhbV9hc3luY0V2ZW50UXVldWUuaGFzUGVuZGluZ0V2 ZW50cygpOwogfQogCi12b2lkIFNvdXJjZUJ1ZmZlckxpc3Q6OnN1c3BlbmQoUmVhc29uRm9yU3Vz cGVuc2lvbikKK3ZvaWQgU291cmNlQnVmZmVyTGlzdDo6c3VzcGVuZChSZWFzb25Gb3JTdXNwZW5z aW9uIHJlYXNvbikKIHsKLSAgICBBU1NFUlQoIW1fYXN5bmNFdmVudFF1ZXVlLmhhc1BlbmRpbmdF dmVudHMoKSk7CisgICAgc3dpdGNoIChyZWFzb24pIHsKKyAgICBjYXNlIFJlYXNvbkZvclN1c3Bl bnNpb246OlBhZ2VDYWNoZToKKyAgICBjYXNlIFJlYXNvbkZvclN1c3BlbnNpb246OlBhZ2VXaWxs QmVTdXNwZW5kZWQ6CisgICAgICAgIG1fYXN5bmNFdmVudFF1ZXVlLnN1c3BlbmQoKTsKKyAgICAg ICAgYnJlYWs7CisgICAgY2FzZSBSZWFzb25Gb3JTdXNwZW5zaW9uOjpKYXZhU2NyaXB0RGVidWdn ZXJQYXVzZWQ6CisgICAgY2FzZSBSZWFzb25Gb3JTdXNwZW5zaW9uOjpXaWxsRGVmZXJMb2FkaW5n OgorICAgICAgICAvLyBEbyBub3RoaW5nLCB3ZSBkb24ndCBwYXVzZSBtZWRpYSBwbGF5YmFjayBp biB0aGVzZSBjYXNlcy4KKyAgICAgICAgYnJlYWs7CisgICAgfQogfQogCiB2b2lkIFNvdXJjZUJ1 ZmZlckxpc3Q6OnJlc3VtZSgpCiB7Ci0gICAgQVNTRVJUKCFtX2FzeW5jRXZlbnRRdWV1ZS5oYXNQ ZW5kaW5nRXZlbnRzKCkpOworICAgIG1fYXN5bmNFdmVudFF1ZXVlLnJlc3VtZSgpOwogfQogCiB2 b2lkIFNvdXJjZUJ1ZmZlckxpc3Q6OnN0b3AoKQpJbmRleDogU291cmNlL1dlYkNvcmUvaHRtbC90 cmFjay9UcmFja0xpc3RCYXNlLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9odG1s L3RyYWNrL1RyYWNrTGlzdEJhc2UuY3BwCShyZXZpc2lvbiAyMzM1NTkpCisrKyBTb3VyY2UvV2Vi Q29yZS9odG1sL3RyYWNrL1RyYWNrTGlzdEJhc2UuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xODAs MTQgKzE4MCwyMyBAQCBib29sIFRyYWNrTGlzdEJhc2U6OmNhblN1c3BlbmRGb3JEb2N1bWVuCiAg ICAgcmV0dXJuICFtX2FzeW5jRXZlbnRRdWV1ZS5oYXNQZW5kaW5nRXZlbnRzKCk7CiB9CiAKLXZv aWQgVHJhY2tMaXN0QmFzZTo6c3VzcGVuZChSZWFzb25Gb3JTdXNwZW5zaW9uKQordm9pZCBUcmFj a0xpc3RCYXNlOjpzdXNwZW5kKFJlYXNvbkZvclN1c3BlbnNpb24gcmVhc29uKQogewotICAgIEFT U0VSVCghbV9hc3luY0V2ZW50UXVldWUuaGFzUGVuZGluZ0V2ZW50cygpKTsKKyAgICBzd2l0Y2gg KHJlYXNvbikgeworICAgIGNhc2UgUmVhc29uRm9yU3VzcGVuc2lvbjo6UGFnZUNhY2hlOgorICAg IGNhc2UgUmVhc29uRm9yU3VzcGVuc2lvbjo6UGFnZVdpbGxCZVN1c3BlbmRlZDoKKyAgICAgICAg bV9hc3luY0V2ZW50UXVldWUuc3VzcGVuZCgpOworICAgICAgICBicmVhazsKKyAgICBjYXNlIFJl YXNvbkZvclN1c3BlbnNpb246OkphdmFTY3JpcHREZWJ1Z2dlclBhdXNlZDoKKyAgICBjYXNlIFJl YXNvbkZvclN1c3BlbnNpb246OldpbGxEZWZlckxvYWRpbmc6CisgICAgICAgIC8vIERvIG5vdGhp bmcsIHdlIGRvbid0IHBhdXNlIG1lZGlhIHBsYXliYWNrIGluIHRoZXNlIGNhc2VzLgorICAgICAg ICBicmVhazsKKyAgICB9CiB9CiAKIHZvaWQgVHJhY2tMaXN0QmFzZTo6cmVzdW1lKCkKIHsKLSAg ICBBU1NFUlQoIW1fYXN5bmNFdmVudFF1ZXVlLmhhc1BlbmRpbmdFdmVudHMoKSk7CisgICAgbV9h c3luY0V2ZW50UXVldWUucmVzdW1lKCk7CiB9CiAKIHZvaWQgVHJhY2tMaXN0QmFzZTo6c3RvcCgp Cg==