187359 2018-07-05 12:53:09 -0700 ProgramExecutable may be collected as we checkSyntax on it 2018-07-19 12:45:11 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 saam saam benjamin commit-queue fpizlo ggaren gskachkov jfbastien keith_miller mark.lam msaboff rmorisset ticaiolima webkit-bug-importer ysuzuki oldest_to_newest 1439507 0 saam 2018-07-05 12:53:09 -0700 The reason this is bad is we call into various functions with a reference to one of ProgramExecutable's fields. We either need to: - drop in a use() on it - Copy the field instead of passing a reference - defer GC (I like the first option) This is already caught by our iOS JSC testing on various tests. 1439517 1 saam 2018-07-05 13:21:02 -0700 Actually, let's do (2) 1439521 2 saam 2018-07-05 13:28:15 -0700 <rdar://problem/41832135> 1439527 3 344358 saam 2018-07-05 13:35:15 -0700 Created attachment 344358 patch 1439528 4 344358 mark.lam 2018-07-05 13:36:26 -0700 Comment on attachment 344358 patch r=me 1439559 5 344358 commit-queue 2018-07-05 14:35:16 -0700 Comment on attachment 344358 patch Clearing flags on attachment: 344358 Committed r233540: <https://trac.webkit.org/changeset/233540> 1439560 6 commit-queue 2018-07-05 14:35:18 -0700 All reviewed patches have been landed. Closing bug. 1443468 7 mark.lam 2018-07-19 12:44:34 -0700 *** Bug 187812 has been marked as a duplicate of this bug. *** 1443470 8 mark.lam 2018-07-19 12:45:11 -0700 *** Bug 187811 has been marked as a duplicate of this bug. *** 344358 2018-07-05 13:35:15 -0700 2018-07-05 14:35:16 -0700 patch a-backup.diff text/plain 1727 saam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjMzNTM3KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBA CisyMDE4LTA3LTA1ICBTYWFtIEJhcmF0aSAgPHNiYXJhdGlAYXBwbGUuY29tPgorCisgICAgICAg IFByb2dyYW1FeGVjdXRhYmxlIG1heSBiZSBjb2xsZWN0ZWQgYXMgd2UgY2hlY2tTeW50YXggb24g aXQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4NzM1 OQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNDE4MzIxMzU+CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIGJ1ZyB3YXMgd2Ugd2VyZSBwYXNzaW5n IGluIGEgcmVmZXJlbmNlIHRvIHRoZSBTb3VyY2VDb2RlIGZpZWxkIG9uIFByb2dyYW1FeGVjdXRh YmxlIGFzCisgICAgICAgIHRoZSBQcm9ncmFtRXhlY3V0YWJsZSBpdHNlbGYgbWF5IGJlIGNvbGxl Y3RlZC4gVGhlIGZpeCBoZXJlIGlzIHRvIG1ha2UgYSBjb3B5CisgICAgICAgIG9mIHRoZSBmaWVs ZCBpbnN0ZWFkIG9mIHBhc3NpbmcgaW4gYSByZWZlcmVuY2UgaW5zaWRlIG9mIFBhcnNlckVycm9y Ojp0b0Vycm9yT2JqZWN0LgorICAgICAgICAKKyAgICAgICAgTm8gbmV3IHRlc3RzIGhlcmUgYXMg dGhpcyB3YXMgYWxyZWFkeSBjYXVnaHQgYnkgb3VyIGlPUyBKU0MgdGVzdGVycy4KKworICAgICAg ICAqIHBhcnNlci9QYXJzZXJFcnJvci5oOgorICAgICAgICAoSlNDOjpQYXJzZXJFcnJvcjo6dG9F cnJvck9iamVjdCk6CisKIDIwMTgtMDctMDQgIFRpbSBIb3J0b24gIDx0aW1vdGh5X2hvcnRvbkBh cHBsZS5jb20+CiAKICAgICAgICAgSW50cm9kdWNlIFBMQVRGT1JNKElPU01BQykKSW5kZXg6IFNv dXJjZS9KYXZhU2NyaXB0Q29yZS9wYXJzZXIvUGFyc2VyRXJyb3IuaAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBT b3VyY2UvSmF2YVNjcmlwdENvcmUvcGFyc2VyL1BhcnNlckVycm9yLmgJKHJldmlzaW9uIDIzMzUz MSkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9wYXJzZXIvUGFyc2VyRXJyb3IuaAkod29ya2lu ZyBjb3B5KQpAQCAtODYsNyArODYsOCBAQCBwdWJsaWM6CiAgICAgRXJyb3JUeXBlIHR5cGUoKSBj b25zdCB7IHJldHVybiBtX3R5cGU7IH0KIAogICAgIEpTT2JqZWN0KiB0b0Vycm9yT2JqZWN0KAot ICAgICAgICBKU0dsb2JhbE9iamVjdCogZ2xvYmFsT2JqZWN0LCBjb25zdCBTb3VyY2VDb2RlJiBz b3VyY2UsIAorICAgICAgICBKU0dsb2JhbE9iamVjdCogZ2xvYmFsT2JqZWN0LAorICAgICAgICBT b3VyY2VDb2RlIHNvdXJjZSwgLy8gTm90ZTogV2UgbXVzdCBjb3B5IHRoZSBzb3VyY2UgaGVyZSwg c2luY2UgdGhlIG9iamVjdHMgdGhhdCBwYXNzIGluIHRoZWlyIFNvdXJjZUNvZGUgZmllbGQgbWF5 IGJlIGRlc3Ryb3llZCBpbiBhZGRFcnJvckluZm8uCiAgICAgICAgIGludCBvdmVycmlkZUxpbmVO dW1iZXIgPSAtMSkKICAgICB7CiAgICAgICAgIEV4ZWNTdGF0ZSogZXhlYyA9IGdsb2JhbE9iamVj dC0+Z2xvYmFsRXhlYygpOwo=