187356 2018-07-05 12:37:21 -0700 Regression(r232886): WebsiteDataStore objects may get destroyed on a background thread 2018-07-05 13:41:56 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 186682 1 cdumez cdumez beidson commit-queue ggaren webkit-bug-importer youennf oldest_to_newest 1439488 0 cdumez 2018-07-05 12:37:21 -0700 As of r232886, CallbackAggregators in WebsiteDataStore hold a Ref<> to their WebsiteDataStore. This is an issue because CallbackAggregator objects can get destroyed on a background thread and may be the last ones holding a ref to the data store. When this happens, the WebsiteDataStore would get destroyed on a background store and potentially cause crashes. Note that even if the callback aggregator would not be the last one to hold a ref to the store, it still would not be safe to deref the store on the background thread since WebsiteDataStore is not ThreadSafeRefCounted. 1439489 1 cdumez 2018-07-05 12:37:37 -0700 <rdar://problem/41854555> 1439495 2 344353 cdumez 2018-07-05 12:41:32 -0700 Created attachment 344353 Patch 1439498 3 344353 cdumez 2018-07-05 12:41:57 -0700 Comment on attachment 344353 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=344353&action=review > Source/WebKit/ChangeLog:17 > + store member on the main thread. Note that we could also have WebsiteDataStore subclass Let me know if you think I should do this instead. 1439512 4 344353 ggaren 2018-07-05 13:14:15 -0700 Comment on attachment 344353 Patch r=me I think this is the best design for now because we generally require our API objects to be used only on the main thread. If we ever want to reconsider that requirement, we can reconsider this change too. 1439533 5 344353 commit-queue 2018-07-05 13:41:54 -0700 Comment on attachment 344353 Patch Clearing flags on attachment: 344353 Committed r233538: <https://trac.webkit.org/changeset/233538> 1439534 6 commit-queue 2018-07-05 13:41:56 -0700 All reviewed patches have been landed. Closing bug. 344353 2018-07-05 12:41:32 -0700 2018-07-05 13:41:54 -0700 Patch bug-187356-20180705124131.patch text/plain 6230 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjMzNTIxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDljYzRhZDNiMjkxZjcwOTk2 YWMwYmU5ODUwMzllZmFhZDI0MGY3OGQuLmU4MzBiOGEwZDM2MGM2ZjgwOWQ3OTg5MjFmZmIxNWQ0 ZDNkMjRiMGYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjkgQEAKKzIwMTgtMDctMDUgIENocmlzIER1 bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KKworICAgICAgICBSZWdyZXNzaW9uKHIyMzI4ODYpOiBX ZWJzaXRlRGF0YVN0b3JlIG9iamVjdHMgbWF5IGdldCBkZXN0cm95ZWQgb24gYSBiYWNrZ3JvdW5k IHRocmVhZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTg3MzU2CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS80MTg1NDU1NT4KKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBcyBvZiByMjMyODg2LCBDYWxsYmFj a0FnZ3JlZ2F0b3JzIGluIFdlYnNpdGVEYXRhU3RvcmUgaG9sZCBhIFJlZjw+IHRvIHRoZWlyIFdl YnNpdGVEYXRhU3RvcmUuIFRoaXMKKyAgICAgICAgaXMgYW4gaXNzdWUgYmVjYXVzZSBDYWxsYmFj a0FnZ3JlZ2F0b3Igb2JqZWN0cyBjYW4gZ2V0IGRlc3Ryb3llZCBvbiBhIGJhY2tncm91bmQgdGhy ZWFkIGFuZCBtYXkgYmUKKyAgICAgICAgdGhlIGxhc3Qgb25lcyBob2xkaW5nIGEgcmVmIHRvIHRo ZSBkYXRhIHN0b3JlLiBXaGVuIHRoaXMgaGFwcGVucywgdGhlIFdlYnNpdGVEYXRhU3RvcmUgd291 bGQgZ2V0CisgICAgICAgIGRlc3Ryb3llZCBvbiBhIGJhY2tncm91bmQgc3RvcmUgYW5kIHBvdGVu dGlhbGx5IGNhdXNlIGNyYXNoZXMuIE5vdGUgdGhhdCBldmVuIGlmIHRoZSBjYWxsYmFjaworICAg ICAgICBhZ2dyZWdhdG9yIHdvdWxkIG5vdCBiZSB0aGUgbGFzdCBvbmUgdG8gaG9sZCBhIHJlZiB0 byB0aGUgc3RvcmUsIGl0IHN0aWxsIHdvdWxkIG5vdCBiZSBzYWZlIHRvIGRlcmVmCisgICAgICAg IHRoZSBzdG9yZSBvbiB0aGUgYmFja2dyb3VuZCB0aHJlYWQgc2luY2UgV2Vic2l0ZURhdGFTdG9y ZSBpcyBub3QgVGhyZWFkU2FmZVJlZkNvdW50ZWQuCisKKyAgICAgICAgVG8gYWRkcmVzcyB0aGUg aXNzdWUsIHRoaXMgcGF0Y2ggdXBkYXRlcyB0aGUgQ2FsbGJhY2tBZ2dyZWdhdG9ycycgZGVzdHJ1 Y3RvciB0byBkZXJlZiB0aGVpciBkYXRhCisgICAgICAgIHN0b3JlIG1lbWJlciBvbiB0aGUgbWFp biB0aHJlYWQuIE5vdGUgdGhhdCB3ZSBjb3VsZCBhbHNvIGhhdmUgV2Vic2l0ZURhdGFTdG9yZSBz dWJjbGFzcworICAgICAgICBUaHJlYWRTYWZlUmVmQ291bnRlZDxULCBEZXN0cnVjdGlvblRocmVh ZDo6TWFpbj4gYnV0IHRoZSBkYXRhIHN0b3JlIHRlY2huaWNhbGx5IGRvZXMgbm90IG5lZWQgdG8K KyAgICAgICAgYmUgVGhyZWFkU2FmZVJlZkNvdW50ZWQgYXQgdGhlIG1vbWVudC4KKworICAgICAg ICAqIFVJUHJvY2Vzcy9XZWJzaXRlRGF0YS9XZWJzaXRlRGF0YVN0b3JlLmNwcDoKKyAgICAgICAg KFdlYktpdDo6V2Vic2l0ZURhdGFTdG9yZTo6V2Vic2l0ZURhdGFTdG9yZSk6CisgICAgICAgIChX ZWJLaXQ6OldlYnNpdGVEYXRhU3RvcmU6On5XZWJzaXRlRGF0YVN0b3JlKToKKyAgICAgICAgKFdl YktpdDo6V2Vic2l0ZURhdGFTdG9yZTo6ZmV0Y2hEYXRhQW5kQXBwbHkpOgorICAgICAgICAoV2Vi S2l0OjpXZWJzaXRlRGF0YVN0b3JlOjpyZW1vdmVEYXRhKToKKwogMjAxOC0wNy0wNSAgUm9iIEJ1 aXMgIDxyYnVpc0BpZ2FsaWEuY29tPgogCiAgICAgICAgIFtHVEtdIFJlbW92ZSBzb3VwL0Rvd25s b2FkU291cEVycm9ycy5oCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJz aXRlRGF0YS9XZWJzaXRlRGF0YVN0b3JlLmNwcCBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1dl YnNpdGVEYXRhL1dlYnNpdGVEYXRhU3RvcmUuY3BwCmluZGV4IDA2ZmM1MDVlZDJiYjlhNTRmYWVk MjE3MTVlYTQzZTBiYmVlMDdjOWIuLjdmMzdlNzg3NzA0YTFmMzc0MmI4ZjdjYzdmYjYwNDZlN2Ji MzI3MDEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1dlYnNpdGVEYXRhL1dl YnNpdGVEYXRhU3RvcmUuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1dlYnNpdGVE YXRhL1dlYnNpdGVEYXRhU3RvcmUuY3BwCkBAIC0xMDAsNiArMTAwLDggQEAgV2Vic2l0ZURhdGFT dG9yZTo6V2Vic2l0ZURhdGFTdG9yZShDb25maWd1cmF0aW9uIGNvbmZpZ3VyYXRpb24sIFBBTDo6 U2Vzc2lvbklEIHMKICAgICBXVEY6OnNldFByb2Nlc3NQcml2aWxlZ2VzKGFsbFByaXZpbGVnZXMo KSk7CiAgICAgbWF5YmVSZWdpc3RlcldpdGhTZXNzaW9uSURNYXAoKTsKICAgICBwbGF0Zm9ybUlu aXRpYWxpemUoKTsKKworICAgIEFTU0VSVChSdW5Mb29wOjppc01haW4oKSk7CiB9CiAKIFdlYnNp dGVEYXRhU3RvcmU6OldlYnNpdGVEYXRhU3RvcmUoUEFMOjpTZXNzaW9uSUQgc2Vzc2lvbklEKQpA QCAtMTA5LDEwICsxMTEsMTQgQEAgV2Vic2l0ZURhdGFTdG9yZTo6V2Vic2l0ZURhdGFTdG9yZShQ QUw6OlNlc3Npb25JRCBzZXNzaW9uSUQpCiB7CiAgICAgbWF5YmVSZWdpc3RlcldpdGhTZXNzaW9u SURNYXAoKTsKICAgICBwbGF0Zm9ybUluaXRpYWxpemUoKTsKKworICAgIEFTU0VSVChSdW5Mb29w Ojppc01haW4oKSk7CiB9CiAKIFdlYnNpdGVEYXRhU3RvcmU6On5XZWJzaXRlRGF0YVN0b3JlKCkK IHsKKyAgICBBU1NFUlQoUnVuTG9vcDo6aXNNYWluKCkpOworCiAgICAgcGxhdGZvcm1EZXN0cm95 KCk7CiAKICAgICBpZiAobV9zZXNzaW9uSUQuaXNWYWxpZCgpICYmIG1fc2Vzc2lvbklEICE9IFBB TDo6U2Vzc2lvbklEOjpkZWZhdWx0U2Vzc2lvbklEKCkpIHsKQEAgLTIzOSwxNyArMjQ1LDIxIEBA IHZvaWQgV2Vic2l0ZURhdGFTdG9yZTo6ZmV0Y2hEYXRhKE9wdGlvblNldDxXZWJzaXRlRGF0YVR5 cGU+IGRhdGFUeXBlcywgT3B0aW9uU2V0CiB2b2lkIFdlYnNpdGVEYXRhU3RvcmU6OmZldGNoRGF0 YUFuZEFwcGx5KE9wdGlvblNldDxXZWJzaXRlRGF0YVR5cGU+IGRhdGFUeXBlcywgT3B0aW9uU2V0 PFdlYnNpdGVEYXRhRmV0Y2hPcHRpb24+IGZldGNoT3B0aW9ucywgUmVmUHRyPFdvcmtRdWV1ZT4m JiBxdWV1ZSwgRnVuY3Rpb248dm9pZChWZWN0b3I8V2Vic2l0ZURhdGFSZWNvcmQ+KT4mJiBhcHBs eSkKIHsKICAgICBzdHJ1Y3QgQ2FsbGJhY2tBZ2dyZWdhdG9yIGZpbmFsIDogVGhyZWFkU2FmZVJl ZkNvdW50ZWQ8Q2FsbGJhY2tBZ2dyZWdhdG9yPiB7Ci0gICAgICAgIGV4cGxpY2l0IENhbGxiYWNr QWdncmVnYXRvcihPcHRpb25TZXQ8V2Vic2l0ZURhdGFGZXRjaE9wdGlvbj4gZmV0Y2hPcHRpb25z LCBSZWZQdHI8V29ya1F1ZXVlPiYmIHF1ZXVlLCBGdW5jdGlvbjx2b2lkKFZlY3RvcjxXZWJzaXRl RGF0YVJlY29yZD4pPiYmIGFwcGx5LCBXZWJzaXRlRGF0YVN0b3JlJiBkYXRhU3RvcmUpCisgICAg ICAgIENhbGxiYWNrQWdncmVnYXRvcihPcHRpb25TZXQ8V2Vic2l0ZURhdGFGZXRjaE9wdGlvbj4g ZmV0Y2hPcHRpb25zLCBSZWZQdHI8V29ya1F1ZXVlPiYmIHF1ZXVlLCBGdW5jdGlvbjx2b2lkKFZl Y3RvcjxXZWJzaXRlRGF0YVJlY29yZD4pPiYmIGFwcGx5LCBXZWJzaXRlRGF0YVN0b3JlJiBkYXRh U3RvcmUpCiAgICAgICAgICAgICA6IGZldGNoT3B0aW9ucyhmZXRjaE9wdGlvbnMpCiAgICAgICAg ICAgICAsIHF1ZXVlKFdURk1vdmUocXVldWUpKQogICAgICAgICAgICAgLCBhcHBseShXVEZNb3Zl KGFwcGx5KSkKICAgICAgICAgICAgICwgcHJvdGVjdGVkRGF0YVN0b3JlKGRhdGFTdG9yZSkKICAg ICAgICAgeworICAgICAgICAgICAgQVNTRVJUKFJ1bkxvb3A6OmlzTWFpbigpKTsKICAgICAgICAg fQogCiAgICAgICAgIH5DYWxsYmFja0FnZ3JlZ2F0b3IoKQogICAgICAgICB7CiAgICAgICAgICAg ICBBU1NFUlQoIXBlbmRpbmdDYWxsYmFja3MpOworCisgICAgICAgICAgICAvLyBNYWtlIHN1cmUg dGhlIGRhdGEgc3RvcmUgZ2V0cyBkZXN0cm95ZWQgb24gdGhlIG1haW4gdGhyZWFkIGV2ZW4gdGhv dWdoIHRoZSBDYWxsYmFja0FnZ3JlZ2F0b3IgY2FuIGdldCBkZXN0cm95ZWQgb24gYSBiYWNrZ3Jv dW5kIHF1ZXVlLgorICAgICAgICAgICAgUnVuTG9vcDo6bWFpbigpLmRpc3BhdGNoKFtwcm90ZWN0 ZWREYXRhU3RvcmUgPSBXVEZNb3ZlKHByb3RlY3RlZERhdGFTdG9yZSldIHsgfSk7CiAgICAgICAg IH0KIAogICAgICAgICB2b2lkIGFkZFBlbmRpbmdDYWxsYmFjaygpCkBAIC02NTMsMTAgKzY2Mywx NyBAQCBzdGF0aWMgUHJvY2Vzc0FjY2Vzc1R5cGUgY29tcHV0ZVdlYlByb2Nlc3NBY2Nlc3NUeXBl Rm9yRGF0YVJlbW92YWwoT3B0aW9uU2V0PFdlYgogdm9pZCBXZWJzaXRlRGF0YVN0b3JlOjpyZW1v dmVEYXRhKE9wdGlvblNldDxXZWJzaXRlRGF0YVR5cGU+IGRhdGFUeXBlcywgV2FsbFRpbWUgbW9k aWZpZWRTaW5jZSwgRnVuY3Rpb248dm9pZCgpPiYmIGNvbXBsZXRpb25IYW5kbGVyKQogewogICAg IHN0cnVjdCBDYWxsYmFja0FnZ3JlZ2F0b3IgOiBUaHJlYWRTYWZlUmVmQ291bnRlZDxDYWxsYmFj a0FnZ3JlZ2F0b3I+IHsKLSAgICAgICAgZXhwbGljaXQgQ2FsbGJhY2tBZ2dyZWdhdG9yKFdlYnNp dGVEYXRhU3RvcmUmIGRhdGFTdG9yZSwgRnVuY3Rpb248dm9pZCgpPiYmIGNvbXBsZXRpb25IYW5k bGVyKQorICAgICAgICBDYWxsYmFja0FnZ3JlZ2F0b3IoV2Vic2l0ZURhdGFTdG9yZSYgZGF0YVN0 b3JlLCBGdW5jdGlvbjx2b2lkKCk+JiYgY29tcGxldGlvbkhhbmRsZXIpCiAgICAgICAgICAgICA6 IGNvbXBsZXRpb25IYW5kbGVyKFdURk1vdmUoY29tcGxldGlvbkhhbmRsZXIpKQogICAgICAgICAg ICAgLCBwcm90ZWN0ZWREYXRhU3RvcmUoZGF0YVN0b3JlKQogICAgICAgICB7CisgICAgICAgICAg ICBBU1NFUlQoUnVuTG9vcDo6aXNNYWluKCkpOworICAgICAgICB9CisKKyAgICAgICAgfkNhbGxi YWNrQWdncmVnYXRvcigpCisgICAgICAgIHsKKyAgICAgICAgICAgIC8vIE1ha2Ugc3VyZSB0aGUg ZGF0YSBzdG9yZSBnZXRzIGRlc3Ryb3llZCBvbiB0aGUgbWFpbiB0aHJlYWQgZXZlbiB0aG91Z2gg dGhlIENhbGxiYWNrQWdncmVnYXRvciBjYW4gZ2V0IGRlc3Ryb3llZCBvbiBhIGJhY2tncm91bmQg cXVldWUuCisgICAgICAgICAgICBSdW5Mb29wOjptYWluKCkuZGlzcGF0Y2goW3Byb3RlY3RlZERh dGFTdG9yZSA9IFdURk1vdmUocHJvdGVjdGVkRGF0YVN0b3JlKV0geyB9KTsKICAgICAgICAgfQog CiAgICAgICAgIHZvaWQgYWRkUGVuZGluZ0NhbGxiYWNrKCkKQEAgLTkxMywxMCArOTMwLDE3IEBA IHZvaWQgV2Vic2l0ZURhdGFTdG9yZTo6cmVtb3ZlRGF0YShPcHRpb25TZXQ8V2Vic2l0ZURhdGFU eXBlPiBkYXRhVHlwZXMsIGNvbnN0IFZlCiAgICAgfQogCiAgICAgc3RydWN0IENhbGxiYWNrQWdn cmVnYXRvciA6IFRocmVhZFNhZmVSZWZDb3VudGVkPENhbGxiYWNrQWdncmVnYXRvcj4gewotICAg ICAgICBleHBsaWNpdCBDYWxsYmFja0FnZ3JlZ2F0b3IoV2Vic2l0ZURhdGFTdG9yZSYgZGF0YVN0 b3JlLCBGdW5jdGlvbjx2b2lkKCk+JiYgY29tcGxldGlvbkhhbmRsZXIpCisgICAgICAgIENhbGxi YWNrQWdncmVnYXRvcihXZWJzaXRlRGF0YVN0b3JlJiBkYXRhU3RvcmUsIEZ1bmN0aW9uPHZvaWQo KT4mJiBjb21wbGV0aW9uSGFuZGxlcikKICAgICAgICAgICAgIDogY29tcGxldGlvbkhhbmRsZXIo V1RGTW92ZShjb21wbGV0aW9uSGFuZGxlcikpCiAgICAgICAgICAgICAsIHByb3RlY3RlZERhdGFT dG9yZShkYXRhU3RvcmUpCiAgICAgICAgIHsKKyAgICAgICAgICAgIEFTU0VSVChSdW5Mb29wOjpp c01haW4oKSk7CisgICAgICAgIH0KKworICAgICAgICB+Q2FsbGJhY2tBZ2dyZWdhdG9yKCkKKyAg ICAgICAgeworICAgICAgICAgICAgLy8gTWFrZSBzdXJlIHRoZSBkYXRhIHN0b3JlIGdldHMgZGVz dHJveWVkIG9uIHRoZSBtYWluIHRocmVhZCBldmVuIHRob3VnaCB0aGUgQ2FsbGJhY2tBZ2dyZWdh dG9yIGNhbiBnZXQgZGVzdHJveWVkIG9uIGEgYmFja2dyb3VuZCBxdWV1ZS4KKyAgICAgICAgICAg IFJ1bkxvb3A6Om1haW4oKS5kaXNwYXRjaChbcHJvdGVjdGVkRGF0YVN0b3JlID0gV1RGTW92ZShw cm90ZWN0ZWREYXRhU3RvcmUpXSB7IH0pOwogICAgICAgICB9CiAKICAgICAgICAgdm9pZCBhZGRQ ZW5kaW5nQ2FsbGJhY2soKQo=