187318 2018-07-04 02:11:22 -0700 Fix some -Wdocumentation warnings in WebKit 2018-07-05 15:21:23 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 thorton thorton andersca commit-queue mitz webkit-bug-importer oldest_to_newest 1439168 0 thorton 2018-07-04 02:11:22 -0700 Fix some -Wdocumentation warnings in WebKit 1439169 1 344270 thorton 2018-07-04 02:11:36 -0700 Created attachment 344270 Patch 1439170 2 thorton 2018-07-04 02:12:51 -0700 The remaining ones are complaining about WKWebView's frequent @description @link WKWebView @/link is KVO compliant blah blah. And complains that the @description is empty. 1439216 3 344270 mitz 2018-07-04 07:02:48 -0700 Comment on attachment 344270 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=344270&action=review > Source/WebKit/ChangeLog:13 > + Define U_HIDE_DEPRECATED_API. It's defined in all other WebKit projects, > + and the doc comments in the deprecated ICU API have some errors. We should just go back to treating the ICU headers as system headers, and thus exempt from warnings. 1439217 4 mitz 2018-07-04 07:03:50 -0700 (In reply to mitz from comment #3) > Comment on attachment 344270 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=344270&action=review > > > Source/WebKit/ChangeLog:13 > > + Define U_HIDE_DEPRECATED_API. It's defined in all other WebKit projects, > > + and the doc comments in the deprecated ICU API have some errors. > > We should just go back to treating the ICU headers as system headers, and > thus exempt from warnings. See bug 183355. 1439582 5 344270 commit-queue 2018-07-05 15:20:14 -0700 Comment on attachment 344270 Patch Clearing flags on attachment: 344270 Committed r233544: <https://trac.webkit.org/changeset/233544> 1439583 6 commit-queue 2018-07-05 15:20:16 -0700 All reviewed patches have been landed. Closing bug. 1439586 7 webkit-bug-importer 2018-07-05 15:21:23 -0700 <rdar://problem/41866876> 344270 2018-07-04 02:11:36 -0700 2018-07-05 15:20:14 -0700 Patch bug-187318-20180704021135.patch text/plain 5027 thorton U3VidmVyc2lvbiBSZXZpc2lvbjogMjMzNDk4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGQxNGEyYWQ3NTVmNjc5ZDI0 ZmU0N2I1OGEzZjdjYTgwMGMwYzUwOGEuLjQxZGFmMzlhZjFkOGU5Yjg3MDc1NjA1YzZiMTViYmVi ZDBiNjBkOTEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjIgQEAKKzIwMTgtMDctMDQgIFRpbSBIb3J0 b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CisKKyAgICAgICAgRml4IHNvbWUgLVdkb2N1 bWVudGF0aW9uIHdhcm5pbmdzIGluIFdlYktpdAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg3MzE4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgRml4IG1vc3Qgb2YgdGhlIC1XZG9jdW1lbnRhdGlvbiB3YXJu aW5ncyBpbiBXZWJLaXQuIFRoZSByZW1haW5pbmcKKyAgICAgICAgb25lcyBhcmUgc2xpZ2h0bHkg bXlzdGVyaW91cywgc28gd2UgY2FuJ3QgdHVybiB0aGUgd2FybmluZyBvbiB5ZXQuCisKKyAgICAg ICAgKiBDb25maWd1cmF0aW9ucy9CYXNlVGFyZ2V0LnhjY29uZmlnOgorICAgICAgICBEZWZpbmUg VV9ISURFX0RFUFJFQ0FURURfQVBJLiBJdCdzIGRlZmluZWQgaW4gYWxsIG90aGVyIFdlYktpdCBw cm9qZWN0cywKKyAgICAgICAgYW5kIHRoZSBkb2MgY29tbWVudHMgaW4gdGhlIGRlcHJlY2F0ZWQg SUNVIEFQSSBoYXZlIHNvbWUgZXJyb3JzLgorCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9Db2Nv YS9XS1VJRGVsZWdhdGUuaDoKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL0NvY29hL1dLV2ViVmll dy5oOgorICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvQ29jb2EvV0tXZWJzaXRlRGF0YVN0b3JlLmg6 CisgICAgICAgIEFkanVzdCBjb21tZW50cyBvciBwYXJhbWV0ZXIgbmFtZXMgdG8gYmUgY29uc2lz dGVudCB3aXRoIGVhY2ggb3RoZXIuCisKIDIwMTgtMDctMDMgIFlvdWVubiBGYWJsZXQgIDx5b3Vl bm5AYXBwbGUuY29tPgogCiAgICAgICAgIFJlbW92ZSBxdWFyYW50aW5lIGZvciBXZWJleCBwbHVn aW4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ29uZmlndXJhdGlvbnMvQmFzZVRhcmdldC54 Y2NvbmZpZyBiL1NvdXJjZS9XZWJLaXQvQ29uZmlndXJhdGlvbnMvQmFzZVRhcmdldC54Y2NvbmZp ZwppbmRleCAwOWI0ZTA5MzdjYzA3MDdmMTczZWZkZjcxMGZjNTBlODFhYmFiNDU1Li5mNjFhMDhk ZTYyNmU2MDVkMTI0MWZkMmE1Zjk0NGQyMTZhZThhMDI1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi S2l0L0NvbmZpZ3VyYXRpb25zL0Jhc2VUYXJnZXQueGNjb25maWcKKysrIGIvU291cmNlL1dlYktp dC9Db25maWd1cmF0aW9ucy9CYXNlVGFyZ2V0LnhjY29uZmlnCkBAIC0zNCw3ICszNCw3IEBAIEZS QU1FV09SS19TRUFSQ0hfUEFUSFMgPSAkKEZSQU1FV09SS19TRUFSQ0hfUEFUSFNfYmFzZSk7CiBT WVNURU1fRlJBTUVXT1JLX1NFQVJDSF9QQVRIUyA9ICQoaW5oZXJpdGVkKSAkKFNES1JPT1QpJChT WVNURU1fTElCUkFSWV9ESVIpL1ByaXZhdGVGcmFtZXdvcmtzICQoU0RLUk9PVCkkKFNZU1RFTV9M SUJSQVJZX0RJUikvRnJhbWV3b3JrczsKIAogR0NDX1BSRUZJWF9IRUFERVIgPSBXZWJLaXQyUHJl Zml4Lmg7Ci1HQ0NfUFJFUFJPQ0VTU09SX0RFRklOSVRJT05TID0gJChERUJVR19ERUZJTkVTKSAk KEZFQVRVUkVfREVGSU5FUykgJChXS19NQU5VQUxfU0FOREJPWElOR19ERUZJTkVTKSAkKFdLX0NP UkVfUFJFRElDVElPTl9ERUZJTkVTKSBVX0RJU0FCTEVfUkVOQU1JTkc9MSBVX1NIT1dfQ1BMVVNQ TFVTX0FQST0wIEZSQU1FV09SS19OQU1FPVdlYktpdDsKK0dDQ19QUkVQUk9DRVNTT1JfREVGSU5J VElPTlMgPSAkKERFQlVHX0RFRklORVMpICQoRkVBVFVSRV9ERUZJTkVTKSAkKFdLX01BTlVBTF9T QU5EQk9YSU5HX0RFRklORVMpICQoV0tfQ09SRV9QUkVESUNUSU9OX0RFRklORVMpIFVfSElERV9E RVBSRUNBVEVEX0FQSSBVX0RJU0FCTEVfUkVOQU1JTkc9MSBVX1NIT1dfQ1BMVVNQTFVTX0FQST0w IEZSQU1FV09SS19OQU1FPVdlYktpdDsKIFdFQktJVEFERElUSU9OU19IRUFERVJfU0VBUkNIX1BB VEhTID0gJChCVUlMVF9QUk9EVUNUU19ESVIpL3Vzci9sb2NhbC9pbmNsdWRlL1dlYktpdEFkZGl0 aW9ucyAkKFNES1JPT1QpL3Vzci9sb2NhbC9pbmNsdWRlL1dlYktpdEFkZGl0aW9uczsKIExJQldF QlJUQ19IRUFERVJfU0VBUkNIX1BBVEhTID0gJChCVUlMVF9QUk9EVUNUU19ESVIpL3Vzci9sb2Nh bC9pbmNsdWRlL3dlYnJ0YyAkKFNES1JPT1QpL3Vzci9sb2NhbC9pbmNsdWRlL3dlYnJ0YzsKIApk aWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL0NvY29hL1dLVUlEZWxlZ2F0 ZS5oIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL0NvY29hL1dLVUlEZWxlZ2F0ZS5oCmlu ZGV4IGQ1YmI2YmU4YmY3ZWU5Nzg3NmIwYWJkMmJmNzY4NmYxODhmMTBjNjkuLjAzZDcxMWJjZDg4 MzdiNmI0ZjE2NDFjNGI4YzZiZGYwZTcxM2I5ZWQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQv VUlQcm9jZXNzL0FQSS9Db2NvYS9XS1VJRGVsZWdhdGUuaAorKysgYi9Tb3VyY2UvV2ViS2l0L1VJ UHJvY2Vzcy9BUEkvQ29jb2EvV0tVSURlbGVnYXRlLmgKQEAgLTEwMiw3ICsxMDIsNyBAQCBOU19B U1NVTUVfTk9OTlVMTF9CRUdJTgogCiAvKiEgQGFic3RyYWN0IERpc3BsYXlzIGEgSmF2YVNjcmlw dCB0ZXh0IGlucHV0IHBhbmVsLgogIEBwYXJhbSB3ZWJWaWV3IFRoZSB3ZWIgdmlldyBpbnZva2lu ZyB0aGUgZGVsZWdhdGUgbWV0aG9kLgotIEBwYXJhbSBtZXNzYWdlIFRoZSBtZXNzYWdlIHRvIGRp c3BsYXkuCisgQHBhcmFtIHByb21wdCBUaGUgcHJvbXB0IHRvIGRpc3BsYXkuCiAgQHBhcmFtIGRl ZmF1bHRUZXh0IFRoZSBpbml0aWFsIHRleHQgdG8gZGlzcGxheSBpbiB0aGUgdGV4dCBlbnRyeSBm aWVsZC4KICBAcGFyYW0gZnJhbWUgSW5mb3JtYXRpb24gYWJvdXQgdGhlIGZyYW1lIHdob3NlIEph dmFTY3JpcHQgaW5pdGlhdGVkIHRoaXMgY2FsbC4KICBAcGFyYW0gY29tcGxldGlvbkhhbmRsZXIg VGhlIGNvbXBsZXRpb24gaGFuZGxlciB0byBjYWxsIGFmdGVyIHRoZSB0ZXh0CmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tXZWJWaWV3LmggYi9Tb3VyY2Uv V2ViS2l0L1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tXZWJWaWV3LmgKaW5kZXggZTdjNDEwMWJlMzg3 MzdiYTMzZmRkMjNlYjliMWFkYjllYTRhNmM3ZC4uOGU5NzgyZjRhZjZkZmRjMWZiYTcwN2JiOTM3 MWVhOTE0YjIzNGVmMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL0Nv Y29hL1dLV2ViVmlldy5oCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9Db2NvYS9X S1dlYlZpZXcuaApAQCAtMTExLDcgKzExMSw3IEBAIFdLX0NMQVNTX0FWQUlMQUJMRShtYWNvc3go MTAuMTApLCBpb3MoOC4wKSkKIC8qISBAYWJzdHJhY3QgU2V0cyB0aGUgd2VicGFnZSBjb250ZW50 cyBhbmQgYmFzZSBVUkwuCiAgQHBhcmFtIGRhdGEgVGhlIGRhdGEgdG8gdXNlIGFzIHRoZSBjb250 ZW50cyBvZiB0aGUgd2VicGFnZS4KICBAcGFyYW0gTUlNRVR5cGUgVGhlIE1JTUUgdHlwZSBvZiB0 aGUgZGF0YS4KLSBAcGFyYW0gZW5jb2RpbmdOYW1lIFRoZSBkYXRhJ3MgY2hhcmFjdGVyIGVuY29k aW5nIG5hbWUuCisgQHBhcmFtIGNoYXJhY3RlckVuY29kaW5nTmFtZSBUaGUgZGF0YSdzIGNoYXJh Y3RlciBlbmNvZGluZyBuYW1lLgogIEBwYXJhbSBiYXNlVVJMIEEgVVJMIHRoYXQgaXMgdXNlZCB0 byByZXNvbHZlIHJlbGF0aXZlIFVSTHMgd2l0aGluIHRoZSBkb2N1bWVudC4KICBAcmVzdWx0IEEg bmV3IG5hdmlnYXRpb24uCiAgKi8KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNz L0FQSS9Db2NvYS9XS1dlYnNpdGVEYXRhU3RvcmUuaCBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNz L0FQSS9Db2NvYS9XS1dlYnNpdGVEYXRhU3RvcmUuaAppbmRleCA0NDY0MzkwMTQ5MmEzMmU2ZmQ0 Nzg3NmQyMzBhNzM5Nzg2YzhmNGIzLi45OTJhMjU1OTRkNThhYWM2MDE4YjNkYTU2NmJjMGI1ZTYx N2Y0YWE0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tX ZWJzaXRlRGF0YVN0b3JlLmgKKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL0NvY29h L1dLV2Vic2l0ZURhdGFTdG9yZS5oCkBAIC03NSw3ICs3NSw3IEBAIFdLX0NMQVNTX0FWQUlMQUJM RShtYWNvc3goMTAuMTEpLCBpb3MoOS4wKSkKICBAcGFyYW0gZGF0ZSBBIGRhdGUuIEFsbCB3ZWJz aXRlIGRhdGEgbW9kaWZpZWQgYWZ0ZXIgdGhpcyBkYXRlIHdpbGwgYmUgcmVtb3ZlZC4KICBAcGFy YW0gY29tcGxldGlvbkhhbmRsZXIgQSBibG9jayB0byBpbnZva2Ugd2hlbiB0aGUgd2Vic2l0ZSBk YXRhIGhhcyBiZWVuIHJlbW92ZWQuCiAqLwotLSAodm9pZClyZW1vdmVEYXRhT2ZUeXBlczooTlNT ZXQ8TlNTdHJpbmcgKj4gKil3ZWJzaXRlRGF0YVR5cGVzIG1vZGlmaWVkU2luY2U6KE5TRGF0ZSAq KWRhdGUgY29tcGxldGlvbkhhbmRsZXI6KHZvaWQgKF4pKHZvaWQpKWNvbXBsZXRpb25IYW5kbGVy OworLSAodm9pZClyZW1vdmVEYXRhT2ZUeXBlczooTlNTZXQ8TlNTdHJpbmcgKj4gKilkYXRhVHlw ZXMgbW9kaWZpZWRTaW5jZTooTlNEYXRlICopZGF0ZSBjb21wbGV0aW9uSGFuZGxlcjoodm9pZCAo Xikodm9pZCkpY29tcGxldGlvbkhhbmRsZXI7CiAKIC8qISBAYWJzdHJhY3QgUmV0dXJucyB0aGUg Y29va2llIHN0b3JlIHJlcHJlc2VudGluZyBIVFRQIGNvb2tpZXMgaW4gdGhpcyB3ZWJzaXRlIGRh dGEgc3RvcmUuICovCiBAcHJvcGVydHkgKG5vbmF0b21pYywgcmVhZG9ubHkpIFdLSFRUUENvb2tp ZVN0b3JlICpodHRwQ29va2llU3RvcmUgV0tfQVBJX0FWQUlMQUJMRShtYWNvc3goMTAuMTMpLCBp b3MoMTEuMCkpOwo=