187309 2018-07-03 16:25:49 -0700 [mac-wk1] Layout Test editing/selection/navigation-clears-editor-state.html is a flaky failure 2018-10-25 09:45:08 -0700 1 1 1 Unclassified WebKit HTML Editing Other Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=187389 https://bugs.webkit.org/show_bug.cgi?id=190890 InRadar P2 Normal --- 1 ryanhaddad saam ap commit-queue mark.lam realdawei rniwa saam tsavell webkit-bug-importer wenson_hsieh oldest_to_newest 1439051 0 ryanhaddad 2018-07-03 16:25:49 -0700 The following layout test is flaky on macOS WK1 editing/selection/navigation-clears-editor-state.html Probable cause: Unknown. This test was added in https://trac.webkit.org/changeset/232434/webkit. It looks like it was flaky since the start, but it has become very flaky recently. The test was modified as part of https://trac.webkit.org/changeset/233236/webkit, which may be the culprit. Flakiness Dashboard: https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=editing%2Fselection%2Fnavigation-clears-editor-state.html --- /Volumes/Data/slave/highsierra-release-tests-wk1/build/layout-test-results/editing/selection/navigation-clears-editor-state-expected.txt +++ /Volumes/Data/slave/highsierra-release-tests-wk1/build/layout-test-results/editing/selection/navigation-clears-editor-state-actual.txt @@ -3,7 +3,7 @@ On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". -PASS freed more than 60 documents +FAIL freed fewer than 60 documents PASS successfullyParsed is true TEST COMPLETE 1439111 1 rniwa 2018-07-03 19:32:12 -0700 Ugh... conservative GC is hard :( 1439467 2 saam 2018-07-05 11:42:15 -0700 We can just make the threshold smaller. 1439556 3 344366 saam 2018-07-05 14:23:22 -0700 Created attachment 344366 patch 1439557 4 344366 mark.lam 2018-07-05 14:25:36 -0700 Comment on attachment 344366 patch r=me 1439558 5 344367 saam 2018-07-05 14:29:35 -0700 Created attachment 344367 patch for landing 1439661 6 344367 commit-queue 2018-07-05 18:35:38 -0700 Comment on attachment 344367 patch for landing Clearing flags on attachment: 344367 Committed r233555: <https://trac.webkit.org/changeset/233555> 1439662 7 commit-queue 2018-07-05 18:35:39 -0700 All reviewed patches have been landed. Closing bug. 1439663 8 webkit-bug-importer 2018-07-05 18:36:21 -0700 <rdar://problem/41873906> 344366 2018-07-05 14:23:22 -0700 2018-07-05 14:29:35 -0700 patch a-backup.diff text/plain 2324 saam SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDIzMzUzOSkKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29y a2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE4LTA3LTA1ICBTYWFtIEJhcmF0aSAgPHNi YXJhdGlAYXBwbGUuY29tPgorCisgICAgICAgIFttYWMtd2sxXSBMYXlvdXQgVGVzdCBlZGl0aW5n L3NlbGVjdGlvbi9uYXZpZ2F0aW9uLWNsZWFycy1lZGl0b3Itc3RhdGUuaHRtbCBpcyBhIGZsYWt5 IGZhaWx1cmUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTE4NzMwOQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IFRyeSB0byBtYWtlIHRoaXMgdGVzdCBsZXNzIGZsYWt5IGJ5IG1ha2luZyBwZXJjZW50cyB0aHJl c2hvbGQgb2YgZnJlZWQKKyAgICAgICAgb2JqZWN0cyBzbWFsbGVyLgorCisgICAgICAgICogZWRp dGluZy9zZWxlY3Rpb24vbmF2aWdhdGlvbi1jbGVhcnMtZWRpdG9yLXN0YXRlLWV4cGVjdGVkLnR4 dDoKKyAgICAgICAgKiBlZGl0aW5nL3NlbGVjdGlvbi9uYXZpZ2F0aW9uLWNsZWFycy1lZGl0b3It c3RhdGUuaHRtbDoKKwogMjAxOC0wNy0wNCAgUnlvc3VrZSBOaXdhICA8cm5pd2FAd2Via2l0Lm9y Zz4KIAogICAgICAgICBZb3V0dWJlIHZpZGVvIHBhZ2VzIGNyYXNoIGFmdGVyIGEgY291cGxlIG9m IG1pbnV0ZXMKSW5kZXg6IExheW91dFRlc3RzL2VkaXRpbmcvc2VsZWN0aW9uL25hdmlnYXRpb24t Y2xlYXJzLWVkaXRvci1zdGF0ZS1leHBlY3RlZC50eHQKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVz dHMvZWRpdGluZy9zZWxlY3Rpb24vbmF2aWdhdGlvbi1jbGVhcnMtZWRpdG9yLXN0YXRlLWV4cGVj dGVkLnR4dAkocmV2aXNpb24gMjMzNTM5KQorKysgTGF5b3V0VGVzdHMvZWRpdGluZy9zZWxlY3Rp b24vbmF2aWdhdGlvbi1jbGVhcnMtZWRpdG9yLXN0YXRlLWV4cGVjdGVkLnR4dAkod29ya2luZyBj b3B5KQpAQCAtMyw3ICszLDcgQEAgVGhpcyB0ZXN0cyBuYXZpZ2F0aW5nIGF3YXkgZnJvbSBhIGRv Y3VtZQogT24gc3VjY2VzcywgeW91IHdpbGwgc2VlIGEgc2VyaWVzIG9mICJQQVNTIiBtZXNzYWdl cywgZm9sbG93ZWQgYnkgIlRFU1QgQ09NUExFVEUiLgogCiAKLVBBU1MgZnJlZWQgbW9yZSB0aGFu IDYwIGRvY3VtZW50cworUEFTUyBmcmVlZCBtb3JlIHRoYW4gMTUlIG9mIGRvY3VtZW50cwogUEFT UyBzdWNjZXNzZnVsbHlQYXJzZWQgaXMgdHJ1ZQogCiBURVNUIENPTVBMRVRFCkluZGV4OiBMYXlv dXRUZXN0cy9lZGl0aW5nL3NlbGVjdGlvbi9uYXZpZ2F0aW9uLWNsZWFycy1lZGl0b3Itc3RhdGUu aHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9lZGl0aW5nL3NlbGVjdGlvbi9uYXZpZ2F0 aW9uLWNsZWFycy1lZGl0b3Itc3RhdGUuaHRtbAkocmV2aXNpb24gMjMzNTM5KQorKysgTGF5b3V0 VGVzdHMvZWRpdGluZy9zZWxlY3Rpb24vbmF2aWdhdGlvbi1jbGVhcnMtZWRpdG9yLXN0YXRlLmh0 bWwJKHdvcmtpbmcgY29weSkKQEAgLTU5LDEwICs1OSwxMCBAQCBhc3luYyBmdW5jdGlvbiBydW5U ZXN0KCkKICAgICAgICAgICAgIEdDQ29udHJvbGxlci5jb2xsZWN0KCk7CiAgICAgICAgICAgICBs ZXQgYWZ0ZXIgPSBpbnRlcm5hbHMubnVtYmVyT2ZMaXZlRG9jdW1lbnRzKCk7CiAgICAgICAgICAg ICBsZXQgZGVsdGEgPSBiZWZvcmUgLSBhZnRlcjsKLSAgICAgICAgICAgIGlmIChkZWx0YSA+IDAu MyAqIGNvdW50KQotICAgICAgICAgICAgICAgIGRlYnVnKCJQQVNTIGZyZWVkIG1vcmUgdGhhbiA2 MCBkb2N1bWVudHMiKTsKKyAgICAgICAgICAgIGlmIChkZWx0YSA+IDAuMTUgKiBjb3VudCkKKyAg ICAgICAgICAgICAgICBkZWJ1ZygiUEFTUyBmcmVlZCBtb3JlIHRoYW4gMTUlIG9mIGRvY3VtZW50 cyIpOwogICAgICAgICAgICAgZWxzZQotICAgICAgICAgICAgICAgIGRlYnVnKCJGQUlMIGZyZWVk IGZld2VyIHRoYW4gNjAgZG9jdW1lbnRzIik7CisgICAgICAgICAgICAgICAgZGVidWcoIkZBSUwg ZnJlZWQgZmV3ZXIgdGhhbiAxNSUgb2YgZG9jdW1lbnRzIik7CiAgICAgICAgICAgICBmaW5pc2hK U1Rlc3QoKTsgICAgICAgICAgICAgICAgCiAgICAgICAgIH07CiAgICAgfQo= 344367 2018-07-05 14:29:35 -0700 2018-07-05 18:35:38 -0700 patch for landing a-backup.diff text/plain 2317 saam SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDIzMzUzOSkKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29y a2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE4LTA3LTA1ICBTYWFtIEJhcmF0aSAgPHNi YXJhdGlAYXBwbGUuY29tPgorCisgICAgICAgIFttYWMtd2sxXSBMYXlvdXQgVGVzdCBlZGl0aW5n L3NlbGVjdGlvbi9uYXZpZ2F0aW9uLWNsZWFycy1lZGl0b3Itc3RhdGUuaHRtbCBpcyBhIGZsYWt5 IGZhaWx1cmUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTE4NzMwOQorCisgICAgICAgIFJldmlld2VkIGJ5IE1hcmsgTGFtLgorCisgICAgICAgIFRyeSB0 byBtYWtlIHRoaXMgdGVzdCBsZXNzIGZsYWt5IGJ5IG1ha2luZyBwZXJjZW50cyB0aHJlc2hvbGQg b2YgZnJlZWQKKyAgICAgICAgb2JqZWN0cyBzbWFsbGVyLgorCisgICAgICAgICogZWRpdGluZy9z ZWxlY3Rpb24vbmF2aWdhdGlvbi1jbGVhcnMtZWRpdG9yLXN0YXRlLWV4cGVjdGVkLnR4dDoKKyAg ICAgICAgKiBlZGl0aW5nL3NlbGVjdGlvbi9uYXZpZ2F0aW9uLWNsZWFycy1lZGl0b3Itc3RhdGUu aHRtbDoKKwogMjAxOC0wNy0wNCAgUnlvc3VrZSBOaXdhICA8cm5pd2FAd2Via2l0Lm9yZz4KIAog ICAgICAgICBZb3V0dWJlIHZpZGVvIHBhZ2VzIGNyYXNoIGFmdGVyIGEgY291cGxlIG9mIG1pbnV0 ZXMKSW5kZXg6IExheW91dFRlc3RzL2VkaXRpbmcvc2VsZWN0aW9uL25hdmlnYXRpb24tY2xlYXJz LWVkaXRvci1zdGF0ZS1leHBlY3RlZC50eHQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZWRp dGluZy9zZWxlY3Rpb24vbmF2aWdhdGlvbi1jbGVhcnMtZWRpdG9yLXN0YXRlLWV4cGVjdGVkLnR4 dAkocmV2aXNpb24gMjMzNTM5KQorKysgTGF5b3V0VGVzdHMvZWRpdGluZy9zZWxlY3Rpb24vbmF2 aWdhdGlvbi1jbGVhcnMtZWRpdG9yLXN0YXRlLWV4cGVjdGVkLnR4dAkod29ya2luZyBjb3B5KQpA QCAtMyw3ICszLDcgQEAgVGhpcyB0ZXN0cyBuYXZpZ2F0aW5nIGF3YXkgZnJvbSBhIGRvY3VtZQog T24gc3VjY2VzcywgeW91IHdpbGwgc2VlIGEgc2VyaWVzIG9mICJQQVNTIiBtZXNzYWdlcywgZm9s bG93ZWQgYnkgIlRFU1QgQ09NUExFVEUiLgogCiAKLVBBU1MgZnJlZWQgbW9yZSB0aGFuIDYwIGRv Y3VtZW50cworUEFTUyBmcmVlZCBtb3JlIHRoYW4gMTUlIG9mIGRvY3VtZW50cwogUEFTUyBzdWNj ZXNzZnVsbHlQYXJzZWQgaXMgdHJ1ZQogCiBURVNUIENPTVBMRVRFCkluZGV4OiBMYXlvdXRUZXN0 cy9lZGl0aW5nL3NlbGVjdGlvbi9uYXZpZ2F0aW9uLWNsZWFycy1lZGl0b3Itc3RhdGUuaHRtbAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9lZGl0aW5nL3NlbGVjdGlvbi9uYXZpZ2F0aW9uLWNs ZWFycy1lZGl0b3Itc3RhdGUuaHRtbAkocmV2aXNpb24gMjMzNTM5KQorKysgTGF5b3V0VGVzdHMv ZWRpdGluZy9zZWxlY3Rpb24vbmF2aWdhdGlvbi1jbGVhcnMtZWRpdG9yLXN0YXRlLmh0bWwJKHdv cmtpbmcgY29weSkKQEAgLTU5LDEwICs1OSwxMCBAQCBhc3luYyBmdW5jdGlvbiBydW5UZXN0KCkK ICAgICAgICAgICAgIEdDQ29udHJvbGxlci5jb2xsZWN0KCk7CiAgICAgICAgICAgICBsZXQgYWZ0 ZXIgPSBpbnRlcm5hbHMubnVtYmVyT2ZMaXZlRG9jdW1lbnRzKCk7CiAgICAgICAgICAgICBsZXQg ZGVsdGEgPSBiZWZvcmUgLSBhZnRlcjsKLSAgICAgICAgICAgIGlmIChkZWx0YSA+IDAuMyAqIGNv dW50KQotICAgICAgICAgICAgICAgIGRlYnVnKCJQQVNTIGZyZWVkIG1vcmUgdGhhbiA2MCBkb2N1 bWVudHMiKTsKKyAgICAgICAgICAgIGlmIChkZWx0YSA+IDAuMTUgKiBjb3VudCkKKyAgICAgICAg ICAgICAgICBkZWJ1ZygiUEFTUyBmcmVlZCBtb3JlIHRoYW4gMTUlIG9mIGRvY3VtZW50cyIpOwog ICAgICAgICAgICAgZWxzZQotICAgICAgICAgICAgICAgIGRlYnVnKCJGQUlMIGZyZWVkIGZld2Vy IHRoYW4gNjAgZG9jdW1lbnRzIik7CisgICAgICAgICAgICAgICAgZGVidWcoIkZBSUwgZnJlZWQg bGVzcyB0aGFuIDE1JSBvZiBkb2N1bWVudHMiKTsKICAgICAgICAgICAgIGZpbmlzaEpTVGVzdCgp OyAgICAgICAgICAgICAgICAKICAgICAgICAgfTsKICAgICB9Cg==