187301 2018-07-03 14:29:18 -0700 [LFC] Generate anonymous inline box for text content. 2018-07-03 15:31:18 -0700 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan bfulgham koivisto simon.fraser webkit-bug-importer zalan oldest_to_newest 1438985 0 zalan 2018-07-03 14:29:18 -0700 ssia. 1438990 1 344220 zalan 2018-07-03 14:34:26 -0700 Created attachment 344220 Patch 1438993 2 344220 koivisto 2018-07-03 14:38:24 -0700 Comment on attachment 344220 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=344220&action=review > Source/WebCore/layout/layouttree/LayoutInlineBox.h:44 > + void setContent(String text) { m_textContent = text; } Maybe setTextContent? 1439021 3 zalan 2018-07-03 15:28:48 -0700 Committed r233482: <https://trac.webkit.org/changeset/233482> 1439022 4 webkit-bug-importer 2018-07-03 15:31:18 -0700 <rdar://problem/41795310> 344220 2018-07-03 14:34:26 -0700 2018-07-03 14:38:24 -0700 Patch bug-187301-20180703143425.patch text/plain 4797 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjMzNDcwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYzM0ZDcyOWRkMzZhMmUy MDVkMTZmZWJhNDA0MjMwMmFkZDE0MGQ1Mi4uODRjMzc4NDMzZDcxNmNmNmFlYTRhMDVlMWNlM2Zj MTFhNDYwY2I3NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE4LTA3LTAzICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW0xGQ10gR2VuZXJhdGUgYW5v bnltb3VzIGlubGluZSBib3ggZm9yIHRleHQgY29udGVudC4KKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4NzMwMQorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFsd2F5cyBoYXZlIGEgaW5saW5lIGNvbnRhaW5l ciBmb3IgdGV4dCBjb250ZW50IChhbmQgbm8gZGVkaWNhdGVkIHRleHQgcmVuZGVyZXIpLiAKKwor ICAgICAgICAqIGxheW91dC9sYXlvdXR0cmVlL0xheW91dElubGluZUJveC5jcHA6CisgICAgICAg IChXZWJDb3JlOjpMYXlvdXQ6OklubGluZUJveDo6SW5saW5lQm94KToKKyAgICAgICAgKiBsYXlv dXQvbGF5b3V0dHJlZS9MYXlvdXRJbmxpbmVCb3guaDoKKyAgICAgICAgKFdlYkNvcmU6OkxheW91 dDo6SW5saW5lQm94OjpzZXRDb250ZW50KToKKyAgICAgICAgKiBsYXlvdXQvbGF5b3V0dHJlZS9M YXlvdXRUcmVlQnVpbGRlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpMYXlvdXQ6OlRyZWVCdWls ZGVyOjpjcmVhdGVTdWJUcmVlKToKKwogMjAxOC0wNy0wMyAgWmFsYW4gQnVqdGFzICA8emFsYW5A YXBwbGUuY29tPgogCiAgICAgICAgIFtMRkNdIEltcGxlbWVudCBtaW5pbXVtL21heGltdW0gY29u dGVudCB3aWR0aCBsb2dpYy4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2xheW91dC9sYXlv dXR0cmVlL0xheW91dElubGluZUJveC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvbGF5b3V0 dHJlZS9MYXlvdXRJbmxpbmVCb3guY3BwCmluZGV4IGZiMTM0ZjcyZTc2YjgxN2NkMTRlOWJmYzEx NWZmY2MxYzIxYmQ1ODguLmVlOWIxMzk3YzdkNTJlOTYyNTNmMzY4ZDE2ZDk5NmYxMGIzYjVlZGIg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2xheW91dC9sYXlvdXR0cmVlL0xheW91dElubGlu ZUJveC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvbGF5b3V0L2xheW91dHRyZWUvTGF5b3V0SW5s aW5lQm94LmNwcApAQCAtMzYsOCArMzYsOCBAQCBuYW1lc3BhY2UgTGF5b3V0IHsKIAogV1RGX01B S0VfSVNPX0FMTE9DQVRFRF9JTVBMKElubGluZUJveCk7CiAKLUlubGluZUJveDo6SW5saW5lQm94 KHN0ZDo6b3B0aW9uYWw8RWxlbWVudEF0dHJpYnV0ZXM+IGF0dHJpYnV0ZXMsIFJlbmRlclN0eWxl JiYgc3R5bGUsIEJhc2VUeXBlRmxhZ3MgYmFzZVR5cGVGbGFncykKLSAgICA6IEJveChhdHRyaWJ1 dGVzLCBXVEZNb3ZlKHN0eWxlKSwgYmFzZVR5cGVGbGFncyB8IElubGluZUJveEZsYWcpCitJbmxp bmVCb3g6OklubGluZUJveChzdGQ6Om9wdGlvbmFsPEVsZW1lbnRBdHRyaWJ1dGVzPiBhdHRyaWJ1 dGVzLCBSZW5kZXJTdHlsZSYmIHN0eWxlKQorICAgIDogQm94KGF0dHJpYnV0ZXMsIFdURk1vdmUo c3R5bGUpLCBJbmxpbmVCb3hGbGFnKQogewogfQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9sYXlvdXQvbGF5b3V0dHJlZS9MYXlvdXRJbmxpbmVCb3guaCBiL1NvdXJjZS9XZWJDb3JlL2xh eW91dC9sYXlvdXR0cmVlL0xheW91dElubGluZUJveC5oCmluZGV4IDI5ZjhhN2QzYzlhNTI1NTMw ZGNiNzM3OTA5N2VlOWUwNzE4NTZiZjguLmVkZjgyYjRmOWU1NzA3NzEzNzU3OGE4M2RmZGUwNmMy M2MyMDg0ZjcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2xheW91dC9sYXlvdXR0cmVlL0xh eW91dElubGluZUJveC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2xheW91dC9sYXlvdXR0cmVlL0xh eW91dElubGluZUJveC5oCkBAIC0zOSw3ICszOSwxMiBAQCBuYW1lc3BhY2UgTGF5b3V0IHsKIGNs YXNzIElubGluZUJveCA6IHB1YmxpYyBCb3ggewogICAgIFdURl9NQUtFX0lTT19BTExPQ0FURUQo SW5saW5lQm94KTsKIHB1YmxpYzoKLSAgICBJbmxpbmVCb3goc3RkOjpvcHRpb25hbDxFbGVtZW50 QXR0cmlidXRlcz4sIFJlbmRlclN0eWxlJiYsIEJhc2VUeXBlRmxhZ3MpOworICAgIElubGluZUJv eChzdGQ6Om9wdGlvbmFsPEVsZW1lbnRBdHRyaWJ1dGVzPiwgUmVuZGVyU3R5bGUmJik7CisKKyAg ICB2b2lkIHNldENvbnRlbnQoU3RyaW5nIHRleHQpIHsgbV90ZXh0Q29udGVudCA9IHRleHQ7IH0K KworcHJpdmF0ZToKKyAgICBTdHJpbmcgbV90ZXh0Q29udGVudDsKIH07CiAKIH0KZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL2xheW91dC9sYXlvdXR0cmVlL0xheW91dFRyZWVCdWlsZGVyLmNw cCBiL1NvdXJjZS9XZWJDb3JlL2xheW91dC9sYXlvdXR0cmVlL0xheW91dFRyZWVCdWlsZGVyLmNw cAppbmRleCAwZjI0ZDViNWM2ZTljNDBjZjc5M2QxMWFkMGVkZTYxMjA0YmUzNGFiLi5lMDM1ZDE4 NmFjNDhkNjg3YzgzMjhkMTBkZTc1YmE3ZGUxMWM5ZGYzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9sYXlvdXQvbGF5b3V0dHJlZS9MYXlvdXRUcmVlQnVpbGRlci5jcHAKKysrIGIvU291cmNl L1dlYkNvcmUvbGF5b3V0L2xheW91dHRyZWUvTGF5b3V0VHJlZUJ1aWxkZXIuY3BwCkBAIC04MSwx NSArODEsMTkgQEAgdm9pZCBUcmVlQnVpbGRlcjo6Y3JlYXRlU3ViVHJlZShjb25zdCBSZW5kZXJF bGVtZW50JiByb290UmVuZGVyZXIsIENvbnRhaW5lciYgcm8KICAgICAgICAgcmV0dXJuIHN0ZDo6 bnVsbG9wdDsKICAgICB9OwogCi0gICAgLy8gU2tpcCBSZW5kZXJUZXh0IChhbmQgc29tZSBvdGhl cnMpIGZvciBub3cuCi0gICAgZm9yIChhdXRvJiBjaGlsZCA6IGNoaWxkcmVuT2ZUeXBlPFJlbmRl ckVsZW1lbnQ+KHJvb3RSZW5kZXJlcikpIHsKKyAgICBmb3IgKGF1dG8mIGNoaWxkIDogY2hpbGRy ZW5PZlR5cGU8UmVuZGVyT2JqZWN0Pihyb290UmVuZGVyZXIpKSB7CiAgICAgICAgIEJveCogYm94 ID0gbnVsbHB0cjsKIAotICAgICAgICBpZiAoaXM8UmVuZGVyQmxvY2s+KGNoaWxkKSkKLSAgICAg ICAgICAgIGJveCA9IG5ldyBCbG9ja0NvbnRhaW5lcihlbGVtZW50QXR0cmlidXRlcyhjaGlsZCks IFJlbmRlclN0eWxlOjpjbG9uZShjaGlsZC5zdHlsZSgpKSk7Ci0gICAgICAgIGVsc2UgaWYgKGlz PFJlbmRlcklubGluZT4oY2hpbGQpKQotICAgICAgICAgICAgYm94ID0gbmV3IElubGluZUNvbnRh aW5lcihlbGVtZW50QXR0cmlidXRlcyhjaGlsZCksIFJlbmRlclN0eWxlOjpjbG9uZShjaGlsZC5z dHlsZSgpKSk7Ci0gICAgICAgIGVsc2UKKyAgICAgICAgaWYgKGlzPFJlbmRlckVsZW1lbnQ+KGNo aWxkKSkgeworICAgICAgICAgICAgYXV0byYgcmVuZGVyZXIgPSBkb3duY2FzdDxSZW5kZXJFbGVt ZW50PihjaGlsZCk7CisgICAgICAgICAgICBpZiAoaXM8UmVuZGVyQmxvY2s+KHJlbmRlcmVyKSkK KyAgICAgICAgICAgICAgICBib3ggPSBuZXcgQmxvY2tDb250YWluZXIoZWxlbWVudEF0dHJpYnV0 ZXMocmVuZGVyZXIpLCBSZW5kZXJTdHlsZTo6Y2xvbmUocmVuZGVyZXIuc3R5bGUoKSkpOworICAg ICAgICAgICAgZWxzZSBpZiAoaXM8UmVuZGVySW5saW5lPihyZW5kZXJlcikpCisgICAgICAgICAg ICAgICAgYm94ID0gbmV3IElubGluZUNvbnRhaW5lcihlbGVtZW50QXR0cmlidXRlcyhyZW5kZXJl ciksIFJlbmRlclN0eWxlOjpjbG9uZShyZW5kZXJlci5zdHlsZSgpKSk7CisgICAgICAgIH0gZWxz ZSBpZiAoaXM8UmVuZGVyVGV4dD4oY2hpbGQpKSB7CisgICAgICAgICAgICBib3ggPSBuZXcgSW5s aW5lQm94KCB7IH0sIFJlbmRlclN0eWxlOjpjcmVhdGVBbm9ueW1vdXNTdHlsZVdpdGhEaXNwbGF5 KHJvb3RSZW5kZXJlci5zdHlsZSgpLCBEaXNwbGF5VHlwZTo6SW5saW5lKSk7CisgICAgICAgICAg ICBkb3duY2FzdDxJbmxpbmVCb3g+KCpib3gpLnNldENvbnRlbnQoZG93bmNhc3Q8UmVuZGVyVGV4 dD4oY2hpbGQpLm9yaWdpbmFsVGV4dCgpKTsKKyAgICAgICAgfSBlbHNlCiAgICAgICAgICAgICBB U1NFUlRfTk9UX0lNUExFTUVOVEVEX1lFVCgpOwogCiAgICAgICAgIGlmICghcm9vdENvbnRhaW5l ci5oYXNDaGlsZCgpKSB7CkBAIC0xMDgsNyArMTEyLDggQEAgdm9pZCBUcmVlQnVpbGRlcjo6Y3Jl YXRlU3ViVHJlZShjb25zdCBSZW5kZXJFbGVtZW50JiByb290UmVuZGVyZXIsIENvbnRhaW5lciYg cm8KICAgICAgICAgICAgIC8vIENvbGxlY3QgdGhlIG91dC1vZi1mbG93IGRlc2NlbmRhbnRzIGF0 IHRoZSBmb3JtYXR0aW5nIHJvb3QgbGV2ZXIgKGFzIG9wcG9zZWQgdG8gYXQgdGhlIGNvbnRhaW5p bmcgYmxvY2sgbGV2ZWwsIHRob3VnaCB0aGV5IG1pZ2h0IGJlIHRoZSBzYW1lKS4KICAgICAgICAg ICAgIGNvbnN0X2Nhc3Q8Q29udGFpbmVyJj4oYm94LT5mb3JtYXR0aW5nQ29udGV4dFJvb3QoKSku YWRkT3V0T2ZGbG93RGVzY2VuZGFudCgqYm94KTsKICAgICAgICAgfQotICAgICAgICBjcmVhdGVT dWJUcmVlKGNoaWxkLCBkb3duY2FzdDxDb250YWluZXI+KCpib3gpKTsKKyAgICAgICAgaWYgKGlz PFJlbmRlckVsZW1lbnQ+KGNoaWxkKSkKKyAgICAgICAgICAgIGNyZWF0ZVN1YlRyZWUoZG93bmNh c3Q8UmVuZGVyRWxlbWVudD4oY2hpbGQpLCBkb3duY2FzdDxDb250YWluZXI+KCpib3gpKTsKICAg ICB9CiB9CiAK