187248 2018-07-02 08:05:05 -0700 YARR: . doesn't match non-BMP Unicode characters in some cases 2018-07-10 10:34:42 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 msaboff msaboff commit-queue ews-watchlist ggaren keith_miller ljharb mark.lam mathias saam webkit-bug-importer oldest_to_newest 1438479 0 msaboff 2018-07-02 08:05:05 -0700 The expression /^.-clef/u.test("\u{1D11E}-clef") should be true, but evaluates to false. The issue is only present when the RegExp JIT is enabled (the default). The YARR interpreter evaluates the expression properly. 1439308 1 msaboff 2018-07-04 22:33:53 -0700 This bug was raised in this GitHub issue thread - https://github.com/kangax/compat-table/issues/1322#issuecomment-401969005 This RE also fails, but should pass: /c.lef/u.test( "c𝄞lef" ) 1440862 2 webkit-bug-importer 2018-07-10 09:18:24 -0700 <rdar://problem/42026714> 1440870 3 msaboff 2018-07-10 09:24:06 -0700 The bug is that the alternative optimizer moved the '.' character class term to after the fixed character terms. The safety check for moving the term did not take into account that the character class is inverted, specifically "not a newline" and therefore the character class' m_hasNonBMPCharacters has an inverted sense. The fix is to check that the character class doesn't have non-BMP character AND it isn't an inverted check of that character class. 1440883 4 344706 msaboff 2018-07-10 09:43:44 -0700 Created attachment 344706 Patch 1440888 5 344706 ggaren 2018-07-10 09:51:32 -0700 Comment on attachment 344706 Patch r=me "Does not not have BMP characters and is not notted". OK. 1440889 6 keith_miller 2018-07-10 09:53:17 -0700 r=me too. 1440899 7 344706 commit-queue 2018-07-10 10:34:41 -0700 Comment on attachment 344706 Patch Clearing flags on attachment: 344706 Committed r233690: <https://trac.webkit.org/changeset/233690> 1440900 8 commit-queue 2018-07-10 10:34:42 -0700 All reviewed patches have been landed. Closing bug. 344706 2018-07-10 09:43:44 -0700 2018-07-10 10:34:41 -0700 Patch 187248.patch text/plain 3294 msaboff SW5kZXg6IEpTVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvQ2hhbmdlTG9n CShyZXZpc2lvbiAyMzM2ODUpCisrKyBKU1Rlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA QCAtMSwzICsxLDE0IEBACisyMDE4LTA3LTEwICBNaWNoYWVsIFNhYm9mZiAgPG1zYWJvZmZAYXBw bGUuY29tPgorCisgICAgICAgIFlBUlI6IC4gZG9lc24ndCBtYXRjaCBub24tQk1QIFVuaWNvZGUg Y2hhcmFjdGVycyBpbiBzb21lIGNhc2VzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xODcyNDgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBOZXcgcmVncmVzc2lvbiB0ZXN0LgorCisgICAgICAgICogc3RyZXNz L3JlZ2V4cC13aXRoLW5vbkJNUC1hbnkuanM6IEFkZGVkLgorCiAyMDE4LTA3LTA5ICBNaWNoYWVs IFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29tPgogCiAgICAgICAgIFJFR1JFU1NJT04gKElDVS02 MjEwMC4wLjEpOiBKU0MgdGVzdCBtb3ppbGxhLXRlc3RzLnlhbWwvZWNtYS9TdHJpbmcvMTUuNS40 LjEyLTMuanMgaXMgZmFpbGluZwpJbmRleDogSlNUZXN0cy9zdHJlc3MvcmVnZXhwLXdpdGgtbm9u Qk1QLWFueS5qcwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKU1Rlc3RzL3N0cmVzcy9yZWdleHAtd2l0aC1ub25C TVAtYW55LmpzCShub25leGlzdGVudCkKKysrIEpTVGVzdHMvc3RyZXNzL3JlZ2V4cC13aXRoLW5v bkJNUC1hbnkuanMJKHdvcmtpbmcgY29weSkKQEAgLTAsMCArMSwxMCBAQAorLy8gVGhpcyB0ZXN0 IHRoYXQgLiBmb2xsb3dlZCBieSBmaXhlZCBjaGFyYWN0ZXIgdGVybXMgd29ya3Mgd2l0aCBub24t Qk1QIGNoYXJhY3RlcnMKKworaWYgKCEvXi4tY2xlZi91LnRlc3QoIlx1ezFEMTIzfS1jbGVmIikp CisgICAgdGhyb3cgIlNob3VsZCBoYXZlIG1hdGNoZWQgc3RyaW5nIHdpdGggbGVhZGluZyBub24t Qk1QIHdpdGggQk9MIGFuY2hvcmVkIC4gaW4gUkUiOworCitpZiAoIS9jLmxlZi91LnRlc3QoImNc dXsxQzM0NX1sZWYiKSkKKyAgICB0aHJvdyAiU2hvdWxkIGhhdmUgbWF0Y2hlZCBzdHJpbmcgd2l0 aCBub24tQk1QIHdpdGggLiBpbiBSRSI7CisKKworCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VM b2cJKHJldmlzaW9uIDIzMzY4MikKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cJ KHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwyMSBAQAorMjAxOC0wNy0xMCAgTWljaGFlbCBTYWJv ZmYgIDxtc2Fib2ZmQGFwcGxlLmNvbT4KKworICAgICAgICBZQVJSOiAuIGRvZXNuJ3QgbWF0Y2gg bm9uLUJNUCBVbmljb2RlIGNoYXJhY3RlcnMgaW4gc29tZSBjYXNlcworICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg3MjQ4CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIHNhZmV0eSBjaGVjayBpbiBvcHRp bWl6ZUFsdGVybmF0aXZlKCkgZm9yIG1vdmluZyBjaGFyYWN0ZXIgY2xhc3NlcyB0aGF0IG9ubHkg Y29uc2lzdCBvZiBCTVAKKyAgICAgICAgY2hhcmFjdGVycyBkaWQgbm90IHRha2UgaW50byBhY2Nv dW50IHRoYXQgdGhlIGNoYXJhY3RlciBjbGFzcyBpcyBpbnZlcnRlZC4gIEluIHRoaXMgY2FzZSwg d2UKKyAgICAgICAgcmVwcmVzZW50ICcuJyBhcyAibm90IGEgbmV3bGluZSIgdXNpbmcgdGhlIG5l d2xpbmUgY2hhcmFjdGVyIGNsYXNzIHdpdGggYW4gaW52ZXJ0ZWQgY2hlY2suCisgICAgICAgIENs ZWFybHkgdGhhdCBpbmNsdWRlcyBub24tQk1QIGNoYXJhY3RlcnMuCisKKyAgICAgICAgVGhlIGZp eCBpcyB0byBjaGVjayB0aGF0IHRoZSBjaGFyYWN0ZXIgY2xhc3MgZG9lc24ndCBoYXZlIG5vbi1C TVAgY2hhcmFjdGVycyBBTkQgaXQgaXNuJ3QgYW4KKyAgICAgICAgaW52ZXJ0ZWQgdXNlIG9mIHRo YXQgY2hhcmFjdGVyIGNsYXNzLgorCisgICAgICAgICogeWFyci9ZYXJySklULmNwcDoKKyAgICAg ICAgKEpTQzo6WWFycjo6WWFyckdlbmVyYXRvcjo6b3B0aW1pemVBbHRlcm5hdGl2ZSk6CisKIDIw MTgtMDctMDkgIE1hcmsgTGFtICA8bWFyay5sYW1AYXBwbGUuY29tPgogCiAgICAgICAgIEFkZCAt LXRyYWNlTExJbnRFeGVjdXRpb24gYW5kIC0tdHJhY2VMTEludFNsb3dQYXRoIG9wdGlvbnMuCklu ZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUveWFyci9ZYXJySklULmNwcAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBTb3VyY2UvSmF2YVNjcmlwdENvcmUveWFyci9ZYXJySklULmNwcAkocmV2aXNpb24gMjMzNjgy KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL3lhcnIvWWFyckpJVC5jcHAJKHdvcmtpbmcgY29w eSkKQEAgLTMyMSw3ICszMjEsNyBAQCBjbGFzcyBZYXJyR2VuZXJhdG9yIDogcHJpdmF0ZSBNYWNy b0Fzc2VtCiAgICAgICAgICAgICAvLyBXZSBjYW4gbW92ZSBCTVAgb25seSBjaGFyYWN0ZXIgY2xh c3NlcyBhZnRlciBmaXhlZCBjaGFyYWN0ZXIgdGVybXMuCiAgICAgICAgICAgICBpZiAoKHRlcm0u dHlwZSA9PSBQYXR0ZXJuVGVybTo6VHlwZUNoYXJhY3RlckNsYXNzKQogICAgICAgICAgICAgICAg ICYmICh0ZXJtLnF1YW50aXR5VHlwZSA9PSBRdWFudGlmaWVyRml4ZWRDb3VudCkKLSAgICAgICAg ICAgICAgICAmJiAoIW1fZGVjb2RlU3Vycm9nYXRlUGFpcnMgfHwgIXRlcm0uY2hhcmFjdGVyQ2xh c3MtPm1faGFzTm9uQk1QQ2hhcmFjdGVycykKKyAgICAgICAgICAgICAgICAmJiAoIW1fZGVjb2Rl U3Vycm9nYXRlUGFpcnMgfHwgKCF0ZXJtLmNoYXJhY3RlckNsYXNzLT5tX2hhc05vbkJNUENoYXJh Y3RlcnMgJiYgIXRlcm0ubV9pbnZlcnQpKQogICAgICAgICAgICAgICAgICYmIChuZXh0VGVybS50 eXBlID09IFBhdHRlcm5UZXJtOjpUeXBlUGF0dGVybkNoYXJhY3RlcikKICAgICAgICAgICAgICAg ICAmJiAobmV4dFRlcm0ucXVhbnRpdHlUeXBlID09IFF1YW50aWZpZXJGaXhlZENvdW50KSkgewog ICAgICAgICAgICAgICAgIFBhdHRlcm5UZXJtIHRlcm1Db3B5ID0gdGVybTsK