187246 2018-07-02 07:19:13 -0700 String buffer is reallocated in FileSystem::fileSystemRepresentation. 2018-07-03 07:44:58 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified NEW P2 Normal --- 1 pvollan pvollan ap oldest_to_newest 1438464 0 pvollan 2018-07-02 07:19:13 -0700 The length of the new string buffer is computed by CFStringGetMaximumSizeOfFileSystemRepresentation, which over-estimates the required length. To save space, the string buffer is currently reallocated before returning the string. Since the returned string is never stored by any callers as far as I can see, reallocating is not necessary. The caller can reallocate the buffer if the string is going to be stored. 1438466 1 344100 pvollan 2018-07-02 07:24:19 -0700 Created attachment 344100 Patch 1438791 2 344100 ap 2018-07-03 02:26:30 -0700 Comment on attachment 344100 Patch svn blame points to http://trac.webkit.org/r149531, which explains why this is necessary. 1438843 3 pvollan 2018-07-03 07:44:58 -0700 (In reply to Alexey Proskuryakov from comment #2) > Comment on attachment 344100 [details] > Patch > > svn blame points to http://trac.webkit.org/r149531, which explains why this > is necessary. Ah, I see. Thanks for reviewing! 344100 2018-07-02 07:24:19 -0700 2018-07-03 02:26:30 -0700 Patch bug-187246-20180702072418.patch text/plain 2569 pvollan SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIzMzQyMSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBACisyMDE4LTA3LTAyICBQZXIgQXJu ZSBWb2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBTdHJpbmcgYnVmZmVyIGlz IHJlYWxsb2NhdGVkIGluIEZpbGVTeXN0ZW06OmZpbGVTeXN0ZW1SZXByZXNlbnRhdGlvbi4KKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4NzI0NgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZSBsZW5ndGgg b2YgdGhlIG5ldyBzdHJpbmcgYnVmZmVyIGlzIGNvbXB1dGVkIGJ5IENGU3RyaW5nR2V0TWF4aW11 bVNpemVPZkZpbGVTeXN0ZW1SZXByZXNlbnRhdGlvbiwKKyAgICAgICAgd2hpY2ggb3Zlci1lc3Rp bWF0ZXMgdGhlIHJlcXVpcmVkIGxlbmd0aC4gVG8gc2F2ZSBzcGFjZSwgdGhlIHN0cmluZyBidWZm ZXIgaXMgY3VycmVudGx5IHJlYWxsb2NhdGVkCisgICAgICAgIGJlZm9yZSByZXR1cm5pbmcgdGhl IHN0cmluZy4gU2luY2UgdGhlIHJldHVybmVkIHN0cmluZyBpcyBuZXZlciBzdG9yZWQgYnkgYW55 IGNhbGxlcnMsIHJlYWxsb2NhdGluZworICAgICAgICBpcyBub3QgbmVjZXNzYXJ5LiBUaGUgY2Fs bGVyIGNhbiByZWFsbG9jYXRlIHRoZSBidWZmZXIgaWYgdGhlIHN0cmluZyBpcyBnb2luZyB0byBi ZSBzdG9yZWQuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLiBObyBjaGFuZ2UgaW4gYmVoYXZpb3Iu CisKKyAgICAgICAgKiBwbGF0Zm9ybS9jZi9GaWxlU3lzdGVtQ0YuY3BwOgorICAgICAgICAoV2Vi Q29yZTo6RmlsZVN5c3RlbTo6ZmlsZVN5c3RlbVJlcHJlc2VudGF0aW9uKToKKwogMjAxOC0wNy0w MSAgRnVqaWkgSGlyb25vcmkgIDxIaXJvbm9yaS5GdWppaUBzb255LmNvbT4KIAogICAgICAgICBb V0syXSBmYXN0L3BhcnNlci9kb2N1bWVudC1vcGVuLWluLXVubG9hZC5odG1sIG1ha2VzIHRoZSBm b2xsb3dpbmcgdGVzdCBjcmFzaApJbmRleDogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vY2YvRmls ZVN5c3RlbUNGLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9jZi9G aWxlU3lzdGVtQ0YuY3BwCShyZXZpc2lvbiAyMzM0MDMpCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9jZi9GaWxlU3lzdGVtQ0YuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zNiw2ICszNiw4IEBA CiAKIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAorLy8gTm90ZTogaWYgeW91IGFyZSBzdG9yaW5nIHRo ZSByZXN1bHQgb2YgdGhpcyBmdW5jdGlvbiBjYWxsLCBjb25zaWRlciByZWFsbG9jYXRpbmcgdGhl IHN0cmluZyBidWZmZXIuCisvLyBUaGUgcmV0dXJuZWQgc3RyaW5nIGJ1ZmZlciBpcyBsYXJnZXIg dGhhbiB3aGF0IGlzIHN0cmljdGx5IG5lZWRlZC4KIENTdHJpbmcgRmlsZVN5c3RlbTo6ZmlsZVN5 c3RlbVJlcHJlc2VudGF0aW9uKGNvbnN0IFN0cmluZyYgcGF0aCkKIHsKICAgICBSZXRhaW5QdHI8 Q0ZTdHJpbmdSZWY+IGNmU3RyaW5nID0gcGF0aC5jcmVhdGVDRlN0cmluZygpOwpAQCAtNDUsMTQg KzQ3LDE4IEBAIENTdHJpbmcgRmlsZVN5c3RlbTo6ZmlsZVN5c3RlbVJlcHJlc2VudGEKIAogICAg IENGSW5kZXggc2l6ZSA9IENGU3RyaW5nR2V0TWF4aW11bVNpemVPZkZpbGVTeXN0ZW1SZXByZXNl bnRhdGlvbihjZlN0cmluZy5nZXQoKSk7CiAKLSAgICBWZWN0b3I8Y2hhcj4gYnVmZmVyKHNpemUp OworICAgIGlmIChzaXplIDw9IDEpCisgICAgICAgIHJldHVybiBDU3RyaW5nKCk7CisKKyAgICBj aGFyKiBidWZmZXIgPSBudWxscHRyOworICAgIENTdHJpbmcgc3RyaW5nID0gQ1N0cmluZzo6bmV3 VW5pbml0aWFsaXplZChzaXplIC0gMSwgYnVmZmVyKTsKIAotICAgIGlmICghQ0ZTdHJpbmdHZXRG aWxlU3lzdGVtUmVwcmVzZW50YXRpb24oY2ZTdHJpbmcuZ2V0KCksIGJ1ZmZlci5kYXRhKCksIGJ1 ZmZlci5zaXplKCkpKSB7CisgICAgaWYgKCFDRlN0cmluZ0dldEZpbGVTeXN0ZW1SZXByZXNlbnRh dGlvbihjZlN0cmluZy5nZXQoKSwgYnVmZmVyLCBzaXplKSkgewogICAgICAgICBMT0dfRVJST1Io IkZhaWxlZCB0byBnZXQgZmlsZXN5c3RlbSByZXByZXNlbnRhdGlvbiB0byBjcmVhdGUgQ1N0cmlu ZyBmcm9tIGNmU3RyaW5nIik7CiAgICAgICAgIHJldHVybiBDU3RyaW5nKCk7CiAgICAgfQogCi0g ICAgcmV0dXJuIENTdHJpbmcoYnVmZmVyLmRhdGEoKSwgc3RybGVuKGJ1ZmZlci5kYXRhKCkpKTsK KyAgICByZXR1cm4gc3RyaW5nOwogfQogCiBTdHJpbmcgRmlsZVN5c3RlbTo6c3RyaW5nRnJvbUZp bGVTeXN0ZW1SZXByZXNlbnRhdGlvbihjb25zdCBjaGFyKiBmaWxlU3lzdGVtUmVwcmVzZW50YXRp b24pCg==