<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>187236</bug_id>
          
          <creation_ts>2018-07-01 12:28:49 -0700</creation_ts>
          <short_desc>[GTK] /webkit/WebKitWebView/mouse-target subtest fails</short_desc>
          <delta_ts>2018-07-03 13:46:00 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>WebKit Local Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>NEW</bug_status>
          <resolution></resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>Gtk, MakingBotsRed, PlatformOnly</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Rob Buis">rbuis</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>bugs-noreply</cc>
    
    <cc>calvaris</cc>
    
    <cc>cgarcia</cc>
    
    <cc>clopez</cc>
    
    <cc>dbates</cc>
    
    <cc>lforschler</cc>
    
    <cc>mcatanzaro</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1438324</commentid>
    <comment_count>0</comment_count>
    <who name="Rob Buis">rbuis</who>
    <bug_when>2018-07-01 12:28:49 -0700</bug_when>
    <thetext>/webkit/WebKitWebView/mouse-target from TestUIClient run FAILs.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1438327</commentid>
    <comment_count>1</comment_count>
      <attachid>344057</attachid>
    <who name="Rob Buis">rbuis</who>
    <bug_when>2018-07-01 12:40:30 -0700</bug_when>
    <thetext>Created attachment 344057
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1438350</commentid>
    <comment_count>2</comment_count>
      <attachid>344057</attachid>
    <who name="Daniel Bates">dbates</who>
    <bug_when>2018-07-01 15:25:38 -0700</bug_when>
    <thetext>Comment on attachment 344057
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=344057&amp;action=review

&gt; Tools/ChangeLog:9
&gt; +        video URL is not exposed this will fail. So allow local file access for the video

Can you please elaborate on what you mean by &quot;the local video URL is not exposed&quot;?

&gt; Tools/TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:682
&gt; +    WebKitSettings* settings = webkit_web_view_get_settings(test-&gt;m_webView);
&gt; +    webkit_settings_set_allow_universal_access_from_file_urls(settings, TRUE);

Can you please explain why we need to universal access? I mean, this test only loads subresources with file URLs. (The markup is substituted for the request with URL file://// and movie.org is computed relative to it, file:///movie.ogg).</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1438353</commentid>
    <comment_count>3</comment_count>
    <who name="Daniel Bates">dbates</who>
    <bug_when>2018-07-01 15:38:42 -0700</bug_when>
    <thetext>(In reply to Rob Buis from comment #0)
&gt; /webkit/WebKitWebView/mouse-target from TestUIClient run FAILs.

For completeness, here is the error from the GTK Linux 64-bit Debug Tests bot that you are referring to:

[[
  /webkit/WebKitWebView/mouse-target:                                 FAIL
ERROR:/home/slave/webkitgtk/gtk-linux-64-debug/build/Tools/TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:734:void testWebViewMouseTarget(UIClientTest*, gconstpointer): assertion failed: (webkit_hit_test_result_context_is_media(hitTestResult))
]]
&lt;https://build.webkit.org/builders/GTK%20Linux%2064-bit%20Debug%20%28Tests%29/builds/3307/steps/API%20tests/logs/stdio&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1438356</commentid>
    <comment_count>4</comment_count>
      <attachid>344057</attachid>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2018-07-01 15:44:56 -0700</bug_when>
    <thetext>Comment on attachment 344057
Patch

Thanks for caring for the API tests, Rob! These are important and their current condition is embarrassing.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1438561</commentid>
    <comment_count>5</comment_count>
      <attachid>344118</attachid>
    <who name="Rob Buis">rbuis</who>
    <bug_when>2018-07-02 11:21:55 -0700</bug_when>
    <thetext>Created attachment 344118
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1438562</commentid>
    <comment_count>6</comment_count>
    <who name="Rob Buis">rbuis</who>
    <bug_when>2018-07-02 11:23:29 -0700</bug_when>
    <thetext>(In reply to Daniel Bates from comment #2)
&gt; Comment on attachment 344057 [details]
&gt; Patch
&gt; 
&gt; View in context:
&gt; https://bugs.webkit.org/attachment.cgi?id=344057&amp;action=review
&gt; 
&gt; &gt; Tools/ChangeLog:9
&gt; &gt; +        video URL is not exposed this will fail. So allow local file access for the video
&gt; 
&gt; Can you please elaborate on what you mean by &quot;the local video URL is not
&gt; exposed&quot;?
&gt; 
&gt; &gt; Tools/TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:682
&gt; &gt; +    WebKitSettings* settings = webkit_web_view_get_settings(test-&gt;m_webView);
&gt; &gt; +    webkit_settings_set_allow_universal_access_from_file_urls(settings, TRUE);
&gt; 
&gt; Can you please explain why we need to universal access? I mean, this test
&gt; only loads subresources with file URLs. (The markup is substituted for the
&gt; request with URL file://// and movie.org is computed relative to it,
&gt; file:///movie.ogg).

Sorry my previous ChangeLog entry was a bit terse, I tried to phrase it better this time. Let me know if it needs even more rephrasing or you think this is the wrong approach.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1438590</commentid>
    <comment_count>7</comment_count>
    <who name="Daniel Bates">dbates</who>
    <bug_when>2018-07-02 12:58:25 -0700</bug_when>
    <thetext>(In reply to Rob Buis from comment #6)
&gt; (In reply to Daniel Bates from comment #2)
&gt; &gt; Comment on attachment 344057 [details]
&gt; &gt; Patch
&gt; &gt; 
&gt; &gt; View in context:
&gt; &gt; https://bugs.webkit.org/attachment.cgi?id=344057&amp;action=review
&gt; &gt; 
&gt; &gt; &gt; Tools/ChangeLog:9
&gt; &gt; &gt; +        video URL is not exposed this will fail. So allow local file access for the video
&gt; &gt; 
&gt; &gt; Can you please elaborate on what you mean by &quot;the local video URL is not
&gt; &gt; exposed&quot;?
&gt; &gt; 
&gt; &gt; &gt; Tools/TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:682
&gt; &gt; &gt; +    WebKitSettings* settings = webkit_web_view_get_settings(test-&gt;m_webView);
&gt; &gt; &gt; +    webkit_settings_set_allow_universal_access_from_file_urls(settings, TRUE);
&gt; &gt; 
&gt; &gt; Can you please explain why we need to universal access? I mean, this test
&gt; &gt; only loads subresources with file URLs. (The markup is substituted for the
&gt; &gt; request with URL file://// and movie.org is computed relative to it,
&gt; &gt; file:///movie.ogg).
&gt; 
&gt; Sorry my previous ChangeLog entry was a bit terse, I tried to phrase it
&gt; better this time. Let me know if it needs even more rephrasing or you think
&gt; this is the wrong approach.

The revised ChangeLog does not explain why a local file cannot load a local file as a subresource. Can you please explain this?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1438596</commentid>
    <comment_count>8</comment_count>
    <who name="Rob Buis">rbuis</who>
    <bug_when>2018-07-02 13:20:15 -0700</bug_when>
    <thetext>(In reply to Daniel Bates from comment #7)
&gt; (In reply to Rob Buis from comment #6)
&gt; &gt; (In reply to Daniel Bates from comment #2)
&gt; &gt; &gt; Comment on attachment 344057 [details]
&gt; &gt; &gt; Patch
&gt; &gt; &gt; 
&gt; &gt; &gt; View in context:
&gt; &gt; &gt; https://bugs.webkit.org/attachment.cgi?id=344057&amp;action=review
&gt; &gt; &gt; 
&gt; &gt; &gt; &gt; Tools/ChangeLog:9
&gt; &gt; &gt; &gt; +        video URL is not exposed this will fail. So allow local file access for the video
&gt; &gt; &gt; 
&gt; &gt; &gt; Can you please elaborate on what you mean by &quot;the local video URL is not
&gt; &gt; &gt; exposed&quot;?
&gt; &gt; &gt; 
&gt; &gt; &gt; &gt; Tools/TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:682
&gt; &gt; &gt; &gt; +    WebKitSettings* settings = webkit_web_view_get_settings(test-&gt;m_webView);
&gt; &gt; &gt; &gt; +    webkit_settings_set_allow_universal_access_from_file_urls(settings, TRUE);
&gt; &gt; &gt; 
&gt; &gt; &gt; Can you please explain why we need to universal access? I mean, this test
&gt; &gt; &gt; only loads subresources with file URLs. (The markup is substituted for the
&gt; &gt; &gt; request with URL file://// and movie.org is computed relative to it,
&gt; &gt; &gt; file:///movie.ogg).
&gt; &gt; 
&gt; &gt; Sorry my previous ChangeLog entry was a bit terse, I tried to phrase it
&gt; &gt; better this time. Let me know if it needs even more rephrasing or you think
&gt; &gt; this is the wrong approach.
&gt; 
&gt; The revised ChangeLog does not explain why a local file cannot load a local
&gt; file as a subresource. Can you please explain this?

&quot;local file cannot load a local file as a subresource&quot;? What file do you mean?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1438634</commentid>
    <comment_count>9</comment_count>
    <who name="Daniel Bates">dbates</who>
    <bug_when>2018-07-02 14:34:11 -0700</bug_when>
    <thetext>(In reply to Rob Buis from comment #8)
&gt; (In reply to Daniel Bates from comment #7)
&gt; &gt; (In reply to Rob Buis from comment #6)
&gt; &gt; &gt; (In reply to Daniel Bates from comment #2)
&gt; &gt; &gt; &gt; Comment on attachment 344057 [details]
&gt; &gt; &gt; &gt; Patch
&gt; &gt; &gt; &gt; 
&gt; &gt; &gt; &gt; View in context:
&gt; &gt; &gt; &gt; https://bugs.webkit.org/attachment.cgi?id=344057&amp;action=review
&gt; &gt; &gt; &gt; 
&gt; &gt; &gt; &gt; &gt; Tools/ChangeLog:9
&gt; &gt; &gt; &gt; &gt; +        video URL is not exposed this will fail. So allow local file access for the video
&gt; &gt; &gt; &gt; 
&gt; &gt; &gt; &gt; Can you please elaborate on what you mean by &quot;the local video URL is not
&gt; &gt; &gt; &gt; exposed&quot;?
&gt; &gt; &gt; &gt; 
&gt; &gt; &gt; &gt; &gt; Tools/TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:682
&gt; &gt; &gt; &gt; &gt; +    WebKitSettings* settings = webkit_web_view_get_settings(test-&gt;m_webView);
&gt; &gt; &gt; &gt; &gt; +    webkit_settings_set_allow_universal_access_from_file_urls(settings, TRUE);
&gt; &gt; &gt; &gt; 
&gt; &gt; &gt; &gt; Can you please explain why we need to universal access? I mean, this test
&gt; &gt; &gt; &gt; only loads subresources with file URLs. (The markup is substituted for the
&gt; &gt; &gt; &gt; request with URL file://// and movie.org is computed relative to it,
&gt; &gt; &gt; &gt; file:///movie.ogg).
&gt; &gt; &gt; 
&gt; &gt; &gt; Sorry my previous ChangeLog entry was a bit terse, I tried to phrase it
&gt; &gt; &gt; better this time. Let me know if it needs even more rephrasing or you think
&gt; &gt; &gt; this is the wrong approach.
&gt; &gt; 
&gt; &gt; The revised ChangeLog does not explain why a local file cannot load a local
&gt; &gt; file as a subresource. Can you please explain this?
&gt; 
&gt; &quot;local file cannot load a local file as a subresource&quot;? What file do you
&gt; mean?
 
The unit test code is loading the markup as substitute data for a file URL (i.e. we mimic a local file). This markup contains a &lt;video&gt; That loads file:///movie.ogg (a local file).</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1438695</commentid>
    <comment_count>10</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2018-07-02 16:36:09 -0700</bug_when>
    <thetext>By default, file URIs do not have permission to load other file URIs. That&apos;s controlled by the property WebKitSettings::allow-file-access-from-file-urls.

It might be sufficient to use webkit_settings_set_allow_file_access_from_file_urls() instead of the more heavyweight webkit_settings_set_allow_universal_access_from_file_urls() (which additionally allows access to e.g. localstorage). If so, that would be preferable.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1438958</commentid>
    <comment_count>11</comment_count>
    <who name="Rob Buis">rbuis</who>
    <bug_when>2018-07-03 13:46:00 -0700</bug_when>
    <thetext>(In reply to Michael Catanzaro from comment #10)
&gt; By default, file URIs do not have permission to load other file URIs. That&apos;s
&gt; controlled by the property WebKitSettings::allow-file-access-from-file-urls.
&gt; 
&gt; It might be sufficient to use
&gt; webkit_settings_set_allow_file_access_from_file_urls() instead of the more
&gt; heavyweight webkit_settings_set_allow_universal_access_from_file_urls()
&gt; (which additionally allows access to e.g. localstorage). If so, that would
&gt; be preferable.

I tried webkit_settings_set_allow_file_access_from_file_urls, unfortunately that is not enough to make the test PASS.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>344057</attachid>
            <date>2018-07-01 12:40:30 -0700</date>
            <delta_ts>2018-07-02 11:21:48 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-187236-20180701214028.patch</filename>
            <type>text/plain</type>
            <size>2901</size>
            <attacher name="Rob Buis">rbuis</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjMzMzk5CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg
Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYjA3YjZiNGQ5ODRhZGYyZmE4NmFhYzkwNzI3MzVkYmIy
YWJmNjBlMC4uZmJkZjk2NGEwOGQzMTZiNTZlNDczMjZjMDI5ZWI2ZDJiYWI1YjUxZiAxMDA2NDQK
LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4
IEBACisyMDE4LTA3LTAxICBSb2IgQnVpcyAgPHJidWlzQGlnYWxpYS5jb20+CisKKyAgICAgICAg
W0dUS10gL3dlYmtpdC9XZWJLaXRXZWJWaWV3L21vdXNlLXRhcmdldCBzdWJ0ZXN0IGZhaWxzCisg
ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODcyMzYKKwor
ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgc3VidGVz
dCBtb3VzZS10YXJnZXQgbmVlZHMgdGhlIHZpZGVvIGVsZW1lbnQgYXMgaGl0IHRlc3QgdXJsLCBo
b3dldmVyIHNpbmNlIHRoZSBsb2NhbAorICAgICAgICB2aWRlbyBVUkwgaXMgbm90IGV4cG9zZWQg
dGhpcyB3aWxsIGZhaWwuIFNvIGFsbG93IGxvY2FsIGZpbGUgYWNjZXNzIGZvciB0aGUgdmlkZW8K
KyAgICAgICAgdGhpcyB0ZXN0IHRvIFBBU1MgYW5kIHJlc2V0IGl0IGFmdGVyd2FyZHMuCisKKyAg
ICAgICAgKiBUZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdEdMaWIvVGVzdFVJQ2xpZW50LmNwcDoK
KyAgICAgICAgKHRlc3RXZWJWaWV3TW91c2VUYXJnZXQpOgorICAgICAgICAqIFRlc3RXZWJLaXRB
UEkvZ2xpYi9UZXN0RXhwZWN0YXRpb25zLmpzb246CisKIDIwMTgtMDYtMzAgIFRoaWJhdWx0IFNh
dW5pZXIgIDx0c2F1bmllckBpZ2FsaWEuY29tPgogCiAgICAgICAgIE1ha2UgY2hlY2tfZmxhdHBh
aygpIG5vdCB2ZXJib3NlIHdoZW4gb25seSB0cnlpbmcgdG8gcnVuIGNvbW1hbmQgaW5zaWRlIGZs
YXRwYWsKZGlmZiAtLWdpdCBhL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0R0xpYi9U
ZXN0VUlDbGllbnQuY3BwIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXRHTGliL1Rl
c3RVSUNsaWVudC5jcHAKaW5kZXggNjkzOTEwMmZkMzE4ZGZiZTQwZTQ5M2JlM2M3YTM3NWU3Y2Q1
Y2M0OS4uZWQzOTgzNzU5NzJjNDczNDJjNzk2YWEyMjM5NTYwNTJhZWMxNzliNiAxMDA2NDQKLS0t
IGEvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXRHTGliL1Rlc3RVSUNsaWVudC5jcHAK
KysrIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXRHTGliL1Rlc3RVSUNsaWVudC5j
cHAKQEAgLTY3OCw2ICs2NzgsOSBAQCBzdGF0aWMgdm9pZCB0ZXN0V2ViVmlld01vdXNlVGFyZ2V0
KFVJQ2xpZW50VGVzdCogdGVzdCwgZ2NvbnN0cG9pbnRlcikKICAgICAgICAgIiA8cCBzdHlsZT0n
cG9zaXRpb246YWJzb2x1dGU7IGxlZnQ6MTsgdG9wOjEyMCcgaWQ9J3RleHRfdG9fc2VsZWN0Jz5M
b3JlbSBpcHN1bS48L3A+IgogICAgICAgICAiPC9ib2R5PjwvaHRtbD4iOwogCisgICAgV2ViS2l0
U2V0dGluZ3MqIHNldHRpbmdzID0gd2Via2l0X3dlYl92aWV3X2dldF9zZXR0aW5ncyh0ZXN0LT5t
X3dlYlZpZXcpOworICAgIHdlYmtpdF9zZXR0aW5nc19zZXRfYWxsb3dfdW5pdmVyc2FsX2FjY2Vz
c19mcm9tX2ZpbGVfdXJscyhzZXR0aW5ncywgVFJVRSk7CisKICAgICB0ZXN0LT5sb2FkSHRtbChs
aW5rc0hvdmVyZWRIVE1MLCAiZmlsZTovLy8iKTsKICAgICB0ZXN0LT53YWl0VW50aWxMb2FkRmlu
aXNoZWQoKTsKIApAQCAtNzY3LDYgKzc3MCw4IEBAIHN0YXRpYyB2b2lkIHRlc3RXZWJWaWV3TW91
c2VUYXJnZXQoVUlDbGllbnRUZXN0KiB0ZXN0LCBnY29uc3Rwb2ludGVyKQogICAgIGdfYXNzZXJ0
KCF3ZWJraXRfaGl0X3Rlc3RfcmVzdWx0X2NvbnRleHRfaXNfc2Nyb2xsYmFyKGhpdFRlc3RSZXN1
bHQpKTsKICAgICBnX2Fzc2VydCh3ZWJraXRfaGl0X3Rlc3RfcmVzdWx0X2NvbnRleHRfaXNfc2Vs
ZWN0aW9uKGhpdFRlc3RSZXN1bHQpKTsKICAgICBnX2Fzc2VydCghdGVzdC0+bV9tb3VzZVRhcmdl
dE1vZGlmaWVycyk7CisKKyAgICB3ZWJraXRfc2V0dGluZ3Nfc2V0X2FsbG93X3VuaXZlcnNhbF9h
Y2Nlc3NfZnJvbV9maWxlX3VybHMoc2V0dGluZ3MsIEZBTFNFKTsKIH0KICNlbmRpZiAvLyBQTEFU
Rk9STShHVEspCiAKZGlmZiAtLWdpdCBhL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvZ2xpYi9UZXN0RXhw
ZWN0YXRpb25zLmpzb24gYi9Ub29scy9UZXN0V2ViS2l0QVBJL2dsaWIvVGVzdEV4cGVjdGF0aW9u
cy5qc29uCmluZGV4IGU0ZGI4ZGEwN2YxYjlhOTNjM2I4YWY0Y2Q5Y2E2Yzg3ZTNhZjhlZmUuLjll
YWI1YWQwNzQzZjMyZDYxMmI1MDIwN2FiZmI2NzNiZDA0ZmQxM2EgMTAwNjQ0Ci0tLSBhL1Rvb2xz
L1Rlc3RXZWJLaXRBUEkvZ2xpYi9UZXN0RXhwZWN0YXRpb25zLmpzb24KKysrIGIvVG9vbHMvVGVz
dFdlYktpdEFQSS9nbGliL1Rlc3RFeHBlY3RhdGlvbnMuanNvbgpAQCAtMSw5ICsxLDYgQEAKIHsK
ICAgICAiVGVzdFVJQ2xpZW50IjogewogICAgICAgICAic3VidGVzdHMiOiB7Ci0gICAgICAgICAg
ICAiL3dlYmtpdC9XZWJLaXRXZWJWaWV3L21vdXNlLXRhcmdldCI6IHsKLSAgICAgICAgICAgICAg
ICAiZXhwZWN0ZWQiOiB7Imd0ayI6IHsic3RhdHVzIjogWyJUSU1FT1VUIiwgIkZBSUwiXSwgImJ1
ZyI6ICJ3ZWJraXQub3JnL2IvMTE3Njg5In19Ci0gICAgICAgICAgICB9LAogICAgICAgICAgICAg
Ii93ZWJraXQvV2ViS2l0V2ViVmlldy91c2VybWVkaWEtcGVybWlzc2lvbi1yZXF1ZXN0cyI6IHsK
ICAgICAgICAgICAgICAgICAiZXhwZWN0ZWQiOiB7Imd0ayI6IHsic3RhdHVzIjogWyJUSU1FT1VU
Il0sICJidWciOiAid2Via2l0Lm9yZy9iLzE1ODI1NyJ9fQogICAgICAgICAgICAgfSwK
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>344118</attachid>
            <date>2018-07-02 11:21:55 -0700</date>
            <delta_ts>2018-07-02 11:33:14 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-187236-20180702202153.patch</filename>
            <type>text/plain</type>
            <size>3138</size>
            <attacher name="Rob Buis">rbuis</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjMzNDE1CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg
Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggOTU3YzYyYzlmOWNkYjc3NzEwMDM0OTA4MDMyNDkxOGVk
MmYxMzdmNy4uZDVhMzgzMTdjYjI5YjkxOTIyNGVhM2MyNmY3YmM3MzlhNGU1NzVhZSAxMDA2NDQK
LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIw
IEBACisyMDE4LTA3LTAxICBSb2IgQnVpcyAgPHJidWlzQGlnYWxpYS5jb20+CisKKyAgICAgICAg
W0dUS10gL3dlYmtpdC9XZWJLaXRXZWJWaWV3L21vdXNlLXRhcmdldCBzdWJ0ZXN0IGZhaWxzCisg
ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODcyMzYKKwor
ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgc3VidGVz
dCBtb3VzZS10YXJnZXQgcmVsaWVzIG9uIHdlYmtpdF9oaXRfdGVzdF9yZXN1bHRfY29udGV4dF9p
c19tZWRpYSwgd2hpY2ggaW4KKyAgICAgICAgdHVybiByZWxpZXMgb24gSGl0VGVzdFJlc3VsdDo6
YWJzb2x1dGVNZWRpYVVSTCwgd2hpY2ggZmluYWxseSByZWxpZXMgb24gSFRNTE1lZGlhRWxlbWVu
dDo6Y3VycmVudFNyYy4KKyAgICAgICAgSG93ZXZlciBIVE1MTWVkaWFFbGVtZW50OjpjdXJyZW50
U3JjIGRvZXMgbm90IGV4cG9zZSB0aGUgVVJMIHNpbmNlIGJ5IGRlZmF1bHQgYWNjZXNzIHRvIGxv
Y2FsIGZpbGUKKyAgICAgICAgc3lzdGVtIGlzIG5vdCBhbGxvd2VkIGFuZCB0aGUgbG9hZCBvZiB0
aGUgcmVzb3VyY2UgZmFpbHMuIFNvIGFsbG93IGFjY2VzcyB0byBsb2NhbCBmaWxlIHN5c3RlbSBm
b3IKKyAgICAgICAgdGhlIHZpZGVvIGZvciB0aGlzIHRlc3QgdG8gUEFTUyBhbmQgcmVzZXQgaXQg
YWZ0ZXJ3YXJkcy4KKworICAgICAgICAqIFRlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0R0xpYi9U
ZXN0VUlDbGllbnQuY3BwOgorICAgICAgICAodGVzdFdlYlZpZXdNb3VzZVRhcmdldCk6CisgICAg
ICAgICogVGVzdFdlYktpdEFQSS9nbGliL1Rlc3RFeHBlY3RhdGlvbnMuanNvbjoKKwogMjAxOC0w
Ny0wMSAgV2Vuc29uIEhzaWVoICA8d2Vuc29uX2hzaWVoQGFwcGxlLmNvbT4KIAogICAgICAgICBb
bWFjT1NdIFRleHQgcmVwbGFjZW1lbnRzIHRoYXQgZW5kIHdpdGggc3ltYm9scyBhcmUgZXhwYW5k
ZWQgaW1tZWRpYXRlbHkKZGlmZiAtLWdpdCBhL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2Vi
S2l0R0xpYi9UZXN0VUlDbGllbnQuY3BwIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJL
aXRHTGliL1Rlc3RVSUNsaWVudC5jcHAKaW5kZXggNjkzOTEwMmZkMzE4ZGZiZTQwZTQ5M2JlM2M3
YTM3NWU3Y2Q1Y2M0OS4uZWQzOTgzNzU5NzJjNDczNDJjNzk2YWEyMjM5NTYwNTJhZWMxNzliNiAx
MDA2NDQKLS0tIGEvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXRHTGliL1Rlc3RVSUNs
aWVudC5jcHAKKysrIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXRHTGliL1Rlc3RV
SUNsaWVudC5jcHAKQEAgLTY3OCw2ICs2NzgsOSBAQCBzdGF0aWMgdm9pZCB0ZXN0V2ViVmlld01v
dXNlVGFyZ2V0KFVJQ2xpZW50VGVzdCogdGVzdCwgZ2NvbnN0cG9pbnRlcikKICAgICAgICAgIiA8
cCBzdHlsZT0ncG9zaXRpb246YWJzb2x1dGU7IGxlZnQ6MTsgdG9wOjEyMCcgaWQ9J3RleHRfdG9f
c2VsZWN0Jz5Mb3JlbSBpcHN1bS48L3A+IgogICAgICAgICAiPC9ib2R5PjwvaHRtbD4iOwogCisg
ICAgV2ViS2l0U2V0dGluZ3MqIHNldHRpbmdzID0gd2Via2l0X3dlYl92aWV3X2dldF9zZXR0aW5n
cyh0ZXN0LT5tX3dlYlZpZXcpOworICAgIHdlYmtpdF9zZXR0aW5nc19zZXRfYWxsb3dfdW5pdmVy
c2FsX2FjY2Vzc19mcm9tX2ZpbGVfdXJscyhzZXR0aW5ncywgVFJVRSk7CisKICAgICB0ZXN0LT5s
b2FkSHRtbChsaW5rc0hvdmVyZWRIVE1MLCAiZmlsZTovLy8iKTsKICAgICB0ZXN0LT53YWl0VW50
aWxMb2FkRmluaXNoZWQoKTsKIApAQCAtNzY3LDYgKzc3MCw4IEBAIHN0YXRpYyB2b2lkIHRlc3RX
ZWJWaWV3TW91c2VUYXJnZXQoVUlDbGllbnRUZXN0KiB0ZXN0LCBnY29uc3Rwb2ludGVyKQogICAg
IGdfYXNzZXJ0KCF3ZWJraXRfaGl0X3Rlc3RfcmVzdWx0X2NvbnRleHRfaXNfc2Nyb2xsYmFyKGhp
dFRlc3RSZXN1bHQpKTsKICAgICBnX2Fzc2VydCh3ZWJraXRfaGl0X3Rlc3RfcmVzdWx0X2NvbnRl
eHRfaXNfc2VsZWN0aW9uKGhpdFRlc3RSZXN1bHQpKTsKICAgICBnX2Fzc2VydCghdGVzdC0+bV9t
b3VzZVRhcmdldE1vZGlmaWVycyk7CisKKyAgICB3ZWJraXRfc2V0dGluZ3Nfc2V0X2FsbG93X3Vu
aXZlcnNhbF9hY2Nlc3NfZnJvbV9maWxlX3VybHMoc2V0dGluZ3MsIEZBTFNFKTsKIH0KICNlbmRp
ZiAvLyBQTEFURk9STShHVEspCiAKZGlmZiAtLWdpdCBhL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvZ2xp
Yi9UZXN0RXhwZWN0YXRpb25zLmpzb24gYi9Ub29scy9UZXN0V2ViS2l0QVBJL2dsaWIvVGVzdEV4
cGVjdGF0aW9ucy5qc29uCmluZGV4IGU0ZGI4ZGEwN2YxYjlhOTNjM2I4YWY0Y2Q5Y2E2Yzg3ZTNh
ZjhlZmUuLjllYWI1YWQwNzQzZjMyZDYxMmI1MDIwN2FiZmI2NzNiZDA0ZmQxM2EgMTAwNjQ0Ci0t
LSBhL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvZ2xpYi9UZXN0RXhwZWN0YXRpb25zLmpzb24KKysrIGIv
VG9vbHMvVGVzdFdlYktpdEFQSS9nbGliL1Rlc3RFeHBlY3RhdGlvbnMuanNvbgpAQCAtMSw5ICsx
LDYgQEAKIHsKICAgICAiVGVzdFVJQ2xpZW50IjogewogICAgICAgICAic3VidGVzdHMiOiB7Ci0g
ICAgICAgICAgICAiL3dlYmtpdC9XZWJLaXRXZWJWaWV3L21vdXNlLXRhcmdldCI6IHsKLSAgICAg
ICAgICAgICAgICAiZXhwZWN0ZWQiOiB7Imd0ayI6IHsic3RhdHVzIjogWyJUSU1FT1VUIiwgIkZB
SUwiXSwgImJ1ZyI6ICJ3ZWJraXQub3JnL2IvMTE3Njg5In19Ci0gICAgICAgICAgICB9LAogICAg
ICAgICAgICAgIi93ZWJraXQvV2ViS2l0V2ViVmlldy91c2VybWVkaWEtcGVybWlzc2lvbi1yZXF1
ZXN0cyI6IHsKICAgICAgICAgICAgICAgICAiZXhwZWN0ZWQiOiB7Imd0ayI6IHsic3RhdHVzIjog
WyJUSU1FT1VUIl0sICJidWciOiAid2Via2l0Lm9yZy9iLzE1ODI1NyJ9fQogICAgICAgICAgICAg
fSwK
</data>
<flag name="review"
          id="362165"
          type_id="1"
          status="+"
          setter="mcatanzaro"
    />
          </attachment>
      

    </bug>

</bugzilla>