187232 2018-07-01 08:08:47 -0700 [WPE][GTK] Fix retrieving backtrace from within flatpak sandbox in test runner 2018-07-01 16:52:16 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 tsaunier webkit-unassigned clopez commit-queue ews-watchlist glenn mcatanzaro tsaunier webkit-bug-importer oldest_to_newest 1438303 0 tsaunier 2018-07-01 08:08:47 -0700 See commit message. 1438304 1 344049 tsaunier 2018-07-01 08:10:11 -0700 Created attachment 344049 [WPE][GTK] Fix retrieving backtrace from within flatpak sandbox in test runner The place where host tmp folder is mounted changed to /run/host/ we need to take that into account. Also explicitely close temporary files as relying on garbage collection to remove them is a bad idea. Also minor optimization avoiding to compile regex for each backtrace retrieval. 1438359 2 344049 commit-queue 2018-07-01 16:51:47 -0700 Comment on attachment 344049 [WPE][GTK] Fix retrieving backtrace from within flatpak sandbox in test runner Clearing flags on attachment: 344049 Committed r233411: <https://trac.webkit.org/changeset/233411> 1438360 3 commit-queue 2018-07-01 16:51:48 -0700 All reviewed patches have been landed. Closing bug. 1438361 4 webkit-bug-importer 2018-07-01 16:52:16 -0700 <rdar://problem/41704367> 344049 2018-07-01 08:10:11 -0700 2018-07-01 16:51:47 -0700 [WPE][GTK] Fix retrieving backtrace from within flatpak sandbox in test runner WPEGTK-Fix-retrieving-backtrace-from-within-flatpa.patch text/plain 4103 tsaunier RnJvbSA4ZmJlOGJiMmExNzI1NDY4NDU5MzM3NzBmNjEyMzRjMzQyNWY0MzdkIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBUaGliYXVsdCBTYXVuaWVyIDx0c2F1bmllckBpZ2FsaWEuY29t PgpEYXRlOiBTdW4sIDEgSnVsIDIwMTggMTA6MjM6MzQgLTA0MDAKU3ViamVjdDogW1BBVENIIHhz ZXJ2ZXJdIFtXUEVdW0dUS10gRml4IHJldHJpZXZpbmcgYmFja3RyYWNlIGZyb20gd2l0aGluCiBm bGF0cGFrIHNhbmRib3ggaW4gdGVzdCBydW5uZXIKClRoZSBwbGFjZSB3aGVyZSBob3N0IHRtcCBm b2xkZXIgaXMgbW91bnRlZCBjaGFuZ2VkIHRvIC9ydW4vaG9zdC8gd2UKbmVlZCB0byB0YWtlIHRo YXQgaW50byBhY2NvdW50LgoKQWxzbyBleHBsaWNpdGVseSBjbG9zZSB0ZW1wb3JhcnkgZmlsZXMg YXMgcmVseWluZyBvbiBnYXJiYWdlIGNvbGxlY3Rpb24gdG8KcmVtb3ZlIHRoZW0gaXMgYSBiYWQg aWRlYS4KCkFsc28gbWlub3Igb3B0aW1pemF0aW9uIGF2b2lkaW5nIHRvIGNvbXBpbGUgcmVnZXgg Zm9yIGVhY2ggYmFja3RyYWNlCnJldHJpZXZhbC4KCmh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xODcyMzIKLS0tCiBUb29scy9DaGFuZ2VMb2cgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgfCAyMSArKysrKysrKysrKysrKysrKysrCiAuLi4vd2Via2l0cHkvcG9y dC9saW51eF9nZXRfY3Jhc2hfbG9nLnB5ICAgICAgfCAyMCArKysrKysrKysrKystLS0tLS0KIDIg ZmlsZXMgY2hhbmdlZCwgMzUgaW5zZXJ0aW9ucygrKSwgNiBkZWxldGlvbnMoLSkKCmRpZmYgLS1n aXQgYS9Ub29scy9DaGFuZ2VMb2cgYi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMTFlNDkzNmY1MDku LjYyZmNjMGNkYWY5IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMjQgQEAKKzIwMTgtMDctMDEgIFRoaWJhdWx0IFNhdW5pZXIgIDx0 c2F1bmllckBpZ2FsaWEuY29tPgorCisgICAgICAgIFtXUEVdW0dUS10gRml4IHJldHJpZXZpbmcg YmFja3RyYWNlIGZyb20gd2l0aGluIGZsYXRwYWsgc2FuZGJveCBpbiB0ZXN0IHJ1bm5lcgorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg3MjMyCisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIHBsYWNlIHdo ZXJlIGhvc3QgdG1wIGZvbGRlciBpcyBtb3VudGVkIGNoYW5nZWQgdG8gL3J1bi9ob3N0LyB3ZQor ICAgICAgICBuZWVkIHRvIHRha2UgdGhhdCBpbnRvIGFjY291bnQuCisKKyAgICAgICAgQWxzbyBl eHBsaWNpdGVseSBjbG9zZSB0ZW1wb3JhcnkgZmlsZXMgYXMgcmVseWluZyBvbiBnYXJiYWdlIGNv bGxlY3Rpb24gdG8KKyAgICAgICAgcmVtb3ZlIHRoZW0gaXMgYSBiYWQgaWRlYS4KKworICAgICAg ICBBbHNvIG1pbm9yIG9wdGltaXphdGlvbiBhdm9pZGluZyB0byBjb21waWxlIHJlZ2V4IGZvciBl YWNoIGJhY2t0cmFjZQorICAgICAgICByZXRyaWV2YWwuCisKKyAgICAgICAgKiBTY3JpcHRzL3dl YmtpdHB5L3BvcnQvbGludXhfZ2V0X2NyYXNoX2xvZy5weToKKyAgICAgICAgKEdEQkNyYXNoTG9n R2VuZXJhdG9yKToKKyAgICAgICAgKEdEQkNyYXNoTG9nR2VuZXJhdG9yLl9nZXRfdG1wX2ZpbGVf bmFtZSk6CisgICAgICAgIChHREJDcmFzaExvZ0dlbmVyYXRvci5fZ2V0X3RyYWNlX2Zyb21fc3lz dGVtZCk6CisKIDIwMTgtMDYtMzAgIERhbmllbCBCYXRlcyAgPGRhYmF0ZXNAYXBwbGUuY29tPgog CiAgICAgICAgIHRlc3Qtd2Via2l0cHkgbmV2ZXIgcmVidWlsZHMgbGxkYldlYktpdFRlc3Rlcgpk aWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9wb3J0L2xpbnV4X2dldF9jcmFzaF9s b2cucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3BvcnQvbGludXhfZ2V0X2NyYXNoX2xvZy5w eQppbmRleCAyZTQ1OTRlMDMyMS4uYzY5YjQ3NzI2ZTggMTAwNjQ0Ci0tLSBhL1Rvb2xzL1Njcmlw dHMvd2Via2l0cHkvcG9ydC9saW51eF9nZXRfY3Jhc2hfbG9nLnB5CisrKyBiL1Rvb2xzL1Njcmlw dHMvd2Via2l0cHkvcG9ydC9saW51eF9nZXRfY3Jhc2hfbG9nLnB5CkBAIC0zOSw2ICszOSw3IEBA IGZyb20gd2Via2l0cHkuY29tbW9uLnN5c3RlbS5leGVjdXRpdmUgaW1wb3J0IFNjcmlwdEVycm9y CiAKIAogY2xhc3MgR0RCQ3Jhc2hMb2dHZW5lcmF0b3Iob2JqZWN0KToKKyAgICBfZmluZF9waWRf cmVnZXggPSByZS5jb21waWxlKHInUElEOiAoXGQrKSBcKC4qXCknKQogCiAgICAgZGVmIF9faW5p dF9fKHNlbGYsIGV4ZWN1dGl2ZSwgbmFtZSwgcGlkLCBuZXdlcl90aGFuLCBmaWxlc3lzdGVtLCBw YXRoX3RvX2RyaXZlcik6CiAgICAgICAgIHNlbGYubmFtZSA9IG5hbWUKQEAgLTU4LDYgKzU5LDEy IEBAIGNsYXNzIEdEQkNyYXNoTG9nR2VuZXJhdG9yKG9iamVjdCk6CiAgICAgICAgICAgICBzdGRv dXQgPSAoJ0VSUk9SOiBUaGUgZ2RiIHByb2Nlc3MgZXhpdGVkIHdpdGggbm9uLXplcm8gcmV0dXJu IGNvZGUgJXNcblxuJyAlIHByb2MucmV0dXJuY29kZSkgKyBzdGRvdXQKICAgICAgICAgcmV0dXJu IChzdGRvdXQuZGVjb2RlKCd1dGY4JywgJ2lnbm9yZScpLCBlcnJvcnMpCiAKKyAgICBkZWYgX2dl dF90bXBfZmlsZV9uYW1lKHNlbGYsIGNvcmVkdW1wY3RsLCBmaWxlbmFtZSk6CisgICAgICAgIGlm IGNvcmVkdW1wY3RsWzBdID09ICdmbGF0cGFrLXNwYXduJzoKKyAgICAgICAgICAgIHJldHVybiAi L3J1bi9ob3N0LyIgKyBmaWxlbmFtZQorCisgICAgICAgIHJldHVybiBmaWxlbmFtZQorCiAgICAg ZGVmIF9nZXRfdHJhY2VfZnJvbV9zeXN0ZW1kKHNlbGYsIGNvcmVkdW1wY3RsLCBwaWQpOgogICAg ICAgICAjIExldHRpbmcgdXAgdG8gNSBzZWNvbmRzIGZvciB0aGUgYmFja3RyYWNlIHRvIGJlIGdl bmVyYXRlZCBvbiB0aGUgc3lzdGVtZCBzaWRlCiAgICAgICAgIGZvciB0cnlfbnVtYmVyIGluIHJh bmdlKDUpOgpAQCAtNzQsMTggKzgxLDE5IEBAIGNsYXNzIEdEQkNyYXNoTG9nR2VuZXJhdG9yKG9i amVjdCk6CiAgICAgICAgICAgICBmb3VuZF9uZXdlciA9IEZhbHNlCiAgICAgICAgICAgICAjIENv cmVkdW1wY3RsIHdpbGwgdXNlIHRoZSBsYXRlc3QgY29yZSBkdW1wIHdpdGggdGhlIHNwZWNpZmll ZCBQSUQKICAgICAgICAgICAgICMgYXNzdW1lIGl0IGlzIHRoZSByaWdodCBvbmUuCi0gICAgICAg ICAgICBwaWRzID0gcmUuZmluZGFsbChyJ1BJRDogKFxkKykgXCguKlwpJywgaW5mbykKKyAgICAg ICAgICAgIHBpZHMgPSBzZWxmLl9maW5kX3BpZF9yZWdleC5maW5kYWxsKGluZm8pCiAgICAgICAg ICAgICBpZiBub3QgcGlkczoKLSAgICAgICAgICAgICAgICBwcmludChzZWxmLm5hbWUgKyAiXG4i ICsgaW5mbykKICAgICAgICAgICAgICAgICBjb250aW51ZQogCiAgICAgICAgICAgICBwaWQgPSBw aWRzWzBdCisgICAgICAgICAgICB3aXRoIHRlbXBmaWxlLk5hbWVkVGVtcG9yYXJ5RmlsZSgpIGFz IHRlbXBfZmlsZToKKyAgICAgICAgICAgICAgICBpZiBzZWxmLl9leGVjdXRpdmUucnVuX2NvbW1h bmQoY29yZWR1bXBjdGwgKyBbJ2R1bXAnLCBwaWQsICctLW91dHB1dCcsCisgICAgICAgICAgICAg ICAgICAgICAgICB0ZW1wX2ZpbGUubmFtZV0sIHJldHVybl9leGl0X2NvZGU9VHJ1ZSk6CisgICAg ICAgICAgICAgICAgICAgIGNvbnRpbnVlCiAKLSAgICAgICAgICAgIHRlbXBfZmlsZSA9IHRlbXBm aWxlLk5hbWVkVGVtcG9yYXJ5RmlsZSgpCi0gICAgICAgICAgICBpZiBzZWxmLl9leGVjdXRpdmUu cnVuX2NvbW1hbmQoY29yZWR1bXBjdGwgKyBbJ2R1bXAnLCBwaWQsICctLW91dHB1dCcsIHRlbXBf ZmlsZS5uYW1lXSwgcmV0dXJuX2V4aXRfY29kZT1UcnVlKToKLSAgICAgICAgICAgICAgICBjb250 aW51ZQorICAgICAgICAgICAgICAgIHJlcyA9IHNlbGYuX2dldF9nZGJfb3V0cHV0KHNlbGYuX2dl dF90bXBfZmlsZV9uYW1lKGNvcmVkdW1wY3RsLCB0ZW1wX2ZpbGUubmFtZSkpCiAKLSAgICAgICAg ICAgIHJldHVybiBzZWxmLl9nZXRfZ2RiX291dHB1dCh0ZW1wX2ZpbGUubmFtZSkKKyAgICAgICAg ICAgICAgICByZXR1cm4gcmVzCiAKICAgICAgICAgcmV0dXJuICcnLCBbXQogCi0tIAoyLjE4LjA=