187222 2018-06-30 11:58:02 -0700 [CMake] build-webkit should be able to enable address sanitizer 2018-07-01 22:41:10 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build PC Linux RESOLVED FIXED InRadar P2 Normal --- 1 mcatanzaro mcatanzaro bugs-noreply calvaris dbates ews-watchlist lforschler mcatanzaro webkit-bug-importer oldest_to_newest 1438189 0 mcatanzaro 2018-06-30 11:58:02 -0700 If I have run 'set-webkit-configuration --asan' then build-webkit should pass -DENABLE_ADDRESS_SANITIZER=ON to CMake, so it actually does something. 1438190 1 344018 mcatanzaro 2018-06-30 11:58:37 -0700 Created attachment 344018 Patch 1438192 2 344018 dbates 2018-06-30 12:48:50 -0700 Comment on attachment 344018 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=344018&action=review Do we already support ASan building with CMake using script build-jsc? If not, we should fix this up. > Tools/ChangeLog:7 > + Please add a description for this change. I liked what you wrote in comment 0. 1438193 3 344018 dbates 2018-06-30 12:50:20 -0700 Comment on attachment 344018 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=344018&action=review > Tools/Scripts/webkitdirs.pm:2255 > + determineASanIsEnabled(); It is unnecessary to call this. We should call asanIsEnabled() on the line below (notice it is a function call). 1438208 4 mcatanzaro 2018-06-30 13:57:56 -0700 (In reply to Daniel Bates from comment #2) > Comment on attachment 344018 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=344018&action=review > > Do we already support ASan building with CMake using script build-jsc? If > not, we should fix this up. We did not, but build-jsc uses buildCMakeProjectOrExit(), which calls generateBuildSystemFromCMakeProject(), which is the function I'm modifying here, so now it will. > > Tools/ChangeLog:7 > > + > > Please add a description for this change. I liked what you wrote in comment > 0. OK. (In reply to Daniel Bates from comment #3) > It is unnecessary to call this. We should call asanIsEnabled() on the line > below (notice it is a function call). Yes. 1438210 5 mcatanzaro 2018-06-30 14:07:54 -0700 Committed r233402: <https://trac.webkit.org/changeset/233402> 1438211 6 webkit-bug-importer 2018-06-30 14:08:23 -0700 <rdar://problem/41682664> 344018 2018-06-30 11:58:37 -0700 2018-06-30 12:48:50 -0700 Patch bug-187222-20180630135836.patch text/plain 1243 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjMzNDAwCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYjA3YjZiNGQ5ODRhZGYyZmE4NmFhYzkwNzI3MzVkYmIy YWJmNjBlMC4uYTA4OWJkOGU4Nzc1YmZlZGNjNDg2NTc2ZDY1MzQ1OTExYWIyMGMyMCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEz IEBACisyMDE4LTA2LTMwICBNaWNoYWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AaWdhbGlhLmNv bT4KKworICAgICAgICBbQ01ha2VdIGJ1aWxkLXdlYmtpdCBzaG91bGQgYmUgYWJsZSB0byBlbmFi bGUgYWRkcmVzcyBzYW5pdGl6ZXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTE4NzIyMgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRkaXJzLnBtOgorICAgICAgICAoZ2VuZXJhdGVC dWlsZFN5c3RlbUZyb21DTWFrZVByb2plY3QpOgorCiAyMDE4LTA2LTMwICBUaGliYXVsdCBTYXVu aWVyICA8dHNhdW5pZXJAaWdhbGlhLmNvbT4KIAogICAgICAgICBNYWtlIGNoZWNrX2ZsYXRwYWso KSBub3QgdmVyYm9zZSB3aGVuIG9ubHkgdHJ5aW5nIHRvIHJ1biBjb21tYW5kIGluc2lkZSBmbGF0 cGFrCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdGRpcnMucG0gYi9Ub29scy9TY3Jp cHRzL3dlYmtpdGRpcnMucG0KaW5kZXggOGRhZGY0MzkwZTg4MmJkZjY0YzhjOTI1NzEyN2JiMGFm ZTczODQxMS4uN2Y3NDViYzk2YzMzMmQzMzNhODVlMWYyZWVmMGRlZTE1ZTUwMjQzNyAxMDA3NTUK LS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtCisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Vi a2l0ZGlycy5wbQpAQCAtMjI1Miw2ICsyMjUyLDkgQEAgc3ViIGdlbmVyYXRlQnVpbGRTeXN0ZW1G cm9tQ01ha2VQcm9qZWN0CiAgICAgICAgIHB1c2ggQGFyZ3MsICItRENNQUtFX0JVSUxEX1RZUEU9 RGVidWciOwogICAgIH0KIAorICAgIGRldGVybWluZUFTYW5Jc0VuYWJsZWQoKTsKKyAgICBwdXNo IEBhcmdzLCAiLURFTkFCTEVfQUREUkVTU19TQU5JVElaRVI9T04iIGlmICRhc2FuSXNFbmFibGVk OworCiAgICAgaWYgKCR3aWxsVXNlTmluamEpIHsKICAgICAgICAgcHVzaCBAYXJncywgIi1HIjsK ICAgICAgICAgaWYgKGNhblVzZUVjbGlwc2VOaW5qYUdlbmVyYXRvcigpKSB7Cg==