187217 2018-06-30 00:06:09 -0700 REGRESSION(r233391): This patch broke Windows ports (Requested by fredw on #webkit). 2018-06-30 00:09:22 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 186536 1 commit-queue commit-queue fred.wang mcatanzaro webkit-bug-importer oldest_to_newest 1438132 0 commit-queue 2018-06-30 00:06:09 -0700 https://trac.webkit.org/changeset/233391 broke the build: This patch broke Windows ports (Requested by fredw on #webkit). This is an automatic bug report generated by webkitbot. If this bug report was created because of a flaky test, please file a bug for the flaky test (if we don't already have one on file) and dup this bug against that bug so that we can track how often these flaky tests fail. 1438134 1 344005 commit-queue 2018-06-30 00:06:16 -0700 Created attachment 344005 ROLLOUT of r233391 Any committer can land this patch automatically by marking it commit-queue+. The commit-queue will build and test the patch before landing to ensure that the rollout will be successful. This process takes approximately 15 minutes. If you would like to land the rollout faster, you can use the following command: webkit-patch land-attachment ATTACHMENT_ID where ATTACHMENT_ID is the ID of this attachment. 1438135 2 344005 commit-queue 2018-06-30 00:08:07 -0700 Comment on attachment 344005 ROLLOUT of r233391 Clearing flags on attachment: 344005 Committed r233392: <https://trac.webkit.org/changeset/233392> 1438136 3 commit-queue 2018-06-30 00:08:09 -0700 All reviewed patches have been landed. Closing bug. 1438137 4 webkit-bug-importer 2018-06-30 00:09:22 -0700 <rdar://problem/41669885> 344005 2018-06-30 00:06:16 -0700 2018-06-30 00:08:07 -0700 ROLLOUT of r233391 bug-187217-20180630030616.patch text/plain 6500 commit-queue U3VidmVyc2lvbiBSZXZpc2lvbjogMjMzMzkxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDJhYjFhNjM5ODQwNDk1OGU1ODJkMDE0 NGFkYmY2OGIyNDYxMzM1NDQuLmJiYTNmM2JiZWZkMjdhMjAyYTc0ZTgxMjk1MjQxZjBhZTllYWI1 NmMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTgtMDYtMzAgIENvbW1pdCBRdWV1ZSAgPGNvbW1p dC1xdWV1ZUB3ZWJraXQub3JnPgorCisgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHIy MzMzOTEuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x ODcyMTcKKworICAgICAgICBUaGlzIHBhdGNoIGJyb2tlIFdpbmRvd3MgcG9ydHMgKFJlcXVlc3Rl ZCBieSBmcmVkdyBvbgorICAgICAgICAjd2Via2l0KS4KKworICAgICAgICBSZXZlcnRlZCBjaGFu Z2VzZXQ6CisKKyAgICAgICAgIldURidzIGludGVybmFsIHN0ZDo6b3B0aW9uYWwgaW1wbGVtZW50 YXRpb24gc2hvdWxkIGFib3J0KCkgb24KKyAgICAgICAgYmFkIG9wdGlvbmFsIGFjY2VzcyIKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4NjUzNgorICAg ICAgICBodHRwczovL3RyYWMud2Via2l0Lm9yZy9jaGFuZ2VzZXQvMjMzMzkxCisKIDIwMTgtMDYt MjkgIEZyZWRlcmljIFdhbmcgIDxmd2FuZ0BpZ2FsaWEuY29tPgogCiAgICAgICAgIFdURidzIGlu dGVybmFsIHN0ZDo6b3B0aW9uYWwgaW1wbGVtZW50YXRpb24gc2hvdWxkIGFib3J0KCkgb24gYmFk IG9wdGlvbmFsIGFjY2VzcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dURi93dGYvQXNzZXJ0aW9ucy5o IGIvU291cmNlL1dURi93dGYvQXNzZXJ0aW9ucy5oCmluZGV4IGNmYmNmMGNhZmViMzQ4NDg3MDNh MGI5YWY5MGJiZjJiZjdiMTBiNTguLjVlMDZlYWE2ZTYxOTlhMjI5MTgxMzY4ZTBlNzBlY2FhN2Ri ZDRmNTUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvd3RmL0Fzc2VydGlvbnMuaAorKysgYi9Tb3Vy Y2UvV1RGL3d0Zi9Bc3NlcnRpb25zLmgKQEAgLTIyMCwxMiArMjIwLDYgQEAgV1RGX0VYUE9SVF9Q UklWQVRFIGJvb2wgV1RGSXNEZWJ1Z2dlckF0dGFjaGVkKHZvaWQpOwogI2RlZmluZSBXVEZCcmVh a3BvaW50VHJhcCgpIFdURkNyYXNoKCkgLy8gTm90IGltcGxlbWVudGVkLgogI2VuZGlmCiAKLSNp ZiBDT01QSUxFUihNU1ZDKQotI2RlZmluZSBXVEZCcmVha3BvaW50VHJhcFVuZGVyQ29uc3RleHBy Q29udGV4dCgpIF9fZGVidWdicmVhaygpCi0jZWxzZQotI2RlZmluZSBXVEZCcmVha3BvaW50VHJh cFVuZGVyQ29uc3RleHByQ29udGV4dCgpIF9fYnVpbHRpbl90cmFwKCkKLSNlbmRpZgotCiAjaWZu ZGVmIENSQVNICiAKICNpZiBkZWZpbmVkKE5ERUJVRykgJiYgT1MoREFSV0lOKQpAQCAtNTExLDI3 ICs1MDUsNiBAQCBXVEZfRVhQT1JUX1BSSVZBVEUgTk9fUkVUVVJOX0RVRV9UT19DUkFTSCB2b2lk IFdURkNyYXNoV2l0aFNlY3VyaXR5SW1wbGljYXRpb24odgogI2RlZmluZSBSRUxFQVNFX0FTU0VS VF9OT1RfUkVBQ0hFRCgpIEFTU0VSVF9OT1RfUkVBQ0hFRCgpCiAjZW5kaWYKIAotLyogUkVMRUFT RV9BU1NFUlRfVU5ERVJfQ09OU1RFWFBSX0NPTlRFWFQKLQotICAgVGhpcyBpcyBhIHNwZWNpYWwg dmVyc2lvbiBvZiBSRUxFQVNFX0FTU0VSVChhc3NlcnRpb24pIHRoYXQgY2FuIGJlIHVzZWQgaW4g Y29uc3RleHByIGNvbnRleHRzLgotKi8KLSNpZiBBU1NFUlRfRElTQUJMRUQKLSNkZWZpbmUgUkVM RUFTRV9BU1NFUlRfVU5ERVJfQ09OU1RFWFBSX0NPTlRFWFQoYXNzZXJ0aW9uKSBkbyB7IFwKLSAg ICBpZiAoVU5MSUtFTFkoIShhc3NlcnRpb24pKSkgeyBcCi0gICAgICAgIFdURkJyZWFrcG9pbnRU cmFwVW5kZXJDb25zdGV4cHJDb250ZXh0KCk7IFwKLSAgICAgICAgX19idWlsdGluX3VucmVhY2hh YmxlKCk7IFwKLSAgICB9IFwKLX0gd2hpbGUgKDApCi0jZWxzZQotI2RlZmluZSBSRUxFQVNFX0FT U0VSVF9VTkRFUl9DT05TVEVYUFJfQ09OVEVYVChhc3NlcnRpb24pIGRvIHsgXAotICAgIGlmICgh KGFzc2VydGlvbikpIHsgXAotICAgICAgICBXVEZSZXBvcnRBc3NlcnRpb25GYWlsdXJlKF9fRklM RV9fLCBfX0xJTkVfXywgV1RGX1BSRVRUWV9GVU5DVElPTiwgI2Fzc2VydGlvbik7IFwKLSAgICAg ICAgV1RGQnJlYWtwb2ludFRyYXBVbmRlckNvbnN0ZXhwckNvbnRleHQoKTsgXAotICAgICAgICBf X2J1aWx0aW5fdW5yZWFjaGFibGUoKTsgXAotICAgIH0gXAotfSB3aGlsZSAoMCkKLSNlbmRpZgot CiAvKiBVTlJFQUNIQUJMRV9GT1JfUExBVEZPUk0gKi8KIAogI2lmIENPTVBJTEVSKENMQU5HKQpk aWZmIC0tZ2l0IGEvU291cmNlL1dURi93dGYvT3B0aW9uYWwuaCBiL1NvdXJjZS9XVEYvd3RmL09w dGlvbmFsLmgKaW5kZXggYzU3M2RkOWRhNmYwYmQ3NzI2MmQ4ODY2NTM1MzNiYjU5MTM4NTJjMS4u NjdlZTI3NzUyZmY5MDgyMDJiMzdiYTg1YTcxZDE1ODBmNzFiNjEwMSAxMDA2NDQKLS0tIGEvU291 cmNlL1dURi93dGYvT3B0aW9uYWwuaAorKysgYi9Tb3VyY2UvV1RGL3d0Zi9PcHRpb25hbC5oCkBA IC01MzAsNyArNTMwLDggQEAgcHVibGljOgogICB9CiAKICAgT1BUSU9OQUxfTVVUQUJMRV9DT05T VEVYUFIgVCogb3BlcmF0b3IgLT4oKSB7Ci0gICAgUkVMRUFTRV9BU1NFUlRfVU5ERVJfQ09OU1RF WFBSX0NPTlRFWFQoaW5pdGlhbGl6ZWQoKSk7CisgICAgLy8gRklYTUU6IFdlIG5lZWQgdG8gb2Zm ZXIgc3BlY2lhbCBhc3NlcnQgZnVuY3Rpb24gdGhhdCBjYW4gYmUgdXNlZCB1bmRlciB0aGUgY29u dGV4cHIgY29udGV4dC4KKyAgICAvLyBDT05TVEVYUFJfQVNTRVJUKGluaXRpYWxpemVkKCkpOwog ICAgIHJldHVybiBkYXRhcHRyKCk7CiAgIH0KIApAQCAtNTM5LDI3ICs1NDAsMzIgQEAgcHVibGlj OgogICB9CiAKICAgT1BUSU9OQUxfTVVUQUJMRV9DT05TVEVYUFIgVCYgb3BlcmF0b3IgKigpICYg ewotICAgIFJFTEVBU0VfQVNTRVJUX1VOREVSX0NPTlNURVhQUl9DT05URVhUKGluaXRpYWxpemVk KCkpOworICAgIC8vIEZJWE1FOiBXZSBuZWVkIHRvIG9mZmVyIHNwZWNpYWwgYXNzZXJ0IGZ1bmN0 aW9uIHRoYXQgY2FuIGJlIHVzZWQgdW5kZXIgdGhlIGNvbnRleHByIGNvbnRleHQuCisgICAgLy8g Q09OU1RFWFBSX0FTU0VSVChpbml0aWFsaXplZCgpKTsKICAgICByZXR1cm4gY29udGFpbmVkX3Zh bCgpOwogICB9CiAKICAgT1BUSU9OQUxfTVVUQUJMRV9DT05TVEVYUFIgVCYmIG9wZXJhdG9yICoo KSAmJiB7Ci0gICAgUkVMRUFTRV9BU1NFUlRfVU5ERVJfQ09OU1RFWFBSX0NPTlRFWFQoaW5pdGlh bGl6ZWQoKSk7CisgICAgLy8gRklYTUU6IFdlIG5lZWQgdG8gb2ZmZXIgc3BlY2lhbCBhc3NlcnQg ZnVuY3Rpb24gdGhhdCBjYW4gYmUgdXNlZCB1bmRlciB0aGUgY29udGV4cHIgY29udGV4dC4KKyAg ICAvLyBDT05TVEVYUFJfQVNTRVJUKGluaXRpYWxpemVkKCkpOwogICAgIHJldHVybiBkZXRhaWxf Ojpjb25zdGV4cHJfbW92ZShjb250YWluZWRfdmFsKCkpOwogICB9CiAKICAgY29uc3RleHByIFQg Y29uc3QmIHZhbHVlKCkgY29uc3QmIHsKLSAgICBSRUxFQVNFX0FTU0VSVF9VTkRFUl9DT05TVEVY UFJfQ09OVEVYVChpbml0aWFsaXplZCgpKTsKKyAgICAvLyBGSVhNRTogV2UgbmVlZCB0byBvZmZl ciBzcGVjaWFsIGFzc2VydCBmdW5jdGlvbiB0aGF0IGNhbiBiZSB1c2VkIHVuZGVyIHRoZSBjb250 ZXhwciBjb250ZXh0LgorICAgIC8vIHJldHVybiBpbml0aWFsaXplZCgpID8gY29udGFpbmVkX3Zh bCgpIDogKHRocm93IGJhZF9vcHRpb25hbF9hY2Nlc3MoImJhZCBvcHRpb25hbCBhY2Nlc3MiKSwg Y29udGFpbmVkX3ZhbCgpKTsKICAgICByZXR1cm4gY29udGFpbmVkX3ZhbCgpOwogICB9CiAKICAg T1BUSU9OQUxfTVVUQUJMRV9DT05TVEVYUFIgVCYgdmFsdWUoKSAmIHsKLSAgICBSRUxFQVNFX0FT U0VSVF9VTkRFUl9DT05TVEVYUFJfQ09OVEVYVChpbml0aWFsaXplZCgpKTsKKyAgICAvLyBGSVhN RTogV2UgbmVlZCB0byBvZmZlciBzcGVjaWFsIGFzc2VydCBmdW5jdGlvbiB0aGF0IGNhbiBiZSB1 c2VkIHVuZGVyIHRoZSBjb250ZXhwciBjb250ZXh0LgorICAgIC8vIHJldHVybiBpbml0aWFsaXpl ZCgpID8gY29udGFpbmVkX3ZhbCgpIDogKHRocm93IGJhZF9vcHRpb25hbF9hY2Nlc3MoImJhZCBv cHRpb25hbCBhY2Nlc3MiKSwgY29udGFpbmVkX3ZhbCgpKTsKICAgICByZXR1cm4gY29udGFpbmVk X3ZhbCgpOwogICB9CiAKICAgT1BUSU9OQUxfTVVUQUJMRV9DT05TVEVYUFIgVCYmIHZhbHVlKCkg JiYgewotICAgIFJFTEVBU0VfQVNTRVJUX1VOREVSX0NPTlNURVhQUl9DT05URVhUKGluaXRpYWxp emVkKCkpOworICAgIC8vIEZJWE1FOiBXZSBuZWVkIHRvIG9mZmVyIHNwZWNpYWwgYXNzZXJ0IGZ1 bmN0aW9uIHRoYXQgY2FuIGJlIHVzZWQgdW5kZXIgdGhlIGNvbnRleHByIGNvbnRleHQuCisgICAg Ly8gaWYgKCFpbml0aWFsaXplZCgpKSBfX1RIUk9XX0VYQ0VQVElPTihiYWRfb3B0aW9uYWxfYWNj ZXNzKCJiYWQgb3B0aW9uYWwgYWNjZXNzIikpOwogICAgIHJldHVybiBzdGQ6Om1vdmUoY29udGFp bmVkX3ZhbCgpKTsKICAgfQogCkBAIC02NzcsNyArNjgzLDggQEAgcHVibGljOgogICB9CiAKICAg Y29uc3RleHByIFQmIHZhbHVlKCkgY29uc3QgewotICAgIFJFTEVBU0VfQVNTRVJUX1VOREVSX0NP TlNURVhQUl9DT05URVhUKHJlZigpKTsKKyAgICAvLyBGSVhNRTogV2UgbmVlZCB0byBvZmZlciBz cGVjaWFsIGFzc2VydCBmdW5jdGlvbiB0aGF0IGNhbiBiZSB1c2VkIHVuZGVyIHRoZSBjb250ZXhw ciBjb250ZXh0LgorICAgIC8vIHJldHVybiByZWYgPyAqcmVmIDogKHRocm93IGJhZF9vcHRpb25h bF9hY2Nlc3MoImJhZCBvcHRpb25hbCBhY2Nlc3MiKSwgKnJlZik7CiAgICAgcmV0dXJuICpyZWY7 CiAgIH0KIApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCmluZGV4IGE5YWZjMjUwNmMxZmM1YmZlM2QwN2RkNThlNTdhZTkxYmFhODc0ZmUu LjgwODA3NTgzYjZlNGY5NzMxYjhlZjY5MzFlZjM0NDJhMDQzMGRmYmQgMTAwNjQ0Ci0tLSBhL0xh eW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyAr MSwxOCBAQAorMjAxOC0wNi0zMCAgQ29tbWl0IFF1ZXVlICA8Y29tbWl0LXF1ZXVlQHdlYmtpdC5v cmc+CisKKyAgICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjIzMzM5MS4KKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4NzIxNworCisgICAgICAg IFRoaXMgcGF0Y2ggYnJva2UgV2luZG93cyBwb3J0cyAoUmVxdWVzdGVkIGJ5IGZyZWR3IG9uCisg ICAgICAgICN3ZWJraXQpLgorCisgICAgICAgIFJldmVydGVkIGNoYW5nZXNldDoKKworICAgICAg ICAiV1RGJ3MgaW50ZXJuYWwgc3RkOjpvcHRpb25hbCBpbXBsZW1lbnRhdGlvbiBzaG91bGQgYWJv cnQoKSBvbgorICAgICAgICBiYWQgb3B0aW9uYWwgYWNjZXNzIgorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg2NTM2CisgICAgICAgIGh0dHBzOi8vdHJh Yy53ZWJraXQub3JnL2NoYW5nZXNldC8yMzMzOTEKKwogMjAxOC0wNi0yOSAgRnJlZGVyaWMgV2Fu ZyAgPGZ3YW5nQGlnYWxpYS5jb20+CiAKICAgICAgICAgV1RGJ3MgaW50ZXJuYWwgc3RkOjpvcHRp b25hbCBpbXBsZW1lbnRhdGlvbiBzaG91bGQgYWJvcnQoKSBvbiBiYWQgb3B0aW9uYWwgYWNjZXNz CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9UZXN0RXhwZWN0YXRpb25zIGIvTGF5b3V0VGVzdHMv VGVzdEV4cGVjdGF0aW9ucwppbmRleCA5YmQ5YjMwMDZlMjgxYTBiM2U2NThhOGNiMDY4ZDJiZDI4 ZWY4N2QwLi41ZTBiMTljZDJlMTRhYTIzOTc3YWYzYTk0MWRhZTFiNTc1NTgzMGY4IDEwMDY0NAot LS0gYS9MYXlvdXRUZXN0cy9UZXN0RXhwZWN0YXRpb25zCisrKyBiL0xheW91dFRlc3RzL1Rlc3RF eHBlY3RhdGlvbnMKQEAgLTM4Niw4ICszODYsNiBAQCBodHRwL3dwdC9jcm9zcy1vcmlnaW4tcmVz b3VyY2UtcG9saWN5LyBbIFNraXAgXQogIyBFbmQgcGxhdGZvcm0tc3BlY2lmaWMgdGVzdHMuCiAj Ly8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8v Ly8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vCiAKLXdlYmtpdC5vcmcvYi8xODcxNDUg aW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy93ZWItYW5pbWF0aW9ucy9pbnRlcmZhY2Vz L0FuaW1hdGFibGUvYW5pbWF0ZS1uby1icm93c2luZy1jb250ZXh0Lmh0bWwgWyBDcmFzaCBdCi0K ICMgbWVkaWEvdmlkZW8tc2Vlay1hZnRlci1lbmQuaHRtbCBpcyBmbGFreQogd2Via2l0Lm9yZy9i LzExNjI5MyBtZWRpYS92aWRlby1zZWVrLWFmdGVyLWVuZC5odG1sIFsgUGFzcyBGYWlsdXJlIF0K IAo=