187216 2018-06-29 23:32:11 -0700 DeclarativeAnimation should suspend, resume, & stop m_eventQueue 2018-07-20 10:08:49 -0700 1 1 1 Unclassified WebKit Animations WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 rniwa graouts dino graouts rniwa webkit-bug-importer oldest_to_newest 1438121 0 rniwa 2018-06-29 23:32:11 -0700 We need to stop/suspend GenericEventQueue when DeclarativeAnimation, as an active DOM object, gets stopped, suspended. We should also resume it when we get out of the page cache, etc.. 1438131 1 webkit-bug-importer 2018-06-30 00:02:49 -0700 <rdar://problem/41669739> 1443613 2 graouts 2018-07-19 17:21:13 -0700 DeclarativeAnimation is not an ActiveDOMObject… yet :) 1443614 3 graouts 2018-07-19 17:21:41 -0700 Except its superclass, WebAnimation, is. Duh. 1443628 4 345412 graouts 2018-07-19 18:04:18 -0700 Created attachment 345412 Patch 1443654 5 345412 rniwa 2018-07-19 19:24:44 -0700 Comment on attachment 345412 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=345412&action=review > Source/WebCore/animation/DeclarativeAnimation.cpp:220 > + ActiveDOMObject::suspend(reason); There is no need to call this. It's empty. But we should call WebAnimation::suspend(reason) to make this code future proof. > Source/WebCore/animation/DeclarativeAnimation.cpp:226 > + ActiveDOMObject::resume(); Ditto. 1443800 6 graouts 2018-07-20 10:08:49 -0700 Committed r234049: <https://trac.webkit.org/changeset/234049> 345412 2018-07-19 18:04:18 -0700 2018-07-19 19:24:44 -0700 Patch bug-187216-20180719180417.patch text/plain 4045 graouts U3VidmVyc2lvbiBSZXZpc2lvbjogMjM0MDE3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODhkZTg0ZDcwMWRkNjk4 MjBkZmM4OTA4NGI3MmI0OWUzNWY2ZTFhYi4uNDlhYmM5MGJmOGRiODNlMzFlODIxMWU5MzNhZmI4 ZjU1NTJkNThlNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDE4LTA3LTE5ICBBbnRv aW5lIFF1aW50ICA8Z3Jhb3V0c0BhcHBsZS5jb20+CisKKyAgICAgICAgRGVjbGFyYXRpdmVBbmlt YXRpb24gc2hvdWxkIHN1c3BlbmQsIHJlc3VtZSwgJiBzdG9wIG1fZXZlbnRRdWV1ZQorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg3MjE2CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgU3VzcGVuZCwgcmVzdW1l IGFuZCBjbG9zZSB0aGUgR2VuZXJpY0V2ZW50UXVldWUgZm9yIERlY2xhcmF0aXZlQW5pbWF0aW9u IGFzIGluc3RydWN0ZWQgdGhyb3VnaCB0aGUgRE9NQWN0aXZlT2JqZWN0IHByb3RvY29sLgorCisg ICAgICAgICogYW5pbWF0aW9uL0RlY2xhcmF0aXZlQW5pbWF0aW9uLmNwcDoKKyAgICAgICAgKFdl YkNvcmU6OkRlY2xhcmF0aXZlQW5pbWF0aW9uOjpzdG9wKToKKyAgICAgICAgKFdlYkNvcmU6OkRl Y2xhcmF0aXZlQW5pbWF0aW9uOjpzdXNwZW5kKToKKyAgICAgICAgKFdlYkNvcmU6OkRlY2xhcmF0 aXZlQW5pbWF0aW9uOjpyZXN1bWUpOgorICAgICAgICAqIGFuaW1hdGlvbi9EZWNsYXJhdGl2ZUFu aW1hdGlvbi5oOgorICAgICAgICAqIGFuaW1hdGlvbi9XZWJBbmltYXRpb24uY3BwOgorICAgICAg ICAoV2ViQ29yZTo6V2ViQW5pbWF0aW9uOjpzdG9wKToKKyAgICAgICAgKiBhbmltYXRpb24vV2Vi QW5pbWF0aW9uLmg6CisKIDIwMTgtMDctMTkgIEFudG9pbmUgUXVpbnQgIDxncmFvdXRzQGFwcGxl LmNvbT4KIAogICAgICAgICBGbGFreSBjcmFzaCBpbiBBbmltYXRpb25UaW1lbGluZTo6Y2FuY2Vs T3JSZW1vdmVEZWNsYXJhdGl2ZUFuaW1hdGlvbgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv YW5pbWF0aW9uL0RlY2xhcmF0aXZlQW5pbWF0aW9uLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2FuaW1h dGlvbi9EZWNsYXJhdGl2ZUFuaW1hdGlvbi5jcHAKaW5kZXggYjMyYjQ3ODgyY2I2N2QwMWIyYmM1 ODMxNzk5N2VkNTdjNDNmMGViMy4uOWEwOGQ4NWU2NmM2MjQxODcyNjYyYzY4ZDg4OTQ0OTQ3YzFm NzBhZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYW5pbWF0aW9uL0RlY2xhcmF0aXZlQW5p bWF0aW9uLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9hbmltYXRpb24vRGVjbGFyYXRpdmVBbmlt YXRpb24uY3BwCkBAIC0yMDgsNCArMjA4LDIyIEBAIHZvaWQgRGVjbGFyYXRpdmVBbmltYXRpb246 OmVucXVldWVET01FdmVudChjb25zdCBBdG9taWNTdHJpbmcmIGV2ZW50VHlwZSwgU2Vjb25kCiAg ICAgICAgIG1fZXZlbnRRdWV1ZS5lbnF1ZXVlRXZlbnQoVHJhbnNpdGlvbkV2ZW50OjpjcmVhdGUo ZXZlbnRUeXBlLCBkb3duY2FzdDxDU1NUcmFuc2l0aW9uPih0aGlzKS0+dHJhbnNpdGlvblByb3Bl cnR5KCksIHRpbWUsIFBzZXVkb0VsZW1lbnQ6OnBzZXVkb0VsZW1lbnROYW1lRm9yRXZlbnRzKG1f dGFyZ2V0LnBzZXVkb0lkKCkpKSk7CiB9CiAKK3ZvaWQgRGVjbGFyYXRpdmVBbmltYXRpb246OnN0 b3AoKQoreworICAgIG1fZXZlbnRRdWV1ZS5jbG9zZSgpOworICAgIFdlYkFuaW1hdGlvbjo6c3Rv cCgpOworfQorCit2b2lkIERlY2xhcmF0aXZlQW5pbWF0aW9uOjpzdXNwZW5kKFJlYXNvbkZvclN1 c3BlbnNpb24gcmVhc29uKQoreworICAgIG1fZXZlbnRRdWV1ZS5zdXNwZW5kKCk7CisgICAgQWN0 aXZlRE9NT2JqZWN0OjpzdXNwZW5kKHJlYXNvbik7Cit9CisKK3ZvaWQgRGVjbGFyYXRpdmVBbmlt YXRpb246OnJlc3VtZSgpCit7CisgICAgbV9ldmVudFF1ZXVlLnJlc3VtZSgpOworICAgIEFjdGl2 ZURPTU9iamVjdDo6cmVzdW1lKCk7Cit9CisKIH0gLy8gbmFtZXNwYWNlIFdlYkNvcmUKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL2FuaW1hdGlvbi9EZWNsYXJhdGl2ZUFuaW1hdGlvbi5oIGIv U291cmNlL1dlYkNvcmUvYW5pbWF0aW9uL0RlY2xhcmF0aXZlQW5pbWF0aW9uLmgKaW5kZXggY2Ux NGU1MTg2NWU3NWUwMDA2OTE0YzZhOTk4ZWM5NzEwNDlkM2JiZi4uZDI4ZGFkYjRiNTNmYjk2NTZj NTA2ZWNiZDgxODEzMWNhZWNjY2ZmNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYW5pbWF0 aW9uL0RlY2xhcmF0aXZlQW5pbWF0aW9uLmgKKysrIGIvU291cmNlL1dlYkNvcmUvYW5pbWF0aW9u L0RlY2xhcmF0aXZlQW5pbWF0aW9uLmgKQEAgLTYwLDYgKzYwLDExIEBAIHByaXZhdGU6CiAgICAg dm9pZCBlbnF1ZXVlRE9NRXZlbnQoY29uc3QgQXRvbWljU3RyaW5nJiwgU2Vjb25kcyk7CiAgICAg dm9pZCByZW1vdmUoKSBmaW5hbDsKIAorICAgIC8vIEFjdGl2ZURPTU9iamVjdC4KKyAgICB2b2lk IHN1c3BlbmQoUmVhc29uRm9yU3VzcGVuc2lvbikgZmluYWw7CisgICAgdm9pZCByZXN1bWUoKSBm aW5hbDsKKyAgICB2b2lkIHN0b3AoKSBmaW5hbDsKKwogICAgIEVsZW1lbnQmIG1fdGFyZ2V0Owog ICAgIFJlZjxBbmltYXRpb24+IG1fYmFja2luZ0FuaW1hdGlvbjsKICAgICBib29sIG1fd2FzUGVu ZGluZyB7IGZhbHNlIH07CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9hbmltYXRpb24vV2Vi QW5pbWF0aW9uLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2FuaW1hdGlvbi9XZWJBbmltYXRpb24uY3Bw CmluZGV4IDllYWNkNDU1OTgwNmI5MzY2MTQ4MjVkYmM4MmNmNjY2Nzg2MjU4YzMuLjdlNDBkNDkz OTgwOTIzNjQ2NzllMzgwNDA1NDUzYmRlMjhiMDI1OGUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL2FuaW1hdGlvbi9XZWJBbmltYXRpb24uY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2FuaW1h dGlvbi9XZWJBbmltYXRpb24uY3BwCkBAIC0xMTE5LDYgKzExMTksNyBAQCB2b2lkIFdlYkFuaW1h dGlvbjo6c3RvcCgpCiB7CiAgICAgbV9pc1N0b3BwZWQgPSB0cnVlOwogICAgIHJlbW92ZUFsbEV2 ZW50TGlzdGVuZXJzKCk7CisgICAgQWN0aXZlRE9NT2JqZWN0OjpzdG9wKCk7CiB9CiAKIGJvb2wg V2ViQW5pbWF0aW9uOjpjYW5CZUxpc3RlZCgpIGNvbnN0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9hbmltYXRpb24vV2ViQW5pbWF0aW9uLmggYi9Tb3VyY2UvV2ViQ29yZS9hbmltYXRpb24v V2ViQW5pbWF0aW9uLmgKaW5kZXggZDA1NzhlODhiOWFkYjM5NDgwMTZmMTExN2M0ZDc3Y2UzMjY3 OTRkMS4uOWI4M2YzOTJhOWRiOWJiZDc3MmIyZmMyOWU4NDY3ZGRlNmUxOWZhMyAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvYW5pbWF0aW9uL1dlYkFuaW1hdGlvbi5oCisrKyBiL1NvdXJjZS9X ZWJDb3JlL2FuaW1hdGlvbi9XZWJBbmltYXRpb24uaApAQCAtMTI5LDYgKzEyOSw3IEBAIHByb3Rl Y3RlZDoKICAgICBleHBsaWNpdCBXZWJBbmltYXRpb24oRG9jdW1lbnQmKTsKIAogICAgIGJvb2wg aXNFZmZlY3RJbnZhbGlkYXRpb25TdXNwZW5kZWQoKSB7IHJldHVybiBtX3N1c3BlbmRDb3VudDsg fQorICAgIHZvaWQgc3RvcCgpIG92ZXJyaWRlOwogCiBwcml2YXRlOgogICAgIGVudW0gY2xhc3Mg RGlkU2VlayB7IFllcywgTm8gfTsKQEAgLTE4MCw3ICsxODEsNiBAQCBwcml2YXRlOgogICAgIC8v IEFjdGl2ZURPTU9iamVjdC4KICAgICBjb25zdCBjaGFyKiBhY3RpdmVET01PYmplY3ROYW1lKCkg Y29uc3QgZmluYWw7CiAgICAgYm9vbCBjYW5TdXNwZW5kRm9yRG9jdW1lbnRTdXNwZW5zaW9uKCkg Y29uc3QgZmluYWw7Ci0gICAgdm9pZCBzdG9wKCkgZmluYWw7CiAKICAgICAvLyBFdmVudFRhcmdl dAogICAgIEV2ZW50VGFyZ2V0SW50ZXJmYWNlIGV2ZW50VGFyZ2V0SW50ZXJmYWNlKCkgY29uc3Qg ZmluYWwgeyByZXR1cm4gV2ViQW5pbWF0aW9uRXZlbnRUYXJnZXRJbnRlcmZhY2VUeXBlOyB9Cg==