187208 2018-06-29 17:04:59 -0700 Perl uninitialized value $isEnabled when running build-jsc using a CMake build 2018-06-29 19:07:18 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 dbates dbates aakash_jain clopez lforschler mcatanzaro thorton webkit-bug-importer oldest_to_newest 1438007 0 dbates 2018-06-29 17:04:59 -0700 While looking at the stdio on <http://ews-build.webkit-uat.org/#/builders/17/builds/5/steps/2/logs/stdio>, which builds JSC using CMake, I noticed the following error output: Use of uninitialized value in numeric ne (!=) at ./Tools/Scripts/build-jsc line 221. Use of uninitialized value $isEnabled in numeric ne (!=) at ./Tools/Scripts/build-jsc line 221. 1438008 1 dbates 2018-06-29 17:05:37 -0700 Following the patch for bug #177338, we no longer encode a default value for feature flags in webkitperl::FeatureList. 1438016 2 343978 dbates 2018-06-29 17:11:50 -0700 Created attachment 343978 Patch 1438017 3 dbates 2018-06-29 17:13:13 -0700 Can someone save me some time, should we enable enable ENABLE_EXPERIMENTAL_FEATURES when building JSC? For now, I kept the current behavior and do not enable ENABLE_EXPERIMENTAL_FEATURES. 1438072 4 dbates 2018-06-29 18:57:37 -0700 (In reply to Daniel Bates from comment #3) > Can someone save me some time, should we enable enable > ENABLE_EXPERIMENTAL_FEATURES when building JSC? For now, I kept the current > behavior and do not enable ENABLE_EXPERIMENTAL_FEATURES. We may set this feature flag per: <https://trac.webkit.org/browser/trunk/Source/JavaScriptCore/Configurations/FeatureDefines.xcconfig?rev=233385#L127> 1438073 5 dbates 2018-06-29 19:03:59 -0700 (In reply to Daniel Bates from comment #3) > Can someone save me some time, should we enable enable > ENABLE_EXPERIMENTAL_FEATURES when building JSC? For now, I kept the current > behavior and do not enable ENABLE_EXPERIMENTAL_FEATURES. The --no-experimental-features option in build-webkit, added in the patch for bug #177338, is only used by the GTK Linux bots. For now, I am going to keep this bug focused on fixing the uninitialized value error and keep the current behavior of not toggling experimental features when building with CMake. 1438074 6 dbates 2018-06-29 19:06:42 -0700 Committed r233386: <https://trac.webkit.org/changeset/233386> 1438076 7 webkit-bug-importer 2018-06-29 19:07:18 -0700 <rdar://problem/41663440> 343978 2018-06-29 17:11:50 -0700 2018-06-29 17:17:01 -0700 Patch bug-187208-20180629171149.patch text/plain 5642 dbates U3VidmVyc2lvbiBSZXZpc2lvbjogMjMzMzc0CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYTg0OGQ5ZWI2MzE5YjJjOTM2ZmE2M2NkMmNjZGFjNGNk NzQ5OGYxZi4uNzMyM2NhYjI2ZTNhZTA3ZjgxOWU4NzcxZDhlNGQxMzk2MTQ3NjJkYSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1 IEBACisyMDE4LTA2LTI5ICBEYW5pZWwgQmF0ZXMgIDxkYWJhdGVzQGFwcGxlLmNvbT4KKworICAg ICAgICBQZXJsIHVuaW5pdGlhbGl6ZWQgdmFsdWUgJGlzRW5hYmxlZCB3aGVuIHJ1bm5pbmcgYnVp bGQtanNjIHVzaW5nIGEgQ01ha2UgYnVpbGQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTE4NzIwOAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIFNoYXJlIGxvZ2ljIGZvciBjb21wdXRpbmcgdGhlIGZlYXR1cmUg ZmxhZ3MgdG8gZW5hYmxlIGluIENNYWtlIHdpdGggYm90aCBzY3JpcHQKKyAgICAgICAgYnVpbGQt d2Via2l0IGFuZCBzY3JpcHQgYnVpbGQtanNjIGluc3RlYWQgb2YgZHVwbGljYXRpbmcgaXQuIFRo aXMgYWxzbyBmaXhlcyBhCisgICAgICAgIGJ1ZyBpbiB0aGUgdmVyc2lvbiBvZiB0aGlzIGxvZ2lj IGluIGJ1aWxkLWpzYyB0aGF0IHdhcyBpbmFkdmVydGVudGx5IG5vdCB1cGRhdGVkCisgICAgICAg IGluIHIyMjIzOTQuIEluIHIyMjIzOTQgd2UgcmVtb3ZlZCB0aGUgbm90aW9uIG9mIGEgZGVmYXVs dCB2YWx1ZSBmb3IgYSBmZWF0dXJlIGZsYWcKKyAgICAgICAgbGlzdGVkIGluIHdlYmtpdHBlcmw6 OkZlYXR1cmVMaXN0LgorCisgICAgICAgICogU2NyaXB0cy9idWlsZC1qc2M6CisgICAgICAgIChi dWlsZE15UHJvamVjdCk6CisgICAgICAgIChjTWFrZUFyZ3NGcm9tRmVhdHVyZXMpOiBEZWxldGVk LgorICAgICAgICAqIFNjcmlwdHMvYnVpbGQtd2Via2l0OgorICAgICAgICAoY01ha2VBcmdzRnJv bUZlYXR1cmVzKTogRGVsZXRlZDsgbW92ZWQgdG8gd2Via2l0ZGlycy5wbS4KKyAgICAgICAgKiBT Y3JpcHRzL3dlYmtpdGRpcnMucG06CisgICAgICAgIChjbWFrZUFyZ3NGcm9tRmVhdHVyZXMpOiBN b3ZlZCBjb2RlIGZyb20gc2NyaXB0IGJ1aWxkLXdlYmtpdCBzbyB0aGF0IGl0IGNhbiBiZSBzaGFy ZWQKKyAgICAgICAgd2l0aCBidWlsZC1qc2MuCisKIDIwMTgtMDYtMjkgIERhbmllbCBCYXRlcyAg PGRhYmF0ZXNAYXBwbGUuY29tPgogCiAgICAgICAgIFtsbGRiLXdlYmtpdF0gTm9uLWVtcHR5IHN0 cmluZ3MgbWF5IGJlIHByZXR0eS1wcmludGVkIGFzIGVtcHR5CmRpZmYgLS1naXQgYS9Ub29scy9T Y3JpcHRzL2J1aWxkLWpzYyBiL1Rvb2xzL1NjcmlwdHMvYnVpbGQtanNjCmluZGV4IGYxZGVmMmFk OTE1YjBhNjEzMDBkYTBkNDgyMmM4ODkxN2JhZDdkN2QuLmFkMDMzZjA4YWI1Y2VlMjBjNjNjMTY5 MTJlMWE3NmIzNzlhZTdiOTggMTAwNzU1Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvYnVpbGQtanNjCisr KyBiL1Rvb2xzL1NjcmlwdHMvYnVpbGQtanNjCkBAIC0zNyw3ICszNyw2IEBAIHVzZSB3ZWJraXRk aXJzOwogdXNlIHdlYmtpdHBlcmw6OkZlYXR1cmVMaXN0IHF3KGdldEZlYXR1cmVPcHRpb25MaXN0 KTsKIHVzZSBQT1NJWDsKIAotc3ViIGNNYWtlQXJnc0Zyb21GZWF0dXJlcygpOwogc3ViIHdyaXRl Q29uZ3JhdHMoKTsKIAogcHJvaGliaXRVbmtub3duUG9ydCgpOwpAQCAtMTQ5LDcgKzE0OCw3IEBA IGlmIChpc0NNYWtlQnVpbGQoKSkgewogICAgICAgICBzZXRCYXNlUHJvZHVjdERpcigkYnVpbGRE aXIpOwogICAgIH0KIAotICAgIG15IEBmZWF0dXJlQXJncyA9IGNNYWtlQXJnc0Zyb21GZWF0dXJl cygpOworICAgIG15IEBmZWF0dXJlQXJncyA9IGNtYWtlQXJnc0Zyb21GZWF0dXJlcyhAZmVhdHVy ZXMpOwogCiAgICAgbXkgJGJ1aWxkVGFyZ2V0ID0gIiI7CiAgICAgdW5sZXNzIChpc0FueVdpbmRv d3MoKSkgewpAQCAtMjExLDIyICsyMTAsNiBAQCBzdWIgYnVpbGRNeVByb2plY3QKICAgICBjaGRp cldlYktpdCgpOwogfQogCi1zdWIgY01ha2VBcmdzRnJvbUZlYXR1cmVzKCkKLXsKLSAgICBteSBA YXJnczsKLSAgICBmb3JlYWNoIChAZmVhdHVyZXMpIHsKLSAgICAgICAgbXkgJGZlYXR1cmVOYW1l ID0gJF8tPntkZWZpbmV9OwotICAgICAgICBpZiAoJGZlYXR1cmVOYW1lKSB7Ci0gICAgICAgICAg ICBteSAkaXNFbmFibGVkID0gJHskXy0+e3ZhbHVlfX07Ci0gICAgICAgICAgICBpZiAoJGlzRW5h YmxlZCAhPSAkXy0+e2RlZmF1bHR9KSB7Ci0gICAgICAgICAgICAgICAgbXkgJGZlYXR1cmVFbmFi bGVkID0gJGlzRW5hYmxlZCA/ICJPTiIgOiAiT0ZGIjsKLSAgICAgICAgICAgICAgICBwdXNoIEBh cmdzLCAiLUQkZmVhdHVyZU5hbWU9JGZlYXR1cmVFbmFibGVkIjsKLSAgICAgICAgICAgIH0KLSAg ICAgICAgfQotICAgIH0KLSAgICByZXR1cm4gQGFyZ3M7Ci19Ci0KIHN1YiB3cml0ZUNvbmdyYXRz KCkKIHsKICAgICBteSAkZW5kVGltZSA9IHRpbWUoKTsKZGlmZiAtLWdpdCBhL1Rvb2xzL1Njcmlw dHMvYnVpbGQtd2Via2l0IGIvVG9vbHMvU2NyaXB0cy9idWlsZC13ZWJraXQKaW5kZXggNmYzMDRh N2Y5ZTViODU0NjNkMzVmNzMwNTk3NWY4YzRiZjAwMDk5ZC4uMjNkMmVjNDk2MmVjZGU5NWYzYjdm OTc4ZWNjMmQ4MTE1ODUyM2YwNCAxMDA3NTUKLS0tIGEvVG9vbHMvU2NyaXB0cy9idWlsZC13ZWJr aXQKKysrIGIvVG9vbHMvU2NyaXB0cy9idWlsZC13ZWJraXQKQEAgLTQ1LDcgKzQ1LDYgQEAgdXNl IExpc3Q6OlV0aWwgcXcoZmlyc3QpOwogdXNlIHdlYmtpdHBlcmw6OkZlYXR1cmVMaXN0IHF3KGdl dEZlYXR1cmVPcHRpb25MaXN0KTsKIHVzZSBQT1NJWDsKIAotc3ViIGNNYWtlQXJnc0Zyb21GZWF0 dXJlcygpOwogc3ViIHdyaXRlQ29uZ3JhdHMoKTsKIAogY2hlY2tSZXF1aXJlZFN5c3RlbUNvbmZp ZygpOwpAQCAtMjg1LDcgKzI4NCw3IEBAIGlmIChpc0NNYWtlQnVpbGQoKSAmJiAhaXNBbnlXaW5k b3dzKCkpIHsKIAogICAgICMgV2UgcmVtb3ZlIENNYWtlQ2FjaGUgdG8gYXZvaWQgdGhlIGJvdHMg cmV1c2luZyBjYWNoZWQgZmxhZ3Mgd2hlbgogICAgICMgd2UgZW5hYmxlIG5ldyBmZWF0dXJlcy4g VGhpcyBmb3JjZXMgYSByZWNvbmZpZ3VyYXRpb24uCi0gICAgbXkgQGZlYXR1cmVBcmdzID0gY01h a2VBcmdzRnJvbUZlYXR1cmVzKCk7CisgICAgbXkgQGZlYXR1cmVBcmdzID0gY21ha2VBcmdzRnJv bUZlYXR1cmVzKEBmZWF0dXJlcywgISRub0V4cGVyaW1lbnRhbEZlYXR1cmVzKTsKICAgICByZW1v dmVDTWFrZUNhY2hlKEBmZWF0dXJlQXJncyk7CiAKICAgICBidWlsZENNYWtlUHJvamVjdE9yRXhp dCgkY2xlYW4sICRwcmVmaXhQYXRoLCAkbWFrZUFyZ3MsIChjbWFrZUJhc2VkUG9ydEFyZ3VtZW50 cygpLCBAZmVhdHVyZUFyZ3MpLCBAY21ha2VBcmdzKTsKQEAgLTI5Myw3ICsyOTIsNyBAQCBpZiAo aXNDTWFrZUJ1aWxkKCkgJiYgIWlzQW55V2luZG93cygpKSB7CiAKIG15ICRiYXNlUHJvZHVjdERp ciA9IGJhc2VQcm9kdWN0RGlyKCk7CiBpZiAoaXNBcHBsZVdpbldlYktpdCgpIHx8IGlzV2luQ2Fp cm8oKSkgewotICAgIG15IEBmZWF0dXJlQXJncyA9IGNNYWtlQXJnc0Zyb21GZWF0dXJlcygpOwor ICAgIG15IEBmZWF0dXJlQXJncyA9IGNtYWtlQXJnc0Zyb21GZWF0dXJlcyhAZmVhdHVyZXMsICEk bm9FeHBlcmltZW50YWxGZWF0dXJlcyk7CiAgICAgcmVtb3ZlQ01ha2VDYWNoZShAZmVhdHVyZUFy Z3MpOwogCiAgICAgY2hkaXJXZWJLaXQoKTsKQEAgLTM3NywyOCArMzc2LDYgQEAgd3JpdGVDb25n cmF0cygpOwogCiBleGl0IDA7CiAKLXN1YiBjTWFrZUFyZ3NGcm9tRmVhdHVyZXMoKQotewotICAg IG15IEBhcmdzOwotCi0gICAgaWYgKCEkbm9FeHBlcmltZW50YWxGZWF0dXJlcykgewotICAgICAg ICBwdXNoIEBhcmdzLCAiLURFTkFCTEVfRVhQRVJJTUVOVEFMX0ZFQVRVUkVTPU9OIjsKLSAgICB9 Ci0KLSAgICBmb3JlYWNoIChAZmVhdHVyZXMpIHsKLSAgICAgICAgbXkgJGZlYXR1cmVOYW1lID0g JF8tPntkZWZpbmV9OwotICAgICAgICBpZiAoJGZlYXR1cmVOYW1lKSB7Ci0gICAgICAgICAgICBt eSAkZmVhdHVyZVZhbHVlID0gJHskXy0+e3ZhbHVlfX07Ci0gICAgICAgICAgICBpZiAoZGVmaW5l ZCAkZmVhdHVyZVZhbHVlKSB7Ci0gICAgICAgICAgICAgICAgbXkgJGZlYXR1cmVFbmFibGVkID0g JGZlYXR1cmVWYWx1ZSA/ICJPTiIgOiAiT0ZGIjsKLSAgICAgICAgICAgICAgICBwdXNoIEBhcmdz LCAiLUQkZmVhdHVyZU5hbWU9JGZlYXR1cmVFbmFibGVkIjsKLSAgICAgICAgICAgIH0KLSAgICAg ICAgfQotICAgIH0KLQotICAgIHJldHVybiBAYXJnczsKLX0KLQogc3ViIHdyaXRlQ29uZ3JhdHMo KQogewogICAgIG15ICRsYXVuY2hlclBhdGggPSBsYXVuY2hlclBhdGgoKTsKZGlmZiAtLWdpdCBh L1Rvb2xzL1NjcmlwdHMvd2Via2l0ZGlycy5wbSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0ZGlycy5w bQppbmRleCBkZDRkMjQwMWY2YmM1NDc2M2I2ODQwOGE3OGE5MGFlZGU0ZmQzN2JiLi5lYTNmY2Ez NTcwMzg3MzlhNzkzNGU1MWU2NzAzNTc0MWM4MzIwMGMwIDEwMDc1NQotLS0gYS9Ub29scy9TY3Jp cHRzL3dlYmtpdGRpcnMucG0KKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtCkBAIC02 NSw2ICs2NSw3IEBAIEJFR0lOIHsKICAgICAgICAmYmFzZVByb2R1Y3REaXIKICAgICAgICAmY2hk aXJXZWJLaXQKICAgICAgICAmY2hlY2tGcmFtZXdvcmtzCisgICAgICAgJmNtYWtlQXJnc0Zyb21G ZWF0dXJlcwogICAgICAgICZjbWFrZUJhc2VkUG9ydEFyZ3VtZW50cwogICAgICAgICZjdXJyZW50 U1ZOUmV2aXNpb24KICAgICAgICAmZGVidWdTYWZhcmkKQEAgLTIzNTQsNiArMjM1NSwyNiBAQCBz dWIgYnVpbGRDTWFrZVByb2plY3RPckV4aXQoJCQkQCkKICAgICByZXR1cm4gMDsKIH0KIAorc3Vi IGNtYWtlQXJnc0Zyb21GZWF0dXJlcyhcQDskKQoreworICAgIG15ICgkZmVhdHVyZXNBcnJheVJl ZiwgJGVuYWJsZUV4cGVyaW1lbnRhbEZlYXR1cmVzKSA9IEBfOworCisgICAgbXkgQGFyZ3M7Cisg ICAgcHVzaCBAYXJncywgIi1ERU5BQkxFX0VYUEVSSU1FTlRBTF9GRUFUVVJFUz1PTiIgaWYgJGVu YWJsZUV4cGVyaW1lbnRhbEZlYXR1cmVzOworICAgIGZvcmVhY2ggKEAkZmVhdHVyZXNBcnJheVJl ZikgeworICAgICAgICBteSAkZmVhdHVyZU5hbWUgPSAkXy0+e2RlZmluZX07CisgICAgICAgIGlm ICgkZmVhdHVyZU5hbWUpIHsKKyAgICAgICAgICAgIG15ICRmZWF0dXJlVmFsdWUgPSAkeyRfLT57 dmFsdWV9fTsgIyBVbmRlZiB0byBsZXQgdGhlIGJ1aWxkIHN5c3RlbSB1c2UgaXRzIGRlZmF1bHQu CisgICAgICAgICAgICBpZiAoZGVmaW5lZCgkZmVhdHVyZVZhbHVlKSkgeworICAgICAgICAgICAg ICAgIG15ICRmZWF0dXJlRW5hYmxlZCA9ICRmZWF0dXJlVmFsdWUgPyAiT04iIDogIk9GRiI7Cisg ICAgICAgICAgICAgICAgcHVzaCBAYXJncywgIi1EJGZlYXR1cmVOYW1lPSRmZWF0dXJlRW5hYmxl ZCI7CisgICAgICAgICAgICB9CisgICAgICAgIH0KKyAgICB9CisgICAgcmV0dXJuIEBhcmdzOwor fQorCisKIHN1YiBjbWFrZUJhc2VkUG9ydEFyZ3VtZW50cygpCiB7CiAgICAgcmV0dXJuICgpOwo=