187205 2018-06-29 16:41:32 -0700 Fix a bug in range bisector that start commit may be counted twice. 2018-07-02 20:56:05 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 dewei_zhu webkit-unassigned darin dewei_zhu rniwa oldest_to_newest 1437990 0 dewei_zhu 2018-06-29 16:41:32 -0700 Fix a bug in range bisector that start commit will be counted twice. 1437993 1 343970 dewei_zhu 2018-06-29 16:46:25 -0700 Created attachment 343970 Patch 1438765 2 dewei_zhu 2018-07-02 20:56:05 -0700 Landed in r233455. 343970 2018-06-29 16:46:25 -0700 2018-06-29 18:07:55 -0700 Patch bug-187205-20180629164624.patch text/plain 7275 dewei_zhu U3VidmVyc2lvbiBSZXZpc2lvbjogMjMzMzcxCmRpZmYgLS1naXQgYS9XZWJzaXRlcy9wZXJmLndl YmtpdC5vcmcvQ2hhbmdlTG9nIGIvV2Vic2l0ZXMvcGVyZi53ZWJraXQub3JnL0NoYW5nZUxvZwpp bmRleCBhYTRkZGUxNzAyMGNhYzg3YzE3NzlkMjhlZWI0NGEwMjZmZjYyNmYwLi5kNjcyMDdlMTk2 NWUyZWFiMzJjMDFjZjcxM2EzNTQ2OGE2NzZlNzZmIDEwMDY0NAotLS0gYS9XZWJzaXRlcy9wZXJm LndlYmtpdC5vcmcvQ2hhbmdlTG9nCisrKyBiL1dlYnNpdGVzL3BlcmYud2Via2l0Lm9yZy9DaGFu Z2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxOC0wNi0yOSAgRGV3ZWkgWmh1ICA8ZGV3ZWlfemh1 QGFwcGxlLmNvbT4KKworICAgICAgICBGaXggYSBidWcgaW4gcmFuZ2UgYmlzZWN0b3IgdGhhdCBz dGFydCBjb21taXQgbWF5IGJlIGNvdW50ZWQgdHdpY2UuCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODcyMDUKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSYW5nZSBiaXNlY3RvciBjb3VudGVkIHN0YXJ0IGNv bW1pdCB0d2ljZSBpZiBzdGFydCBjb21taXQgaXMgdGhlIHNhbWUgYXMgZW5kIGNvbW1pdC4KKwor ICAgICAgICAqIHB1YmxpYy92My9jb21taXQtc2V0LXJhbmdlLWJpc2VjdG9yLmpzOgorICAgICAg ICAoQ29tbWl0U2V0UmFuZ2VCaXNlY3Rvci5hc3luYy5jb21taXRTZXRDbG9zZXN0VG9NaWRkbGVP ZkFsbENvbW1pdHMpOgorICAgICAgICAqIHVuaXQtdGVzdHMvY29tbWl0LXNldC1yYW5nZS1iaXNl Y3Rvci10ZXN0cy5qczogQWRkZWQgYSB1bml0IHRlc3QgZm9yIHRoaXMgY2hhbmdlLgorCiAyMDE4 LTA2LTI4ICBEZXdlaSBaaHUgIDxkZXdlaV96aHVAYXBwbGUuY29tPgogCiAgICAgICAgIEZpeCBh IGJ1ZyBDb21wb25lbnRCYXNlIHRoYXQgd3JvbmcgY29udGVudCB0ZW1wbGF0ZSBtYXkgYmUgdXNl ZC4KZGlmZiAtLWdpdCBhL1dlYnNpdGVzL3BlcmYud2Via2l0Lm9yZy9wdWJsaWMvdjMvY29tbWl0 LXNldC1yYW5nZS1iaXNlY3Rvci5qcyBiL1dlYnNpdGVzL3BlcmYud2Via2l0Lm9yZy9wdWJsaWMv djMvY29tbWl0LXNldC1yYW5nZS1iaXNlY3Rvci5qcwppbmRleCA1ODQwZDY4NjYyNjMyNzc2MmZh YzYzZGVlMDI3YzNiZDRmZWFhZWU5Li42NTE5NThmYWZjZTFiOTYxZDYwMjZkOGE4Yjk2ZDJlMjBj ZDFjNjMwIDEwMDY0NAotLS0gYS9XZWJzaXRlcy9wZXJmLndlYmtpdC5vcmcvcHVibGljL3YzL2Nv bW1pdC1zZXQtcmFuZ2UtYmlzZWN0b3IuanMKKysrIGIvV2Vic2l0ZXMvcGVyZi53ZWJraXQub3Jn L3B1YmxpYy92My9jb21taXQtc2V0LXJhbmdlLWJpc2VjdG9yLmpzCkBAIC0yOSwxNyArMjksMTcg QEAgY2xhc3MgQ29tbWl0U2V0UmFuZ2VCaXNlY3RvciB7CiAgICAgICAgICAgICB9CiAKICAgICAg ICAgICAgIGNvbnN0IFtzdGFydENvbW1pdCwgZW5kQ29tbWl0XSA9IENvbW1pdExvZy5vcmRlclR3 b0NvbW1pdHMoZmlyc3RDb21taXQsIHNlY29uZENvbW1pdCk7Ci0gICAgICAgICAgICBjb25zdCBj b21taXRzID0gc3RhcnRDb21taXQgPT09IGVuZENvbW1pdCA/IFtzdGFydENvbW1pdF0gOiBhd2Fp dCBDb21taXRMb2cuZmV0Y2hCZXR3ZWVuUmV2aXNpb25zKHJlcG9zaXRvcnksIHN0YXJ0Q29tbWl0 LnJldmlzaW9uKCksIGVuZENvbW1pdC5yZXZpc2lvbigpKTsKKyAgICAgICAgICAgIGNvbnN0IGNv bW1pdHNFeGNsdWRpbmdTdGFydENvbW1pdCA9IHN0YXJ0Q29tbWl0ID09PSBlbmRDb21taXQgPyBb XSA6IGF3YWl0IENvbW1pdExvZy5mZXRjaEJldHdlZW5SZXZpc2lvbnMocmVwb3NpdG9yeSwgc3Rh cnRDb21taXQucmV2aXNpb24oKSwgZW5kQ29tbWl0LnJldmlzaW9uKCkpOwogCiAgICAgICAgICAg ICBpZiAoc3RhcnRDb21taXQuaGFzQ29tbWl0VGltZSgpKSB7Ci0gICAgICAgICAgICAgICAgYWxs Q29tbWl0c1dpdGhDb21taXRUaW1lLnB1c2goc3RhcnRDb21taXQsIC4uLmNvbW1pdHMpOworICAg ICAgICAgICAgICAgIGFsbENvbW1pdHNXaXRoQ29tbWl0VGltZS5wdXNoKHN0YXJ0Q29tbWl0LCAu Li5jb21taXRzRXhjbHVkaW5nU3RhcnRDb21taXQpOwogICAgICAgICAgICAgICAgIGNvbW1pdFJh bmdlQnlSZXBvc2l0b3J5LnNldChyZXBvc2l0b3J5LCAoY29tbWl0KSA9PgogICAgICAgICAgICAg ICAgICAgICBjb21taXQuaGFzQ29tbWl0VGltZSgpICYmIHN0YXJ0Q29tbWl0LnRpbWUoKSA8PSBj b21taXQudGltZSgpICYmIGNvbW1pdC50aW1lKCkgPD0gZW5kQ29tbWl0LnRpbWUoKSk7CiAgICAg ICAgICAgICAgICAgcmVwb3NpdG9yaWVzV2l0aENvbW1pdFRpbWUuYWRkKHJlcG9zaXRvcnkpOwog ICAgICAgICAgICAgfSBlbHNlIHsKICAgICAgICAgICAgICAgICBjb25zdCBpbmRleEJ5Q29tbWl0 ID0gbmV3IE1hcDsKICAgICAgICAgICAgICAgICBpbmRleEJ5Q29tbWl0LnNldChzdGFydENvbW1p dCwgMCk7Ci0gICAgICAgICAgICAgICAgY29tbWl0cy5mb3JFYWNoKChjb21taXQsIGluZGV4KSA9 PiBpbmRleEJ5Q29tbWl0LnNldChjb21taXQsIGluZGV4ICsgMSkpOworICAgICAgICAgICAgICAg IGNvbW1pdHNFeGNsdWRpbmdTdGFydENvbW1pdC5mb3JFYWNoKChjb21taXQsIGluZGV4KSA9PiBp bmRleEJ5Q29tbWl0LnNldChjb21taXQsIGluZGV4ICsgMSkpOwogICAgICAgICAgICAgICAgIGlu ZGV4Rm9yQWxsVGltZWxlc3NDb21taXRzV2l0aE9yZGVyQnlSZXBvc2l0b3J5LnNldChyZXBvc2l0 b3J5LCBpbmRleEJ5Q29tbWl0KTsKICAgICAgICAgICAgICAgICBjb21taXRSYW5nZUJ5UmVwb3Np dG9yeS5zZXQocmVwb3NpdG9yeSwgKGNvbW1pdCkgPT4KICAgICAgICAgICAgICAgICAgICAgY29t bWl0Lmhhc0NvbW1pdE9yZGVyKCkgJiYgc3RhcnRDb21taXQub3JkZXIoKSA8PSBjb21taXQub3Jk ZXIoKSAmJiBjb21taXQub3JkZXIoKSA8PSBlbmRDb21taXQub3JkZXIoKSk7CmRpZmYgLS1naXQg YS9XZWJzaXRlcy9wZXJmLndlYmtpdC5vcmcvdW5pdC10ZXN0cy9jb21taXQtc2V0LXJhbmdlLWJp c2VjdG9yLXRlc3RzLmpzIGIvV2Vic2l0ZXMvcGVyZi53ZWJraXQub3JnL3VuaXQtdGVzdHMvY29t bWl0LXNldC1yYW5nZS1iaXNlY3Rvci10ZXN0cy5qcwppbmRleCAxZTAxNmQ2NmM5NGY1Mjk3M2I4 YzY4MDg0ZjBiNTQ3NzRjMThmMDU2Li43MWNiMTNmNjc1Nzg2ZmU5MDQ4Nzc3YzcyOTJmZTllOWJm MDNhYTExIDEwMDY0NAotLS0gYS9XZWJzaXRlcy9wZXJmLndlYmtpdC5vcmcvdW5pdC10ZXN0cy9j b21taXQtc2V0LXJhbmdlLWJpc2VjdG9yLXRlc3RzLmpzCisrKyBiL1dlYnNpdGVzL3BlcmYud2Vi a2l0Lm9yZy91bml0LXRlc3RzL2NvbW1pdC1zZXQtcmFuZ2UtYmlzZWN0b3ItdGVzdHMuanMKQEAg LTMxNSw2ICszMTUsMzYgQEAgZGVzY3JpYmUoJ0NvbW1pdFNldFJhbmdlQmlzZWN0b3InLCAoKSA9 PiB7CiAgICAgICAgIF07CiAgICAgfQogCisgICAgZnVuY3Rpb24gY29tbWl0U2V0c1dpdGhUaW1l KCkKKyAgICB7CisgICAgICAgIHJldHVybiBbCisgICAgICAgICAgICBDb21taXRTZXQuZW5zdXJl U2luZ2xldG9uKDI4LCB7CisgICAgICAgICAgICAgICAgcmV2aXNpb25JdGVtczogWworICAgICAg ICAgICAgICAgICAgICB7IGNvbW1pdDogbWFrZUNvbW1pdCgxLCBNb2NrTW9kZWxzLndlYmtpdCwg J3dlYmtpdC1jb21taXQtMScsIDEwKSwgcmVxdWlyZXNCdWlsZDogZmFsc2UgfSwKKyAgICAgICAg ICAgICAgICAgICAgeyBjb21taXQ6IG1ha2VDb21taXQoMjAxLCBNb2NrTW9kZWxzLm9zeCwgJ29z eC1jb21taXQtMjAxJywgOCksIHJlcXVpcmVzQnVpbGQ6IGZhbHNlIH0KKyAgICAgICAgICAgICAg ICBdLAorICAgICAgICAgICAgICAgIGN1c3RvbVJvb3RzOiBbXX0pLAorICAgICAgICAgICAgQ29t bWl0U2V0LmVuc3VyZVNpbmdsZXRvbigyOSwgeworICAgICAgICAgICAgICAgIHJldmlzaW9uSXRl bXM6IFsKKyAgICAgICAgICAgICAgICAgICAgeyBjb21taXQ6IG1ha2VDb21taXQoMSwgTW9ja01v ZGVscy53ZWJraXQsICd3ZWJraXQtY29tbWl0LTEnLCAxMCksIHJlcXVpcmVzQnVpbGQ6IGZhbHNl IH0sCisgICAgICAgICAgICAgICAgICAgIHsgY29tbWl0OiBtYWtlQ29tbWl0KDIwMywgTW9ja01v ZGVscy5vc3gsICdvc3gtY29tbWl0LTIwMycsIDExKSwgcmVxdWlyZXNCdWlsZDogZmFsc2UgfQor ICAgICAgICAgICAgICAgIF0sCisgICAgICAgICAgICAgICAgY3VzdG9tUm9vdHM6IFtdfSksCisg ICAgICAgICAgICBDb21taXRTZXQuZW5zdXJlU2luZ2xldG9uKDMwLCB7CisgICAgICAgICAgICAg ICAgcmV2aXNpb25JdGVtczogWworICAgICAgICAgICAgICAgICAgICB7IGNvbW1pdDogbWFrZUNv bW1pdCgxLCBNb2NrTW9kZWxzLndlYmtpdCwgJ3dlYmtpdC1jb21taXQtMScsIDEwKSwgcmVxdWly ZXNCdWlsZDogZmFsc2UgfSwKKyAgICAgICAgICAgICAgICAgICAgeyBjb21taXQ6IG1ha2VDb21t aXQoMjA0LCBNb2NrTW9kZWxzLm9zeCwgJ29zeC1jb21taXQtMjA0JywgMTIpLCByZXF1aXJlc0J1 aWxkOiBmYWxzZSB9CisgICAgICAgICAgICAgICAgXSwKKyAgICAgICAgICAgICAgICBjdXN0b21S b290czogW119KSwKKyAgICAgICAgICAgIENvbW1pdFNldC5lbnN1cmVTaW5nbGV0b24oMzEsIHsK KyAgICAgICAgICAgICAgICByZXZpc2lvbkl0ZW1zOiBbCisgICAgICAgICAgICAgICAgICAgIHsg Y29tbWl0OiBtYWtlQ29tbWl0KDEsIE1vY2tNb2RlbHMud2Via2l0LCAnd2Via2l0LWNvbW1pdC0x JywgMTApLCByZXF1aXJlc0J1aWxkOiBmYWxzZSB9LAorICAgICAgICAgICAgICAgICAgICB7IGNv bW1pdDogbWFrZUNvbW1pdCgyMDUsIE1vY2tNb2RlbHMub3N4LCAnb3N4LWNvbW1pdC0yMDUnLCAx MyksIHJlcXVpcmVzQnVpbGQ6IGZhbHNlIH0KKyAgICAgICAgICAgICAgICBdLAorICAgICAgICAg ICAgICAgIGN1c3RvbVJvb3RzOiBbXX0pLAorICAgICAgICBdOworICAgIH0KKwogICAgIGZ1bmN0 aW9uIGNyZWF0ZVJvb3QoKQogICAgIHsKICAgICAgICAgcmV0dXJuIFVwbG9hZGVkRmlsZS5lbnN1 cmVTaW5nbGV0b24oNDU2LCB7J2NyZWF0ZWRBdCc6IG5ldyBEYXRlKCcyMDE3LTA1LTAxVDIxOjAz OjI3WicpLCAnZmlsZW5hbWUnOiAncm9vdC5kYXQnLCAnZXh0ZW5zaW9uJzogJy5kYXQnLCAnYXV0 aG9yJzogJ3NvbWUgdXNlcicsCkBAIC05ODcsNiArMTAxNyw1MSBAQCBkZXNjcmliZSgnQ29tbWl0 U2V0UmFuZ2VCaXNlY3RvcicsICgpID0+IHsKIAogICAgICAgICAgICAgYXNzZXJ0LmVxdWFsKGF3 YWl0IHByb21pc2UsIGFsbENvbW1pdFNldHNbM10pOwogICAgICAgICB9KTsKKworICAgICAgICBp dCgnc2hvdWxkIG5vdCBkb3VibGUgY291bnQgYSBjb21taXQgaWYgc3RhcnQgYW5kIGVuZCBjb21t aXRzIGFyZSB0aGUgc2FtZScsIGFzeW5jICgpID0+IHsKKyAgICAgICAgICAgIGNvbnN0IGFsbENv bW1pdFNldHMgPSBjb21taXRTZXRzV2l0aFRpbWUoKTsKKyAgICAgICAgICAgIGNvbnN0IHN0YXJ0 Q29tbWl0U2V0ID0gYWxsQ29tbWl0U2V0c1swXTsKKyAgICAgICAgICAgIGNvbnN0IGVuZENvbW1p dFNldCA9IGFsbENvbW1pdFNldHNbYWxsQ29tbWl0U2V0cy5sZW5ndGggLSAxXTsKKyAgICAgICAg ICAgIGNvbnN0IHByb21pc2UgPSBDb21taXRTZXRSYW5nZUJpc2VjdG9yLmNvbW1pdFNldENsb3Nl c3RUb01pZGRsZU9mQWxsQ29tbWl0cyhbc3RhcnRDb21taXRTZXQsIGVuZENvbW1pdFNldF0sIGFs bENvbW1pdFNldHMpOworICAgICAgICAgICAgYXNzZXJ0LmVxdWFsKHJlcXVlc3RzLmxlbmd0aCwg MSk7CisgICAgICAgICAgICBjb25zdCBvc3hGZXRjaFJlcXVlc3QgPSByZXF1ZXN0c1swXTsKKyAg ICAgICAgICAgIGFzc2VydC5lcXVhbChvc3hGZXRjaFJlcXVlc3QudXJsLCAnL2FwaS9jb21taXRz LzkvP3ByZWNlZGluZ1JldmlzaW9uPW9zeC1jb21taXQtMjAxJmxhc3RSZXZpc2lvbj1vc3gtY29t bWl0LTIwNScpOworICAgICAgICAgICAgY29uc3Qgb3N4SWQgPSBNb2NrTW9kZWxzLm9zeC5pZCgp OworICAgICAgICAgICAgb3N4RmV0Y2hSZXF1ZXN0LnJlc29sdmUoeworICAgICAgICAgICAgICAg ICdjb21taXRzJzogWworICAgICAgICAgICAgICAgICAgICB7CisgICAgICAgICAgICAgICAgICAg ICAgICByZXBvc2l0b3J5OiBvc3hJZCwKKyAgICAgICAgICAgICAgICAgICAgICAgIGlkOiAyMDIs CisgICAgICAgICAgICAgICAgICAgICAgICByZXZpc2lvbjogJ29zeC1jb21taXQtMjAyJywKKyAg ICAgICAgICAgICAgICAgICAgICAgIG93bnNDb21taXRzOiBmYWxzZSwKKyAgICAgICAgICAgICAg ICAgICAgICAgIHRpbWU6IDkKKyAgICAgICAgICAgICAgICAgICAgfSwKKyAgICAgICAgICAgICAg ICAgICAgeworICAgICAgICAgICAgICAgICAgICAgICAgcmVwb3NpdG9yeTogb3N4SWQsCisgICAg ICAgICAgICAgICAgICAgICAgICBpZDogMjAzLAorICAgICAgICAgICAgICAgICAgICAgICAgcmV2 aXNpb246ICdvc3gtY29tbWl0LTIwMycsCisgICAgICAgICAgICAgICAgICAgICAgICBvd25zQ29t bWl0czogZmFsc2UsCisgICAgICAgICAgICAgICAgICAgICAgICB0aW1lOiAxMQorICAgICAgICAg ICAgICAgICAgICB9LAorICAgICAgICAgICAgICAgICAgICB7CisgICAgICAgICAgICAgICAgICAg ICAgICByZXBvc2l0b3J5OiBvc3hJZCwKKyAgICAgICAgICAgICAgICAgICAgICAgIGlkOiAyMDQs CisgICAgICAgICAgICAgICAgICAgICAgICByZXZpc2lvbjogJ29zeC1jb21taXQtMjA0JywKKyAg ICAgICAgICAgICAgICAgICAgICAgIG93bnNDb21taXRzOiBmYWxzZSwKKyAgICAgICAgICAgICAg ICAgICAgICAgIHRpbWU6IDEyCisgICAgICAgICAgICAgICAgICAgIH0sCisgICAgICAgICAgICAg ICAgICAgIHsKKyAgICAgICAgICAgICAgICAgICAgICAgIHJlcG9zaXRvcnk6IG9zeElkLAorICAg ICAgICAgICAgICAgICAgICAgICAgaWQ6IDIwNSwKKyAgICAgICAgICAgICAgICAgICAgICAgIHJl dmlzaW9uOiAnb3N4LWNvbW1pdC0yMDUnLAorICAgICAgICAgICAgICAgICAgICAgICAgb3duc0Nv bW1pdHM6IGZhbHNlLAorICAgICAgICAgICAgICAgICAgICAgICAgdGltZTogMTMKKyAgICAgICAg ICAgICAgICAgICAgfQorICAgICAgICAgICAgICAgIF0KKyAgICAgICAgICAgIH0pOworCisgICAg ICAgICAgICBhc3NlcnQuZXF1YWwoYXdhaXQgcHJvbWlzZSwgYWxsQ29tbWl0U2V0c1sxXSk7Cisg ICAgICAgIH0pOwogICAgIH0pOwogCiAgICAgZGVzY3JpYmUoJ19vcmRlckNvbW1pdFNldHNCeVRp bWVBbmRPcmRlclRoZW5EZWR1cGxpY2F0ZScsICgpID0+IHsK