187195 2018-06-29 14:43:28 -0700 teach bisect-builds to fetch supported platforms from the rest api 2018-06-29 15:52:13 -0700 1 1 1 Unclassified WebKit Tools / Tests Safari 11 Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 lforschler lforschler aakash_jain lforschler webkit-bug-importer oldest_to_newest 1437911 0 lforschler 2018-06-29 14:43:28 -0700 We now have an api endpoint to get a list of available builds. teach bisect-builds to use it. 1437912 1 webkit-bug-importer 2018-06-29 14:49:37 -0700 <rdar://problem/41653798> 1437924 2 343951 lforschler 2018-06-29 15:19:17 -0700 Created attachment 343951 patch for review 1437931 3 343951 aakash_jain 2018-06-29 15:39:35 -0700 Comment on attachment 343951 patch for review View in context: https://bugs.webkit.org/attachment.cgi?id=343951&action=review > Tools/Scripts/bisect-builds:202 > + r = urllib2.urlopen(platform_url) You can consider making a separate method to fetching data from url, e.g.: fetch_data_from_url(url). That method can be used in fetch_revision_list() as well. But that can be done later on in a separate patch as well. > Tools/Scripts/bisect-builds:206 > + for platform in data['Items']: Is data guaranteed to have 'Items' key. what if data is empty? Do we want to crash here? You might consider using data.get('Items') 1437945 4 lforschler 2018-06-29 15:52:13 -0700 Committed revision 233373. 343951 2018-06-29 15:19:17 -0700 2018-06-29 15:39:35 -0700 patch for review 187195.patch text/plain 5601 lforschler SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIzMzM3MikKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDIzIEBACisyMDE4LTA2LTI5ICBMdWNhcyBGb3JzY2hsZXIgIDxsZm9yc2NobGVyQGFwcGxl LmNvbT4KKworICAgICAgICBUZWFjaCBiaXNlY3QtYnVpbGRzIHRvIHJldHJpZXZlIHN1cHBvcnRl ZCBwbGF0Zm9ybXMgZnJvbSB0aGUgcmVzdCBhcGkuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODcxOTUKKyAgICAgICAgCisgICAgICAgIFRoaXMgcGF0 Y2ggdXBkYXRlcyBiaXNlY3QtYnVpbGRzIHRvIHVzZSB2Ml8yIG9mIHRoZSBBUEkuIHYyXzIgYWRk cyB0d28gYXBpIGVuZHBvaW50czogL3BsYXRmb3JtcywgYW5kIC9taW5pZmllZC1wbGF0Zm9ybXMu CisgICAgICAgIFRoZXNlIGVuZHBvaW50cyBzY2FuIGEgZHluYW1vREIgZGF0YWJhc2UsIHJldHVy bmluZyB0aGUgaWRlbnRpZmllciBrZXkgZm9yIGFsbCBhdmFpbGFibGUgcGxhdGZvcm1zLgorICAg ICAgICBUaGUgaWRlbnRpZmllciBrZXlzIGFyZSBpbiB0aGUgZm9ybWF0OiBwbGF0Zm9ybS1hcmNo aXRlY3R1cmUtY29uZmlndXJhdGlvbi4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICAqIFNjcmlwdHMvYmlzZWN0LWJ1aWxkczoKKyAgICAgICAgKGdldF9h cGlfYXJjaGl2ZV91cmwpOiByZWZhY3RvcmVkIGZyb20gZ2V0X2FwaV91cmwuCisgICAgICAgIChn ZXRfcGxhdGZvcm1zKTogaGVscGVyIGZ1bmN0aW9uIHRvIHJldHJpZXZlIGZyb20gdGhlIHBsYXRm b3JtcyBhcGkuCisgICAgICAgIChtaW5pZmllZF9wbGF0Zm9ybXMpOiByZXR1cm5zIGEgbGlzdCBv ZiBtaW5pZmllZCBwbGF0Zm9ybXMgY3VycmVudGx5IGluIHRoZSBkYXRhYmFzZQorICAgICAgICAo dW5taW5pZmllZF9wbGF0Zm9ybXMpOiByZXR1cm5zIGEgbGlzdCBvZiB1bm1pbmlmaWVkIHBsYXRm b3JtcyBjdXJyZW50bHkgaW4gdGhlIGRhdGFiYXNlCisgICAgICAgIChpc19zdXBwb3J0ZWRfcGxh dGZvcm0pOiBjaGVja3MgaWYgdGhlIHBsYXRmb3JtLWFyY2hpdGVjdHVyZS1jb25maWd1cmF0aW9u IGNvbWJvIGlzIHN1cHBvcnRlZAorICAgICAgICAoZmV0Y2hfcmV2aXNpb25fbGlzdCk6IHJlZmFj dG9yZWQgdG8gdXNlIGdldF9hcGlfYXJjaGl2ZV91cmwKKyAgICAgICAgKGdldF9hcGlfdXJsKTog RGVsZXRlZC9yZWZhY3RvcmVkIHRvIGdldF9hcGlfYXJjaGl2ZV91cmwuCisKIDIwMTgtMDYtMjkg IEtlaXRoIE1pbGxlciAgPGtlaXRoX21pbGxlckBhcHBsZS5jb20+CiAKICAgICAgICAgcnVuLWpz YyBzaG91bGQgcHJpbnQgd2hlbiBqc2MgZXhpdHMgd2l0aCBub24temVybyBzdGF0dXMKSW5kZXg6 IFRvb2xzL1NjcmlwdHMvYmlzZWN0LWJ1aWxkcwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9TY3JpcHRz L2Jpc2VjdC1idWlsZHMJKHJldmlzaW9uIDIzMzM2NikKKysrIFRvb2xzL1NjcmlwdHMvYmlzZWN0 LWJ1aWxkcwkod29ya2luZyBjb3B5KQpAQCAtMzcsMTAgKzM3LDEzIEBAIGltcG9ydCBzeXMKIGlt cG9ydCB0ZW1wZmlsZQogaW1wb3J0IHVybGxpYjIKIGltcG9ydCB1cmxwYXJzZQorZnJvbSB3ZWJr aXRweS5jb21tb24ubWVtb2l6ZWQgaW1wb3J0IG1lbW9pemVkCiAKLVJFU1RfQVBJX1VSTCA9ICdo dHRwczovL3ExdHpxZnk0OGUuZXhlY3V0ZS1hcGkudXMtd2VzdC0yLmFtYXpvbmF3cy5jb20vdjJf MS8nCi1SRVNUX0FQSV9FTkRQT0lOVCA9ICdhcmNoaXZlcy8nCi1SRVNUX0FQSV9NSU5JRklFRF9F TkRQT0lOVCA9ICdtaW5pZmllZC1hcmNoaXZlcy8nCitSRVNUX0FQSV9VUkwgPSAnaHR0cHM6Ly9x MXR6cWZ5NDhlLmV4ZWN1dGUtYXBpLnVzLXdlc3QtMi5hbWF6b25hd3MuY29tL3YyXzIvJworUkVT VF9BUElfQVJDSElWRV9FTkRQT0lOVCA9ICdhcmNoaXZlcy8nCitSRVNUX0FQSV9NSU5JRklFRF9B UkNISVZFX0VORFBPSU5UID0gJ21pbmlmaWVkLWFyY2hpdmVzLycKK1JFU1RfQVBJX1BMQVRGT1JN X0VORFBPSU5UID0gJ3BsYXRmb3JtcycKK1JFU1RfQVBJX01JTklGSUVEX1BMQVRGT1JNX0VORFBP SU5UID0gJ21pbmlmaWVkLXBsYXRmb3JtcycKIAogCiBkZWYgYmlzZWN0X2J1aWxkcyhyZXZpc2lv bl9saXN0LCBzdGFydF9pbmRleCwgZW5kX2luZGV4LCBvcHRpb25zKToKQEAgLTYyLDcgKzY1LDcg QEAgZGVmIGJpc2VjdF9idWlsZHMocmV2aXNpb25fbGlzdCwgc3RhcnRfaQogCiAKIGRlZiBkb3du bG9hZF9hcmNoaXZlKG9wdGlvbnMsIHJldmlzaW9uKToKLSAgICBhcGlfdXJsID0gZ2V0X2FwaV91 cmwob3B0aW9ucykKKyAgICBhcGlfdXJsID0gZ2V0X2FwaV9hcmNoaXZlX3VybChvcHRpb25zKQog ICAgIHMzX3VybCA9IGdldF9zM19sb2NhdGlvbl9mb3JfcmV2aXNpb24oYXBpX3VybCwgcmV2aXNp b24pCiAgICAgcHJpbnQoJ0FyY2hpdmUgVVJMOiB7fScuZm9ybWF0KHMzX3VybCkpCiAgICAgY29t bWFuZCA9IFsncHl0aG9uJywgJy4uL0J1aWxkU2xhdmVTdXBwb3J0L2Rvd25sb2FkLWJ1aWx0LXBy b2R1Y3QnLCAnLS17fScuZm9ybWF0KG9wdGlvbnMuY29uZmlndXJhdGlvbiksICctLXBsYXRmb3Jt Jywgb3B0aW9ucy5wbGF0Zm9ybSwgczNfdXJsXQpAQCAtOTMsMTEgKzk2LDExIEBAIGRlZiBmaW5k X2dlKGEsIHgpOgogIyAtLS0tIGVuZCBiaXNlY3QgaGVscGVycyAtLS0tCiAKIAotZGVmIGdldF9h cGlfdXJsKG9wdGlvbnMsIExhc3RFdmFsdWF0ZWRLZXk9Tm9uZSk6CitkZWYgZ2V0X2FwaV9hcmNo aXZlX3VybChvcHRpb25zLCBMYXN0RXZhbHVhdGVkS2V5PU5vbmUpOgogICAgIGlmIG9wdGlvbnMu ZnVsbDoKLSAgICAgICAgYmFzZV91cmwgPSB1cmxwYXJzZS51cmxqb2luKFJFU1RfQVBJX1VSTCwg UkVTVF9BUElfRU5EUE9JTlQpCisgICAgICAgIGJhc2VfdXJsID0gdXJscGFyc2UudXJsam9pbihS RVNUX0FQSV9VUkwsIFJFU1RfQVBJX0FSQ0hJVkVfRU5EUE9JTlQpCiAgICAgZWxzZToKLSAgICAg ICAgYmFzZV91cmwgPSB1cmxwYXJzZS51cmxqb2luKFJFU1RfQVBJX1VSTCwgUkVTVF9BUElfTUlO SUZJRURfRU5EUE9JTlQpCisgICAgICAgIGJhc2VfdXJsID0gdXJscGFyc2UudXJsam9pbihSRVNU X0FQSV9VUkwsIFJFU1RfQVBJX01JTklGSUVEX0FSQ0hJVkVfRU5EUE9JTlQpCiAKICAgICBhcGlf dXJsID0gdXJscGFyc2UudXJsam9pbihiYXNlX3VybCwgJy0nLmpvaW4oW29wdGlvbnMucGxhdGZv cm0sIG9wdGlvbnMuYXJjaGl0ZWN0dXJlLCBvcHRpb25zLmNvbmZpZ3VyYXRpb25dKSkKICAgICBp ZiBMYXN0RXZhbHVhdGVkS2V5OgpAQCAtMTkyLDI3ICsxOTUsMzcgQEAgZGVmIHRlc3RfYXJjaGl2 ZShvcHRpb25zLCByZXZpc2lvbik6CiAgICAgaWYgY29tbWFuZDoKICAgICAgICAgc3VicHJvY2Vz cy5jYWxsKGNvbW1hbmQpCiAgICAgcmV0dXJuIHByb21wdF9kaWRfcmVwcm9kdWNlKCkKLSAgICAK IAotZGVmIG1pbmlmaWVkX3BsYXRmb3JtcygpOgotICAgICMgRklYTUU6IHF1ZXJ5IHRoaXMgZHlu YW1pY2FsbHkgZnJvbSBBUEkKLSAgICByZXR1cm4gIFsnbWFjLWVsY2FwaXRhbicsICdtYWMtc2ll cnJhJywgJ21hYy1oaWdoc2llcnJhJywgJ2lvcy1zaW11bGF0b3ItMTAnLCAnaW9zLXNpbXVsYXRv ci0xMSddCiAKK2RlZiBnZXRfcGxhdGZvcm1zKGVuZHBvaW50KToKKyAgICBwbGF0Zm9ybV91cmwg PSB1cmxwYXJzZS51cmxqb2luKFJFU1RfQVBJX1VSTCwgZW5kcG9pbnQpCisgICAgciA9IHVybGxp YjIudXJsb3BlbihwbGF0Zm9ybV91cmwpCisgICAgZGF0YSA9IGpzb24ubG9hZChyKQogCisgICAg cGxhdGZvcm1zID0gW10KKyAgICBmb3IgcGxhdGZvcm0gaW4gZGF0YVsnSXRlbXMnXToKKyAgICAg ICAgcGxhdGZvcm1zLmFwcGVuZChzdHIocGxhdGZvcm1bJ2lkZW50aWZpZXInXVsnUyddKSkKKwor ICAgIHJldHVybiBwbGF0Zm9ybXMKKyAgICAgCitAbWVtb2l6ZWQKK2RlZiBtaW5pZmllZF9wbGF0 Zm9ybXMoKToKKyAgICByZXR1cm4gZ2V0X3BsYXRmb3JtcyhSRVNUX0FQSV9NSU5JRklFRF9QTEFU Rk9STV9FTkRQT0lOVCkKKyAKK0BtZW1vaXplZAogZGVmIHVubWluaWZpZWRfcGxhdGZvcm1zKCk6 Ci0gICAgIyBGSVhNRTogcXVlcnkgdGhpcyBkeW5hbWljYWxseSBmcm9tIEFQSQotICAgIHJldHVy biBbJ2d0aycsICdpb3Mtc2ltdWxhdG9yLTEwJywgJ2lvcy1zaW11bGF0b3ItMTEnLCAnbWFjLWVs Y2FwaXRhbicsICdtYWMtc2llcnJhJywgJ21hYy1oaWdoc2llcnJhJywgJ3dpbicsICd3cGUnXQot Ci0KKyAgICByZXR1cm4gZ2V0X3BsYXRmb3JtcyhSRVNUX0FQSV9QTEFURk9STV9FTkRQT0lOVCkK KyAKIGRlZiBpc19zdXBwb3J0ZWRfcGxhdGZvcm0ob3B0aW9ucyk6CisgICAgcGxhdGZvcm0gPSAn LScuam9pbihbb3B0aW9ucy5wbGF0Zm9ybSwgb3B0aW9ucy5hcmNoaXRlY3R1cmUsIG9wdGlvbnMu Y29uZmlndXJhdGlvbl0pICAgIAogICAgIGlmIG9wdGlvbnMuZnVsbDoKLSAgICAgICAgcmV0dXJu IG9wdGlvbnMucGxhdGZvcm0gaW4gdW5taW5pZmllZF9wbGF0Zm9ybXMoKQotICAgIHJldHVybiBv cHRpb25zLnBsYXRmb3JtIGluIG1pbmlmaWVkX3BsYXRmb3JtcygpCisgICAgICAgIHJldHVybiBw bGF0Zm9ybSBpbiB1bm1pbmlmaWVkX3BsYXRmb3JtcygpCisgICAgcmV0dXJuIHBsYXRmb3JtIGlu IG1pbmlmaWVkX3BsYXRmb3JtcygpCiAKIAogZGVmIHZhbGlkYXRlX29wdGlvbnMob3B0aW9ucyk6 CiAgICAgaWYgbm90IGlzX3N1cHBvcnRlZF9wbGF0Zm9ybShvcHRpb25zKToKLSAgICAgICAgcHJp bnQoJ1Vuc3VwcG9ydGVkIHBsYXRmb3JtOiBbe31dLCBleGl0aW5nLi4uJy5mb3JtYXQob3B0aW9u cy5wbGF0Zm9ybSkpCisgICAgICAgIHByaW50KCdVbnN1cHBvcnRlZCBwbGF0Zm9ybSBjb21iaW5h dGlvbjogW3t9XSwgZXhpdGluZy4uLicuZm9ybWF0KCctJy5qb2luKFtvcHRpb25zLnBsYXRmb3Jt LCBvcHRpb25zLmFyY2hpdGVjdHVyZSwgb3B0aW9ucy5jb25maWd1cmF0aW9uXSkpKQogICAgICAg ICBpZiBvcHRpb25zLmZ1bGw6CiAgICAgICAgICAgICBwcmludCgnQXZhaWxhYmxlIFVubWluaWZp ZWQgcGxhdGZvcm1zOiB7fScuZm9ybWF0KHVubWluaWZpZWRfcGxhdGZvcm1zKCkpKQogICAgICAg ICBlbHNlOgpAQCAtMjI4LDcgKzI0MSw3IEBAIGRlZiBwcmludF9saXN0X2FuZF9leGl0KHJldmlz aW9uX2xpc3QsIG8KICAgICAgICAgZXhpdCgwKQogCiBkZWYgZmV0Y2hfcmV2aXNpb25fbGlzdChv cHRpb25zLCBMYXN0RXZhbHVhdGVkS2V5PU5vbmUpOgotICAgIHVybCA9IGdldF9hcGlfdXJsKG9w dGlvbnMsIExhc3RFdmFsdWF0ZWRLZXkpCisgICAgdXJsID0gZ2V0X2FwaV9hcmNoaXZlX3VybChv cHRpb25zLCBMYXN0RXZhbHVhdGVkS2V5KQogICAgIHIgPSB1cmxsaWIyLnVybG9wZW4odXJsKQog ICAgIGRhdGEgPSBqc29uLmxvYWQocikKICAgICByZXZpc2lvbl9saXN0ID0gZ2V0X3NvcnRlZF9y ZXZpc2lvbnMoZGF0YSkK