187191 2018-06-29 13:18:27 -0700 [ews-build] Add timeout to webkitpy and webkitperl tests 2018-06-30 07:47:21 -0700 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 aakash_jain aakash_jain aakash_jain ap ews-watchlist lforschler webkit-bug-importer oldest_to_newest 1437871 0 aakash_jain 2018-06-29 13:18:27 -0700 There have been occurrences in the past in which webkitpy tests get stuck. In the current system EWS bots get completely stuck (and a manual intervention is required). With buildbot, the build step running the test would be killed by buildbot in 20 minutes. webkitpy and webkitperl tests typically takes 10s. 20 minutes (without any output) is a long time to wait. We should set a smaller timeout (like 2 minutes). 1437874 1 343935 aakash_jain 2018-06-29 13:21:22 -0700 Created attachment 343935 Proposed patch Sample runs: http://ews-build.webkit-uat.org/#/builders/16/builds/7 http://ews-build.webkit-uat.org/#/builders/15/builds/3 1437876 2 ews-watchlist 2018-06-29 13:23:52 -0700 Attachment 343935 did not pass style-queue: ERROR: Tools/BuildSlaveSupport/ews-build/steps.py:92: [RunWebKitPerlTests.__init__] Use of super on an old style class [pylint/E1002] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps.py:103: [RunWebKitPyTests.__init__] Use of super on an old style class [pylint/E1002] [5] Total errors found: 2 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 1437877 3 aakash_jain 2018-06-29 13:26:44 -0700 Committed r233368: <https://trac.webkit.org/changeset/233368>. 1437878 4 webkit-bug-importer 2018-06-29 13:27:19 -0700 <rdar://problem/41649817> 343935 2018-06-29 13:21:22 -0700 2018-06-29 13:24:04 -0700 Proposed patch ews_timeout.patch text/plain 3409 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIzMzM2NykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE1IEBACisyMDE4LTA2LTI5ICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBbZXdzLWJ1aWxkXSBBZGQgdGltZW91dCB0byB3ZWJraXRweSBhbmQgd2Vi a2l0cGVybCB0ZXN0cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTg3MTkxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgKiBCdWlsZFNsYXZlU3VwcG9ydC9ld3MtYnVpbGQvc3RlcHMucHk6CisgICAgICAgIChS dW5XZWJLaXRQZXJsVGVzdHMuX19pbml0X18pOiBTZXQgdGltZW91dCBvZiAyIG1pbnV0ZXMuCisg ICAgICAgIChSdW5XZWJLaXRQeVRlc3RzLl9faW5pdF9fKTogRGl0dG8uCisgICAgICAgICogQnVp bGRTbGF2ZVN1cHBvcnQvZXdzLWJ1aWxkL3N0ZXBzX3VuaXR0ZXN0LnB5OiBVcGRhdGVkIHVuaXQt dGVzdHMuCisKIDIwMTgtMDYtMjkgIENhcmxvcyBBbGJlcnRvIExvcGV6IFBlcmV6ICA8Y2xvcGV6 QGlnYWxpYS5jb20+CiAKICAgICAgICAgW1dQRV06IEZpeCBleGNlcHRpb24gaGFuZGxpbmcgd2hl biBmbGF0cGFrIGlzIG5vdCBpbnN0YWxsZWQKSW5kZXg6IFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0 L2V3cy1idWlsZC9zdGVwcy5weQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9CdWlsZFNsYXZlU3VwcG9y dC9ld3MtYnVpbGQvc3RlcHMucHkJKHJldmlzaW9uIDIzMzM2NykKKysrIFRvb2xzL0J1aWxkU2xh dmVTdXBwb3J0L2V3cy1idWlsZC9zdGVwcy5weQkod29ya2luZyBjb3B5KQpAQCAtODksNiArODks OSBAQCBjbGFzcyBSdW5XZWJLaXRQZXJsVGVzdHMoc2hlbGwuU2hlbGxDb21tCiAgICAgZmx1bmtP bkZhaWx1cmUgPSBUcnVlCiAgICAgY29tbWFuZCA9IFsnVG9vbHMvU2NyaXB0cy90ZXN0LXdlYmtp dHBlcmwnXQogCisgICAgZGVmIF9faW5pdF9fKHNlbGYsICoqa3dhcmdzKToKKyAgICAgICAgc3Vw ZXIoUnVuV2ViS2l0UGVybFRlc3RzLCBzZWxmKS5fX2luaXRfXyh0aW1lb3V0PTIgKiA2MCwgKipr d2FyZ3MpCisKIAogY2xhc3MgUnVuV2ViS2l0UHlUZXN0cyhzaGVsbC5TaGVsbENvbW1hbmQpOgog ICAgIG5hbWUgPSAnd2Via2l0cHktdGVzdHMnCkBAIC05Nyw2ICsxMDAsOSBAQCBjbGFzcyBSdW5X ZWJLaXRQeVRlc3RzKHNoZWxsLlNoZWxsQ29tbWFuCiAgICAgZmx1bmtPbkZhaWx1cmUgPSBUcnVl CiAgICAgY29tbWFuZCA9IFsnVG9vbHMvU2NyaXB0cy90ZXN0LXdlYmtpdHB5J10KIAorICAgIGRl ZiBfX2luaXRfXyhzZWxmLCAqKmt3YXJncyk6CisgICAgICAgIHN1cGVyKFJ1bldlYktpdFB5VGVz dHMsIHNlbGYpLl9faW5pdF9fKHRpbWVvdXQ9MiAqIDYwLCAqKmt3YXJncykKKwogCiBkZWYgYXBw ZW5kQ3VzdG9tQnVpbGRGbGFncyhzdGVwLCBwbGF0Zm9ybSwgZnVsbFBsYXRmb3JtKToKICAgICAj IEZJWE1FOiBNYWtlIGEgY29tbW9uICdzdXBwb3J0ZWQgcGxhdGZvcm1zJyBsaXN0LgpJbmRleDog VG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWJ1aWxkL3N0ZXBzX3VuaXR0ZXN0LnB5Cj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1idWlsZC9zdGVwc191bml0dGVz dC5weQkocmV2aXNpb24gMjMzMzY3KQorKysgVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWJ1 aWxkL3N0ZXBzX3VuaXR0ZXN0LnB5CSh3b3JraW5nIGNvcHkpCkBAIC0yNzMsNiArMjczLDcgQEAg Y2xhc3MgVGVzdHVuV2ViS2l0UGVybFRlc3RzKEJ1aWxkU3RlcE1peAogICAgICAgICBzZWxmLmV4 cGVjdFJlbW90ZUNvbW1hbmRzKAogICAgICAgICAgICAgRXhwZWN0U2hlbGwod29ya2Rpcj0nd2tk aXInLAogICAgICAgICAgICAgICAgICAgICAgICAgY29tbWFuZD1bJ1Rvb2xzL1NjcmlwdHMvdGVz dC13ZWJraXRwZXJsJ10sCisgICAgICAgICAgICAgICAgICAgICAgICB0aW1lb3V0PTEyMCwKICAg ICAgICAgICAgICAgICAgICAgICAgICkKICAgICAgICAgICAgICsgMCwKICAgICAgICAgKQpAQCAt Mjg0LDYgKzI4NSw3IEBAIGNsYXNzIFRlc3R1bldlYktpdFBlcmxUZXN0cyhCdWlsZFN0ZXBNaXgK ICAgICAgICAgc2VsZi5leHBlY3RSZW1vdGVDb21tYW5kcygKICAgICAgICAgICAgIEV4cGVjdFNo ZWxsKHdvcmtkaXI9J3drZGlyJywKICAgICAgICAgICAgICAgICAgICAgICAgIGNvbW1hbmQ9WydU b29scy9TY3JpcHRzL3Rlc3Qtd2Via2l0cGVybCddLAorICAgICAgICAgICAgICAgICAgICAgICAg dGltZW91dD0xMjAsCiAgICAgICAgICAgICAgICAgICAgICAgICApCiAgICAgICAgICAgICArIEV4 cGVjdFNoZWxsLmxvZygnc3RkaW8nLCBzdGRvdXQ9JycnRmFpbGVkIHRlc3RzOiAgMS0zLCA1LTcs IDksIDExLTEzCiBGaWxlcz00MCwgVGVzdHM9NjMwLCAgNCB3YWxsY2xvY2sgc2VjcyAoIDAuMTYg dXNyICAwLjA5IHN5cyArICAyLjc4IGN1c3IgIDAuNjQgY3N5cyA9ICAzLjY3IENQVSkKQEAgLTMw OCw2ICszMTAsNyBAQCBjbGFzcyBUZXN0V2ViS2l0UHlUZXN0cyhCdWlsZFN0ZXBNaXhpbkFkCiAg ICAgICAgIHNlbGYuZXhwZWN0UmVtb3RlQ29tbWFuZHMoCiAgICAgICAgICAgICBFeHBlY3RTaGVs bCh3b3JrZGlyPSd3a2RpcicsCiAgICAgICAgICAgICAgICAgICAgICAgICBjb21tYW5kPVsnVG9v bHMvU2NyaXB0cy90ZXN0LXdlYmtpdHB5J10sCisgICAgICAgICAgICAgICAgICAgICAgICB0aW1l b3V0PTEyMCwKICAgICAgICAgICAgICAgICAgICAgICAgICkKICAgICAgICAgICAgICsgMCwKICAg ICAgICAgKQpAQCAtMzE5LDYgKzMyMiw3IEBAIGNsYXNzIFRlc3RXZWJLaXRQeVRlc3RzKEJ1aWxk U3RlcE1peGluQWQKICAgICAgICAgc2VsZi5leHBlY3RSZW1vdGVDb21tYW5kcygKICAgICAgICAg ICAgIEV4cGVjdFNoZWxsKHdvcmtkaXI9J3drZGlyJywKICAgICAgICAgICAgICAgICAgICAgICAg IGNvbW1hbmQ9WydUb29scy9TY3JpcHRzL3Rlc3Qtd2Via2l0cHknXSwKKyAgICAgICAgICAgICAg ICAgICAgICAgIHRpbWVvdXQ9MTIwLAogICAgICAgICAgICAgICAgICAgICAgICAgKQogICAgICAg ICAgICAgKyBFeHBlY3RTaGVsbC5sb2coJ3N0ZGlvJywgc3Rkb3V0PScnJ1JhbiAxNzQ0IHRlc3Rz IGluIDUuOTEzcwogRkFJTEVEIChmYWlsdXJlcz0xLCBlcnJvcnM9MCknJycpCg==