187175 2018-06-29 05:00:26 -0700 [WPE] Some frames are dropped when using rAF to animate an element 2018-07-01 22:36:19 -0700 1 1 1 Unclassified WebKit WPE WebKit WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 magomez magomez bugs-noreply calvaris commit-queue zan oldest_to_newest 1437751 0 343907 magomez 2018-06-29 05:00:26 -0700 Created attachment 343907 testcase There's a certain situation using rAF to animate an alement where the sequence of frames rendered is not the right, which causes the animation to be flickery. I'm attaching a testcase where the problem can be reproduced. The problem is that instead of rendering the frames in the appropriate order 1-2-3-4-5-6 we're rendering 1-1-2-4-4-5-7-7 and this happens because we're triggering schedules in the ThreadedCompositor that should wait for a pending layerFlush and it's not. 1437762 1 343910 magomez 2018-06-29 05:43:17 -0700 Created attachment 343910 Patch 1437764 2 343910 commit-queue 2018-06-29 06:52:30 -0700 Comment on attachment 343910 Patch Clearing flags on attachment: 343910 Committed r233353: <https://trac.webkit.org/changeset/233353> 1437765 3 commit-queue 2018-06-29 06:52:32 -0700 All reviewed patches have been landed. Closing bug. 343907 2018-06-29 05:00:26 -0700 2018-06-29 05:00:26 -0700 testcase raf.html text/html 1171 magomez PGh0bWw+Cgo8aGVhZD4KICAgPHNjcmlwdD4KICAgICAgKGZ1bmN0aW9uICgpIHsKICAgICAgICAg d2luZG93Lm9ua2V5dXAgPSBmdW5jdGlvbiAoZSkgewogICAgICAgICAgICB2YXIga2V5ID0gZS5r ZXlDb2RlID8gZS5rZXlDb2RlIDogZS53aGljaDsKCiAgICAgICAgICAgIGlmIChrZXkgPT0gMTMp IHsKICAgICAgICAgICAgICAgCiAgICAgICAgICAgICAgICB2YXIgdGVzdGRpdiA9IGRvY3VtZW50 LmdldEVsZW1lbnRCeUlkKCJ0ZXN0ZGl2Iik7CgogICAgICAgICAgICAgICAgdmFyIG9mZnNldCA9 IDA7CgogICAgICAgICAgICAgICB2YXIgZnVuYyA9IGZ1bmN0aW9uKCkgewoKICAgICAgICAgICAg ICAgICAgIHRlc3RkaXYuc3R5bGVbIi13ZWJraXQtdHJhbnNmb3JtIl0gPSAidHJhbnNsYXRlKCIg KyBvZmZzZXQgKyAicHgsIDBweCkgdHJhbnNsYXRlWigwKSI7CgogICAgICAgICAgICAgICAgICAg IG9mZnNldCArPSAxMDsKCiAgICAgICAgICAgICAgICAgICAgaWYgKG9mZnNldCA+IDEwMDApIHsK CiAgICAgICAgICAgICAgICAgICAgICAgIG9mZnNldCA9IDA7CiAgICAgICAgICAgICAgICAgICAg fQoKICAgICAgICAgICAgICAgICAgICB3aW5kb3cucmVxdWVzdEFuaW1hdGlvbkZyYW1lKGZ1bmMp OwogICAgICAgICAgICAgICB9CgogICAgICAgICAgICAgICBmdW5jKCk7CiAgICAgICAgICAgIH0K ICAgICAgICAgICAgaWYgKGtleSA9PSAzOSkgewogICAgICAgICAgICAgICB3aW5kb3cubG9jYXRp b24uaHJlZj0iZmFkZS5odG1sIjsKICAgICAgICAgICAgfQogICAgICAgICB9CiAgICAgIH0pKCk7 CiAgIDwvc2NyaXB0PgogICA8c3R5bGU+CiAgICBib2R5ewogICAgICBiYWNrZ3JvdW5kLWNvbG9y OiByZ2JhKDAsMCwwLDAuOCk7CiAgICAgIGNvbG9yOiB3aGl0ZTsKICAgIH0KIDwvc3R5bGU+Cjwv aGVhZD4KCjxib2R5PgogIDxoMT5yZXF1ZXN0IGFuaW1hdGlvbjwvaDE+CiAgPGgyPltPS10gdG8g c3RhcnQuIENsaWNrIFtSSUdIVF0gdG8gc2tpcCB0byBuZXh0IHRlc3QgPC9oMj4KCiAgIDxkaXYg aWQ9InRlc3RkaXYiIHN0eWxlPSJwb3NpdGlvbjogYWJzb2x1dGU7IHRvcDogMjAwcHg7IGxlZnQ6 IDEwMHB4OyBoZWlnaHQ6IDIwMHB4OyB3aWR0aDogMjAwcHg7IGJhY2tncm91bmQtY29sb3I6IHll bGxvdzsiPjwvZGl2Pgo8L2JvZHk+Cgo8L2h0bWw+Cg== 343910 2018-06-29 05:43:17 -0700 2018-06-29 06:52:30 -0700 Patch bug-187175-20180629144316.patch text/plain 2985 magomez U3VidmVyc2lvbiBSZXZpc2lvbjogMjMzMzUwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDVjYmY2MmZiYzEwZDZiYTI0 MzI4NDM2YWE3OWRkMWQ3N2NiNTcyZWUuLjI5YzNiMmVmY2Y2ZTAzOTRkN2Q4YjljZjM1YWU5OTQ0 M2U3ZjZhNjYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTgtMDYtMjkgIE1pZ3VlbCBH b21leiAgPG1hZ29tZXpAaWdhbGlhLmNvbT4KKworICAgICAgICBbV1BFXSBTb21lIGZyYW1lcyBh cmUgZHJvcHBlZCB3aGVuIHVzaW5nIHJBRiB0byBhbmltYXRlIGFuIGVsZW1lbnQKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4NzE3NQorCisgICAgICAg IEFsd2F5cyBjYWxsIHJlbmRlck5leHRGcmFtZSBpbiBUaHJlYWRlZENvbXBvc2l0b3I6OnJlcXVl c3REaXNwbGF5UmVmcmVzaE1vbml0b3JVcGRhdGUoKQorICAgICAgICBzbyB3ZSBoYXZlIHRvIHBy b2Nlc3MgYW55IHBlbmRpbmcgbGF5ZXIgZmx1c2ggcmVxdWVzdC4KKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFNoYXJlZC9Db29yZGluYXRlZEdyYXBo aWNzL3RocmVhZGVkY29tcG9zaXRvci9UaHJlYWRlZENvbXBvc2l0b3IuY3BwOgorICAgICAgICAo V2ViS2l0OjpUaHJlYWRlZENvbXBvc2l0b3I6OmhhbmRsZURpc3BsYXlSZWZyZXNoTW9uaXRvclVw ZGF0ZSk6CisKIDIwMTgtMDYtMjggIENocmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KIAog ICAgICAgICBNYWtlIHN1cmUgdGhlIFdlYlJlc291cmNlTG9hZFN0YXRpc3RpY3NTdG9yZSBnZXRz IGRlc3Ryb3llZCBvbiB0aGUgbWFpbiB0aHJlYWQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQv U2hhcmVkL0Nvb3JkaW5hdGVkR3JhcGhpY3MvdGhyZWFkZWRjb21wb3NpdG9yL1RocmVhZGVkQ29t cG9zaXRvci5jcHAgYi9Tb3VyY2UvV2ViS2l0L1NoYXJlZC9Db29yZGluYXRlZEdyYXBoaWNzL3Ro cmVhZGVkY29tcG9zaXRvci9UaHJlYWRlZENvbXBvc2l0b3IuY3BwCmluZGV4IDE3YjhkZTkxNzE0 ZTQ3ZTdmYmE2ZGNhZmVlYzJhNTMxNTkyZDZmMDcuLmRlNjc2ZGM1N2Y5YTFjMDRhZGM4MWJjNTM4 MDAyNmZhMDIzNDIzODQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvU2hhcmVkL0Nvb3JkaW5h dGVkR3JhcGhpY3MvdGhyZWFkZWRjb21wb3NpdG9yL1RocmVhZGVkQ29tcG9zaXRvci5jcHAKKysr IGIvU291cmNlL1dlYktpdC9TaGFyZWQvQ29vcmRpbmF0ZWRHcmFwaGljcy90aHJlYWRlZGNvbXBv c2l0b3IvVGhyZWFkZWRDb21wb3NpdG9yLmNwcApAQCAtMzIxLDIxICszMjEsMTggQEAgdm9pZCBU aHJlYWRlZENvbXBvc2l0b3I6OnJlcXVlc3REaXNwbGF5UmVmcmVzaE1vbml0b3JVcGRhdGUoKQog CiB2b2lkIFRocmVhZGVkQ29tcG9zaXRvcjo6aGFuZGxlRGlzcGxheVJlZnJlc2hNb25pdG9yVXBk YXRlKGJvb2wgaGFzQmVlblJlc2NoZWR1bGVkKQogewotICAgIC8vIFJldHJpZXZlIHRoZSBjbGll bnRSZW5kZXJzTmV4dEZyYW1lIGFuZCBjb29yZGluYXRlVXBkYXRlQ29tcGxldGlvbldpdGhDbGll bnQuCi0gICAgYm9vbCBjbGllbnRSZW5kZXJzTmV4dEZyYW1lIHsgZmFsc2UgfTsKKyAgICAvLyBS ZXRyaWV2ZSBjb29yZGluYXRlVXBkYXRlQ29tcGxldGlvbldpdGhDbGllbnQuCiAgICAgYm9vbCBj b29yZGluYXRlVXBkYXRlQ29tcGxldGlvbldpdGhDbGllbnQgeyBmYWxzZSB9OwogICAgIHsKICAg ICAgICAgTG9ja0hvbGRlciBsb2NrZXIobV9hdHRyaWJ1dGVzLmxvY2spOwotICAgICAgICBjbGll bnRSZW5kZXJzTmV4dEZyYW1lID0gc3RkOjpleGNoYW5nZShtX2F0dHJpYnV0ZXMuY2xpZW50UmVu ZGVyc05leHRGcmFtZSwgZmFsc2UpOwogICAgICAgICBjb29yZGluYXRlVXBkYXRlQ29tcGxldGlv bldpdGhDbGllbnQgPSBzdGQ6OmV4Y2hhbmdlKG1fYXR0cmlidXRlcy5jb29yZGluYXRlVXBkYXRl Q29tcGxldGlvbldpdGhDbGllbnQsIGZhbHNlKTsKICAgICB9CiAKLSAgICAvLyBJZiBjbGllbnRS ZW5kZXJzTmV4dEZyYW1lIGlzIHRydWUsIHRoZSBjbGllbnQgaXMgZmluYWxseSBub3RpZmllZCBh Ym91dCB0aGUgc2NlbmUgdXBkYXRlIG5lYXJpbmcKLSAgICAvLyBjb21wbGV0aW9uLiBUaGUgY2xp ZW50IHdpbGwgdXNlIHRoaXMgb3Bwb3J0dW5pdHkgdG8gY2xlYW4gdXAgcmVzb3VyY2VzIGFzIGFw cHJvcHJpYXRlLiBJdCBjYW4gYWxzbwotICAgIC8vIHBlcmZvcm0gYW55IGxheWVyIGZsdXNoIHRo YXQgd2FzIHJlcXVlc3RlZCBkdXJpbmcgdGhlIGNvbXBvc2l0aW9uLCBvciBieSBhbnkgRGlzcGxh eVJlZnJlc2hNb25pdG9yCi0gICAgLy8gbm90aWZpY2F0aW9ucyB0aGF0IGhhdmUgYmVlbiBoYW5k bGVkIGF0IHRoaXMgcG9pbnQuCi0gICAgaWYgKGNsaWVudFJlbmRlcnNOZXh0RnJhbWUpCi0gICAg ICAgIG1fY2xpZW50LnJlbmRlck5leHRGcmFtZSgpOworICAgIC8vIFRoZSBjbGllbnQgaXMgZmlu YWxseSBub3RpZmllZCBhYm91dCB0aGUgc2NlbmUgdXBkYXRlIG5lYXJpbmcgY29tcGxldGlvbi4g VGhlIGNsaWVudCB3aWxsIHVzZSB0aGlzCisgICAgLy8gb3Bwb3J0dW5pdHkgdG8gY2xlYW4gdXAg cmVzb3VyY2VzIGFzIGFwcHJvcHJpYXRlLiBJdCBjYW4gYWxzbyBwZXJmb3JtIGFueSBsYXllciBm bHVzaCB0aGF0IHdhcworICAgIC8vIHJlcXVlc3RlZCBkdXJpbmcgdGhlIGNvbXBvc2l0aW9uLCBv ciBieSBhbnkgRGlzcGxheVJlZnJlc2hNb25pdG9yIG5vdGlmaWNhdGlvbnMgdGhhdCBoYXZlIGJl ZW4KKyAgICAvLyBoYW5kbGVkIGF0IHRoaXMgcG9pbnQuCisgICAgbV9jbGllbnQucmVuZGVyTmV4 dEZyYW1lKCk7CiAKICAgICBMb2NrSG9sZGVyIHN0YXRlTG9ja2VyKG1fY29tcG9zaXRpbmdSdW5M b29wLT5zdGF0ZUxvY2soKSk7CiAK