187174 2018-06-29 04:00:33 -0700 [Linux] Fix memory leak in WTF::forEachLine() 2018-07-02 04:41:38 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 aboya aboya aperez benjamin bugs-noreply calvaris cdumez cmarcelo commit-queue dbates ews-watchlist ysuzuki zan oldest_to_newest 1437744 0 aboya 2018-06-29 04:00:33 -0700 getline() allocates a buffer even when the read fails because EOF. This buffer also needs to be freed. Also note the buffer is intended to be reused to avoid making an allocation each time a line is read, getline() will realloc() the buffer autmatically if necessary. See `man getline()` for an example: #define _GNU_SOURCE #include <stdio.h> #include <stdlib.h> int main(int argc, char *argv[]) { FILE *stream; char *line = NULL; size_t len = 0; ssize_t nread; if (argc != 2) { fprintf(stderr, "Usage: %s <file>\n", argv[0]); exit(EXIT_FAILURE); } stream = fopen(argv[1], "r"); if (stream == NULL) { perror("fopen"); exit(EXIT_FAILURE); } while ((nread = getline(&line, &len, stream)) != -1) { printf("Retrieved line of length %zu:\n", nread); fwrite(line, nread, 1, stdout); } free(line); fclose(stream); exit(EXIT_SUCCESS); } 1437745 1 343904 aboya 2018-06-29 04:15:30 -0700 Created attachment 343904 Patch 1437746 2 343904 aperez 2018-06-29 04:19:10 -0700 Comment on attachment 343904 Patch Informal r+ from me, good catch! :-) 1437752 3 343904 ysuzuki 2018-06-29 05:17:02 -0700 Comment on attachment 343904 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=343904&action=review > Source/WTF/wtf/linux/MemoryFootprintLinux.cpp:43 > while (getline(&buffer, &size, file) != -1) { We should get the size of the line string here (lineLength = getline(...)), since “size” is the length of the allocated buffer. 1437753 4 343904 aboya 2018-06-29 05:26:06 -0700 Comment on attachment 343904 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=343904&action=review >> Source/WTF/wtf/linux/MemoryFootprintLinux.cpp:43 >> while (getline(&buffer, &size, file) != -1) { > > We should get the size of the line string here (lineLength = getline(...)), since “size” is the length of the allocated buffer. Actually, size is never read in the functor, it's an unused argument. 1438398 5 343904 zan 2018-07-01 23:08:43 -0700 Comment on attachment 343904 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=343904&action=review >>> Source/WTF/wtf/linux/MemoryFootprintLinux.cpp:43 >>> while (getline(&buffer, &size, file) != -1) { >> >> We should get the size of the line string here (lineLength = getline(...)), since “size” is the length of the allocated buffer. > > Actually, size is never read in the functor, it's an unused argument. Please remove it before landing. 1438434 6 344089 aboya 2018-07-02 03:26:31 -0700 Created attachment 344089 Patch 1438439 7 344089 commit-queue 2018-07-02 03:47:11 -0700 Comment on attachment 344089 Patch Rejecting attachment 344089 from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 344089, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Zan Dobersek found in /Volumes/Data/EWS/WebKit/Source/WTF/ChangeLog does not appear to be a valid reviewer according to contributors.json. /Volumes/Data/EWS/WebKit/Source/WTF/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: https://webkit-queues.webkit.org/results/8410850 1438440 8 344092 aboya 2018-07-02 04:02:01 -0700 Created attachment 344092 Patch for landing 1438443 9 344092 commit-queue 2018-07-02 04:41:36 -0700 Comment on attachment 344092 Patch for landing Clearing flags on attachment: 344092 Committed r233420: <https://trac.webkit.org/changeset/233420> 1438444 10 commit-queue 2018-07-02 04:41:38 -0700 All reviewed patches have been landed. Closing bug. 343904 2018-06-29 04:15:30 -0700 2018-07-02 03:26:26 -0700 Patch bug-187174-20180629131528.patch text/plain 1225 aboya U3VidmVyc2lvbiBSZXZpc2lvbjogMjMzMjUzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IGI0YTc0MmM2NDQ0NWU5NjE5ODQ0ZjZk OTU5NTUwNDk1MzRhMjk3M2QuLmI2MTJlMzkzZGFkOTFiZjI3MjQ2MjM0Nzk0OTA4OWQ3ODdlNzhm YTIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTgtMDYtMjkgIEFsaWNpYSBCb3lhIEdhcmPDrWEg IDxhYm95YUBpZ2FsaWEuY29tPgorCisgICAgICAgIFtMaW51eF0gRml4IG1lbW9yeSBsZWFrIGlu IFdURjo6Zm9yRWFjaExpbmUoKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTg3MTc0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgKiB3dGYvbGludXgvTWVtb3J5Rm9vdHByaW50TGludXguY3BwOgorICAgICAg ICAoV1RGOjpmb3JFYWNoTGluZSk6CisKIDIwMTgtMDYtMjUgIERhdmlkIEZlbnRvbiAgPGRhdmlk X2ZlbnRvbkBhcHBsZS5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjIz MzEyMC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvd3RmL2xpbnV4L01lbW9yeUZvb3RwcmludExp bnV4LmNwcCBiL1NvdXJjZS9XVEYvd3RmL2xpbnV4L01lbW9yeUZvb3RwcmludExpbnV4LmNwcApp bmRleCA1NTg3MmNhNWY0NTYwYjg3MWQ5YzM0OTU5ZjA0OTViZGRmMTkzZjVkLi4zNDQzNTA1N2E1 ODhkZTVmMWU5NTY5MDMxM2E1ZDViZmQ4Y2VjZDgwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL3d0 Zi9saW51eC9NZW1vcnlGb290cHJpbnRMaW51eC5jcHAKKysrIGIvU291cmNlL1dURi93dGYvbGlu dXgvTWVtb3J5Rm9vdHByaW50TGludXguY3BwCkBAIC00MiwxMCArNDIsOCBAQCBzdGF0aWMgdm9p ZCBmb3JFYWNoTGluZShGSUxFKiBmaWxlLCBGdW5jdG9yIGZ1bmN0b3IpCiAgICAgc2l6ZV90IHNp emUgPSAwOwogICAgIHdoaWxlIChnZXRsaW5lKCZidWZmZXIsICZzaXplLCBmaWxlKSAhPSAtMSkg ewogICAgICAgICBmdW5jdG9yKGJ1ZmZlciwgc2l6ZSk7Ci0gICAgICAgIGZyZWUoYnVmZmVyKTsK LSAgICAgICAgYnVmZmVyID0gbnVsbHB0cjsKLSAgICAgICAgc2l6ZSA9IDA7CiAgICAgfQorICAg IGZyZWUoYnVmZmVyKTsKIH0KICNlbmRpZgogCg== 344089 2018-07-02 03:26:31 -0700 2018-07-02 04:01:57 -0700 Patch bug-187174-20180702122629.patch text/plain 1588 aboya U3VidmVyc2lvbiBSZXZpc2lvbjogMjMzMjUzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IGI0YTc0MmM2NDQ0NWU5NjE5ODQ0ZjZk OTU5NTUwNDk1MzRhMjk3M2QuLmZjNjZjOTVkOGZmMDJhNzAzOGMxYjc1NWNkYjFkZDUzZjk0MGRh NTMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTgtMDYtMjkgIEFsaWNpYSBCb3lhIEdhcmPDrWEg IDxhYm95YUBpZ2FsaWEuY29tPgorCisgICAgICAgIFtMaW51eF0gRml4IG1lbW9yeSBsZWFrIGlu IFdURjo6Zm9yRWFjaExpbmUoKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTg3MTc0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgWmFuIERvYmVyc2VrLgor CisgICAgICAgICogd3RmL2xpbnV4L01lbW9yeUZvb3RwcmludExpbnV4LmNwcDoKKyAgICAgICAg KFdURjo6Zm9yRWFjaExpbmUpOgorCiAyMDE4LTA2LTI1ICBEYXZpZCBGZW50b24gIDxkYXZpZF9m ZW50b25AYXBwbGUuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHIyMzMx MjAuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL3d0Zi9saW51eC9NZW1vcnlGb290cHJpbnRMaW51 eC5jcHAgYi9Tb3VyY2UvV1RGL3d0Zi9saW51eC9NZW1vcnlGb290cHJpbnRMaW51eC5jcHAKaW5k ZXggNTU4NzJjYTVmNDU2MGI4NzFkOWMzNDk1OWYwNDk1YmRkZjE5M2Y1ZC4uZmY5NWI5ZWU4ZjU5 MjgzNmQ1Y2FlOWU2MDU4YzdlYzdmMjcwZWVhMSAxMDA2NDQKLS0tIGEvU291cmNlL1dURi93dGYv bGludXgvTWVtb3J5Rm9vdHByaW50TGludXguY3BwCisrKyBiL1NvdXJjZS9XVEYvd3RmL2xpbnV4 L01lbW9yeUZvb3RwcmludExpbnV4LmNwcApAQCAtNDEsMTEgKzQxLDkgQEAgc3RhdGljIHZvaWQg Zm9yRWFjaExpbmUoRklMRSogZmlsZSwgRnVuY3RvciBmdW5jdG9yKQogICAgIGNoYXIqIGJ1ZmZl ciA9IG51bGxwdHI7CiAgICAgc2l6ZV90IHNpemUgPSAwOwogICAgIHdoaWxlIChnZXRsaW5lKCZi dWZmZXIsICZzaXplLCBmaWxlKSAhPSAtMSkgewotICAgICAgICBmdW5jdG9yKGJ1ZmZlciwgc2l6 ZSk7Ci0gICAgICAgIGZyZWUoYnVmZmVyKTsKLSAgICAgICAgYnVmZmVyID0gbnVsbHB0cjsKLSAg ICAgICAgc2l6ZSA9IDA7CisgICAgICAgIGZ1bmN0b3IoYnVmZmVyKTsKICAgICB9CisgICAgZnJl ZShidWZmZXIpOwogfQogI2VuZGlmCiAKQEAgLTU4LDcgKzU2LDcgQEAgc3RkOjpvcHRpb25hbDxz aXplX3Q+IG1lbW9yeUZvb3RwcmludCgpCiAKICAgICB1bnNpZ25lZCBsb25nIHRvdGFsUHJpdmF0 ZURpcnR5SW5LQiA9IDA7CiAgICAgYm9vbCBpc0Fub255bW91cyA9IGZhbHNlOwotICAgIGZvckVh Y2hMaW5lKGZpbGUsIFsmXSAoY2hhciogYnVmZmVyLCBzaXplX3QpIHsKKyAgICBmb3JFYWNoTGlu ZShmaWxlLCBbJl0gKGNoYXIqIGJ1ZmZlcikgewogICAgICAgICB7CiAgICAgICAgICAgICB1bnNp Z25lZCBsb25nIHN0YXJ0OwogICAgICAgICAgICAgdW5zaWduZWQgbG9uZyBlbmQ7Cg== 344092 2018-07-02 04:02:01 -0700 2018-07-02 04:41:36 -0700 Patch for landing bug-187174-20180702130200.patch text/plain 1590 aboya U3VidmVyc2lvbiBSZXZpc2lvbjogMjMzMjUzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IGI0YTc0MmM2NDQ0NWU5NjE5ODQ0ZjZk OTU5NTUwNDk1MzRhMjk3M2QuLmNhYzQ0ZGFjNGUyNWY5Yjk0ZDM2MjNjZTI5ZTUwZmFhMTFkNjY2 NDQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTgtMDYtMjkgIEFsaWNpYSBCb3lhIEdhcmPDrWEg IDxhYm95YUBpZ2FsaWEuY29tPgorCisgICAgICAgIFtMaW51eF0gRml4IG1lbW9yeSBsZWFrIGlu IFdURjo6Zm9yRWFjaExpbmUoKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTg3MTc0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgxb1hbiBEb2JlcsWhZWsu CisKKyAgICAgICAgKiB3dGYvbGludXgvTWVtb3J5Rm9vdHByaW50TGludXguY3BwOgorICAgICAg ICAoV1RGOjpmb3JFYWNoTGluZSk6CisKIDIwMTgtMDYtMjUgIERhdmlkIEZlbnRvbiAgPGRhdmlk X2ZlbnRvbkBhcHBsZS5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjIz MzEyMC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvd3RmL2xpbnV4L01lbW9yeUZvb3RwcmludExp bnV4LmNwcCBiL1NvdXJjZS9XVEYvd3RmL2xpbnV4L01lbW9yeUZvb3RwcmludExpbnV4LmNwcApp bmRleCA1NTg3MmNhNWY0NTYwYjg3MWQ5YzM0OTU5ZjA0OTViZGRmMTkzZjVkLi5mZjk1YjllZThm NTkyODM2ZDVjYWU5ZTYwNThjN2VjN2YyNzBlZWExIDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL3d0 Zi9saW51eC9NZW1vcnlGb290cHJpbnRMaW51eC5jcHAKKysrIGIvU291cmNlL1dURi93dGYvbGlu dXgvTWVtb3J5Rm9vdHByaW50TGludXguY3BwCkBAIC00MSwxMSArNDEsOSBAQCBzdGF0aWMgdm9p ZCBmb3JFYWNoTGluZShGSUxFKiBmaWxlLCBGdW5jdG9yIGZ1bmN0b3IpCiAgICAgY2hhciogYnVm ZmVyID0gbnVsbHB0cjsKICAgICBzaXplX3Qgc2l6ZSA9IDA7CiAgICAgd2hpbGUgKGdldGxpbmUo JmJ1ZmZlciwgJnNpemUsIGZpbGUpICE9IC0xKSB7Ci0gICAgICAgIGZ1bmN0b3IoYnVmZmVyLCBz aXplKTsKLSAgICAgICAgZnJlZShidWZmZXIpOwotICAgICAgICBidWZmZXIgPSBudWxscHRyOwot ICAgICAgICBzaXplID0gMDsKKyAgICAgICAgZnVuY3RvcihidWZmZXIpOwogICAgIH0KKyAgICBm cmVlKGJ1ZmZlcik7CiB9CiAjZW5kaWYKIApAQCAtNTgsNyArNTYsNyBAQCBzdGQ6Om9wdGlvbmFs PHNpemVfdD4gbWVtb3J5Rm9vdHByaW50KCkKIAogICAgIHVuc2lnbmVkIGxvbmcgdG90YWxQcml2 YXRlRGlydHlJbktCID0gMDsKICAgICBib29sIGlzQW5vbnltb3VzID0gZmFsc2U7Ci0gICAgZm9y RWFjaExpbmUoZmlsZSwgWyZdIChjaGFyKiBidWZmZXIsIHNpemVfdCkgeworICAgIGZvckVhY2hM aW5lKGZpbGUsIFsmXSAoY2hhciogYnVmZmVyKSB7CiAgICAgICAgIHsKICAgICAgICAgICAgIHVu c2lnbmVkIGxvbmcgc3RhcnQ7CiAgICAgICAgICAgICB1bnNpZ25lZCBsb25nIGVuZDsK