187112 2018-06-27 12:48:26 -0700 Add some more register state information when we crash in repatchPutById 2018-06-27 17:19:26 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 saam saam benjamin commit-queue fpizlo ggaren gskachkov jfbastien keith_miller mark.lam msaboff rmorisset ticaiolima webkit-bug-importer ysuzuki oldest_to_newest 1437060 0 saam 2018-06-27 12:48:26 -0700 ... 1437116 1 343756 saam 2018-06-27 15:08:13 -0700 Created attachment 343756 patch 1437119 2 343756 mark.lam 2018-06-27 15:14:10 -0700 Comment on attachment 343756 patch View in context: https://bugs.webkit.org/attachment.cgi?id=343756&action=review r=me > Source/JavaScriptCore/jit/Repatch.cpp:590 > + if (offset != conditionSetOffset) { Add UNLIKELY() around the condition? 1437149 3 343764 saam 2018-06-27 16:04:36 -0700 Created attachment 343764 patch 1437191 4 343764 commit-queue 2018-06-27 17:18:57 -0700 Comment on attachment 343764 patch Clearing flags on attachment: 343764 Committed r233291: <https://trac.webkit.org/changeset/233291> 1437192 5 commit-queue 2018-06-27 17:18:59 -0700 All reviewed patches have been landed. Closing bug. 1437193 6 webkit-bug-importer 2018-06-27 17:19:26 -0700 <rdar://problem/41553229> 343756 2018-06-27 15:08:13 -0700 2018-06-27 16:04:36 -0700 patch a-backup.diff text/plain 3299 saam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjMzMjc5KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBA CisyMDE4LTA2LTI3ICBTYWFtIEJhcmF0aSAgPHNiYXJhdGlAYXBwbGUuY29tPgorCisgICAgICAg IEFkZCBhIHNpbXVsYXRlZCBjcmFzaCB0byB0cnkgdG8gZmluZCB3aHkgd2UncmUgY3Jhc2hpbmcg aW4gcmVwYXRjaFB1dEJ5SWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTE4NzExMgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIFRoaXMgd2lsbCBoZWxwIHVzIGdhdGhlciBkYXRhIHdoZW4gd2UgZW5kIHVwIHNl ZWluZyBhIE9iamVjdFByb3BlcnR5Q29uZGl0aW9uU2V0CisgICAgICAgIHdpdGggYW4gb2Zmc2V0 IHRoYXQgaXMgZGlmZmVyZW50IHRoYW4gd2hhdCB0aGUgcHV0IHRlbGxzIHVzLgorCisgICAgICAg ICogaml0L1JlcGF0Y2guY3BwOgorICAgICAgICAoSlNDOjp0cnlDYWNoZVB1dEJ5SUQpOgorCiAy MDE4LTA2LTI3ICBLZWl0aCBNaWxsZXIgIDxrZWl0aF9taWxsZXJAYXBwbGUuY29tPgogCiAgICAg ICAgIEFkZCBsb2dnaW5nIHRvIHRyeSB0byBkaWFnbm9zZSB3aGVyZSB3ZSBnZXQgYSBudWxsIHN0 cnVjdHVyZS4KSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvUmVwYXRjaC5jcHAKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9SZXBhdGNoLmNwcAkocmV2aXNp b24gMjMzMjczKQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9SZXBhdGNoLmNwcAkod29y a2luZyBjb3B5KQpAQCAtNjMsOCArNjMsMjAgQEAKICNpbmNsdWRlICJUaHVua0dlbmVyYXRvcnMu aCIKICNpbmNsdWRlIDx3dGYvQ29tbWFQcmludGVyLmg+CiAjaW5jbHVkZSA8d3RmL0xpc3REdW1w Lmg+CisjaWYgUExBVEZPUk0oSU9TKQorI2luY2x1ZGUgPHd0Zi9Tb2Z0TGlua2luZy5oPgorI2Vu ZGlmCiAjaW5jbHVkZSA8d3RmL1N0cmluZ1ByaW50U3RyZWFtLmg+CiAKKyNpZiBQTEFURk9STShJ T1MpCituYW1lc3BhY2UgSlNDIHsKK1NPRlRfTElOS19QUklWQVRFX0ZSQU1FV09SSyhDcmFzaFJl cG9ydGVyU3VwcG9ydCk7Cit9CisKK1NPRlRfTElOS19GVU5DVElPTl9GT1JfSEVBREVSKEpTQywg Q3Jhc2hSZXBvcnRlclN1cHBvcnQsIFNpbXVsYXRlQ3Jhc2gsIEJPT0wsIChwaWRfdCBwaWQsIG1h Y2hfZXhjZXB0aW9uX2RhdGFfdHlwZV90IGV4Y2VwdGlvbkNvZGUsIENGU3RyaW5nUmVmIGRlc2Ny aXB0aW9uKSwgKHBpZCwgZXhjZXB0aW9uQ29kZSwgZGVzY3JpcHRpb24pKTsKK1NPRlRfTElOS19G VU5DVElPTl9GT1JfU09VUkNFKEpTQywgQ3Jhc2hSZXBvcnRlclN1cHBvcnQsIFNpbXVsYXRlQ3Jh c2gsIEJPT0wsIChwaWRfdCBwaWQsIG1hY2hfZXhjZXB0aW9uX2RhdGFfdHlwZV90IGV4Y2VwdGlv bkNvZGUsIENGU3RyaW5nUmVmIGRlc2NyaXB0aW9uKSwgKHBpZCwgZXhjZXB0aW9uQ29kZSwgZGVz Y3JpcHRpb24pKTsKKyNlbmRpZgorCiBuYW1lc3BhY2UgSlNDIHsKIAogc3RhdGljIEZ1bmN0aW9u UHRyPENGdW5jdGlvblB0clRhZz4gcmVhZFB1dElDQ2FsbFRhcmdldChDb2RlQmxvY2sqIGNvZGVC bG9jaywgQ29kZUxvY2F0aW9uQ2FsbDxKU0ludGVybmFsUHRyVGFnPiBjYWxsKQpAQCAtNTczLDcg KzU4NSwyMiBAQCBzdGF0aWMgSW5saW5lQ2FjaGVBY3Rpb24gdHJ5Q2FjaGVQdXRCeUlECiAgICAg ICAgICAgICAgICAgICAgICAgICBpZiAoIWNvbmRpdGlvblNldC5pc1ZhbGlkKCkpCiAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgcmV0dXJuIEdpdmVVcE9uQ2FjaGU7CiAKLSAgICAgICAgICAg ICAgICAgICAgICAgIFJFTEVBU0VfQVNTRVJUKG9mZnNldCA9PSBjb25kaXRpb25TZXQuc2xvdEJh c2VDb25kaXRpb24oKS5vZmZzZXQoKSk7CisgICAgICAgICAgICAgICAgICAgICAgICBQcm9wZXJ0 eU9mZnNldCBjb25kaXRpb25TZXRPZmZzZXQgPSBjb25kaXRpb25TZXQuc2xvdEJhc2VDb25kaXRp b24oKS5vZmZzZXQoKTsKKyNpZiBQTEFURk9STShJT1MpCisgICAgICAgICAgICAgICAgICAgICAg ICBpZiAob2Zmc2V0ICE9IGNvbmRpdGlvblNldE9mZnNldCkgeworICAgICAgICAgICAgICAgICAg ICAgICAgICAgIGNvbnN0IG1hY2hfZXhjZXB0aW9uX2RhdGFfdHlwZV90IGtFeGNlcHRpb25Db2Rl ID0gMHhjMTA1Y2ExMTsKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICBTdHJpbmdQcmludFN0 cmVhbSBtZXNzYWdlOworICAgICAgICAgICAgICAgICAgICAgICAgICAgIG1lc3NhZ2UucHJpbnRm KCJyZXBhdGNoIHB1dF9ieV9pZCBmb3IgaWQ6ICVzLCBvZmZzZXRzIGRvIG5vdCBtYXRjaCwgb2Zm c2V0PSVkIGNvbmRpdGlvblNldE9mZnNldD0lZCAgLT4gICIsIFN0cmluZyhpZGVudC5pbXBsKCkp LmFzY2lpKCkuZGF0YSgpLCBvZmZzZXQsIGNvbmRpdGlvblNldE9mZnNldCk7CisgICAgICAgICAg ICAgICAgICAgICAgICAgICAgY29uZGl0aW9uU2V0LmR1bXAobWVzc2FnZSk7CisgICAgICAgICAg ICAgICAgICAgICAgICAgICAgbWVzc2FnZS5wcmludCgiXG4iKTsKKyAgICAgICAgICAgICAgICAg ICAgICAgICAgICBDU3RyaW5nIHN0cmluZyA9IG1lc3NhZ2UudG9DU3RyaW5nKCk7CisgICAgICAg ICAgICAgICAgICAgICAgICAgICAgQ0ZTdHJpbmdSZWYgZGVzY3JpcHRpb24gPSBDRlN0cmluZ0Ny ZWF0ZVdpdGhGb3JtYXQoa0NGQWxsb2NhdG9yRGVmYXVsdCwgbnVsbHB0ciwgQ0ZTVFIoIiVzIiks IHN0cmluZy5kYXRhKCkpOworICAgICAgICAgICAgICAgICAgICAgICAgICAgIHNvZnRMaW5rX0Ny YXNoUmVwb3J0ZXJTdXBwb3J0X1NpbXVsYXRlQ3Jhc2goZ2V0cGlkKCksIGtFeGNlcHRpb25Db2Rl LCBkZXNjcmlwdGlvbik7CisgICAgICAgICAgICAgICAgICAgICAgICAgICAgQ0ZSZWxlYXNlKGRl c2NyaXB0aW9uKTsKKyAgICAgICAgICAgICAgICAgICAgICAgIH0KKyNlbmRpZgorCisgICAgICAg ICAgICAgICAgICAgICAgICBSRUxFQVNFX0FTU0VSVChvZmZzZXQgPT0gY29uZGl0aW9uU2V0T2Zm c2V0KTsKICAgICAgICAgICAgICAgICAgICAgfQogCiAgICAgICAgICAgICAgICAgfQo= 343764 2018-06-27 16:04:36 -0700 2018-06-27 17:18:57 -0700 patch a-backup.diff text/plain 1649 saam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjMzMjc5KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBA CisyMDE4LTA2LTI3ICBTYWFtIEJhcmF0aSAgPHNiYXJhdGlAYXBwbGUuY29tPgorCisgICAgICAg IEFkZCBzb21lIG1vcmUgcmVnaXN0ZXIgc3RhdGUgaW5mb3JtYXRpb24gd2hlbiB3ZSBjcmFzaCBp biByZXBhdGNoUHV0QnlJZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTg3MTEyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgVGhpcyB3aWxsIGhlbHAgdXMgZ2F0aGVyIGluZm8gd2hlbiB3ZSBlbmQgdXAgc2Vl aW5nIGEgT2JqZWN0UHJvcGVydHlDb25kaXRpb25TZXQKKyAgICAgICAgd2l0aCBhbiBvZmZzZXQg dGhhdCBpcyBkaWZmZXJlbnQgdGhhbiB3aGF0IHRoZSBwdXQgdGVsbHMgdXMuCisKKyAgICAgICAg KiBqaXQvUmVwYXRjaC5jcHA6CisgICAgICAgIChKU0M6OnRyeUNhY2hlUHV0QnlJRCk6CisKIDIw MTgtMDYtMjcgIEtlaXRoIE1pbGxlciAgPGtlaXRoX21pbGxlckBhcHBsZS5jb20+CiAKICAgICAg ICAgQWRkIGxvZ2dpbmcgdG8gdHJ5IHRvIGRpYWdub3NlIHdoZXJlIHdlIGdldCBhIG51bGwgc3Ry dWN0dXJlLgpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9SZXBhdGNoLmNwcAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L1JlcGF0Y2guY3BwCShyZXZpc2lv biAyMzMyNzMpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L1JlcGF0Y2guY3BwCSh3b3Jr aW5nIGNvcHkpCkBAIC01NzMsNyArNTczLDkgQEAgc3RhdGljIElubGluZUNhY2hlQWN0aW9uIHRy eUNhY2hlUHV0QnlJRAogICAgICAgICAgICAgICAgICAgICAgICAgaWYgKCFjb25kaXRpb25TZXQu aXNWYWxpZCgpKQogICAgICAgICAgICAgICAgICAgICAgICAgICAgIHJldHVybiBHaXZlVXBPbkNh Y2hlOwogCi0gICAgICAgICAgICAgICAgICAgICAgICBSRUxFQVNFX0FTU0VSVChvZmZzZXQgPT0g Y29uZGl0aW9uU2V0LnNsb3RCYXNlQ29uZGl0aW9uKCkub2Zmc2V0KCkpOworICAgICAgICAgICAg ICAgICAgICAgICAgUHJvcGVydHlPZmZzZXQgY29uZGl0aW9uU2V0T2Zmc2V0ID0gY29uZGl0aW9u U2V0LnNsb3RCYXNlQ29uZGl0aW9uKCkub2Zmc2V0KCk7CisgICAgICAgICAgICAgICAgICAgICAg ICBpZiAoVU5MSUtFTFkob2Zmc2V0ICE9IGNvbmRpdGlvblNldE9mZnNldCkpCisgICAgICAgICAg ICAgICAgICAgICAgICAgICAgQ1JBU0hfV0lUSF9JTkZPKG9mZnNldCwgY29uZGl0aW9uU2V0T2Zm c2V0LCBzbG90LmJhc2UoKS0+dHlwZSgpLCBiYXNlQ2VsbC0+dHlwZSgpLCBjb25kaXRpb25TZXQu c2l6ZSgpKTsKICAgICAgICAgICAgICAgICAgICAgfQogCiAgICAgICAgICAgICAgICAgfQo=