187074 2018-06-26 17:49:57 -0700 eval() is wrong about the LiteralParser never throwing any exceptions. 2018-06-26 20:47:58 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mark.lam mark.lam commit-queue ews-watchlist keith_miller msaboff saam webkit-bug-importer oldest_to_newest 1436766 0 mark.lam 2018-06-26 17:49:57 -0700 The LiteralParser may have thrown a StackOverflowError or OutOfMemoryError too. <rdar://problem/41461099> 1436769 1 343667 mark.lam 2018-06-26 17:59:32 -0700 Created attachment 343667 proposed patch. 1436775 2 saam 2018-06-26 18:11:52 -0700 r=me 1436812 3 343667 mark.lam 2018-06-26 19:42:32 -0700 Comment on attachment 343667 proposed patch. Thanks for the review. Landing now. 1436818 4 343667 commit-queue 2018-06-26 20:10:23 -0700 Comment on attachment 343667 proposed patch. Clearing flags on attachment: 343667 Committed r233242: <https://trac.webkit.org/changeset/233242> 1436819 5 commit-queue 2018-06-26 20:10:25 -0700 All reviewed patches have been landed. Closing bug. 1436820 6 webkit-bug-importer 2018-06-26 20:13:58 -0700 <rdar://problem/41504820> 1436828 7 mark.lam 2018-06-26 20:47:58 -0700 <rdar://problem/41461099> 343667 2018-06-26 17:59:32 -0700 2018-06-26 20:10:23 -0700 proposed patch. bug-187074.patch text/plain 2962 mark.lam SW5kZXg6IEpTVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvQ2hhbmdlTG9n CShyZXZpc2lvbiAyMzMyMzQpCisrKyBKU1Rlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA QCAtMSwzICsxLDEzIEBACisyMDE4LTA2LTI2ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNv bT4KKworICAgICAgICBldmFsKCkgaXMgd3JvbmcgYWJvdXQgdGhlIExpdGVyYWxQYXJzZXIgbmV2 ZXIgdGhyb3dpbmcgYW55IGV4Y2VwdGlvbnMuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xODcwNzQKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzQxNDYx MDk5PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICog c3RyZXNzL3JlZ3Jlc3MtMTg3MDc0LmpzOiBBZGRlZC4KKwogMjAxOC0wNi0yNiAgTWFyayBMYW0g IDxtYXJrLmxhbUBhcHBsZS5jb20+CiAKICAgICAgICAgQVNTRVJUSU9OIEZBSUxFRDogbGVuZ3Ro ID4gYnV0dGVyZmx5LT52ZWN0b3JMZW5ndGgoKSBpbiBKU09iamVjdDo6ZW5zdXJlTGVuZ3RoU2xv dygpLgpJbmRleDogSlNUZXN0cy9zdHJlc3MvcmVncmVzcy0xODcwNzQuanMKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gSlNUZXN0cy9zdHJlc3MvcmVncmVzcy0xODcwNzQuanMJKG5vbmV4aXN0ZW50KQorKysgSlNU ZXN0cy9zdHJlc3MvcmVncmVzcy0xODcwNzQuanMJKHdvcmtpbmcgY29weSkKQEAgLTAsMCArMSwy MCBAQAorLy8gVGhpcyB0ZXN0IHNob3VsZCBub3QgY3Jhc2guCit2YXIgZG9uZSA9IGZhbHNlOwor CitmdW5jdGlvbiBydW5OZWFyU3RhY2tMaW1pdChmKSB7CisgICAgZnVuY3Rpb24gdCgpIHsKKyAg ICAgICAgdHJ5IHsKKyAgICAgICAgICAgIHJldHVybiB0KCk7CisgICAgICAgIH0gY2F0Y2ggKGUp IHsKKyAgICAgICAgICAgIGlmICghZG9uZSkKKyAgICAgICAgICAgICAgICByZXR1cm4gZigpOwor ICAgICAgICB9CisgICAgfQorICAgIHJldHVybiB0KCkKK30KKworcnVuTmVhclN0YWNrTGltaXQo KCkgPT4geworICAgIGRvbmUgPSB0cnVlOworICAgIGV2YWwoIih7IF9fcHJvdG9fXyA6IFtdLCBf X3Byb3RvX186IHt9IH0pIikKK30pOworCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hh bmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIzMzIyNykKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cJKHdvcmtp bmcgY29weSkKQEAgLTEsMyArMSwxNiBAQAorMjAxOC0wNi0yNiAgTWFyayBMYW0gIDxtYXJrLmxh bUBhcHBsZS5jb20+CisKKyAgICAgICAgZXZhbCgpIGlzIHdyb25nIGFib3V0IHRoZSBMaXRlcmFs UGFyc2VyIG5ldmVyIHRocm93aW5nIGFueSBleGNlcHRpb25zLgorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg3MDc0CisgICAgICAgIDxyZGFyOi8vcHJv YmxlbS80MTQ2MTA5OT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBBZGRlZCB0aGUgbWlzc2luZyBleGNlcHRpb24gY2hlY2ssIGFuZCByZW1vdmVkIGFu IGVycm9uZW91cyBhc3NlcnRpb24uCisKKyAgICAgICAgKiBpbnRlcnByZXRlci9JbnRlcnByZXRl ci5jcHA6CisgICAgICAgIChKU0M6OmV2YWwpOgorCiAyMDE4LTA2LTI2ICBNYXJrIExhbSAgPG1h cmsubGFtQGFwcGxlLmNvbT4KIAogICAgICAgICBBU1NFUlRJT04gRkFJTEVEOiBsZW5ndGggPiBi dXR0ZXJmbHktPnZlY3Rvckxlbmd0aCgpIGluIEpTT2JqZWN0OjplbnN1cmVMZW5ndGhTbG93KCku CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaW50ZXJwcmV0ZXIvSW50ZXJwcmV0ZXIuY3Bw Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnRlcnByZXRlci9JbnRlcnBy ZXRlci5jcHAJKHJldmlzaW9uIDIzMzIyNykKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnRl cnByZXRlci9JbnRlcnByZXRlci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTE1NCwxMSArMTU0LDkg QEAgSlNWYWx1ZSBldmFsKENhbGxGcmFtZSogY2FsbEZyYW1lKQogICAgICAgICAgICAgICAgICAg ICByZXR1cm4gcGFyc2VkT2JqZWN0OwogICAgICAgICAgICAgICAgIH0KICAgICAgICAgICAgIH0K KyAgICAgICAgICAgIFJFVFVSTl9JRl9FWENFUFRJT04oc2NvcGUsIEpTVmFsdWUoKSk7CiAgICAg ICAgIH0KICAgICAgICAgCi0gICAgICAgIC8vIElmIHRoZSBsaXRlcmFsIHBhcnNlciBiYWlsZWQs IGl0IHNob3VsZCBub3QgaGF2ZSB0aHJvd24gZXhjZXB0aW9ucy4KLSAgICAgICAgc2NvcGUuYXNz ZXJ0Tm9FeGNlcHRpb24oKTsKLQogICAgICAgICBWYXJpYWJsZUVudmlyb25tZW50IHZhcmlhYmxl c1VuZGVyVERaOwogICAgICAgICBKU1Njb3BlOjpjb2xsZWN0Q2xvc3VyZVZhcmlhYmxlc1VuZGVy VERaKGNhbGxlclNjb3BlQ2hhaW4sIHZhcmlhYmxlc1VuZGVyVERaKTsKICAgICAgICAgZXZhbCA9 IERpcmVjdEV2YWxFeGVjdXRhYmxlOjpjcmVhdGUoY2FsbEZyYW1lLCBtYWtlU291cmNlKHByb2dy YW1Tb3VyY2UsIGNhbGxlckNvZGVCbG9jay0+c291cmNlKCktPnNvdXJjZU9yaWdpbigpKSwgY2Fs bGVyQ29kZUJsb2NrLT5pc1N0cmljdE1vZGUoKSwgZGVyaXZlZENvbnRleHRUeXBlLCBpc0Fycm93 RnVuY3Rpb25Db250ZXh0LCBldmFsQ29udGV4dFR5cGUsICZ2YXJpYWJsZXNVbmRlclREWik7Cg==