187022 2018-06-25 16:13:42 -0700 Remove RELEASE_ASSERT added in r230875 2018-06-25 16:56:09 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 beidson beidson bfulgham commit-queue oldest_to_newest 1436304 0 beidson 2018-06-25 16:13:42 -0700 Remove RELEASE_ASSERT added in r230875 https://trac.webkit.org/changeset/230875/webkit Turns out it's hit a lot. Not terribly surprising as there's more than one way a session can be destroyed unpredictably while a web socket might have just asynchronously started its handshake! <rdar://problem/40860061> 1436306 1 343553 beidson 2018-06-25 16:19:10 -0700 Created attachment 343553 Patch 1436307 2 343553 bfulgham 2018-06-25 16:21:21 -0700 Comment on attachment 343553 Patch Looks great! r=me 1436308 3 343553 bfulgham 2018-06-25 16:21:36 -0700 Comment on attachment 343553 Patch Looks great! r=me. 1436330 4 343553 commit-queue 2018-06-25 16:56:07 -0700 Comment on attachment 343553 Patch Clearing flags on attachment: 343553 Committed r233183: <https://trac.webkit.org/changeset/233183> 1436331 5 commit-queue 2018-06-25 16:56:09 -0700 All reviewed patches have been landed. Closing bug. 343553 2018-06-25 16:19:10 -0700 2018-06-25 16:56:07 -0700 Patch bug-187022-20180625161909.patch text/plain 3946 beidson U3VidmVyc2lvbiBSZXZpc2lvbjogMjMzMTQ4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggY2MxZDMzNDdiZjg1YjI0 ZTE3Y2I5ODliMmE5MmY4ZmQ1N2NmNDVjYi4uODU0MmFmMGY1N2MwOGU5N2EzYTQ4NzQ5MDk2MGJm OGJlMjE0NjRkYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDE4LTA2LTI1ICBCcmFk eSBFaWRzb24gIDxiZWlkc29uQGFwcGxlLmNvbT4KKworICAgICAgICBSZW1vdmUgUkVMRUFTRV9B U1NFUlQgYWRkZWQgaW4gcjIzMDg3NS4KKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzQwODYwMDYx PiBhbmQgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4NzAyMgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZXJlJ3MgYWN0 dWFsbHkgbW9yZSB0aGFuIG9uZSB3YXkgZm9yIGEgbmV0d29yayBzZXNzaW9uIHRvIGJlIGRlc3Ry b3llZCwgYW5kIHRoYXQgY2FuIGhhcHBlbgorICAgICAgICBhc3luY2hyb25vdXNseSBhbmQgdW5w cmVkaWN0YWJseS4KKworICAgICAgICBBbmQgdGhlIHJlcXVlc3QgdG8gc3RhcnQgdXAgYSBXZWJT b2NrZXQgYW5kIGRvIGl0cyBoYW5kc2hha2UgaXMgYWxzbyBhc3luY2hyb25vdXMgYW5kIHVucHJl ZGljdGFibGUKKyAKKyAgICAgICAgSXQncyBhbiBleHBlY3RlZCByYWNlLgorCisgICAgICAgIElm IHRoZSBOZXR3b3JrU3RvcmFnZVNlc3Npb24gY2Fubm90IGJlIGZvdW5kIHRoZW4gdGhlIFdlYlNv Y2tldCBoYW5kc2hha2Ugc2hvdWxkIGp1c3QgZmFpbC4KKworICAgICAgICAqIHBsYXRmb3JtL25l dHdvcmsvU29ja2V0U3RyZWFtSGFuZGxlSW1wbC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpjb29r aWVEYXRhRm9ySGFuZHNoYWtlKTogSWYgdGhlIE5ldHdvcmtTdG9yYWdlU2Vzc2lvbiBjYW5ub3Qg YmUgZm91bmQsIHJldHVybiBzdGQ6Om51bGxvcHQuCisgICAgICAgIChXZWJDb3JlOjpTb2NrZXRT dHJlYW1IYW5kbGVJbXBsOjpwbGF0Zm9ybVNlbmRIYW5kc2hha2UpOiBJZiB0aGUgY29va2llRGF0 YSBpcyBudWxsLCBmYWlsIHRoZSBoYW5kc2hha2UuCisKIDIwMTgtMDYtMjUgIFNpbW9uIEZyYXNl ciAgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+CiAKICAgICAgICAgQXV0b1RhYmxlTGF5b3V0IHdh c3RlcyA1MktCIG9mIFZlY3RvciBjYXBhY2l0eSBvbiBueXRpbWVzLmNvbQpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9Tb2NrZXRTdHJlYW1IYW5kbGVJbXBsLmNw cCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvU29ja2V0U3RyZWFtSGFuZGxlSW1w bC5jcHAKaW5kZXggNjliNDE4MjA2Zjc5ZGZiZGU4MGM4OWVmYWU5NmViYmZkM2RlNzgxOS4uNzU5 ZDYzYTQ2ODViZmRhZmE3MjcwMDViYjc0NGM4YTU2N2FkMWFjMyAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9Tb2NrZXRTdHJlYW1IYW5kbGVJbXBsLmNwcAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL1NvY2tldFN0cmVhbUhhbmRsZUltcGwu Y3BwCkBAIC03NywxNiArNzcsMTcgQEAgc3RhdGljIHNpemVfdCByZW1vdmVUZXJtaW5hdGlvbkNo YXJhY3RlcnMoY29uc3QgdWludDhfdCogZGF0YSwgc2l6ZV90IGRhdGFMZW5ndGgKICAgICByZXR1 cm4gZGF0YUxlbmd0aCAtIDI7CiB9CiAKLXN0YXRpYyBzdGQ6OnBhaXI8VmVjdG9yPHVpbnQ4X3Q+ LCBib29sPiBjb29raWVEYXRhRm9ySGFuZHNoYWtlKGNvbnN0IENvb2tpZVJlcXVlc3RIZWFkZXJG aWVsZFByb3h5JiBoZWFkZXJGaWVsZFByb3h5KQorc3RhdGljIHN0ZDo6b3B0aW9uYWw8c3RkOjpw YWlyPFZlY3Rvcjx1aW50OF90PiwgYm9vbD4+IGNvb2tpZURhdGFGb3JIYW5kc2hha2UoY29uc3Qg Q29va2llUmVxdWVzdEhlYWRlckZpZWxkUHJveHkmIGhlYWRlckZpZWxkUHJveHkpCiB7CiAgICAg YXV0byBuZXR3b3JrU3RvcmFnZVNlc3Npb24gPSBOZXR3b3JrU3RvcmFnZVNlc3Npb246OnN0b3Jh Z2VTZXNzaW9uKGhlYWRlckZpZWxkUHJveHkuc2Vzc2lvbklEKTsKLSAgICBSRUxFQVNFX0FTU0VS VChuZXR3b3JrU3RvcmFnZVNlc3Npb24pOwotCisgICAgaWYgKCFuZXR3b3JrU3RvcmFnZVNlc3Np b24pCisgICAgICAgIHJldHVybiBzdGQ6Om51bGxvcHQ7CisgICAgCiAgICAgU3RyaW5nIGNvb2tp ZURhdGFTdHJpbmc7CiAgICAgYm9vbCBzZWN1cmVDb29raWVzQWNjZXNzZWQgPSBmYWxzZTsKICAg ICBzdGQ6OnRpZShjb29raWVEYXRhU3RyaW5nLCBzZWN1cmVDb29raWVzQWNjZXNzZWQpID0gV2Vi Q29yZTo6Y29va2llUmVxdWVzdEhlYWRlckZpZWxkVmFsdWUoKm5ldHdvcmtTdG9yYWdlU2Vzc2lv biwgaGVhZGVyRmllbGRQcm94eSk7CiAgICAgaWYgKGNvb2tpZURhdGFTdHJpbmcuaXNFbXB0eSgp KQotICAgICAgICByZXR1cm4geyB7IH0sIHNlY3VyZUNvb2tpZXNBY2Nlc3NlZCB9OworICAgICAg ICByZXR1cm4gc3RkOjpwYWlyPFZlY3Rvcjx1aW50OF90PiwgYm9vbD4geyB7IH0sIHNlY3VyZUNv b2tpZXNBY2Nlc3NlZCB9OwogCiAgICAgQ1N0cmluZyBjb29raWVEYXRhID0gY29va2llRGF0YVN0 cmluZy51dGY4KCk7CiAKQEAgLTk0LDcgKzk1LDcgQEAgc3RhdGljIHN0ZDo6cGFpcjxWZWN0b3I8 dWludDhfdD4sIGJvb2w+IGNvb2tpZURhdGFGb3JIYW5kc2hha2UoY29uc3QgQ29va2llUmVxdWUK ICAgICBkYXRhLmFwcGVuZChjb29raWVEYXRhLmRhdGEoKSwgY29va2llRGF0YS5sZW5ndGgoKSk7 CiAgICAgZGF0YS5hcHBlbmRWZWN0b3IoVmVjdG9yPHVpbnQ4X3Q+KHsgJ1xyJywgJ1xuJywgJ1xy JywgJ1xuJyB9KSk7CiAKLSAgICByZXR1cm4geyBkYXRhLCBzZWN1cmVDb29raWVzQWNjZXNzZWQg fTsKKyAgICByZXR1cm4gc3RkOjpwYWlyPFZlY3Rvcjx1aW50OF90PiwgYm9vbD4geyBkYXRhLCBz ZWN1cmVDb29raWVzQWNjZXNzZWQgfTsKIH0KIAogdm9pZCBTb2NrZXRTdHJlYW1IYW5kbGVJbXBs OjpwbGF0Zm9ybVNlbmRIYW5kc2hha2UoY29uc3QgdWludDhfdCogZGF0YSwgc2l6ZV90IGxlbmd0 aCwgY29uc3Qgc3RkOjpvcHRpb25hbDxDb29raWVSZXF1ZXN0SGVhZGVyRmllbGRQcm94eT4mIGhl YWRlckZpZWxkUHJveHksIEZ1bmN0aW9uPHZvaWQoYm9vbCwgYm9vbCk+JiYgY29tcGxldGlvbkhh bmRsZXIpCkBAIC0xMDMsNyArMTA0LDEzIEBAIHZvaWQgU29ja2V0U3RyZWFtSGFuZGxlSW1wbDo6 cGxhdGZvcm1TZW5kSGFuZHNoYWtlKGNvbnN0IHVpbnQ4X3QqIGRhdGEsIHNpemVfdCBsCiAgICAg Ym9vbCBzZWN1cmVDb29raWVzQWNjZXNzZWQgPSBmYWxzZTsKIAogICAgIGlmIChoZWFkZXJGaWVs ZFByb3h5KSB7Ci0gICAgICAgIHN0ZDo6dGllKGNvb2tpZURhdGEsIHNlY3VyZUNvb2tpZXNBY2Nl c3NlZCkgPSBjb29raWVEYXRhRm9ySGFuZHNoYWtlKGhlYWRlckZpZWxkUHJveHkudmFsdWUoKSk7 CisgICAgICAgIGF1dG8gY29va2llRGF0YUZyb21OZXR3b3JrU2Vzc2lvbiA9IGNvb2tpZURhdGFG b3JIYW5kc2hha2UoaGVhZGVyRmllbGRQcm94eS52YWx1ZSgpKTsKKyAgICAgICAgaWYgKCFjb29r aWVEYXRhRnJvbU5ldHdvcmtTZXNzaW9uKSB7CisgICAgICAgICAgICBjb21wbGV0aW9uSGFuZGxl cihmYWxzZSwgZmFsc2UpOworICAgICAgICAgICAgcmV0dXJuOworICAgICAgICB9CisKKyAgICAg ICAgc3RkOjp0aWUoY29va2llRGF0YSwgc2VjdXJlQ29va2llc0FjY2Vzc2VkKSA9ICpjb29raWVE YXRhRnJvbU5ldHdvcmtTZXNzaW9uOwogICAgICAgICBpZiAoY29va2llRGF0YS5zaXplKCkpCiAg ICAgICAgICAgICBsZW5ndGggPSByZW1vdmVUZXJtaW5hdGlvbkNoYXJhY3RlcnMoZGF0YSwgbGVu Z3RoKTsKICAgICB9Cg==