187004 2018-06-25 10:04:13 -0700 Tap highlight displayed when tapping a field that is already focussed 2018-07-27 13:51:35 -0700 1 1 1 Unclassified WebKit Forms WebKit Nightly Build iPhone / iPad Other RESOLVED FIXED InRadar P2 Normal --- 1 pxlcoder webkit-unassigned cdumez commit-queue megan_gardner thorton webkit-bug-importer wenson_hsieh oldest_to_newest 1436092 0 pxlcoder 2018-06-25 10:04:13 -0700 The tap highlight is displayed when tapping a field that is already focussed. This bug is present on ToT. Reproduction steps 1. Navigate to https://developer.mozilla.org/en-US/docs/Web/HTML/Element/textarea 2. Tap on the search field to begin an input session - this correctly displays the tap highlight 3. Tap on the field again - the tap highlight is incorrectly shown 1436101 1 343509 pxlcoder 2018-06-25 10:17:11 -0700 Created attachment 343509 Patch 1436102 2 webkit-bug-importer 2018-06-25 10:19:08 -0700 <rdar://problem/41428008> 1436595 3 343509 thorton 2018-06-26 11:23:58 -0700 Comment on attachment 343509 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=343509&action=review > Source/WebKit/ChangeLog:5 > + No Radar? > Source/WebKit/ChangeLog:9 > + _singleTapCommited: could be invoked before the tap highlight request, causing > + _potentialTapInProgress to be set to NO. This results in the early return for Really? I thought these things were all strictly ordered. 1436666 4 343641 pxlcoder 2018-06-26 14:29:57 -0700 Created attachment 343641 Patch 1436667 5 pxlcoder 2018-06-26 14:31:53 -0700 Added radar to the ChangeLog and explained the cause of the different ordering. 1436687 6 343641 commit-queue 2018-06-26 15:21:06 -0700 Comment on attachment 343641 Patch Clearing flags on attachment: 343641 Committed r233225: <https://trac.webkit.org/changeset/233225> 343509 2018-06-25 10:17:11 -0700 2018-06-26 11:23:58 -0700 Patch bug-187004-20180625101711.patch text/plain 2053 pxlcoder U3VidmVyc2lvbiBSZXZpc2lvbjogMjMyOTYyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGFhZGZiYzg5ZDFiNzMwYTli NjQ2MTc2MWNhMzQ3ZWIxMzJlY2Q5OWIuLmMzNzU5Yzk2MmM2NzMxZTYwOTY3ZDlkYjE5MGRkZjFj NzUyZTUyODYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTgtMDYtMjUgIEFkaXR5YSBL ZWVydGhpICA8YWtlZXJ0aGlAYXBwbGUuY29tPgorCisgICAgICAgIFRhcCBoaWdobGlnaHQgZGlz cGxheWVkIHdoZW4gdGFwcGluZyBhIGZpZWxkIHRoYXQgaXMgYWxyZWFkeSBmb2N1c3NlZAorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg3MDA0CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgX3NpbmdsZVRhcENv bW1pdGVkOiBjb3VsZCBiZSBpbnZva2VkIGJlZm9yZSB0aGUgdGFwIGhpZ2hsaWdodCByZXF1ZXN0 LCBjYXVzaW5nCisgICAgICAgIF9wb3RlbnRpYWxUYXBJblByb2dyZXNzIHRvIGJlIHNldCB0byBO Ty4gVGhpcyByZXN1bHRzIGluIHRoZSBlYXJseSByZXR1cm4gZm9yCisgICAgICAgIHByZXZlbnRp bmcgbXVsdGlwbGUgdGFwIGhpZ2hsaWdodHMgb24gYW4gYXNzaXN0ZWQgbm9kZSB0byBiZSBza2lw cGVkLiBTaW5jZSBhCisgICAgICAgIHRhcCBoaWdobGlnaHQgc2hvdWxkIG5ldmVyIGJlIHNob3du IGZvciBhbiBpbnB1dCBmaWVsZCB0aGF0IGlzIGFscmVhZHkKKyAgICAgICAgZm9jdXNzZWQsIF9w b3RlbnRpYWxUYXBJblByb2dyZXNzIGNhbiBiZSByZW1vdmVkIGZyb20gdGhlIGVhcmx5IHJldHVy biBjb25kaXRpb24uCisKKyAgICAgICAgKiBVSVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRl cmFjdGlvbi5tbToKKyAgICAgICAgKC1bV0tDb250ZW50VmlldyBfZGlkR2V0VGFwSGlnaGxpZ2h0 Rm9yUmVxdWVzdDpjb2xvcjpxdWFkczp0b3BMZWZ0UmFkaXVzOnRvcFJpZ2h0UmFkaXVzOmJvdHRv bUxlZnRSYWRpdXM6Ym90dG9tUmlnaHRSYWRpdXM6XSk6CisKIDIwMTgtMDYtMTkgIEJyZW50IEZ1 bGdoYW0gIDxiZnVsZ2hhbUBhcHBsZS5jb20+CiAKICAgICAgICAgTUFQX0pJVCBpcyBub3QgcHJl c2VudCBmb3IgbWluaW1hbCBzaW11bGF0b3IgYnVpbGRzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi S2l0L1VJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlld0ludGVyYWN0aW9uLm1tIGIvU291cmNlL1dl YktpdC9VSVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRlcmFjdGlvbi5tbQppbmRleCA5MjQ2 MTQ2YjRkZjg2MzU2ZjIxY2YyZGQ2YWNjMzM0ODk2MTM3MzQyLi5lZWJlMGU5NzU1ZTJkOThjODM2 ZjcxZTBhZjkyODVlNjUwYWNmMTNhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vz cy9pb3MvV0tDb250ZW50Vmlld0ludGVyYWN0aW9uLm1tCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQ cm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24ubW0KQEAgLTExNzUsNyArMTE3NSw3 IEBAIHN0YXRpYyBOU1ZhbHVlICpuc1NpemVGb3JUYXBIaWdobGlnaHRCb3JkZXJSYWRpdXMoV2Vi Q29yZTo6SW50U2l6ZSBib3JkZXJSYWRpdXMsCiAgICAgaWYgKCFfaXNUYXBIaWdobGlnaHRJRFZh bGlkIHx8IF9sYXRlc3RUYXBJRCAhPSByZXF1ZXN0SUQpCiAgICAgICAgIHJldHVybjsKIAotICAg IGlmIChfcG90ZW50aWFsVGFwSW5Qcm9ncmVzcyAmJiBoYXNBc3Npc3RlZE5vZGUoX2Fzc2lzdGVk Tm9kZUluZm9ybWF0aW9uKSAmJiBfcG9zaXRpb25JbmZvcm1hdGlvbi5ub2RlQXRQb3NpdGlvbklz QXNzaXN0ZWROb2RlKQorICAgIGlmIChoYXNBc3Npc3RlZE5vZGUoX2Fzc2lzdGVkTm9kZUluZm9y bWF0aW9uKSAmJiBfcG9zaXRpb25JbmZvcm1hdGlvbi5ub2RlQXRQb3NpdGlvbklzQXNzaXN0ZWRO b2RlKQogICAgICAgICByZXR1cm47CiAKICAgICBfaXNUYXBIaWdobGlnaHRJRFZhbGlkID0gTk87 Cg== 343641 2018-06-26 14:29:57 -0700 2018-06-26 15:21:06 -0700 Patch bug-187004-20180626142956.patch text/plain 2139 pxlcoder U3VidmVyc2lvbiBSZXZpc2lvbjogMjMyOTYyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGFhZGZiYzg5ZDFiNzMwYTli NjQ2MTc2MWNhMzQ3ZWIxMzJlY2Q5OWIuLmJlMDI2ZTNjNjdkZGFkMjljY2I5MDIyMzgxMjNhNWYw NTY1NGFkODIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTgtMDYtMjUgIEFkaXR5YSBL ZWVydGhpICA8YWtlZXJ0aGlAYXBwbGUuY29tPgorCisgICAgICAgIFRhcCBoaWdobGlnaHQgZGlz cGxheWVkIHdoZW4gdGFwcGluZyBhIGZpZWxkIHRoYXQgaXMgYWxyZWFkeSBmb2N1c3NlZAorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg3MDA0CisgICAg ICAgIDxyZGFyOi8vcHJvYmxlbS80MTQyODAwOD4KKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgSW4gdGhlIGNhc2Ugd2hlcmUgZmFzdC1jbGlja2luZyBpcyBl bmFibGVkLCBfc2luZ2xlVGFwQ29tbWl0ZWQ6IGNvdWxkIGJlIGludm9rZWQKKyAgICAgICAgYmVm b3JlIHRoZSB0YXAgaGlnaGxpZ2h0IHJlcXVlc3QsIGNhdXNpbmcgX3BvdGVudGlhbFRhcEluUHJv Z3Jlc3MgdG8gYmUgc2V0IHRvIE5PLgorICAgICAgICBUaGlzIHJlc3VsdHMgaW4gdGhlIGVhcmx5 IHJldHVybiBmb3IgcHJldmVudGluZyBtdWx0aXBsZSB0YXAgaGlnaGxpZ2h0cyBvbiBhbgorICAg ICAgICBhc3Npc3RlZCBub2RlIHRvIGJlIHNraXBwZWQuIFNpbmNlIGEgdGFwIGhpZ2hsaWdodCBz aG91bGQgbmV2ZXIgYmUgc2hvd24gZm9yIGFuCisgICAgICAgIGlucHV0IGZpZWxkIHRoYXQgaXMg YWxyZWFkeSBmb2N1c3NlZCwgX3BvdGVudGlhbFRhcEluUHJvZ3Jlc3MgY2FuIGJlIHJlbW92ZWQg ZnJvbQorICAgICAgICB0aGUgZWFybHkgcmV0dXJuIGNvbmRpdGlvbi4KKworICAgICAgICAqIFVJ UHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlld0ludGVyYWN0aW9uLm1tOgorICAgICAgICAoLVtXS0Nv bnRlbnRWaWV3IF9kaWRHZXRUYXBIaWdobGlnaHRGb3JSZXF1ZXN0OmNvbG9yOnF1YWRzOnRvcExl ZnRSYWRpdXM6dG9wUmlnaHRSYWRpdXM6Ym90dG9tTGVmdFJhZGl1czpib3R0b21SaWdodFJhZGl1 czpdKToKKwogMjAxOC0wNi0xOSAgQnJlbnQgRnVsZ2hhbSAgPGJmdWxnaGFtQGFwcGxlLmNvbT4K IAogICAgICAgICBNQVBfSklUIGlzIG5vdCBwcmVzZW50IGZvciBtaW5pbWFsIHNpbXVsYXRvciBi dWlsZHMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRW aWV3SW50ZXJhY3Rpb24ubW0gYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9pb3MvV0tDb250ZW50 Vmlld0ludGVyYWN0aW9uLm1tCmluZGV4IDkyNDYxNDZiNGRmODYzNTZmMjFjZjJkZDZhY2MzMzQ4 OTYxMzczNDIuLmVlYmUwZTk3NTVlMmQ5OGM4MzZmNzFlMGFmOTI4NWU2NTBhY2YxM2EgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rp b24ubW0KKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRl cmFjdGlvbi5tbQpAQCAtMTE3NSw3ICsxMTc1LDcgQEAgc3RhdGljIE5TVmFsdWUgKm5zU2l6ZUZv clRhcEhpZ2hsaWdodEJvcmRlclJhZGl1cyhXZWJDb3JlOjpJbnRTaXplIGJvcmRlclJhZGl1cywK ICAgICBpZiAoIV9pc1RhcEhpZ2hsaWdodElEVmFsaWQgfHwgX2xhdGVzdFRhcElEICE9IHJlcXVl c3RJRCkKICAgICAgICAgcmV0dXJuOwogCi0gICAgaWYgKF9wb3RlbnRpYWxUYXBJblByb2dyZXNz ICYmIGhhc0Fzc2lzdGVkTm9kZShfYXNzaXN0ZWROb2RlSW5mb3JtYXRpb24pICYmIF9wb3NpdGlv bkluZm9ybWF0aW9uLm5vZGVBdFBvc2l0aW9uSXNBc3Npc3RlZE5vZGUpCisgICAgaWYgKGhhc0Fz c2lzdGVkTm9kZShfYXNzaXN0ZWROb2RlSW5mb3JtYXRpb24pICYmIF9wb3NpdGlvbkluZm9ybWF0 aW9uLm5vZGVBdFBvc2l0aW9uSXNBc3Npc3RlZE5vZGUpCiAgICAgICAgIHJldHVybjsKIAogICAg IF9pc1RhcEhpZ2hsaWdodElEVmFsaWQgPSBOTzsK