186923 2018-06-22 08:38:37 -0700 Security EWS: bots fails with exception 'NoneType' object has no attribute 'is_closed' 2018-06-22 16:10:10 -0700 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=186291 https://bugs.webkit.org/show_bug.cgi?id=186817 InRadar P2 Normal --- 1 aakash_jain dbates aakash_jain ap dbates ews-watchlist glenn lforschler webkit-bug-importer oldest_to_newest 1435439 0 aakash_jain 2018-06-22 08:38:37 -0700 Some of the EWS bots are hitting following exception while processing security sensitive bugs: 2018-06-21 18:41:22,834 - You don't have permission to view this attachment. Traceback (most recent call last): File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/tool/bot/queueengine.py", line 103, in run if not self._delegate.process_work_item(work_item): File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/tool/commands/queues.py", line 465, in process_work_item passed = self.review_patch(patch) File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/tool/commands/earlywarningsystem.py", line 105, in review_patch succeeded = task.run() File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/tool/bot/earlywarningsystemtask.py", line 63, in run if not self._clean(): File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/tool/bot/patchanalysistask.py", line 113, in _clean "Unable to clean working directory") File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/tool/bot/patchanalysistask.py", line 97, in _run_command if not self.validate(): File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/tool/bot/earlywarningsystemtask.py", line 48, in validate if self._patch.bug().is_closed(): AttributeError: 'NoneType' object has no attribute 'is_closed' 2018-06-21 18:41:23,296 - Exception while preparing queue Sleeping until 2018-06-21 18:43:23 (120 seconds). 1435637 1 dbates 2018-06-22 15:39:14 -0700 This cause of this bug is due to the fact that attachments downloaded from the status server do not have an associated Bug object (i.e. Attachment.bug() returns None). They do not have an associated Bug object because these attachments were not fetched from Bugzilla (since the EWS bot does not have access to the security-sensitive bug the attachment is actually hosted on). We need to fix bug #186817 and provide a way for the EWS bots to fetch up-to-date state of both the attachment and the associated bug. 1435649 2 343382 dbates 2018-06-22 15:47:57 -0700 Created attachment 343382 Patch 1435661 3 343382 dbates 2018-06-22 16:06:00 -0700 Comment on attachment 343382 Patch Clearing flags on attachment: 343382 Committed r233107: <https://trac.webkit.org/changeset/233107> 1435662 4 dbates 2018-06-22 16:06:02 -0700 All reviewed patches have been landed. Closing bug. 1435665 5 webkit-bug-importer 2018-06-22 16:10:10 -0700 <rdar://problem/41385843> 343382 2018-06-22 15:47:57 -0700 2018-06-22 16:06:00 -0700 Patch bug-186923-20180622154756.patch text/plain 2521 dbates U3VidmVyc2lvbiBSZXZpc2lvbjogMjMzMTAyCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggODE2OTgwZmVlODJiZGZkODg1ZjQ5ZmQzNDU2YTQ5MGNj NmY4OTQ5Mi4uZmFiMjE3NTc2NzVhYTNkNmFiNDgxOTVmOWZiZmY0OTgyZDkyN2JiOSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIx IEBACisyMDE4LTA2LTIyICBEYW5pZWwgQmF0ZXMgIDxkYWJhdGVzQGFwcGxlLmNvbT4KKworICAg ICAgICBTZWN1cml0eSBFV1M6IGJvdHMgZmFpbHMgd2l0aCBleGNlcHRpb24gJ05vbmVUeXBlJyBv YmplY3QgaGFzIG5vIGF0dHJpYnV0ZSAnaXNfY2xvc2VkJworICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg2OTIzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQXR0YWNobWVudHMgZG93bmxvYWRlZCBmcm9tIHRo ZSBzdGF0dXMgc2VydmVyIChodHRwOi8vd2Via2l0LXF1ZXVlcy53ZWJraXQub3JnKSBkbyBub3QK KyAgICAgICAgaGF2ZSBhbiBhc3NvY2lhdGVkIEJ1ZyBvYmplY3QgKGkuZS4gQXR0YWNobWVudC5i dWcoKSBpcyBOb25lKSBhbmQgcmVmbGVjdCB0aGUgc3RhdGUgdGhleQorICAgICAgICB3ZXJlIGlu LCBpbmNsdWRpbmcgZmxhZ3Mgc2V0LCBhdCB0aGUgdGltZSB0aGV5IHdlcmUgdXBsb2FkZWQgdG8g dGhlIHN0YXR1cyBzZXJ2ZXIuIFdlCisgICAgICAgIHdpbGwgYWRkIHN1cHBvcnQgZm9yIGZldGNo aW5nIHVwLXRvLWRhdGUgc3RhdHVzIGluZm8gYWJvdXQgdGhlIGF0dGFjaG1lbnQgYW5kIGl0cyBi dWcKKyAgICAgICAgaW4gPGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x ODY4MTc+LiBGb3Igbm93LCB3ZSBvbmx5IGNoZWNrIGlmIHRoZQorICAgICAgICBidWcgYXNzb2Np YXRlZCB3aXRoIHRoZSBwYXRjaCB3ZSBhcmUgcHJvY2Vzc2luZyBpcyBjbG9zZWQgaWYgdGhlIGF0 dGFjaG1lbnQgaGFzIGEKKyAgICAgICAgbm9uLU5vbmUgQnVnIG9iamVjdC4KKworICAgICAgICAq IFNjcmlwdHMvd2Via2l0cHkvdG9vbC9ib3QvZWFybHl3YXJuaW5nc3lzdGVtdGFzay5weToKKyAg ICAgICAgKEVhcmx5V2FybmluZ1N5c3RlbVRhc2sudmFsaWRhdGUpOgorCiAyMDE4LTA2LTIyICBS b3NzIEtpcnNsaW5nICA8cm9zcy5raXJzbGluZ0Bzb255LmNvbT4KIAogICAgICAgICBbV2luXSBJ bWFnZURpZmYgc2hvdWxkIHVzZSBETExMYXVuY2hlcgpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0 cy93ZWJraXRweS90b29sL2JvdC9lYXJseXdhcm5pbmdzeXN0ZW10YXNrLnB5IGIvVG9vbHMvU2Ny aXB0cy93ZWJraXRweS90b29sL2JvdC9lYXJseXdhcm5pbmdzeXN0ZW10YXNrLnB5CmluZGV4IDEw MGUyMjIzNDk2NGY3M2Q3ZTYyOGExMTFiMjllZjViOTk3ODM4NDEuLjk4NWEwYjFlZDk2ZjNlYmY1 N2FmNDFlMGMwYzBlNjQzZGRhY2ZhOTAgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0 cHkvdG9vbC9ib3QvZWFybHl3YXJuaW5nc3lzdGVtdGFzay5weQorKysgYi9Ub29scy9TY3JpcHRz L3dlYmtpdHB5L3Rvb2wvYm90L2Vhcmx5d2FybmluZ3N5c3RlbXRhc2sucHkKQEAgLTQxLDExICs0 MSwxNSBAQCBjbGFzcyBFYXJseVdhcm5pbmdTeXN0ZW1UYXNrKFBhdGNoQW5hbHlzaXNUYXNrKToK ICAgICAgICAgc2VsZi5fc2hvdWxkX2J1aWxkID0gc2hvdWxkX2J1aWxkCiAKICAgICBkZWYgdmFs aWRhdGUoc2VsZik6CisgICAgICAgICMgRklYTUU6IE5lZWQgYSB3YXkgdG8gYXNrIHRoZSBzdGF0 dXMgc2VydmVyIGZvciBsYXRlc3Qgc3RhdHVzIG9mIGEgc2VjdXJpdHkgYnVnLgorICAgICAgICAj IEF0dGFjaG1lbnRzIGRvd25sb2FkZWQgZnJvbSB0aGUgc3RhdHVzIHNlcnZlciBkbyBub3QgaGF2 ZSBhbiBhc3NvY2lhdGVkIGJ1ZyBhbmQKKyAgICAgICAgIyByZWZsZWN0IHRoZSBCdWd6aWxsYSBz dGF0ZSBhdCB0aGUgdGltZSB0aGV5IHdlcmUgdXBsb2FkZWQgdG8gdGhlIHN0YXR1cyBzZXJ2ZXIu CisgICAgICAgICMgU2VlIDxodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTg2ODE3Pi4KICAgICAgICAgc2VsZi5fcGF0Y2ggPSBzZWxmLl9kZWxlZ2F0ZS5yZWZldGNoX3Bh dGNoKHNlbGYuX3BhdGNoKQogICAgICAgICBpZiBzZWxmLl9wYXRjaC5pc19vYnNvbGV0ZSgpOgog ICAgICAgICAgICAgc2VsZi5lcnJvciA9ICJQYXRjaCBpcyBvYnNvbGV0ZS4iCiAgICAgICAgICAg ICByZXR1cm4gRmFsc2UKLSAgICAgICAgaWYgc2VsZi5fcGF0Y2guYnVnKCkuaXNfY2xvc2VkKCk6 CisgICAgICAgIGlmIHNlbGYuX3BhdGNoLmJ1ZygpIGFuZCBzZWxmLl9wYXRjaC5idWcoKS5pc19j bG9zZWQoKToKICAgICAgICAgICAgIHNlbGYuZXJyb3IgPSAiQnVnIGlzIGFscmVhZHkgY2xvc2Vk LiIKICAgICAgICAgICAgIHJldHVybiBGYWxzZQogICAgICAgICBpZiBzZWxmLl9wYXRjaC5yZXZp ZXcoKSA9PSAiLSI6Cg==